Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-22 Thread Wanpeng Li
Hi Jaegeuk, On Fri, Mar 20, 2015 at 01:13:39PM -0700, Jaegeuk Kim wrote: Hi Wanpeng, The Chao's patch is what I intended. Could anyone of you enhance that patch? If we use inline_data by default, we need another option to disable it. Like noinline_data? Will do, thanks for you and Chao's help.

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-18 Thread Wanpeng Li
Hi Jaegeuk, On Tue, Mar 17, 2015 at 10:21:27AM -0700, Jaegeuk Kim wrote: -err = page_symlink(inode, symname, symlen); + +if (symlen MAX_FAST_SYMLINK_SIZE) { +/* slow symlink */ +inode-i_op = f2fs_symlink_inode_operations; +inode-i_mapping-a_ops =

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-18 Thread Jaegeuk Kim
Hi, On Wed, Mar 18, 2015 at 04:58:52PM +0800, Wanpeng Li wrote: Hi Jaegeuk, On Tue, Mar 17, 2015 at 10:21:27AM -0700, Jaegeuk Kim wrote: - err = page_symlink(inode, symname, symlen); + + if (symlen MAX_FAST_SYMLINK_SIZE) { + /* slow symlink */ + inode-i_op =

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-18 Thread Chao Yu
Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Thursday, March 19, 2015 7:02 AM To: Jaegeuk Kim Cc: Wanpeng Li; Changman Lee; Chao Yu; linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-17 Thread Jaegeuk Kim
Hi guys, Sorry for the delay due to travel. On Fri, Mar 13, 2015 at 02:33:39PM +0800, Wanpeng Li wrote: This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-16 Thread Wanpeng Li
Hi Chao, On Mon, Mar 16, 2015 at 09:03:30PM +0800, Chao Yu wrote: Hi Wanpeng, Jaegeuk, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Friday, March 13, 2015 2:34 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-devel@lists.sourceforge.net;

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-16 Thread Chao Yu
Hi Wanpeng, Jaegeuk, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Friday, March 13, 2015 2:34 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-devel@lists.sourceforge.net; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; Wanpeng

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-16 Thread Wanpeng Li
Ping Jaegeuk, On Fri, Mar 13, 2015 at 02:33:39PM +0800, Wanpeng Li wrote: This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to using the original slow symlink if

[f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-13 Thread Wanpeng Li
This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to using the original slow symlink if the target path exceeds the available inode space. Signed-off-by: Wanpeng