Re: [f2fs-dev] [PATCH v5 3/9] block: blk-crypto for Inline Encryption

2019-11-05 Thread Christoph Hellwig
On Mon, Nov 04, 2019 at 06:01:17PM -0800, Eric Biggers wrote: > I think that "Severely bloating the per-I/O data structure" is an > exaggeration, > since that it's only 32 bytes, and it isn't in struct bio directly but rather > in > struct bio_crypt_ctx... Yes, and none of that is needed for

Re: [f2fs-dev] [PATCH v5 3/9] block: blk-crypto for Inline Encryption

2019-11-04 Thread Eric Biggers
On Thu, Oct 31, 2019 at 02:22:34PM -0700, Christoph Hellwig wrote: > On Thu, Oct 31, 2019 at 04:50:45PM -0400, Theodore Y. Ts'o wrote: > > One of the reasons I really want this is so I (as an upstream > > maintainer of ext4 and fscrypt) can test the new code paths using > > xfstests on GCE,

Re: [f2fs-dev] [PATCH v5 3/9] block: blk-crypto for Inline Encryption

2019-10-31 Thread Christoph Hellwig
On Thu, Oct 31, 2019 at 04:50:45PM -0400, Theodore Y. Ts'o wrote: > One of the reasons I really want this is so I (as an upstream > maintainer of ext4 and fscrypt) can test the new code paths using > xfstests on GCE, without needing special pre-release hardware that has > the ICE support. > >

Re: [f2fs-dev] [PATCH v5 3/9] block: blk-crypto for Inline Encryption

2019-10-31 Thread Theodore Y. Ts'o
On Thu, Oct 31, 2019 at 10:57:13AM -0700, Christoph Hellwig wrote: > On Mon, Oct 28, 2019 at 12:20:26AM -0700, Satya Tangirala wrote: > > We introduce blk-crypto, which manages programming keyslots for struct > > bios. With blk-crypto, filesystems only need to call bio_crypt_set_ctx with > > the

Re: [f2fs-dev] [PATCH v5 3/9] block: blk-crypto for Inline Encryption

2019-10-31 Thread Christoph Hellwig
On Mon, Oct 28, 2019 at 12:20:26AM -0700, Satya Tangirala wrote: > We introduce blk-crypto, which manages programming keyslots for struct > bios. With blk-crypto, filesystems only need to call bio_crypt_set_ctx with > the encryption key, algorithm and data_unit_num; they don't have to worry >

[f2fs-dev] [PATCH v5 3/9] block: blk-crypto for Inline Encryption

2019-10-28 Thread Satya Tangirala via Linux-f2fs-devel
We introduce blk-crypto, which manages programming keyslots for struct bios. With blk-crypto, filesystems only need to call bio_crypt_set_ctx with the encryption key, algorithm and data_unit_num; they don't have to worry about getting a keyslot for each encryption context, as blk-crypto handles