Re: [f2fs-dev] Consolidated file encryption interface/semantics?

2016-01-12 Thread Theodore Ts'o
On Mon, Jan 11, 2016 at 11:47:56PM -0800, Jaegeuk Kim wrote: > > Actually, I tried to prepare this quite long time ago [1], which was stuck > that moment unfortunately, since I needed to wait for how AOSP finally treats > with this feature. At some moment later, I couldn't even follow up every

[f2fs-dev] Consolidated file encryption interface/semantics?

2016-01-11 Thread Richard Weinberger
Hi! I consider adding file encryption to UBIFS. While looking into ext4 and f2fs I realized that both use the same data structures/concepts. f2fs copy a lot from ext4. Before I do the next copy, I'd to ask whether it would make sense to more parts of the ioctl() interface out to VFS? Let's

Re: [f2fs-dev] Consolidated file encryption interface/semantics?

2016-01-11 Thread Dave Chinner
On Mon, Jan 11, 2016 at 11:56:25PM +0100, Richard Weinberger wrote: > Hi! > > I consider adding file encryption to UBIFS. > While looking into ext4 and f2fs I realized that both > use the same data structures/concepts. When the ext4 code was first posted, I noted that 90% of the implementation

Re: [f2fs-dev] Consolidated file encryption interface/semantics?

2016-01-11 Thread Jaegeuk Kim
Hello, Actually, I tried to prepare this quite long time ago [1], which was stuck that moment unfortunately, since I needed to wait for how AOSP finally treats with this feature. At some moment later, I couldn't even follow up every ext4 changes into this patch set, since the feature was not

Re: [f2fs-dev] Consolidated file encryption interface/semantics?

2016-01-11 Thread Theodore Ts'o
On Mon, Jan 11, 2016 at 11:56:25PM +0100, Richard Weinberger wrote: > > So, the data structures are identical and AFAIK also the supported cipher > modes are. > But as both use their own ioctls having a single tool to control file > encryption > can be error prone in future. > Interestingly the