Re: [f2fs-dev] f2fs: callers take care of the page from bio error

2015-08-12 Thread Jaegeuk Kim
Hi Dan, On Wed, Aug 12, 2015 at 01:40:10PM +0300, Dan Carpenter wrote: Hello Jaegeuk Kim, The patch 86531d6b84bc: f2fs: callers take care of the page from bio error from Jul 15, 2015, leads to the following static checker warning: fs/f2fs/node.c:1042 ra_node_page() warn:

Re: [f2fs-dev] f2fs: callers take care of the page from bio error

2015-08-12 Thread Dan Carpenter
On Wed, Aug 12, 2015 at 10:18:37AM -0700, Jaegeuk Kim wrote: 1041 err = read_node_page(apage, READA); 1042 f2fs_put_page(apage, err ? 1 : 0); In the old code we took errors into consideration but now we treat them as LOCKED_PAGE. Is that intentional? A lot of the