Re: [f2fs-dev] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-28 Thread Dan Carpenter
On Thu, Nov 28, 2013 at 01:04:47PM +0900, Jaegeuk Kim wrote: diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index b7ad1ec..5fa54c1 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -664,8 +664,6 @@ static void do_garbage_collect(struct f2fs_sb_info *sbi, unsigned int segno, /* read segment

Re: [f2fs-dev] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-27 Thread Dan Carpenter
On Wed, Nov 27, 2013 at 11:46:21AM +0900, Jaegeuk Kim wrote: Hi Dan, Thank you for the report. How about this? Thanks, You've just disguised the bug instead of fixing it. Later versions of this static checker will complain about the new code as well. We're unlikely to support 18TB with

Re: [f2fs-dev] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-27 Thread Jaegeuk Kim
Thank you Dan. I wrote two patches to address the warnings below. Thanks. From 1745cd1e14eff75089a8d88fe07f07549e1f3946 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Thu, 28 Nov 2013 12:44:05 +0900 Subject: [PATCH 1/2] f2fs: bug fix on bit overflow from 32bits to