Re: [f2fs-dev] [PATCH] f2fs: refactor bio-related operations

2013-12-02 Thread Jaegeuk Kim
Hi, 2013-12-02 (월), 12:47 +0800, Chao Yu: Hi, Some comments as following. -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Saturday, November 30, 2013 2:26 PM Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org;

Re: [f2fs-dev] [PATCH v2] f2fs: refactor bio-related operations

2013-12-02 Thread Jaegeuk Kim
Change log from v1: o remove redundant codes From a480dfc915490f4bca7275f6fbb44fa34aa00eaa Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Sat, 30 Nov 2013 12:51:14 +0900 Subject: [PATCH] f2fs: refactor bio-related operations Cc: linux-fsde...@vger.kernel.org,

Re: [f2fs-dev] [PATCH] f2fs: remove the own bi_private allocation

2013-12-02 Thread Chao Yu
Hi Kim, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Monday, December 02, 2013 4:15 PM To: Chao Yu Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net; 谭姝 Subject: RE: [f2fs-dev] [PATCH] f2fs:

[f2fs-dev] [PATCH 1/2] f2fs: A minor change for avoiding any possible conflicts to the other fs

2013-12-02 Thread Younger Liu
From: Younger Liu liuyiy...@hisense.com This minor change for the naming conventions of debugfs_root to avoid any possible conflicts to the other filesystem. This patch is based on the first patch [PATCH 0/2] f2fs: remove debufs dir if debugfs_create_file() failed. Signed-off-by: Younger Liu

[f2fs-dev] [PATCH 01/18] reiserfs: prefix ACL symbols with reiserfs_

2013-12-02 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de --- fs/reiserfs/xattr_acl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c index 06c04f7..6f721ea 100644 --- a/fs/reiserfs/xattr_acl.c +++

[f2fs-dev] [PATCH 11/18] jffs2: use generic posix ACL infrastructure

2013-12-02 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de --- fs/jffs2/acl.c | 134 +--- fs/jffs2/acl.h |7 +-- fs/jffs2/dir.c |1 + fs/jffs2/file.c|1 + fs/jffs2/fs.c |2 +- fs/jffs2/symlink.c |1 + fs/jffs2/xattr.c |

Re: [f2fs-dev] [PATCH 01/18] reiserfs: prefix ACL symbols with reiserfs_

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:04, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig h...@lst.de Looks good. You can add: Reviewed-by: Jan Kara j...@suse.cz Honza --- fs/reiserfs/xattr_acl.c | 20 ++-- 1 file

[f2fs-dev] [PATCH 06/18] fs: make posix_acl_create more useful

2013-12-02 Thread Christoph Hellwig
Rename the current posix_acl_created to __posix_acl_create and add a fully featured helper to set up the ACLs on file creation that uses get_acl(). Signed-off-by: Christoph Hellwig h...@lst.de --- fs/9p/acl.c |2 +- fs/btrfs/acl.c|2 +- fs/ext2/acl.c

[f2fs-dev] [PATCH 13/18] reiserfs: use generic posix ACL infrastructure

2013-12-02 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de --- fs/reiserfs/acl.h |4 +- fs/reiserfs/file.c |1 + fs/reiserfs/namei.c |3 + fs/reiserfs/xattr.c |5 +- fs/reiserfs/xattr_acl.c | 175 --- 5 files changed, 36

[f2fs-dev] [PATCH 10/18] hfsplus: use generic posix ACL infrastructure

2013-12-02 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig h...@lst.de --- fs/hfsplus/acl.h |9 +-- fs/hfsplus/dir.c |1 + fs/hfsplus/inode.c |3 +- fs/hfsplus/posix_acl.c | 161 +--- fs/hfsplus/xattr.c |5 +- fs/hfsplus/xattr.h |2 -

Re: [f2fs-dev] [PATCH 02/18] fs: add get_acl helper

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:05, Christoph Hellwig wrote: Factor out the code to get an ACL either from the inode or disk from check_acl, so that it can be used elsewhere later on. Signed-off-by: Christoph Hellwig h...@lst.de Looks good. You can add: Reviewed-by: Jan Kara j...@suse.cz

Re: [f2fs-dev] [PATCH 08/18] ext2/3/4: use generic posix ACL infrastructure

2013-12-02 Thread Jan Kara
On Sun 01-12-13 03:59:11, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig h...@lst.de Looks good. You can add: Reviewed-by: Jan Kara j...@suse.cz Honza --- fs/ext2/acl.c | 176 -

Re: [f2fs-dev] [PATCH 0/2] f2fs: remove debufs dir if debugfs_create_file() failed

2013-12-02 Thread Chao Yu
Hi Liu, You're right, we should release it instead of holding the resource with no use. And here are some comments as following. BTW, your patch is out of format. You'd better not let remote terminal or editor to instead tab with blanks in the patch. Thanks, Yu -Original Message-