[f2fs-dev] [PATCH 1/3] f2fs: flush symlink path to avoid broken symlink after POR

2015-04-16 Thread Jaegeuk Kim
This patch tries to avoid broken symlink case after POR in best effort. This results in performance regression. But, if f2fs has inline_data and the target path is under 3KB-sized long, the page would be stored in its inode_block, so that there would be no performance regression. Note that, if

[f2fs-dev] [PATCH] fsck.f2fs: show ckeckpoint version info

2015-04-16 Thread Jaegeuk Kim
This patch shows the valid checkpoint version number. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fsck/mount.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fsck/mount.c b/fsck/mount.c index f900dd7..1c55f40 100644 --- a/fsck/mount.c +++ b/fsck/mount.c @@

[f2fs-dev] [PATCH 3/3] f2fs: pass checkpoint reason on roll-forward recovery

2015-04-16 Thread Jaegeuk Kim
This patch adds CP_RECOVERY to remain recovery information for checkpoint. And, it makes sure writing checkpoint in this case. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/checkpoint.c| 6 +- fs/f2fs/f2fs.h | 1 + fs/f2fs/recovery.c | 2 +-

[f2fs-dev] [PATCH 2/3] f2fs: avoid abnormal behavior on broken symlink

2015-04-16 Thread Jaegeuk Kim
When f2fs_symlink was triggered and checkpoint was done before syncing its link path, f2fs can get broken symlink like xxx - \0\0\0. This incurs abnormal path_walk by VFS. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/namei.c | 20 +++- 1 file changed, 19

[f2fs-dev] [PATCH] f2fs: remove duplicated code in the f2fs_lookup()

2015-04-16 Thread Taehee Yoo
in the f2fs_lookup(), checks that inode isn't null but d_splice_alias() has same routine at first line. so i remove this routine. Signed-off-by: Taehee Yoo ap420...@gmail.com --- fs/f2fs/namei.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index

Re: [f2fs-dev] [PATCH 1/3] f2fs: flush symlink path to avoid broken symlink after POR

2015-04-16 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Thursday, April 16, 2015 3:31 PM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [f2fs-dev] [PATCH 1/3] f2fs: flush

Re: [f2fs-dev] [PATCH 1/3] f2fs: flush symlink path to avoid broken symlink after POR

2015-04-16 Thread Jaegeuk Kim
Hi Chao, On Thu, Apr 16, 2015 at 06:33:29PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Thursday, April 16, 2015 3:31 PM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org;

Re: [f2fs-dev] [PATCH] f2fs: remove duplicated code in the f2fs_lookup()

2015-04-16 Thread Jaegeuk Kim
Hi Taehee, On Thu, Apr 16, 2015 at 05:42:43PM +0900, Taehee Yoo wrote: in the f2fs_lookup(), checks that inode isn't null but d_splice_alias() has same routine at first line. so i remove this routine. In the latest f2fs, we cannot merge this patch. Since some inline_dots codes were added with

Re: [f2fs-dev] [PATCH] f2fs: remove duplicated code in the f2fs_lookup()

2015-04-16 Thread Taehee Yoo
2015-04-17 2:00 GMT+09:00 Jaegeuk Kim jaeg...@kernel.org: Hi Taehee, On Thu, Apr 16, 2015 at 05:42:43PM +0900, Taehee Yoo wrote: in the f2fs_lookup(), checks that inode isn't null but d_splice_alias() has same routine at first line. so i remove this routine. In the latest f2fs, we cannot