Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Jaegeuk Kim
On Mon, Aug 24, 2015 at 05:40:45PM +0800, Chao Yu wrote: In following call stack, if unfortunately we lose all chances to truncate inode page in remove_inode_page, eventually we will add the nid allocated previously into free nid cache, this nid is with NID_NEW status and with NEW_ADDR in its

Re: [f2fs-dev] [PATCH] fs/f2fs: replace open coded nofail allocation in __add_ino_entry

2015-08-24 Thread Zhang Zhen
On 2015/8/24 12:56, Jaegeuk Kim wrote: Hi Zhang, On Mon, Aug 24, 2015 at 11:39:55AM +0800, Zhang Zhen wrote: __add_ino_entry is looping around the allocation request and minics __GFP_NOFAIL behavior without any allocation fallback strategy. Here remove the open coded loop and replace it

Re: [f2fs-dev] [PATCH 1/2] f2fs: handle failed bio allocation

2015-08-24 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Monday, August 24, 2015 12:54 PM To: Chao Yu Cc: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: handle

Re: [f2fs-dev] [PATCH] fs/f2fs: atomically set inode-i_flags

2015-08-24 Thread Chao Yu
-Original Message- From: Zhang Zhen [mailto:zhenzhang.zh...@huawei.com] Sent: Monday, August 24, 2015 11:29 AM To: jaeg...@kernel.org; cm224@samsung.com Cc: linux-f2fs-devel@lists.sourceforge.net Subject: [f2fs-dev] [PATCH] fs/f2fs: atomically set inode-i_flags According to

[f2fs-dev] [PATCH v2 2/9] f2fs: avoid unneeded initializing when converting inline dentry

2015-08-24 Thread Chao Yu
When converting inline dentry, we will zero out target dentry page before duplicating data of inline dentry into target page, it become overhead since inline dentry size is not small. So this patch tries to remove unneeded initializing in the space of target dentry page. Signed-off-by: Chao Yu

Re: [f2fs-dev] [PATCH 5/5] f2fs: check the node block address of newly allocated nid

2015-08-24 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Chao Yu [mailto:yuchaoch...@hotmail.com] Sent: Friday, August 21, 2015 11:00 PM To: Chao Yu Cc: Jaegeuk Kim; linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 5/5]

[f2fs-dev] [PATCH 1/2] f2fs: handle f2fs_truncate error correctly

2015-08-24 Thread Chao Yu
This patch fixes to return error number of f2fs_truncate, so that we can handle the error correctly in callers. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 26 +- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Jaegeuk Kim
Hi Chao, On Mon, Aug 24, 2015 at 09:54:23AM -0700, Jaegeuk Kim wrote: On Mon, Aug 24, 2015 at 05:40:45PM +0800, Chao Yu wrote: In following call stack, if unfortunately we lose all chances to truncate inode page in remove_inode_page, eventually we will add the nid allocated previously into

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix to release inode correctly

2015-08-24 Thread Chao Yu
Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Tuesday, August 25, 2015 12:54 AM To: Chao Yu Cc: linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org Subject: Re: [PATCH 2/2] f2fs: fix to release inode correctly [snip] +*