Re: [f2fs-dev] [PATCH] fsck: clear useless "continue" in __chk_dentries

2016-09-20 Thread Chao Yu
On 2016/9/20 20:43, Yunlong Song wrote: > Signed-off-by: Yunlong Song Acked-by: Chao Yu -- ___ Linux-f2fs-devel mailing list

Re: [f2fs-dev] [PATCH v2] F2FS customized migrate_page callback

2016-09-20 Thread Chao Yu
On 2016/9/20 10:20, guoweichao wrote: > No, the 'page_count' of the old/new page for Page Cache has been maintained > in 'migrate_page_move_mapping'. As atomic-written pages have an additional > reference, we should update their 'page_count' here. Got it. Now, this patch looks good to me. :)

Re: [f2fs-dev] [PATCH 1/2] f2fs: use crc and cp version to determine roll-forward recovery

2016-09-20 Thread Chao Yu
Hi Jaegeuk, On 2016/9/20 10:55, Jaegeuk Kim wrote: > Previously, we used cp_version only to detect recoverable dnodes. > In order to avoid same garbage cp_version, we needed to truncate the next > dnode during checkpoint, resulting in additional discard or data write. > If we can distinguish this

[f2fs-dev] [PATCH] fsck: clear useless "continue" in __chk_dentries

2016-09-20 Thread Yunlong Song
Signed-off-by: Yunlong Song --- fsck/fsck.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index e2081c8..301685b 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@ -1240,7 +1240,6 @@ static int __chk_dentries(struct f2fs_sb_info *sbi, struct

Re: [f2fs-dev] [PATCH 1/2] f2fs: use crc and cp version to determine roll-forward recovery

2016-09-20 Thread Jaegeuk Kim
On Tue, Sep 20, 2016 at 11:48:24PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/9/20 10:55, Jaegeuk Kim wrote: > > Previously, we used cp_version only to detect recoverable dnodes. > > In order to avoid same garbage cp_version, we needed to truncate the next > > dnode during checkpoint,

Re: [f2fs-dev] [RFC PATCH v2] f2fs: preallocate blocks for encrypted file

2016-09-20 Thread Jaegeuk Kim
Hi Yunlei, I'll add the below bug fix into your patch. --- fs/f2fs/segment.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index abf1c3d..e78501c 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1653,11 +1653,9 @@ void