Re: [f2fs-dev] [PATCH 04/28] f2fs: replace a build-time warning with runtime WARN_ON

2016-10-27 Thread Chao Yu
On 2016/10/26 22:57, Arnd Bergmann wrote: > On Wednesday, October 26, 2016 10:05:00 PM CEST Chao Yu wrote: >> On 2016/10/18 6:05, Arnd Bergmann wrote: >>> gcc is unsure about the use of last_ofs_in_node, which might happen >>> without a prior initialization: >>> >>>

Re: [f2fs-dev] [PATCH] f2fs: use BIO_MAX_PAGES for bio allocation

2016-10-27 Thread Chao Yu
On 2016/10/19 2:48, Jaegeuk Kim wrote: > We don't need to allocate bio partially in order to maximize sequential > writes. We are going to allocate bio with max size supposing that there will be more opportunity to merge small IOs into one bio. Otherwise, if MAX_BIO_BLOCKS is smaller than

[f2fs-dev] [PATCH v2] f2fs: replace a build-time warning with runtime WARN_ON

2016-10-27 Thread Arnd Bergmann
gcc is unsure about the use of last_ofs_in_node, which might happen without a prior initialization: fs/f2fs//git/arm-soc/fs/f2fs/data.c: In function ‘f2fs_map_blocks’: fs/f2fs/data.c:799:54: warning: ‘last_ofs_in_node’ may be used uninitialized in this function [-Wmaybe-uninitialized] if

Re: [f2fs-dev] [PATCH] f2fs: return directly if block has been removed from the victim

2016-10-27 Thread Jaegeuk Kim
On Wed, Oct 26, 2016 at 10:14:04AM +0800, heyunlei wrote: > > > On 2016/10/26 9:09, Jaegeuk Kim wrote: > Hi Kim, > > Hi Yunlei, > > > > On Mon, Oct 24, 2016 at 11:37:28AM +0800, Yunlei He wrote: > >> If one block has been to written to a new place, just return > >> in move data process. > >> >

Re: [f2fs-dev] [PATCH] f2fs: use BIO_MAX_PAGES for bio allocation

2016-10-27 Thread Jaegeuk Kim
On Thu, Oct 27, 2016 at 06:28:04PM +0800, Chao Yu wrote: > On 2016/10/19 2:48, Jaegeuk Kim wrote: > > We don't need to allocate bio partially in order to maximize sequential > > writes. > > We are going to allocate bio with max size supposing that there will be more > opportunity to merge small