Re: [f2fs-dev] [PATCH v2] f2fs: check blkaddr more accuratly before issue a bio

2018-03-07 Thread Chao Yu
On 2018/3/5 15:07, Yunlei He wrote: > This patch check blkaddr more accuratly before issue a > write or read bio. > > Signed-off-by: Yunlei He > --- > fs/f2fs/checkpoint.c | 2 ++ > fs/f2fs/data.c | 5 +++-- > fs/f2fs/f2fs.h | 1 + > fs/f2fs/segment.h| 29

Re: [f2fs-dev] [PATCH v5] f2fs: introduce mount option for fsync mode

2018-03-07 Thread Chao Yu
On 2018/3/7 12:07, Junling Zheng wrote: > Commit "0a007b97aad6"(f2fs: recover directory operations by fsync) > fixed xfstest generic/342 case, but it also increased the written > data and caused the performance degradation. In most cases, there's > no need to do so heavy fsync actually. > > So we

Re: [f2fs-dev] [PATCH v2] dump.f2fs: fix a wrong report for dump an {d, id, did}node

2018-03-07 Thread Chao Yu
On 2018/3/7 11:59, Yunlei He wrote: > fix a wrong report for dump an {d,id,did}node like this: > > [print_node_info: 283] Node ID [0x6820:26656] is direct node or indirect node. > [0] [0x 16b6684 : 23815812] > [1] [0x 16b6685 : 23815813] > [2]

Re: [f2fs-dev] [PATCH] f2fs: Don't overwrite all types of node to keep node chain

2018-03-07 Thread Chao Yu
On 2018/3/7 16:22, Yunlei He wrote: > Currently, we enable node SSR by default, and mixed > different types of node segment to do SSR more intensively. > Although reuse warm node is not allowed, warm node chain > will be destroyed by errors introduced by other types > node chain. So we'd better

Re: [f2fs-dev] [PATCH] f2fs: add nowait aio support

2018-03-07 Thread Chao Yu
On 2018/3/2 15:48, Hyunchul Lee wrote: > From: Hyunchul Lee > > This patch adds nowait aio support[1]. > > Return EAGAIN if any of the following checks fail for direct I/O: > - i_rwsem is not lockable > - Blocks are not allocated at the write location > > And xfstests

Re: [f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-07 Thread Chao Yu
On 2018/3/8 5:10, Weichao Guo wrote: > Only enable in-memory inode checksum to protect metadata blocks > from in-memory scribbles when checking consistency, which has no > performance requirements. Once we modify the node page of inode, we will call set_page_dirty, not sure, can you check that we

[f2fs-dev] [PATCH] f2fs: wrap all options with f2fs_sb_info.mount_opt

2018-03-07 Thread Chao Yu
This patch merges miscellaneous mount options into struct f2fs_mount_info, After this patch, once we add new mount option, we don't need to worry about recovery of it in remount_fs(), since we will recover the f2fs_sb_info.mount_opt including all options. Signed-off-by: Chao Yu

Re: [f2fs-dev] [RFC PATCH v3 2/2] fsck.f2fs: reconnect unreachable files to lost+found

2018-03-07 Thread Chao Yu
On 2018/3/6 11:39, Sheng Yong wrote: > This patch introduces lost_found feature to fsck. If a file is found > unreachable by fsck. Fsck tries to reconnect the file to lost+found > directory: > 1. Scan all unreachable file inodes, ignore non-inodes ones and > directories. > 2. Check them

[f2fs-dev] [PATCH] f2fs: Don't overwrite all types of node to keep node chain

2018-03-07 Thread Yunlei He
Currently, we enable node SSR by default, and mixed different types of node segment to do SSR more intensively. Although reuse warm node is not allowed, warm node chain will be destroyed by errors introduced by other types node chain. So we'd better forbid reusing all types of node to keep warm

[f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-07 Thread Weichao Guo
Only enable in-memory inode checksum to protect metadata blocks from in-memory scribbles when checking consistency, which has no performance requirements. --- fs/f2fs/inline.c | 18 ++ fs/f2fs/inode.c | 10 ++ fs/f2fs/node.c | 4 +++- fs/f2fs/node.h | 24