Hi Christoph,
On Wed, Dec 12, 2018 at 01:14:06AM -0800, Christoph Hellwig wrote:
> As this apparently got merged despite no proper reviews from VFS
> level persons:
fs-verity has been out for review since August, and Cc'ed to all relevant
mailing lists including linux-fsdevel, linux-ext4,
https://bugzilla.kernel.org/show_bug.cgi?id=201911
Jaegeuk Kim (jaeg...@kernel.org) changed:
What|Removed |Added
CC||jaeg...@kernel.org
On 12/12, Yunlong Song wrote:
> v1->v2: delete comments in f2fs.h: "/* bio ordering for NODE/DATA */"
It's quite late for me to rebase the repo. Could you please send another patch
for this?
>
> Signed-off-by: Yunlong Song
> Reviewed-by: Chao Yu
> Signed-off-by: Jaegeuk Kim
> ---
>
On 12/07, Chao Yu wrote:
> On 2018/12/1 4:36, Jaegeuk Kim wrote:
> > On 11/30, Chao Yu wrote:
> >> On 2018/11/29 9:52, Jaegeuk Kim wrote:
> >>> This adds an option in ioctl(F2FS_IOC_SHUTDOWN) in order to trigger fsck
> >>> by
> >>> setting a NEED_FSCK flag.
> >>>
> >>> Signed-off-by: Jaegeuk Kim
On 2018/12/13 11:56, Jaegeuk Kim wrote:
> On 12/07, Chao Yu wrote:
>> On 2018/12/1 4:36, Jaegeuk Kim wrote:
>>> On 11/30, Chao Yu wrote:
On 2018/11/29 9:52, Jaegeuk Kim wrote:
> This adds an option in ioctl(F2FS_IOC_SHUTDOWN) in order to trigger fsck
> by
> setting a NEED_FSCK
In order to have a common code base for fsverity "post read" processing
for all filesystems which support fsverity, this commit removes
filesystem specific build config option (e.g. CONFIG_EXT4_FS_VERITY)
and replaces it with a build option (i.e. CONFIG_FS_VERITY) whose
value affects all the
Instead of conditionally checking for verity status of an inode before
invoking fsverity_file_open(), this commit moves the check inside the
definition of fsverity_file_open().
Signed-off-by: Chandan Rajendra
(EB: fix the !CONFIG_FS_VERITY case and inline the IS_VERITY() check)
Signed-off-by:
In order to have a common code base for fscrypt & fsverity "post read"
processing across filesystems which implement fscrypt/fsverity, this
commit removes filesystem specific build config option
(CONFIG_EXT4_FS_ENCRYPTION, CONFIG_EXT4_FS_VERITY,
CONFIG_F2FS_FS_ENCRYPTION, CONFIG_F2FS_FS_VERITY and
Instead of conditionally checking for verity status of an inode before
invoking fsverity_prepare_setattr(), this commit moves the check inside the
definition of fsverity_prepare_setattr().
Signed-off-by: Chandan Rajendra
(EB: fix the !CONFIG_FS_VERITY case and inline the IS_VERITY() check)
If all free_nat_bitmap are available, we can rebuild nat_bits from
free_nat_bitmap entirely during umount, let's make another chance
to reenable nat_bits for image.
Signed-off-by: Chao Yu
---
fs/f2fs/checkpoint.c | 10 +---
fs/f2fs/f2fs.h | 4 +--
fs/f2fs/node.c | 60
This commit removes the ext4 specific ext4_verity_inode() and makes
use of the generic IS_ENCRYPTED() macro or ext4_test_inode_flag() to
check for the encryption status of an inode.
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
fs/ext4/ext4.h | 9 -
fs/ext4/file.c
In order to have a common code base for fscrypt "post read" processing
for all filesystems which support encryption, this commit removes
filesystem specific build config option (e.g. CONFIG_EXT4_FS_ENCRYPTION)
and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
value affects all
This commit removes the f2fs specific f2fs_encrypted_inode() and makes
use of the generic IS_ENCRYPTED() macro to check for the encryption
status of an inode.
Acked-by: Chao Yu
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
fs/f2fs/data.c | 4 ++--
fs/f2fs/dir.c | 10
This commit removes the f2fs specific f2fs_verity_file() and makes use
of the generic IS_VERITY() macro or file_is_verity() to check for the
verity status of an inode.
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
fs/f2fs/f2fs.h | 7 +--
fs/f2fs/file.c | 6 +++---
Similar to S_ENCRYPTED/IS_ENCRYPTED(), this commit adds
S_VERITY/IS_VERITY() to be able to check if a VFS inode has verity
information associated with it.
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
include/linux/fs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git
This commit removes the ext4 specific ext4_encrypted_inode() and makes
use of the generic IS_ENCRYPTED() macro to check for the encryption
status of an inode.
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
fs/ext4/dir.c | 8
fs/ext4/ext4.h| 5 -
For all ordered cases in f2fs_wait_on_page_writeback(), we need to
check PageWriteback status, so let's clean up to relocate the check
into f2fs_wait_on_page_writeback().
Signed-off-by: Chao Yu
---
fs/f2fs/checkpoint.c | 1 -
fs/f2fs/node.c | 3 ---
fs/f2fs/segment.c| 6 --
3
This patch cleans up checkpoint flow a bit:
- remove unneeded circulation of flushing meta pages.
- don't flush nat_bits pages in prior to other checkpoint pages.
- add bug_on to check remained meta pages after flushing.
Signed-off-by: Chao Yu
---
fs/f2fs/checkpoint.c | 18 +-
1
This patch reorders flow from
- update page
- set_page_dirty
- wait_on_page_writeback
to
- wait_on_page_writeback
- update page
- set_page_dirty
The reason is:
- set_page_dirty will increase reference of dirty page, the reference
should be cleared before wait_on_page_writeback to keep its
As this apparently got merged despite no proper reviews from VFS
level persons:
NAK - the ioctl format that expects the verifycation hash in the file
data data with padding after the real data is simply not acceptable,
we can't just transform the data in the file itself based on a magic
calls
20 matches
Mail list logo
