Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Eric Biggers
On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: > On 2019/8/16 13:55, Eric Biggers wrote: > > From: Eric Biggers > > > > Userspace provides a null-terminated string, so don't assume that the > > full FSLABEL_MAX bytes can always be copied.> > > Fixes: 61a3da4d5ef8 ("f2fs: support

Re: [f2fs-dev] [PATCH 0/3] f2fs: fixes for FS_IOC_{GET,SET}FSLABEL

2019-08-18 Thread Chao Yu
Hi Eric, Do you mind folding these fixes into original patch as it's still in dev branch? BTW, any comment or suggestion is welcome in my original patch :) Thanks, On 2019-8-16 14:49, Chao Yu wrote: > Eric, thanks for all the fixes. > > Thanks, > > On 2019/8/16 13:55, Eric Biggers wrote:

Re: [f2fs-dev] kernel BUG at fs/f2fs/segment.c:2391 during xfstest generic/204

2019-08-18 Thread Eric Biggers
On Fri, Aug 16, 2019 at 04:37:35PM +0800, Chao Yu wrote: > Hi Eric, > > Sorry for late reply... > > I only hit ENOSPC error: > > QA output created by 204 > line 82: echo: write error: No space left on device > > What is your mkfs/mount option? > It's: MKFS_OPTIONS -- /dev/vdc MOUNT_OPTIONS

Re: [f2fs-dev] [PATCH] fsck.f2fs: check only max extra_isize

2019-08-18 Thread Chao Yu
On 2019-8-17 9:03, Jaegeuk Kim wrote: > If we use later kernel having larger extra_isize, old fsck will delete > entire old files. Would it be better to construct the length based on existed features? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fsck/fsck.c | 2 +- > 1 file changed, 1

Re: [f2fs-dev] [PATCH V4 5/8] f2fs: Use read_callbacks for decrypting file data

2019-08-18 Thread Chao Yu
Hi Chandan, On 2019-8-16 14:18, Chandan Rajendra wrote: > F2FS has a copy of "post read processing" code using which encrypted > file data is decrypted. This commit replaces it to make use of the > generic read_callbacks facility. I remember that previously Jaegeuk had mentioned f2fs will

Re: [f2fs-dev] [PATCH 0/3] f2fs: fixes for FS_IOC_{GET,SET}FSLABEL

2019-08-18 Thread Eric Biggers
On Sun, Aug 18, 2019 at 09:03:21PM +0800, Chao Yu wrote: > Hi Eric, > > Do you mind folding these fixes into original patch as it's still in dev > branch? > > BTW, any comment or suggestion is welcome in my original patch :) > > Thanks, > I'm fine with the patches being folded in. -

[f2fs-dev] [PATCH v8 00/20] vfs: Add support for timestamp limits

2019-08-18 Thread Deepa Dinamani
The series is an update and a more complete version of the previously posted series at https://lore.kernel.org/linux-fsdevel/20180122020426.2988-1-deepa.ker...@gmail.com/ Thanks to Arnd Bergmann for doing a few preliminary reviews. They helped me fix a few issues I had overlooked. The limits

[f2fs-dev] [PATCH v8 03/20] timestamp_truncate: Replace users of timespec64_trunc

2019-08-18 Thread Deepa Dinamani
Update the inode timestamp updates to use timestamp_truncate() instead of timespec64_trunc(). The change was mostly generated by the following coccinelle script. virtual context virtual patch @r1 depends on patch forall@ struct inode *inode; identifier i_xtime =~ "^i_[acm]time$"; expression e;

Re: [PATCH v8 03/20] timestamp_truncate: Replace users of timespec64_trunc

2019-08-18 Thread Greg KH
On Sun, Aug 18, 2019 at 09:58:00AM -0700, Deepa Dinamani wrote: > Update the inode timestamp updates to use timestamp_truncate() > instead of timespec64_trunc(). > > The change was mostly generated by the following coccinelle > script. > > virtual context > virtual patch > > @r1 depends on

Re: [f2fs-dev] [PATCH 0/6] fs-verity fixups

2019-08-18 Thread Eric Biggers
On Sun, Aug 11, 2019 at 02:35:51PM -0700, Eric Biggers wrote: > A few fixes and cleanups for fs-verity. > > If there are no objections, I'll fold these into the original patches. > > Eric Biggers (6): > fs-verity: fix crash on read error in build_merkle_tree_level() > ext4: skip truncate

Re: [f2fs-dev] [PATCH 3/6] f2fs: skip truncate when verity in progress in ->write_begin()

2019-08-18 Thread Eric Biggers
On Tue, Aug 13, 2019 at 10:40:39AM +0800, Chao Yu wrote: > Hi Eric, > > On 2019/8/13 6:58, Eric Biggers wrote: > > Hi Chao, > > > > On Mon, Aug 12, 2019 at 08:25:33PM +0800, Chao Yu wrote: > >> Hi Eric, > >> > >> On 2019/8/12 5:35, Eric Biggers wrote: > >>> From: Eric Biggers > >>> > >>> When

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Eric Biggers
On Mon, Aug 19, 2019 at 09:58:30AM +0800, Chao Yu wrote: > On 2019/8/19 9:33, Chao Yu wrote: > > On 2019/8/18 23:41, Eric Biggers wrote: > >> On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: > >>> On 2019/8/16 13:55, Eric Biggers wrote: > From: Eric Biggers > > Userspace

Re: [f2fs-dev] [PATCH 0/3] f2fs: fixes for FS_IOC_{GET,SET}FSLABEL

2019-08-18 Thread Jaegeuk Kim
On 08/18, Eric Biggers wrote: > On Sun, Aug 18, 2019 at 09:03:21PM +0800, Chao Yu wrote: > > Hi Eric, > > > > Do you mind folding these fixes into original patch as it's still in dev > > branch? > > > > BTW, any comment or suggestion is welcome in my original patch :) > > > > Thanks, > >

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Chao Yu
On 2019/8/19 9:33, Chao Yu wrote: > On 2019/8/18 23:41, Eric Biggers wrote: >> On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: >>> On 2019/8/16 13:55, Eric Biggers wrote: From: Eric Biggers Userspace provides a null-terminated string, so don't assume that the full

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Chao Yu
On 2019/8/19 10:55, Eric Biggers wrote: > On Mon, Aug 19, 2019 at 09:58:30AM +0800, Chao Yu wrote: >> On 2019/8/19 9:33, Chao Yu wrote: >>> On 2019/8/18 23:41, Eric Biggers wrote: On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: > On 2019/8/16 13:55, Eric Biggers wrote: >>

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-18 Thread Chao Yu
On 2019/8/18 23:41, Eric Biggers wrote: > On Fri, Aug 16, 2019 at 02:59:37PM +0800, Chao Yu wrote: >> On 2019/8/16 13:55, Eric Biggers wrote: >>> From: Eric Biggers >>> >>> Userspace provides a null-terminated string, so don't assume that the >>> full FSLABEL_MAX bytes can always be copied.> >>>

Re: [f2fs-dev] [PATCH v2] f2fs_io: add get/setflags

2019-08-18 Thread Chao Yu
On 2019/8/16 10:41, Jaegeuk Kim wrote: > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel