Re: [f2fs-dev] [PATCH 1/2] f2fs: do not select same victim right again

2019-09-16 Thread Jaegeuk Kim
On 09/16, Chao Yu wrote: > On 2019/9/9 20:04, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 16:06, Jaegeuk Kim wrote: > >>> On 09/09, Chao Yu wrote: > On 2019/9/9 9:25, Jaegeuk Kim wrote: > > GC must avoid select the same victim again. > > Blocks in previous

[PATCH] f2fs: add a condition to detect overflow in f2fs_ioc_gc_range()

2019-09-16 Thread Sahitya Tummala
end = range.start + range.len; If the range.start/range.len is a very large value, then end can overflow in this operation. It results into a crash in get_valid_blocks() when accessing the invalid range.start segno. This issue is reported in ioctl fuzz testing. Signed-off-by: Sahitya Tummala

Re: [f2fs-dev] [PATCH 1/2] f2fs: do not select same victim right again

2019-09-16 Thread Chao Yu
On 2019/9/16 23:37, Jaegeuk Kim wrote: > On 09/16, Chao Yu wrote: >> On 2019/9/9 20:04, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On 2019/9/9 16:06, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 9:25, Jaegeuk Kim wrote: >>> GC must avoid select the same victim

Re: [f2fs-dev] [PATCH v4] f2fs: Fix indefinite loop in f2fs_gc()

2019-09-16 Thread Sahitya Tummala
Hi Chao, On Fri, Sep 06, 2019 at 07:00:32PM +0800, Chao Yu wrote: > Hi Sahitya, > > Luckily, I can reproduce this issue with generic/269, and have sent another > patch for the issue, could you please check that one? > Thanks for the fix. The issue could not get reproduced yet, so could not