On 11/28, qixiaoyu1 wrote:
> From: xiongping1
>
> Signed-off-by: xiongping1
> Signed-off-by: qixiaoyu1
> ---
> fs/f2fs/Kconfig | 7 +++
> fs/f2fs/Makefile| 1 +
> fs/f2fs/block_age.c | 28
> fs/f2fs/debug.c | 7 +++
> fs/f2fs/f2fs.h |
Need to run checkpatch?
On 11/23, Yangtao Li wrote:
> This patch adds support for counting the average time of submit discard
> command, and we can see its value in debugfs.
>
> Signed-off-by: Yangtao Li
> ---
> fs/f2fs/debug.c | 7 +--
> fs/f2fs/f2fs.h| 5 +
>
On 11/25, Eric Biggers wrote:
> From: Eric Biggers
>
> As a step towards freeing the PG_error flag for other uses, change ext4
> and f2fs to stop using PG_error to track verity errors. Instead, if a
> verity error occurs, just mark the whole bio as failed. The coarser
> granularity isn't
If you don't mind, let me merge this patch into Chao's patch, since both
are same topic.
On 11/28, Yangtao Li wrote:
> It's better to use bugzilla.kernel.org for reporting bugs.
>
> Signed-off-by: Yangtao Li
> ---
> Documentation/filesystems/f2fs.rst | 6 +-
> 1 file changed, 5
On 11/28, Christoph Hellwig wrote:
> Hi Jaegeuk and Chao,
>
> this series cleans up the segment allocation code a bit.
Thanks, applied for test.
>
> Diffstat
> segment.c | 71
> ++
> segment.h |6 -
> 2 files changed, 30
From: Eric Biggers
As a step towards freeing the PG_error flag for other uses, change ext4
and f2fs to stop using PG_error to track verity errors. Instead, if a
verity error occurs, just mark the whole bio as failed. The coarser
granularity isn't really a problem since it isn't any worse than
To fix:
WARNING: function definition argument 'struct f2fs_attr *' should also have an
identifier name
+ ssize_t (*show)(struct f2fs_attr *, struct f2fs_sb_info *, char *);
WARNING: return sysfs_emit(...) formats should include a terminating newline
+ return sysfs_emit(buf,
This patch adds support for counting the average time of submit discard
command, and we can see its value in debugfs.
Signed-off-by: Yangtao Li
---
fs/f2fs/debug.c | 7 +--
fs/f2fs/f2fs.h| 5 +
fs/f2fs/segment.c | 18 --
3 files changed, 26 insertions(+), 4
On 11/25, Eric Biggers wrote:
> From: Eric Biggers
>
> As a step towards freeing the PG_error flag for other uses, change ext4
> and f2fs to stop using PG_error to track verity errors. Instead, if a
> verity error occurs, just mark the whole bio as failed. The coarser
> granularity isn't
Hi qixiaoyu1,
Thanks for your patchset.
Does this patchset have data related to memory and performance impact?
Can you provide scripts or commands for related tests?
Thx,
Yangtao
___
Linux-f2fs-devel mailing list
> If you don't mind, let me merge this patch into Chao's patch, since both
> are same topic.
Never mind, feel free. :)
Thx,
Yangtao
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
From: Eric Biggers
Add a f2fs/compress configuration which causes all files to be
automatically compressed, similar to how f2fs/encrypt causes all files
to be automatically encrypted.
Signed-off-by: Eric Biggers
---
test-appliance/files/root/fs/f2fs/cfg/all.list | 1 +
On Mon, Nov 28, 2022 at 10:48:41PM -0800, Jaegeuk Kim wrote:
> > static void f2fs_finish_read_bio(struct bio *bio, bool in_task)
> > {
> > struct bio_vec *bv;
> > struct bvec_iter_all iter_all;
> > + struct bio_post_read_ctx *ctx = bio->bi_private;
> >
> > - /*
> > -* Update
From: xiongping1
Signed-off-by: xiongping1
Signed-off-by: qixiaoyu1
---
fs/f2fs/block_age.c | 590 +++-
fs/f2fs/debug.c | 13 +
fs/f2fs/f2fs.h | 64 +++-
fs/f2fs/file.c | 10 +
fs/f2fs/inode.c | 8 +
Signed-off-by: qixiaoyu1
Signed-off-by: xiongping1
---
fs/f2fs/block_age.c | 89 -
fs/f2fs/f2fs.h | 1 +
fs/f2fs/segment.c | 4 ++
3 files changed, 92 insertions(+), 2 deletions(-)
diff --git a/fs/f2fs/block_age.c b/fs/f2fs/block_age.c
index
From: xiongping1
enable data block seperation feature only when
age_extent_cache mount option is on
Signed-off-by: xiongping1
Signed-off-by: qixiaoyu1
---
Documentation/filesystems/f2fs.rst | 4
fs/f2fs/block_age.c| 3 +++
fs/f2fs/f2fs.h | 1 +
Signed-off-by: qixiaoyu1
Signed-off-by: xiongping1
---
Documentation/ABI/testing/sysfs-fs-f2fs | 14
fs/f2fs/block_age.c | 29 +
fs/f2fs/f2fs.h | 4
fs/f2fs/segment.c | 9
From: xiongping1
Signed-off-by: xiongping1
Signed-off-by: qixiaoyu1
---
fs/f2fs/Kconfig | 7 +++
fs/f2fs/Makefile| 1 +
fs/f2fs/block_age.c | 28
fs/f2fs/debug.c | 7 +++
fs/f2fs/f2fs.h | 15 +++
fs/f2fs/segment.c | 4
This patch series introduce a runtime hot/cold data separation
method for f2fs, in order to improve the accuracy for data
temperature classification, reduce the garbage collection overhead
after long-term data updates.
Enhanced hot/cold data separation can record data block update
frequency as
The create argument is always identicaly to map->m_may_create, so use
that consistently.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 32 ++--
fs/f2fs/f2fs.h | 3 +--
fs/f2fs/file.c | 12 ++--
Add a helper to deal with everything needed to return a f2fs_map_blocks
structure based on a lookup in the extent cache.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 62 +++---
1 file changed, 38 insertions(+), 24 deletions(-)
diff --git
m_flags is never interchanged with the buffer_heads b_flags directly,
so use separate codepoints from that.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/f2fs.h | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index
Just use a simple if block for the conditional call to
inc_valid_block_count.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index fc5207859912ce..87c17602a3fdd4 100644
---
Fold f2fs_get_block into the two remaining callers to simplify the
call chain a bit.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 87c17602a3fdd4..2ae8fcf7cf49f4
Split __submit_bio into one function each for reads and writes, and a
helper for aligning writes.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/compress.c | 2 +-
fs/f2fs/data.c | 111 +++--
fs/f2fs/f2fs.h | 4 +-
3 files changed, 61
When testing with a mixed zoned / convention device combination, there
are regular but not 100% reproducible failures in xfstests generic/113
where the __is_valid_data_blkaddr assert hits due to finding a hole.
This seems to be because f2fs_map_blocks can set this flag on a hole
when it was found
Add a is_hole local variable to figure out if the block number might need
allocation, and untangle to logic to report the hole or fill it with a
block allocation.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 113 -
1 file changed, 56
Split f2fs_do_map_lock into a lock and unlock helper to make the code
using it easier to read.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 46 +++---
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
This allows to keep the f2fs_do_map_lock based locking scheme
private to data.c.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 16 ++--
fs/f2fs/f2fs.h | 3 +--
fs/f2fs/file.c | 4 +---
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/fs/f2fs/data.c
No need to keep these two helpers separate.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/extent_cache.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
index 932c070173b976..538e4b79f83c9b 100644
---
All but three callers of f2fs_lookup_extent_cache just want the block
address. Add a small helper to simplify them.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 29 +++--
fs/f2fs/extent_cache.c | 11 +++
fs/f2fs/f2fs.h | 2 ++
Factor out a helper to return a hole when no dnode was found.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 47 ---
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index
NEW_ADDR blocks are purely in-memory preallocated blocks, and thus
equivalent to what the core FS code calls delayed allocations, and not
unwritten extents which do have on-disk blocks allocated from which
reads always return zeroes until they are converted to written status.
Signed-off-by:
Reflow prepare_write_begin so that it reads more straight forward,
and so that there is one place that does an extent cache lookup
instead of three, two of which are hidden in f2fs_get_block calls.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/data.c | 57
Hi Jaegeuk and Chao,
the first patch in this series fixes a warning and subsequent hang when
testing zoned f2fs. The other patches are misc cleanups for the I/O path.
Diffstat
fs/f2fs/compress.c |2
fs/f2fs/data.c | 544 ++--
Hi Jaegeuk and Chao,
this series cleans up the segment allocation code a bit.
Diffstat
segment.c | 71 ++
segment.h |6 -
2 files changed, 30 insertions(+), 47 deletions(-)
___
allocate_segment_by_default has just two callers, which use very
different code pathes inside it based on the force paramter. Just
open code the logic in the two callers using a new helper to decided
if a new segment should be allocated.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/segment.c |
Signed-off-by: Christoph Hellwig
---
fs/f2fs/segment.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 2e54df1d3feea5..b3b7ea6559f95e 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2643,7 +2643,7 @@ bool
There is only single instance of these ops, so remove the indirection
and call allocate_segment_by_default directly.
Signed-off-by: Christoph Hellwig
---
fs/f2fs/segment.c | 11 ++-
fs/f2fs/segment.h | 6 --
2 files changed, 2 insertions(+), 15 deletions(-)
diff --git
Hello,
syzbot found the following issue on:
HEAD commit:6d464646530f Merge branch 'for-next/core' into for-kernelci
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
for-kernelci
console output: https://syzkaller.appspot.com/x/log.txt?x=177fa38188
kernel
40 matches
Mail list logo
