Re: [f2fs-dev] [PATCH 2/2] f2fs: do checkpoint when umount flag is not set

2015-01-23 Thread Jaegeuk Kim
On Fri, Jan 23, 2015 at 06:39:25PM +0800, Chao Yu wrote: -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, January 23, 2015 8:09 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk

Re: [f2fs-dev] [PATCH] fibmap.f2fs: fix the wrong stat info

2015-01-23 Thread Jaegeuk Kim
0 : 0] size [0x 79e00 : 499200] blksize [0x1000 : 4096] blocks[0x 268 : 616] Signed-off-by: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tools/fibmap.c | 10 +++--- 1 file changed, 7

Re: [f2fs-dev] [PATCH 2/2] f2fs: don't discard next free dnode page for an umount checkpoint

2015-02-02 Thread Jaegeuk Kim
Hi Chao, On Sat, Jan 31, 2015 at 05:06:59PM +0800, Chao Yu wrote: Previously, discard_next_dnode is added before a checkpoint to prevent that we may meet a garbage dnode page readed from next free blkaddr in recover flow. Since f2fs will skip recovery flow for a clean umount image, this

Re: [f2fs-dev] [PATCH 1/2] f2fs: don't trigger recovery for normal umount image

2015-02-02 Thread Jaegeuk Kim
Hi Chao, On Sat, Jan 31, 2015 at 04:59:49PM +0800, Chao Yu wrote: Our recovery option is on by default, so we will try to recover data for a normally umounted image when mounting it, but no data will be recovered. So it'd be better to skip the recovery for above condition. No. We should

Re: [f2fs-dev] [PATCH 5/5 v2] f2fs: introduce a batched trim

2015-02-02 Thread Jaegeuk Kim
discard commands. This is to avoid long latency due to huge trim commands. If fstrim was triggered ranging from 0 to the end of device, we should lock all the checkpoint-related mutexes, resulting in very long latency. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs.h| 2

[f2fs-dev] [PATCH 1/2] f2fs: keep PagePrivate during releasepage

2015-02-02 Thread Jaegeuk Kim
] __generic_file_write_iter+0x2a6/0x350 [8118adef] generic_file_write_iter+0x3f/0xb0 [81203081] new_sync_write+0x81/0xb0 [81203837] vfs_write+0xb7/0x1f0 [81204459] SyS_write+0x49/0xb0 [817c286d] system_call_fastpath+0x16/0x1b Signed-off-by: Jaegeuk Kim jaeg

[f2fs-dev] [PATCH 6/9 v5] xfs/086, 087: remove specific testing options in output

2015-02-05 Thread Jaegeuk Kim
This patch removes the mkfs and mount options specified in output files in xfs/086 and xfs/087. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/xfs/086 | 2 +- tests/xfs/086.out | 20 tests/xfs/087 | 2 +- tests/xfs/087.out | 9 - 4 files changed

Re: [f2fs-dev] [PATCH 2/2] f2fs: don't discard next free dnode page for an umount checkpoint

2015-02-05 Thread Jaegeuk Kim
Hi Chao, On Thu, Feb 05, 2015 at 04:16:04PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Tuesday, February 03, 2015 7:38 AM To: Chao Yu Cc: Changman Lee; linux-f2fs-devel@lists.sourceforge.net; linux-ker

Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

2015-02-05 Thread Jaegeuk Kim
lock all the checkpoint-related mutexes, resulting in very long latency. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- Documentation/ABI/testing/sysfs-fs-f2fs | 6 ++ Documentation/filesystems/f2fs.txt | 4 fs/f2fs/f2fs.h | 7 +++ fs/f2fs/segment.c

[f2fs-dev] [PATCH 9/9 v5] tests/generic: relocate xfs's tests into tests/generic/

2015-02-05 Thread Jaegeuk Kim
This patch moves the generic testcases defined in xfs into tests/generic/. xfs/085 - generic/052 xfs/086 - generic/054 xfs/087 - generic/055 Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/{xfs/085 = generic/052} | 6 +++--- tests/{xfs/085.out = generic/052.out} | 2

[f2fs-dev] [PATCH 3/9 v5] common/rc: add _require_norecovery

2015-02-05 Thread Jaegeuk Kim
to support it later. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- common/rc | 8 tests/xfs/200 | 1 + 2 files changed, 9 insertions(+) diff --git a/common/rc b/common/rc index 078d3ca..395bf6c 100644 --- a/common/rc +++ b/common/rc @@ -2332,6 +2332,14

[f2fs-dev] [PATCH 0/9 v5] make xfs/tests generic by introducing shutdown for filesystems

2015-02-05 Thread Jaegeuk Kim
- generic/050 xfs/306 - generic/051 xfs/085 - generic/052 xfs/086 - generic/054 xfs/087 - generic/055 Jaegeuk Kim (9): common/rc: add _require_scratch_shtudown common/rc: add _require_fiemap and _extent_hole_counts common/rc: add _require_norecovery tests/generic: relocate xfs's

[f2fs-dev] [PATCH 7/9 v5] common/log: add _get_log_configs for testing options

2015-02-05 Thread Jaegeuk Kim
This patch adds _get_log_configs for xfs and f2fs to test several mount options for: xfs/086 * xfs/087 In xfs/087, one more test was added, so 10 tests will be done in total. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- common/log| 47

[f2fs-dev] [PATCH 1/9 v5] common/rc: add _require_scratch_shtudown

2015-02-05 Thread Jaegeuk Kim
/087 Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- common/rc | 12 tests/xfs/053 | 1 + tests/xfs/085 | 1 + tests/xfs/086 | 1 + tests/xfs/087 | 1 + tests/xfs/137 | 1 + tests/xfs/138 | 1 + tests/xfs/139 | 1 + tests/xfs/140 | 1 + tests/xfs/179 | 1 + tests/xfs/180

[f2fs-dev] [PATCH 8/8 v4] tests/generic: relocate four xfs's tests into tests/generic/

2015-02-03 Thread Jaegeuk Kim
This patch moves the generic testcases defined in xfs into tests/generic/. xfs/051 - generic/051 xfs/085 - generic/085 xfs/086 - generic/086 xfs/087 - generic/087 Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/generic/051 | 103 + tests/generic/051.out |2 + tests

[f2fs-dev] [PATCH 7/8 v4] tests/xfs: add f2fs testcase and convert them being generic

2015-02-03 Thread Jaegeuk Kim
This patch changes the following xfs's testcases to be generic ones by adding f2fs support. xfs/051 xfs/085 xfs/086 xfs/087 Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/xfs/051 | 18 +- tests/xfs/085 |9 +- tests/xfs/086 | 34 +- tests/xfs/086

[f2fs-dev] [PATCH 1/8 v4] common/rc: add _require_scratch_shtudown

2015-02-03 Thread Jaegeuk Kim
This is to detect whether filesystem supports shutdown feature or not. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- common/rc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/common/rc b/common/rc index 5377ba0..438cd51 100644 --- a/common/rc +++ b/common/rc @@ -2320,6

[f2fs-dev] [PATCH 6/8 v4] common/rc: define dump.f2fs and logstate for f2fs

2015-02-03 Thread Jaegeuk Kim
This patch defines dump.f2fs and logstate for f2fs's clean and dirty logs. And, also it adds _link_out_file_fs to specify output according to filesystem. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- common/config | 1 + common/log| 20 +--- common/rc | 22

[f2fs-dev] [PATCH 3/8 v4] common/rc: add _require_norecovery

2015-02-03 Thread Jaegeuk Kim
This patch adds checking code whether filesystem supports norecovery mount option or not. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- common/rc | 8 1 file changed, 8 insertions(+) diff --git a/common/rc b/common/rc index d413721..72e2f99 100644 --- a/common/rc +++ b/common/rc

[f2fs-dev] [PATCH 2/8 v4] common/rc: add _require_bmap

2015-02-03 Thread Jaegeuk Kim
This is to detect whether the filesystem tool supports bmap or not. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- common/config | 2 ++ common/rc | 18 ++ 2 files changed, 20 insertions(+) diff --git a/common/config b/common/config index 235f4a1..9fb3703 100644

[f2fs-dev] [PATCH 0/8 v4] make xfs/tests generic by introducing shutdown for filesystems

2015-02-03 Thread Jaegeuk Kim
This patch-set modifies several existing xfs's tests to be used by generic filesystems. 1. FS requirement In order to activate these testcases, filesystem should support a new feature, shutdown, triggered by the following ioctl command. #define FS_IOC_SHUTDOWN _IOR('X', 125, __u32) /*

[f2fs-dev] [PATCH 5/8 v4] tests/generic: relocate xfs's tests into tests/generic/

2015-02-03 Thread Jaegeuk Kim
/306 - generic/305 * The test number was changed to address conflicts. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/generic/054 | 102 tests/generic/054.out | 10 tests/generic/137 | 106

[f2fs-dev] [PATCH 4/8 v4] tests/xfs: convert 10 xfs's tests to be generic ones

2015-02-03 Thread Jaegeuk Kim
of them need _require_bmap utils. Suggested-by: Dave Chinner da...@fromorbit.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/xfs/053 | 3 ++- tests/xfs/137 | 10 ++ tests/xfs/138 | 10 ++ tests/xfs/139 | 10 ++ tests/xfs/140 | 8 +--- tests/xfs/179 | 8

Re: [f2fs-dev] [PATCH 5/5 v3] f2fs: introduce a batched trim

2015-02-03 Thread Jaegeuk Kim
submits split discard commands. This is to avoid long latency due to huge trim commands. If fstrim was triggered ranging from 0 to the end of device, we should lock all the checkpoint-related mutexes, resulting in very long latency. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- Documentation

Re: [f2fs-dev] [PATCH 1/2 v3] xfs/087: test f2fs selectively

2015-01-22 Thread Jaegeuk Kim
On Wed, Jan 21, 2015 at 02:38:32PM +1100, Dave Chinner wrote: On Fri, Jan 09, 2015 at 03:52:45AM -0800, Jaegeuk Kim wrote: This patch add the f2fs support for xfs/087 with goingdown. xfs/087 is not really a test that should be made generic/shared; it's testing a bunch of different XFS

[f2fs-dev] [PATCH 2/2] f2fs: do checkpoint when umount flag is not set

2015-01-22 Thread Jaegeuk Kim
If the previous checkpoint was done without CP_UMOUNT flag, it needs to do checkpoint with CP_UMOUNT for the next fast boot. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/checkpoint.c | 3 ++- fs/f2fs/super.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [f2fs-dev] [PATCH 2/2] f2fs: enable recover_xattr_data to avoid cp when fsync after operating xattr

2015-01-22 Thread Jaegeuk Kim
Hi Chao, On Wed, Jan 14, 2015 at 01:01:13PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, January 14, 2015 8:22 AM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-devel@lists.sourceforge.net; linux-ker

[f2fs-dev] [PATCH 2/3] dump.f2fs: show checkpoint flag

2015-01-22 Thread Jaegeuk Kim
This patch is to show the checkpoint flag. With this flag, we can guess the last status of the partition. And, this can be used by xfstests. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fsck/main.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/fsck/main.c b/fsck

[f2fs-dev] [PATCH 1/3] fsck.f2fs: fix sit types seamlessly

2015-01-22 Thread Jaegeuk Kim
SIT types can be wrong when active_logs are 2 or 4. So, let's fix this implicitly. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fsck/fsck.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 09bb26f..a5f9adc 100644 --- a/fsck

Re: [f2fs-dev] [RFC PATCH 03/10] f2fs: introduce f2fs_map_bh to clean codes of check_extent_cache

2015-01-22 Thread Jaegeuk Kim
Hi Chao, On Mon, Jan 12, 2015 at 03:11:04PM +0800, Chao Yu wrote: This patch introduces f2fs_map_bh to clean codes of check_extent_cache. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/data.c | 42 -- 1 file changed, 28 insertions(+), 14

Re: [f2fs-dev] [RFC PATCH 04/10] f2fs: introduce universal lookup/update interface for extent cache

2015-01-22 Thread Jaegeuk Kim
Hi Chao, On Mon, Jan 12, 2015 at 03:12:13PM +0800, Chao Yu wrote: In this patch, we do these jobs: 1. rename {check,update}_extent_cache to f2fs_{lookup,update}_extent_info; 2. introduce universal lookup/update interface of extent cache: f2fs_{lookup,update}_extent_cache including above two

Re: [f2fs-dev] [RFC PATCH 06/10] f2fs: add core functions for rb-tree extent cache

2015-01-22 Thread Jaegeuk Kim
On Mon, Jan 12, 2015 at 03:14:48PM +0800, Chao Yu wrote: This patch adds core functions including slab cache init function and init/lookup/update/shrink/destroy function for rb-tree based extent cache. Thank Jaegeuk Kim and Changman Lee as they gave much suggestion about detail design

[f2fs-dev] [PATCH] f2fs: fix accessing wrong indexed data blocks

2015-02-11 Thread Jaegeuk Kim
- find_data_page - get_dnode_of_data returns wrong data index retrieved from inline_data - f2fs_submit_page_bio(wrong data index) - submit_bio(wrong data index) Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/node.c | 10 +- 1 file changed, 9 insertions

[f2fs-dev] [PATCH 1/2] f2fs: fix sparse warnings

2015-02-10 Thread Jaegeuk Kim
fs/f2fs/checkpoint.c:592:15: warning: cast to restricted __le32 fs/f2fs/trace.c:19:1: warning: symbol 'pids' was not declared. Should it be static? fs/f2fs/trace.c:21:21: warning: symbol 'last_io' was not declared. Should it be static? Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs

[f2fs-dev] [PATCH 2/2] f2fs: avoid variable length array

2015-02-10 Thread Jaegeuk Kim
Instead of using variable length array, this patch let preallocate memory for them. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/debug.c | 1 + fs/f2fs/segment.c | 10 -- fs/f2fs/segment.h | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/fs/f2fs

Re: [f2fs-dev] [PATCH v3 06/10] f2fs: add core functions for rb-tree extent cache

2015-02-17 Thread Jaegeuk Kim
function for rb-tree based extent cache. Thank Jaegeuk Kim and Changman Lee as they gave much suggestion about detail design and implementation of extent cache. Todo: * register rb-based extent cache shrink with mm shrink interface. v2: o move set_extent_info and __is_{extent,back

[f2fs-dev] [GIT PULL] f2fs updates for v3.20

2015-02-12 Thread Jaegeuk Kim
flags in struct f2fs_sb_info f2fs: merge {invalidate,release}page for meta/node/data pages f2fs: fix to use highmem for pages of newly created directory f2fs: avoid data offset overflow when lseeking huge file f2fs: use spinlock for segmap_lock instead of rwlock Jaegeuk Kim

[f2fs-dev] [PATCH 4/5] f2fs: should fail mount when trying to recover data on read-only dev

2015-01-27 Thread Jaegeuk Kim
If device is read-only, we should not proceed data recovery. But, if the previous checkpoint was done by normal clean shutdown, it's safe to proceed the recovery, since there will be no data to be recovered. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/super.c | 9 + 1 file

[f2fs-dev] [PATCH 3/5] f2fs: avoid write_checkpoint if f2fs is mounted readonly

2015-01-27 Thread Jaegeuk Kim
Do not change any partition when f2fs is changed to readonly mode. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/checkpoint.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c index 79f8281..1ee6162 100644 --- a/fs/f2fs/checkpoint.c

[f2fs-dev] [PATCH 2/5] f2fs: support norecovery mount option

2015-01-27 Thread Jaegeuk Kim
., xfstests/200) Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/super.c | 8 1 file changed, 8 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index fbc7f5a..0ca1fb2 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -42,6 +42,7 @@ static struct kset *f2fs_kset; enum

[f2fs-dev] [PATCH 1/5] f2fs: fix not to drop mount options when retrying fill_super

2015-01-27 Thread Jaegeuk Kim
If wrong mount option was requested, f2fs tries to fill_super again. But, during the next trial, f2fs has no valid mount options, since parse_options deleted all the separators in the original string. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/super.c | 15 --- 1 file

[f2fs-dev] [PATCH 5/5] f2fs: introduce a batched trim

2015-01-27 Thread Jaegeuk Kim
This patch introduces a batched trimming feature, which submits split discard commands. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs.h| 1 + fs/f2fs/segment.c | 15 ++- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs

Re: [f2fs-dev] [PATCH 2/5] f2fs: support norecovery mount option

2015-01-29 Thread Jaegeuk Kim
Hi Chao, On Thu, Jan 29, 2015 at 07:52:56PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: linux-fsdevel-ow...@vger.kernel.org [mailto:linux-fsdevel-ow...@vger.kernel.org] On Behalf Of Jaegeuk Kim Sent: Wednesday, January 28, 2015 7:32 AM To: linux-ker

Re: [f2fs-dev] [PATCH 1/5 v2] f2fs: fix not to drop mount options when retrying fill_super

2015-01-29 Thread Jaegeuk Kim
Chang log from v1: o fix memory leak pointed by Chao From 82760814db6a01539ad15026b0469686110d92bc Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaeg...@kernel.org Date: Fri, 23 Jan 2015 17:41:39 -0800 Subject: [PATCH] f2fs: fix not to drop mount options when retrying fill_super If wrong mount

Re: [f2fs-dev] [PATCH 2/5 v2] f2fs: support norecovery mount option

2015-01-29 Thread Jaegeuk Kim
Change log from v1: o add description for the new mount option in Documentation/filesystems/f2fs.txt From 079dbb14c7d91d90863c9be4d9337b8ec086db7e Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaeg...@kernel.org Date: Fri, 23 Jan 2015 18:33:46 -0800 Subject: [PATCH] f2fs: support norecovery mount

Re: [f2fs-dev] [PATCH] f2fs: fix wrong memory footprint statistics in debugfs

2015-01-10 Thread Jaegeuk Kim
On Sat, Jan 10, 2015 at 08:09:52PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, January 07, 2015 3:49 AM To: Chao Yu Cc: Changman Lee; linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel.org

[f2fs-dev] [PATCH 1/2] xfs: introduce a generic shutdown ioctl

2015-01-09 Thread Jaegeuk Kim
This patch introduces a generic ioctl for fs shutdown used by xfs. Cc: Dave Chinner da...@fromorbit.com Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/xfs/xfs_fs.h | 8 include/uapi/linux/fs.h | 8 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/fs

[f2fs-dev] [PATCH 2/2] f2fs: support fs shutdown

2015-01-09 Thread Jaegeuk Kim
. FS_GOING_DOWN_METASYNC : this will do checkpoint before shutdown. 3. FS_GOING_DOWN_NOSYNC : this will trigger shutdown as is. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/file.c | 37 + 1 file changed, 37 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs

[f2fs-dev] [PATCH 1/4] f2fs: clean up to remove parameter

2015-01-06 Thread Jaegeuk Kim
This patch uses dn-data_blkaddr as a parameter for the destination block address. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 27 ++- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 3 ++- fs/f2fs/inline.c | 2 +- fs/f2fs/recovery.c | 3

[f2fs-dev] [PATCH 3/4] f2fs: remove uncovered code path

2015-01-06 Thread Jaegeuk Kim
This patch removes unnecessary function calls. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 155885b..3e0f5f3 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs

[f2fs-dev] [PATCH 4/4] f2fs: align direct_io'ed data to section

2015-01-06 Thread Jaegeuk Kim
. Thus, since f2fs has a section that is well aligned to FTL units, we can align the block address to the section size so that f2fs avoids this misalignment. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c| 7 +-- fs/f2fs/f2fs.h| 3 ++- fs/f2fs/segment.c | 27

Re: [f2fs-dev] [PATCH 1/2] f2fs: get rid of kzalloc in __recover_inline_status

2015-01-06 Thread Jaegeuk Kim
Hi Chao, On Tue, Jan 06, 2015 at 02:28:43PM +0800, Chao Yu wrote: We use kzalloc to allocate memory in __recover_inline_status, and use this all-zero memory to check the inline date content of inode page by comparing them. This is low effective and not needed, let's check inline date content

Re: [f2fs-dev] [PATCH] f2fs: fix wrong memory footprint statistics in debugfs

2015-01-06 Thread Jaegeuk Kim
Hi Chao, On Tue, Jan 06, 2015 at 04:40:49PM +0800, Chao Yu wrote: Our value of memory footprint statistics showed in debugfs is not calculated correctly. Fix it in this patch. Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs/debug.c | 15 ++- 1 file changed, 10

Re: [f2fs-dev] [PATCH 2/2] f2fs: enable recover_xattr_data to avoid cp when fsync after operating xattr

2015-01-06 Thread Jaegeuk Kim
Hi Chao, On Tue, Jan 06, 2015 at 02:29:40PM +0800, Chao Yu wrote: Now if we call fsync() after we update the xattr date belongs to the file, f2fs will do checkpoint to keep data. This can cause low performance because checkpoint block most operation and write lots of blocks. So we'd

Re: [f2fs-dev] [PATCH] f2fs: add adaptive ssr/ipu policy as valid blocks in dirty segments

2015-01-06 Thread Jaegeuk Kim
Hi Changman, On Wed, Dec 31, 2014 at 02:15:22PM +0900, Changman Lee wrote: If there is not enough invalid area in dirty segments, SSR won't get any gains. In the case, IPU could be better than SSR. This patch is for changing write style into IPU or SSR according to valid blocks in dirty

Re: [f2fs-dev] [RFC PATCH] f2fs: add extent cache base on rb-tree

2015-01-06 Thread Jaegeuk Kim
Hi Chao, On Sun, Jan 04, 2015 at 04:24:10PM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, December 31, 2014 4:26 PM To: Chao Yu Cc: 'Changman Lee'; linux-f2fs-devel@lists.sourceforge.net; linux-ker

[f2fs-dev] [PATCH 1/2] f2fs: avoid infinite loop on cp_error

2015-01-13 Thread Jaegeuk Kim
If cp_error is set, we should avoid all the infinite loop. In f2fs_sync_file, there is a hole, and this patch fixes that. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/file.c | 4 1 file changed, 4 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index a7114858

[f2fs-dev] [PATCH 2/2] f2fs: update memory footprint information

2015-01-13 Thread Jaegeuk Kim
This patch adds missing memory usages, and splits them in detail. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/debug.c | 24 +--- fs/f2fs/f2fs.h | 2 +- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index

[f2fs-dev] [PATCH 1/2 v3] xfs/087: test f2fs selectively

2015-01-09 Thread Jaegeuk Kim
This patch add the f2fs support for xfs/087 with goingdown. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- common/rc | 10 + tests/xfs/087 | 53 +++-- tests/xfs/087.out | 389 - tests/xfs/087.out.f2fs | 583

[f2fs-dev] [PATCH 2/2 v3] xfs/087: move to shared/087

2015-01-09 Thread Jaegeuk Kim
This patch moves xfs/087 to shared/. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/shared/087 | 174 ++ tests/shared/087.out.f2fs | 583 ++ tests/shared/087.out.xfs | 389 +++ tests/shared

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Jaegeuk Kim
On Fri, Jan 09, 2015 at 09:04:12AM +1100, Dave Chinner wrote: On Thu, Jan 08, 2015 at 01:21:29PM -0800, Jaegeuk Kim wrote: On Fri, Jan 09, 2015 at 07:54:16AM +1100, Dave Chinner wrote: On Thu, Jan 08, 2015 at 02:33:17PM -0600, Eric Sandeen wrote: On 1/8/15 2:18 PM, Jaegeuk Kim wrote

[f2fs-dev] [PATCH 2/2 v2] xfs/087: move to shared/087

2015-01-08 Thread Jaegeuk Kim
This patch moves xfs/087 to shared/. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/shared/087 | 169 ++ tests/shared/087.out | 389 +++ tests/shared/group | 1 + tests/xfs/087| 169

[f2fs-dev] [PATCH 1/2 v2] xfs/087: test f2fs selectively

2015-01-08 Thread Jaegeuk Kim
This patch add the f2fs support for xfs/087 with goingdown. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/xfs/087 | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/tests/xfs/087 b/tests/xfs/087 index 3a3fb49..9dc81c7 100755

Re: [f2fs-dev] [PATCH 2/9 v6] common/rc: add _require_fiemap and counting extents and holes

2015-02-10 Thread Jaegeuk Kim
) xfs/139 (data vs filesize vs partial truncate) xfs/140 (data vs filesize vs extending truncate) xfs/179 (data vs filesize w/ fsync) xfs/180 (data vs filesize w/ sync) xfs/182 (data vs filesize w/ recovery) Signed-off-by: Jaegeuk Kim jaeg...@kernel.org

Re: [f2fs-dev] [PATCH 8/9 v6] xfs/087: give quota mount option per filesystem

2015-02-10 Thread Jaegeuk Kim
Change log from v5: o move function into the test script -- 8 -- This patch add _get_quota_option to assign the mount option selectively. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/xfs/087 | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git

Re: [f2fs-dev] [PATCH 0/9 v5] make xfs/tests generic by introducing shutdown for filesystems

2015-02-10 Thread Jaegeuk Kim
On Tue, Feb 10, 2015 at 05:04:14PM +1100, Dave Chinner wrote: On Thu, Feb 05, 2015 at 10:37:04PM -0800, Jaegeuk Kim wrote: Thanks to Dave. :) Change log from v4: o add mkfs in _require_scratch_shutdown o add _require_fiemap and _extent_hole_counts o add _require_logstate o

[f2fs-dev] [PATCH 2/4] f2fs: call set_buffer_new for get_block

2015-02-10 Thread Jaegeuk Kim
This patch fixes wrong handling of buffer_new flag in get_block. If f2fs allocates new blocks and mapped buffer_head, it needs to set buffer_new for the bh_result. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[f2fs-dev] [PATCH 4/4] f2fs: allocate data blocks in advance for f2fs_direct_IO

2015-02-10 Thread Jaegeuk Kim
This patch adds preallocation for data blocks to prepare f2fs_direct_IO. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 57 ++--- 1 file changed, 54 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c

[f2fs-dev] [PATCH 3/6] f2fs: free radix_tree_nodes used by nat_set entries

2015-01-08 Thread Jaegeuk Kim
In the normal case, the radix_tree_nodes are freed successfully. But, when cp_error was detected, we should destroy them forcefully. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/node.c | 21 +++-- fs/f2fs/node.h | 1 + 2 files changed, 20 insertions(+), 2 deletions

[f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Jaegeuk Kim
This patch add an ioctl to shutdown f2fs, which stops all the further block writes after this point. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index

[f2fs-dev] [PATCH 4/6] f2fs: add nat/sit entries into status

2015-01-08 Thread Jaegeuk Kim
This patch adds NAT/SIT entry informations. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/debug.c | 8 +--- fs/f2fs/f2fs.h | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c index dd7835b..1f0fb58 100644 --- a/fs/f2fs/debug.c

[f2fs-dev] [PATCH 6/6] f2fs: add f2fs_destroy_trace_ios to free radix tree

2015-01-08 Thread Jaegeuk Kim
This patch removes radix tree after finishing tracing IOs. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/super.c | 1 + fs/f2fs/trace.c | 37 + fs/f2fs/trace.h | 2 ++ 3 files changed, 40 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs

[f2fs-dev] [PATCH 1/2] src/godown: support f2fs triggering specific ioctl

2015-01-08 Thread Jaegeuk Kim
This patch triggers the F2FS-related ioctl for godown. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- src/godown.c | 88 1 file changed, 65 insertions(+), 23 deletions(-) diff --git a/src/godown.c b/src/godown.c index b140a41

[f2fs-dev] [PATCH 2/2] f2fs/087: test power failure test using godown

2015-01-08 Thread Jaegeuk Kim
This patch adds f2fs/087 to test power failure by using godown. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/f2fs/087 | 88 ++ tests/f2fs/087.out | 21 + tests/f2fs/group | 1 + 3 files changed, 110 insertions

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Jaegeuk Kim
On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote: On 1/8/15 12:10 PM, Jaegeuk Kim wrote: This patch add an ioctl to shutdown f2fs, which stops all the further block writes after this point. would it make sense to just re-use the xfs ioctl nr, if the semantics are the same

Re: [f2fs-dev] [PATCH 2/6] f2fs: support goingdown for fs shutdown

2015-01-08 Thread Jaegeuk Kim
On Fri, Jan 09, 2015 at 07:54:16AM +1100, Dave Chinner wrote: On Thu, Jan 08, 2015 at 02:33:17PM -0600, Eric Sandeen wrote: On 1/8/15 2:18 PM, Jaegeuk Kim wrote: On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote: On 1/8/15 12:10 PM, Jaegeuk Kim wrote: This patch add an ioctl

Re: [f2fs-dev] [PATCH 1/2] src/godown: support f2fs triggering specific ioctl

2015-01-08 Thread Jaegeuk Kim
On Thu, Jan 08, 2015 at 12:44:56PM -0600, Eric Sandeen wrote: On 1/8/15 12:31 PM, Jaegeuk Kim wrote: This patch triggers the F2FS-related ioctl for godown. hohum, wouldn't it be a whole lot easier to just re-use the XFS ioctl number in f2fs? Then you wouldn't have to duplicate all

Re: [f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data

2015-03-18 Thread Jaegeuk Kim
Hi, On Wed, Mar 18, 2015 at 09:12:00AM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Wednesday, March 18, 2015 12:58 AM To: linux-ker...@vger.kernel.org; linux-fsde...@vger.kernel.org; linux-f2fs-devel

Re: [f2fs-dev] [PATCH 2/4 v2] f2fs: set buffer_new when new blocks are allocated

2015-03-18 Thread Jaegeuk Kim
Hi Chao, Thanks for the review. Change log from v1: o add clear_buffer_new() in f2fs_map_bh This patch modifies to call set_buffer_new, if new blocks are allocated. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

Re: [f2fs-dev] [PATCH 1/2] generic/067: add a testcase to check some inline truncation behaviors

2015-03-18 Thread Jaegeuk Kim
Hi Dave, Thank you for the review. I'll resend this series with precise description and fixes as you pointed. Thanks, On Wed, Mar 18, 2015 at 02:46:53PM +1100, Dave Chinner wrote: On Tue, Mar 17, 2015 at 10:32:51AM -0700, Jaegeuk Kim wrote: This patch introduces a new testcase, generic/067

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-18 Thread Jaegeuk Kim
Hi, On Wed, Mar 18, 2015 at 04:58:52PM +0800, Wanpeng Li wrote: Hi Jaegeuk, On Tue, Mar 17, 2015 at 10:21:27AM -0700, Jaegeuk Kim wrote: - err = page_symlink(inode, symname, symlen); + + if (symlen MAX_FAST_SYMLINK_SIZE) { + /* slow symlink */ + inode-i_op

[f2fs-dev] [PATCH 1/2] f2fs: avoid punch_hole overhead when releasing volatile data

2015-03-18 Thread Jaegeuk Kim
This patch is to avoid some punch_hole overhead when releasing volatile data. If volatile data was not written yet, we just can make the first page as zero. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 2 ++ fs/f2fs/f2fs.h | 6 ++ fs/f2fs/file.c | 6 ++ fs

[f2fs-dev] [PATCH 2/2] f2fs: add some tracepoints to debug volatile and atomic writes

2015-03-18 Thread Jaegeuk Kim
Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/data.c | 2 ++ fs/f2fs/f2fs.h | 4 fs/f2fs/segment.c | 4 include/trace/events/f2fs.h | 27 ++- 4 files changed, 36 insertions(+), 1 deletion(-) diff --git a/fs/f2fs

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-17 Thread Jaegeuk Kim
Hi guys, Sorry for the delay due to travel. On Fri, Mar 13, 2015 at 02:33:39PM +0800, Wanpeng Li wrote: This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to

[f2fs-dev] [PATCH 1/2] generic/067: add a testcase to check some inline truncation behaviors

2015-03-17 Thread Jaegeuk Kim
This patch introduces a new testcase, generic/067, to test several truncation cases under the inline feature supported by filesystems. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- tests/generic/067 | 114 ++ tests/generic/067.out | 41

[f2fs-dev] [PATCH 2/3] fsck.f2fs: show cp_state for fsck.f2fs

2015-03-21 Thread Jaegeuk Kim
This patch adds to show cp_state during fsck.f2fs. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fsck/f2fs.h | 1 - fsck/fsck.h | 1 + fsck/main.c | 21 + fsck/mount.c | 20 4 files changed, 26 insertions(+), 17 deletions(-) diff --git a/fsck

[f2fs-dev] [PATCH 3/3] fsck.f2fs: show total sectors consumed by filesystem

2015-03-21 Thread Jaegeuk Kim
This patch shows the information about the number of total sectors composing filesystem. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fsck/mount.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fsck/mount.c b/fsck/mount.c index 879cadb..dfaa596 100644 --- a/fsck/mount.c +++ b

Re: [f2fs-dev] [PATCH] f2fs: enable inline data by default

2015-03-20 Thread Jaegeuk Kim
Hi Wanpeng, Indeed. Please don't do this for backward compatibility. Thanks, On Thu, Mar 19, 2015 at 01:11:35PM +0800, Wanpeng Li wrote: Enable inline_data feature by default since it brings us better performance and space utilization and now has already stable. Signed-off-by: Wanpeng Li

Re: [f2fs-dev] [PATCH 1/1] f2fs: correctly check empty xattr key

2015-03-20 Thread Jaegeuk Kim
Hi Taesoo, On Fri, Mar 20, 2015 at 12:19:07AM -0400, Taesoo Kim wrote: When xattr name (key) is empty (), correctly return -EINVAL error. xattr_advise_set/get() seem to make the same mistake. The intention here is to disallow any xattr name, since this is used to get or set the i_advise value

[f2fs-dev] [PATCH 4/4] f2fs: avoid wrong f2fs_bug_on when truncating inline_data

2015-03-17 Thread Jaegeuk Kim
on file #A. 4. write data at 8192 offset. -- f2fs_write_begin - -ENOSPC = f2fs_convert_inline_page - f2fs_write_failed - truncate_blocks - truncate_inline_inode BUG_ON, since i_size is 4096. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/inline.c | 7

[f2fs-dev] [PATCH 1/4] f2fs: fix to cover sentry_lock for block allocation

2015-03-17 Thread Jaegeuk Kim
- mutex_lock(curseg-curseg_mutex); - s_ops-allocate_segment - new_curseg/change_curseg - reset_curseg - __set_sit_entry_type - __mark_sit_entry_dirty - set_bit(dirty_sentries_bitmap) - dirty_sentries++; Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs

Re: [f2fs-dev] [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-09 Thread Jaegeuk Kim
think of this? Thanks, Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/f2fs.h | 1 + fs/f2fs/file.c | 1 + fs/f2fs/inline.c | 16 +++- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 511d6cd

Re: [f2fs-dev] [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-05 Thread Jaegeuk Kim
Hi Chao, On Thu, Mar 05, 2015 at 05:41:32PM +0800, Chao Yu wrote: Previously if inode is with inline data, we will try to invalid partial inline data in page #0 when we truncate size of inode in truncate_partial_data_page(). And then we set page #0 to dirty, after this we can synchronize

Re: [f2fs-dev] [PATCH] f2fs: fix to truncate inline data past EOF

2015-03-08 Thread Jaegeuk Kim
Hi Chao, On Mon, Mar 09, 2015 at 10:24:35AM +0800, Chao Yu wrote: Hi Jaegeuk, -Original Message- From: Jaegeuk Kim [mailto:jaeg...@kernel.org] Sent: Friday, March 06, 2015 5:34 AM To: Chao Yu Cc: Changman Lee; linux-f2fs-devel@lists.sourceforge.net; linux-ker

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix get stale meta pages when build free nids

2015-03-08 Thread Jaegeuk Kim
Hi Wanpeng, On Mon, Mar 09, 2015 at 11:00:54AM +0800, Wanpeng Li wrote: The blocks of nat pages to be scanned will be readahead when build free nids. The start blkno will be adjusted to 0 when the intended range over max_nids, then function ra_meta_pages readahead the right blkno, however,

Re: [f2fs-dev] [PATCH] F2FS support

2015-03-28 Thread Jaegeuk Kim
Hi Andrei, On Sat, Mar 28, 2015 at 10:31:55AM +0300, Andrei Borzenkov wrote: В Tue, 24 Mar 2015 01:19:00 -0700 Jaegeuk Kim jaeg...@kernel.org пишет: * Makefile.util.def: Add f2fs.c. * doc/grub.texi: Add f2fs description. * grub-core/Makefile.core.def: Add f2fs module. * grub-core

Re: [f2fs-dev] [PATCH 2/2] generic/066: add _require_metadata_replay

2015-02-27 Thread Jaegeuk Kim
Hi Lukas, On Fri, Feb 27, 2015 at 12:34:09PM +0100, Lukáš Czerner wrote: On Thu, 26 Feb 2015, Jaegeuk Kim wrote: Date: Thu, 26 Feb 2015 17:23:47 -0800 From: Jaegeuk Kim jaeg...@kernel.org To: Dave Chinner da...@fromorbit.com Cc: fste...@vger.kernel.org, linux-f2fs-devel

[f2fs-dev] [PATCH 2/2] f2fs: check its block allocation to avoid producing wrong dirty pages

2015-02-27 Thread Jaegeuk Kim
If a page is cached but its block was deallocated, we don't need to make the page dirty again by gc and truncate_partial_data_page. In that case, it needs to check its block allocation all the time instead of giving up-to-date page. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs

[f2fs-dev] [PATCH 1/3] f2fs: avoid to trigger writepage during POR

2015-03-03 Thread Jaegeuk Kim
] bdi_writeback_workfn+0x148/0x980 [810a3782] process_one_work+0x1e2/0x840 [810a3f01] worker_thread+0x121/0x460 [810a9dc8] kthread+0xf8/0x110 [81863dbc] ret_from_fork+0x7c/0xb0 Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs

[f2fs-dev] [PATCH 3/3] f2fs: report -ENOENT for unreached data indices

2015-03-03 Thread Jaegeuk Kim
If inode has inline_data, it should report -ENOENT when accessing out-of-bound region. This is used by f2fs_fiemap which treats -ENOENT with no error. Signed-off-by: Jaegeuk Kim jaeg...@kernel.org --- fs/f2fs/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs

  1   2   3   4   5   6   7   8   9   10   >