[f2fs-dev] [PATCH 2/3] f2fs: fix dentry recovery routine

2013-05-27 Thread Jaegeuk Kim
and its inode and then recover newly created dentry. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/recovery.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index 0dd2ce1..85f5e54 100644 --- a/fs

Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-05-27 Thread Jaegeuk Kim
Hi, 2013-05-27 (월), 13:45 +0900, Namjae Jeon: 2013/5/27, Jaegeuk Kim jaegeuk@samsung.com: Hi Namjae, Hi Jaegeuk. First, Thanks for your interest. This is an interesting functionality. Could you describe why and when we need to do this? What are pros and cons? How can we use

Re: [f2fs-dev] [RFC 0/5] Enable f2fs support inline data

2013-06-03 Thread Jaegeuk Kim
| 156 +++ fs/f2fs/inode.c |8 +++ include/linux/f2fs_fs.h |5 ++ include/trace/events/f2fs.h | 69 +++ 9 files changed, 402 insertions(+), 4 deletions(-) create mode 100644 fs/f2fs/inline.c -- Jaegeuk

[f2fs-dev] [PATCH 1/2] f2fs: fix iget/iput of dir during recovery

2013-06-06 Thread Jaegeuk Kim
set_page_dirty() is called. So let's add this newly got inode into the list explicitly, and put it at the end of the recovery routine. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 55 +--- fs/f2fs/f2fs.h | 1 + fs/f2fs

Re: [f2fs-dev] [PATCH 2/2] f2fs: support xattr security labels

2013-06-07 Thread Jaegeuk Kim
Hi, Thank you for the review. I agreed all, and will submit v3. Thanks, 2013-06-07 (금), 15:13 -0700, Casey Schaufler: On 6/6/2013 10:55 PM, Jaegeuk Kim wrote: This patch adds the support of security labels for f2fs, which will be used by SElinux. Please be inclusive. Security xattrs

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: support xattr security labels

2013-06-07 Thread Jaegeuk Kim
Change log from v2: o fix description and simplify a code line (commented by Casey Schaufler) Change log from v1: o fix a bug From 9f889afcd74a58d9a538fa02f4af31d11eb17c54 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Mon, 3 Jun 2013 19:46:19 +0900 Subject: [PATCH

[f2fs-dev] [PATCH 1/2] lib, mkfs: fix endian conversion for crc calculation

2013-06-19 Thread Jaegeuk Kim
From 860da681961e6891d625abffa02d6df7dea4f5b2 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Wed, 19 Jun 2013 20:49:47 +0900 Subject: [PATCH 1/2] lib, mkfs: fix endian conversion for crc calculation Cc: linux-fsde...@vger.kernel.org, linux-ker...@vger.kernel.org, linux

[f2fs-dev] [PATCH] f2fs: fix crc endian conversion

2013-06-19 Thread Jaegeuk Kim
From ed1e92d596f5356ff2f8f8af2818d36ca31f5cf1 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Wed, 19 Jun 2013 20:47:19 +0900 Subject: [PATCH] f2fs: fix crc endian conversion Cc: linux-fsde...@vger.kernel.org, linux-ker...@vger.kernel.org, linux-f2fs-devel

Re: [f2fs-dev] configure failed even through libuuid is installed

2013-06-24 Thread Jaegeuk Kim
token `libuuid,' ./configure: line 12339: `PKG_CHECK_MODULES(libuuid, uuid)' Regards, Ryan -- Jaegeuk Kim Samsung -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows

Re: [f2fs-dev] [PATCH] f2fs: Remove the unused argument sbi of func destroy_fsync_dnodes()

2013-06-26 Thread Jaegeuk Kim
); kmem_cache_destroy(fsync_entry_slab); sbi-por_doing = 0; if (!err) -- Jaegeuk Kim Samsung -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows

[f2fs-dev] [PATCH 1/2] f2fs: remove reusing any prefree segments

2013-06-26 Thread Jaegeuk Kim
such as y or y+1, we lost the old node blocks so that f2fs even cannot start roll-forward recovery. Therefore, I suggest that we should remove reusing prefree segments. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/segment.c | 56

[f2fs-dev] [PATCH 2/2] f2fs: fix to recover i_size from roll-forward

2013-06-26 Thread Jaegeuk Kim
updated data index excluding inode metadata updates. So, this patch introduces write_end in which updates inode block too when the i_size is changed. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion

Re: [f2fs-dev] [PATCH RESEND] f2fs: Remove the unused argument sbi of func destroy_fsync_dnodes()

2013-06-26 Thread Jaegeuk Kim
); BUG_ON(!list_empty(inode_list)); out: - destroy_fsync_dnodes(sbi, inode_list); + destroy_fsync_dnodes(inode_list); kmem_cache_destroy(fsync_entry_slab); sbi-por_doing = 0; if (!err) -- Jaegeuk Kim Samsung

Re: [f2fs-dev] [PATCH 2/2] f2fs: add sysfs support for controlling the gc_thread

2013-06-26 Thread Jaegeuk Kim
Hi, 2013-06-26 (수), 14:10 +0900, Namjae Jeon: 2013/6/25, Jaegeuk Kim jaegeuk@samsung.com: - any priority scheme for cleaning? Could you plz tell me a little more detail ? I meant, as well as the GC times, user also gives a kind of status like: LONG_IDLE, SHORT_IDLE, something like

[f2fs-dev] [PATCH] f2fs: fix readdir incorrectness

2013-07-04 Thread Jaegeuk Kim
, name length = 6, total files = 4096, nproc=1 4097 files created This bug is due to the misupdate of directory position in ctx. So, this patch fixes this. CC: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/dir.c | 5 +++-- 1 file changed, 3

[f2fs-dev] [PATCH] f2fs: fix a build failure due to missing the kobject header

2013-08-08 Thread Jaegeuk Kim
file in dir.c. So, this patch move the header file to the right location, f2fs.h. CC: Namjae Jeon namjae.j...@samsung.com Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h | 1 + fs/f2fs/super.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h

[f2fs-dev] [PATCH 3/3] f2fs: introduce cur_cp_versioin function to reduce code size

2013-08-09 Thread Jaegeuk Kim
This patch introduces a new inline function, cur_cp_version, to reduce redundant codes. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 6 +++--- fs/f2fs/f2fs.h | 7 ++- fs/f2fs/file.c | 3 +-- fs/f2fs/recovery.c | 4 ++-- fs/f2fs/xattr.c | 2

[f2fs-dev] [PATCH 1/5] f2fs: add flags for inline xattrs

2013-08-26 Thread Jaegeuk Kim
This patch adds basic inode flags for inline xattrs, F2FS_INLINE_XATTR, and add a mount option, inline_xattr, which is enabled when xattr is set. If the mount option is enabled, all the files are marked with the inline_xattrs flag. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs

[f2fs-dev] [PATCH 3/5] f2fs: introduce __find_xattr for readability

2013-08-26 Thread Jaegeuk Kim
The __find_xattr is to search the wanted xattr entry starting from the base_addr. If not found, the returned entry is the last empty xattr entry that can be allocated newly. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/xattr.c | 46

[f2fs-dev] [PATCH 5/5] f2fs: support the inline xattrs

2013-08-26 Thread Jaegeuk Kim
will not touch any existing files and newly created files as well. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h | 16 fs/f2fs/node.c | 7 ++ fs/f2fs/xattr.c | 249 fs/f2fs/xattr.h | 12

[f2fs-dev] [PATCH 4/5] f2fs: add the truncate_xattr_node function

2013-08-26 Thread Jaegeuk Kim
The truncate_xattr_node function will be used by inline xattr. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h | 1 + fs/f2fs/node.c | 39 --- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs

[f2fs-dev] [PATCH 2/2] f2fs: avoid an overflow during utilization calculation

2013-09-03 Thread Jaegeuk Kim
The current f2fs uses all the block counts with 32 bit numbers, which is able to cover about 15TB volume. But in calculation of utilization, f2fs multiplies the count by 100 which can induce overflow. This patch fixes this. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs

Re: [f2fs-dev] [PATCH] f2fs: optimize gc for better performance

2013-09-04 Thread Jaegeuk Kim
Hi Jin, 2013-09-04 (수), 07:59 +0800, Jin Xu: Hi Jaegeuk, On 03/09/2013 08:45, Jaegeuk Kim wrote: Hi Jin, [...] It seems that we can obtain the performance gain just by setting the MAX_VICTIM_SEARCH to 4096, for example. So, how about just adding an ending criteria like below

Re: [f2fs-dev] [PATCH] f2fs: optimize gc for better performance

2013-09-04 Thread Jaegeuk Kim
Hi Jin, 2013-09-04 (수), 21:17 +0800, Jin Xu: Hi Jaegeuk, On 04/09/2013 17:40, Jaegeuk Kim wrote: Hi Jin, 2013-09-04 (수), 07:59 +0800, Jin Xu: Hi Jaegeuk, On 03/09/2013 08:45, Jaegeuk Kim wrote: Hi Jin, [...] It seems that we can obtain the performance gain just

Re: [f2fs-dev] [PATCH] f2fs: optimize fs_lock for better performance

2013-09-09 Thread Jaegeuk Kim
); for (i = 0; i NR_GLOBAL_LOCKS; i++) mutex_init(sbi-fs_lock[i]); + spin_lock_init(sbi-spin_lock); mutex_init(sbi-node_write); sbi-por_doing = 0; spin_lock_init(sbi-stat_lock); (END) -- Jaegeuk Kim Samsung

Re: [f2fs-dev] Crash after unclean shutdown

2013-10-06 Thread Jaegeuk Kim
-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- Jaegeuk Kim Samsung -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application

Re: [f2fs-dev] [PATCH]f2fs: avoid congestion_wait when do_checkpoint for better performance

2013-10-06 Thread Jaegeuk Kim
) mutex_init(sbi-gc_mutex); mutex_init(sbi-writepages); mutex_init(sbi-cp_mutex); + init_waitqueue_head(sbi-writeback_wqh); for (i = 0; i NR_GLOBAL_LOCKS; i++) mutex_init(sbi-fs_lock[i]); mutex_init(sbi-node_write); -- Jaegeuk Kim Samsung

[f2fs-dev] [PATCH] f2fs: avoid unnecessary checkpoints

2013-10-07 Thread Jaegeuk Kim
During the f2fs_put_super procedure, we don't need to conduct checkpoint all the time, since we don't need to do that if superblock is clean. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs

Re: [f2fs-dev] f2fs using tons of cpu

2013-10-09 Thread Jaegeuk Kim
Use% Mounted on /dev/mapper/backups 118G 91G 27G 78% /home/folkert/backups Kernel: folkert@vnvnation ~ $ uname -r 3.9.8+ Folkert van Heusden -- Jaegeuk Kim Samsung -- October Webinars: Code

[f2fs-dev] [PATCH] f2fs: fix the starvation problem on cp_rwsem

2013-10-09 Thread Jaegeuk Kim
didn't need to do this before neither. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h | 13 - fs/f2fs/super.c | 1 - 2 files changed, 14 deletions(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index a955a59..308967b 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs

Re: [f2fs-dev] BUG_ON in recovery.c after powercut

2013-10-14 Thread Jaegeuk Kim
let me know if you need more information, or if I should do some more testing. Cheers, Jan -- Jaegeuk Kim Samsung -- October Webinars: Code for Performance Free Intel webinars can help you accelerate

[f2fs-dev] [PATCH] f2fs: avoid to write during the recovery

2013-10-17 Thread Jaegeuk Kim
This patch enhances the recovery routine not to write any data/node/meta until its completion. If any writes are sent to the disk, it could contaminate the written history that will be used for further recovery. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 2

Re: [f2fs-dev] [Bug] Inaccessible, unerasable file

2013-10-22 Thread Jaegeuk Kim
simply. It may need scan the whole partition to find the stale inode block. Two questions. - Have you experienced any sudden power-off before? - Can I test with the repository having the shared.h that you used? (I'd like to do a simple test storing that repository.) Thanks, -- Jaegeuk Kim Samsung

Re: [f2fs-dev] [PATCH] f2fs: delete and free dirty dir freeing inode entry when sync dirty dir inodes

2013-10-22 Thread Jaegeuk Kim
); + kmem_cache_free(inode_entry_slab, entry); } + goto retry; } -- Jaegeuk Kim Samsung -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips

Re: [f2fs-dev] [PATCH] f2fs: check all ones or zeros bitmap with integer data type for better mount performance

2013-10-22 Thread Jaegeuk Kim
-- Jaegeuk Kim Samsung -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel

Re: [f2fs-dev] [PATCH V2] f2fs: introduce f2fs_kmem_cache_alloc to hide the unfailed, kmem cache allocation

2013-10-22 Thread Jaegeuk Kim
) + return 0; } + + i = f2fs_kmem_cache_alloc(free_nid_slab, GFP_NOFS); i-nid = nid; i-state = NID_NEW; -- Jaegeuk Kim Samsung -- October Webinars: Code for Performance Free Intel webinars can

[f2fs-dev] [PATCH] f2fs: clean up several status-related operations

2013-10-23 Thread Jaegeuk Kim
This patch cleans up improper definitions that update some status information. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 8 ++-- fs/f2fs/data.c | 12 +++- fs/f2fs/f2fs.h | 14 +- fs/f2fs/gc.c | 4 +--- fs/f2fs

Re: [f2fs-dev] [Bug] Inaccessible, unerasable file

2013-10-23 Thread Jaegeuk Kim
? It is the best you can give me the broken image though. Thanks, Such being the case, I have no need to restore the file, but being able to have it properly deleted would be nice. Yours tastky On 22.10.2013 13:09, Jaegeuk Kim wrote: Hi, Thank you for the report. 2013-10-19 (토), 19:36 +0200

[f2fs-dev] [PATCH 3/3] f2fs: add reclaiming control by sysfs

2013-10-24 Thread Jaegeuk Kim
This patch adds a control method in sysfs to reclaim prefree segments. Signed-off-by: Changman Lee cm224@samsung.com Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- Documentation/filesystems/f2fs.txt | 6 + fs/f2fs/super.c| 50

[f2fs-dev] [PATCH 2/3] f2fs: introduce f2fs_balance_fs_bg for some background jobs

2013-10-24 Thread Jaegeuk Kim
This patch merges some background jobs into this new function. Signed-off-by: Changman Lee cm224@samsung.com Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h| 2 ++ fs/f2fs/gc.c | 5 ++--- fs/f2fs/node.c| 10 +++--- fs/f2fs/segment.c | 8 4

[f2fs-dev] [PATCH 1/3] f2fs: reclaim prefree segments periodically

2013-10-24 Thread Jaegeuk Kim
to f2fs_write_node_pages and background GC thread. If there are a lot of prefree segments, let's do checkpoint so that f2fs submits discard commands for the prefree regions to the flash storage. Signed-off-by: Changman Lee cm224@samsung.com Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h

[f2fs-dev] [PATCH 1/2] f2fs: add tracepoint for set_page_dirty

2013-10-24 Thread Jaegeuk Kim
This patch adds a tracepoint for set_page_dirty. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c| 2 ++ fs/f2fs/data.c | 2 ++ fs/f2fs/node.c | 2 ++ include/trace/events/f2fs.h | 44 4

[f2fs-dev] [PATCH] f2fs: remove unnecessary segment bitmap updates

2013-10-27 Thread Jaegeuk Kim
From: Changman Lee cm224@samsung.com From: Changman Lee cm224@samsung.com Only one dirty type is set in __locate_dirty_segment and we can know dirty type of segment. So we don't need to check other dirty types. Signed-off-by: Changman Lee cm224@samsung.com Signed-off-by: Jaegeuk Kim

[f2fs-dev] [PATCH 2/2] f2fs: fix a deadlock during init_acl procedure

2013-10-27 Thread Jaegeuk Kim
at update_inode_page(). So, likewise f2fs_init_security(), this patch adds a parameter to transfer the locked inode page to f2fs_setxattr(). Found by Linux File System Verification project (linuxtesting.org). Reported-by: Alexey Khoroshilov khoroshi...@ispras.ru Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com

Re: [f2fs-dev] [PATCH] f2fs: change the method of calculating the number summary blocks

2013-10-28 Thread Jaegeuk Kim
)/SUMMARY_SIZE) ditto. return 2; return 3; } -- 1.7.9.5 -- Jaegeuk Kim Samsung -- October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore

Re: [f2fs-dev] [f2fs-dev 3/5] f2fs: Add a new function: f2fs_reserve_block()

2013-10-28 Thread Jaegeuk Kim
2013-10-28 (월), 21:16 +0900, Jaegeuk Kim: Hi, 2013-10-26 (토), 00:01 +0800, Huajun Li: From: Huajun Li huajun...@intel.com Add the function f2fs_reserve_block() to easily reserve new blocks. Signed-off-by: Huajun Li huajun...@intel.com Signed-off-by: Haicheng Li haicheng

Re: [f2fs-dev] [f2fs-dev 3/5] f2fs: Add a new function: f2fs_reserve_block()

2013-10-28 Thread Jaegeuk Kim
Hi Huajun, 2013-10-29 (화), 00:53 +0800, Huajun Li: Hi Jaegeuk, Thanks for your kindly review and comments. On Mon, Oct 28, 2013 at 8:28 PM, Jaegeuk Kim jaegeuk@samsung.com wrote: 2013-10-28 (월), 21:16 +0900, Jaegeuk Kim: Hi, 2013-10-26 (토), 00:01 +0800, Huajun Li: From

Re: [f2fs-dev] [f2fs-dev 4/5] f2fs: Key functions to handle inline data

2013-10-28 Thread Jaegeuk Kim
Hi, 2013-10-29 (화), 01:20 +0800, Huajun Li: On Mon, Oct 28, 2013 at 8:43 PM, Jaegeuk Kim jaegeuk@samsung.com wrote: Hi, 2013-10-26 (토), 00:01 +0800, Huajun Li: From: Huajun Li huajun...@intel.com Functions to implement inline data read/write, and move inline data to normal data

[f2fs-dev] [PATCH 2/2] f2fs: add an option to avoid unnecessary BUG_ONs

2013-10-29 Thread Jaegeuk Kim
If you want to remove unnecessary BUG_ONs, you can just turn off F2FS_CHECK_FS in your kernel config. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c | 10 +- fs/f2fs/data.c | 4 ++-- fs/f2fs/dir.c| 2 +- fs/f2fs/f2fs.h | 22

[f2fs-dev] [PATCH 1/2] f2fs: introduce CONFIG_F2FS_CHECK_FS for BUG_ON control

2013-10-29 Thread Jaegeuk Kim
This config will support an option to remove so many BUG_ONs that degrade the performance potentially. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/fs/f2fs/Kconfig b/fs/f2fs/Kconfig index e06e099..214fe10

Re: [f2fs-dev] [PATCH] f2fs:fix truncate_partial_nodes bug

2013-10-29 Thread Jaegeuk Kim
]); + idx = i--; You meant (idx = i - 1)? If so, idx = i--; is wrong. -- Jaegeuk Kim Samsung -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware

Re: [f2fs-dev] F2FS Superblock Locations

2013-10-30 Thread Jaegeuk Kim
is very much hard to be broken especially on flash storages. Thank you, -- Jaegeuk Kim Samsung -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware

Re: [f2fs-dev] F2FS Superblock Locations

2013-10-30 Thread Jaegeuk Kim
the superblock only by mkfs.f2fs, since the superblock contains just static information of its partition. I can simply add an option to do that in mkfs.f2fs. But, if the checkpoint is corrupted, there is no way to recover. Thanks, On Oct 30, 2013 9:56 PM, Jaegeuk Kim jaegeuk@samsung.com

[f2fs-dev] [PATCH] f2fs: avoid to wait all the node blocks during fsync

2013-10-31 Thread Jaegeuk Kim
Previously, f2fs_sync_file() waits for all the node blocks to be written. But, we don't need to do that, but wait only the inode-related node blocks. This patch adds wait_on_node_pages_writeback() in which waits inode-related node blocks that are on writeback. Signed-off-by: Jaegeuk Kim jaegeuk

Re: [f2fs-dev] Porting f2fs tools to Android.

2013-11-03 Thread Jaegeuk Kim
be interested in such the effort. Thanks to the interest in f2fs. :) -- Jaegeuk Kim Samsung -- Android is increasing in popularity, but the open development platform that developers love is also attractive to malware creators

Re: [f2fs-dev] dentry Hash Method

2013-11-03 Thread Jaegeuk Kim
) or f2fs_dentry_hash(fstab, 5) or something completely different? The hash will be made by f2fs_dentry_hash(fstab, 5). Thanks, :) -- Jaegeuk Kim Samsung -- Android is increasing in popularity, but the open development

Re: [f2fs-dev] [PATCH 1/1] No need to do recovery if there is no available CP

2013-11-03 Thread Jaegeuk Kim
by writing one node block with zeros to prevent this. And, if you introduce a new flag, mkfs.f2fs should do the same thing, which means that mkfs.f2fs also needs to set the CP_EXIST_FLAG. So then, it could not fix the bug. How do you think? -- Jaegeuk Kim Samsung

Re: [f2fs-dev] [PATCH 1/1] No need to do recovery if there is no available CP

2013-11-04 Thread Jaegeuk Kim
Hi Huajun, 2013-11-04 (월), 23:40 +0800, Huajun Li: Hi Jaegeuk, On Mon, Nov 4, 2013 at 9:24 AM, Jaegeuk Kim jaegeuk@samsung.com wrote: 2013-11-03 (일), 23:08 +0800, Huajun Li: From: Huajun Li huajun...@intel.com Normally we expect an empty partition after formatting by mkfs.f2fs

[f2fs-dev] [GIT PULL] f2fs updates for v3.13

2013-11-11 Thread Jaegeuk Kim
: introduce f2fs_kmem_cache_alloc to hide the unfailed, kmem cache allocation Haicheng Li (3): f2fs: use true and false for boolean value f2fs: no need to check other dirty_segmap when the seg has been found f2fs: use bool for booleans Jaegeuk Kim (17): f2fs: avoid

Re: [f2fs-dev] [PATCH] f2fs: introduce f2fs_find_next(_zero)_bit

2013-11-14 Thread Jaegeuk Kim
garbage collection. */ -- Jaegeuk Kim Samsung -- DreamFactory - Open Source REST JSON Services for HTML5 Native Apps OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access Free app hosting. Or install

[f2fs-dev] [PATCH 3/5] f2fs: add a sysfs entry to control max_discards

2013-11-14 Thread Jaegeuk Kim
is zero. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/super.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index e9aa3f7..a022412 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -175,6 +175,7 @@ F2FS_RW_ATTR(GC_THREAD, f2fs_gc_kthread

[f2fs-dev] [PATCH 1/5] f2fs: add a slab cache entry for small discards

2013-11-14 Thread Jaegeuk Kim
*/ }; Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h| 14 ++ fs/f2fs/segment.c | 20 fs/f2fs/super.c | 7 ++- 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 89dc750..c73e3df 100644

[f2fs-dev] [PATCH 2/5] f2fs: add key functions for small discards

2013-11-14 Thread Jaegeuk Kim
be marked *invalidated* and also previous checkpoint recognizes it as *valid*. At the end of a checkpoint procedure, f2fs throws discards based on the discard entry list. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/segment.c | 60

[f2fs-dev] [PATCH 4/5] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-14 Thread Jaegeuk Kim
This patch adds f2fs_issue_discard() to clean up blkdev_issue_discard() flows. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/segment.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index

Re: [f2fs-dev] [PATCH V2 4/6] f2fs: Key functions to handle inline data

2013-11-14 Thread Jaegeuk Kim
block after SPO. In order to avoid that, we should write its dnode block too by triggering sync_node_pages(ino) at this point as similar as fsync routine. Thanks, -- Jaegeuk Kim Samsung -- DreamFactory - Open Source REST

Re: [f2fs-dev] [PATCH V2 1/2] f2fs: add a new function to support for merging contiguous read

2013-11-18 Thread Jaegeuk Kim
Hi, 2013-11-18 (월), 09:37 +0800, Chao Yu: Hi Kim, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Monday, November 18, 2013 8:29 AM To: Chao Yu Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel

[f2fs-dev] [PATCH 2/2] f2fs: use sbi-wr_mutex for write bios

2013-11-18 Thread Jaegeuk Kim
This patch removes an unnecessary semaphore (i.e., sbi-bio_sem). There is no reason to use the semaphore when f2fs submits read and write IOs. Instead, let's use a write mutex and cover the sbi-bio[] by the lock. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c| 4

Re: [f2fs-dev] [PATCH] f2fs: split sbi-write_mutex for DATA/NODE/META to avoid unnecessary race

2013-11-18 Thread Jaegeuk Kim
(sbi-write_mutex[META]); init_rwsem(sbi-cp_rwsem); init_waitqueue_head(sbi-cp_wait); init_sb_info(sbi); -- Jaegeuk Kim Samsung -- Shape the Mobile Experience: Free Subscription Software experts

Re: [f2fs-dev] [PATCH] f2fs: split sbi-write_mutex for DATA/NODE/META to avoid unnecessary race

2013-11-18 Thread Jaegeuk Kim
Hi, I think we don't need to make two patches for this. How about this? From 71c27f78e72d680edcd7b1c0917842343044653c Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Mon, 18 Nov 2013 17:16:17 +0900 Subject: [PATCH] f2fs: use sbi-write_mutex for write bios This patch

[f2fs-dev] [PATCH 2/2] f2fs: introduce a bio array for per-page write bios

2013-11-18 Thread Jaegeuk Kim
this new data structure are trivial. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/f2fs.h| 12 +--- fs/f2fs/segment.c | 44 ++-- fs/f2fs/super.c | 2 +- 3 files changed, 32 insertions(+), 26 deletions(-) diff --git a/fs/f2fs

[f2fs-dev] [PATCH 1/2] f2fs: disable the extent cache ops on high fragmented files

2013-11-18 Thread Jaegeuk Kim
cache 5. close the file 6. open the file again 7. give another chance to make a new extent cache 8. write data sequentially again which creates another big extent cache. ... Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 22 ++ fs/f2fs/f2fs.h | 3 +++ 2

Re: [f2fs-dev] [PATCH 5/5] f2fs: move the list_head initialization into the lock protection region

2013-11-20 Thread Jaegeuk Kim
Ok, got it. Thanks, :) 2013-11-20 (수), 17:48 +0800, Gu Zheng: Hi Kim, On 11/20/2013 09:31 AM, Jaegeuk Kim wrote: Hi Gu, IMO, there is no reason to cover the list header by the lock. In any flows, sbi should have the header all the time. Yes, you're right. What is your opinion

[f2fs-dev] [PATCH] f2fs: merge read IOs at ra_nat_pages()

2013-11-21 Thread Jaegeuk Kim
This patch changes the policy of submitting read bios at ra_nat_pages. Previously, f2fs submits small read bios with block plugging. But, with this patch, f2fs itself merges read bios first and then submits a large bio, which can reduce the bio handling overheads. Signed-off-by: Jaegeuk Kim

Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Jaegeuk Kim
Hi, 2013-11-27 (수), 15:58 +0800, Chao Yu: Hi Kim, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Wednesday, November 27, 2013 1:30 PM To: Chao Yu Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Jaegeuk Kim
Hi, 2013-11-28 (목), 09:26 +0800, Chao Yu: Hi Kim, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Wednesday, November 27, 2013 4:19 PM To: Chao Yu Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel

Re: [f2fs-dev] f2fs: introduce f2fs_issue_discard() to clean up

2013-11-27 Thread Jaegeuk Kim
Thank you Dan. I wrote two patches to address the warnings below. Thanks. From 1745cd1e14eff75089a8d88fe07f07549e1f3946 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Thu, 28 Nov 2013 12:44:05 +0900 Subject: [PATCH 1/2] f2fs: bug fix on bit overflow from 32bits

[f2fs-dev] [PATCH] f2fs: refactor bio-related operations

2013-11-29 Thread Jaegeuk Kim
to f2fs_submit_page_bio. 5. Introduce f2fs_submit_page_mbio to integrate previous submit_read_page and submit_write_page. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c| 14 +- fs/f2fs/data.c | 317

Re: [f2fs-dev] [PATCH] f2fs: refactor bio-related operations

2013-12-02 Thread Jaegeuk Kim
Hi, 2013-12-02 (월), 12:47 +0800, Chao Yu: Hi, Some comments as following. -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Saturday, November 30, 2013 2:26 PM Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs: refactor bio-related operations

2013-12-02 Thread Jaegeuk Kim
Change log from v1: o remove redundant codes From a480dfc915490f4bca7275f6fbb44fa34aa00eaa Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Sat, 30 Nov 2013 12:51:14 +0900 Subject: [PATCH] f2fs: refactor bio-related operations Cc: linux-fsde...@vger.kernel.org, linux-ker

Re: [f2fs-dev] [PATCH] f2fs: remove the own bi_private allocation

2013-12-03 Thread Jaegeuk Kim
It causes NULL pointer error without f2fs_bug_on(), so I don't think we need to add this. Thanks, 2013-12-02 (월), 16:59 +0800, Chao Yu: Hi Kim, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Monday, December 02, 2013 4:15 PM To: Chao Yu Cc: linux

Re: [f2fs-dev] [PATCH v2] f2fs: refactor bio-related operations

2013-12-04 Thread Jaegeuk Kim
{ + submit_bio(rw, io-bio); + } + trace_f2fs_submit_write_bio(sbi-sb, rw, btype, io-bio); + io-bio = NULL; +} [snip] Thanks, Yu -- Jaegeuk Kim Samsung -- Sponsored by Intel(R) XDK

Re: [f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Jaegeuk Kim
drop unneeded 'jump' assemble code to improve performance. change log: o add *unlikely* as many as possible across the whole source files at once suggested by Jaegeuk Kim. Suggested-by: Jaegeuk Kim jaegeuk@samsung.com Signed-off-by: Chao Yu chao2...@samsung.com --- fs/f2fs

[f2fs-dev] [PATCH] f2fs: add unlikely() macro for compiler more aggressively

2013-12-05 Thread Jaegeuk Kim
This patch adds unlikely() macro into the most of codes. The basic rule is to add that when: - checking unusual errors, - checking page mappings, - and the other unlikely conditions. Cc: Chao Yu chao2...@samsung.com Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/checkpoint.c

Re: [f2fs-dev] [PATCH 3/3 V2] f2fs: introduce f2fs_cache_node_page() to add page into node_inode cache

2013-12-08 Thread Jaegeuk Kim
2013-12-06 (금), 17:10 +0800, Chao Yu: This patch introduces f2fs_cache_node_page(), in this function, page which is readed ahead will be copy to node_inode's mapping cache. It will avoid rereading these node pages. change log: o check validity of grabbed page suggested by Jaegeuk Kim

Re: [f2fs-dev] [PATCH 3/3 V2] f2fs: introduce f2fs_cache_node_page() to add page into node_inode cache

2013-12-08 Thread Jaegeuk Kim
2013-12-09 (월), 10:14 +0800, Chao Yu: Hi, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Monday, December 09, 2013 7:37 AM To: Chao Yu Cc: linux-fsde...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH v2] f2fs: add unlikely() macro for compiler more aggressively

2013-12-10 Thread Jaegeuk Kim
From d373d7084e4d132fa596fd5def1b9a9843e1410f Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Fri, 6 Dec 2013 15:00:58 +0900 Subject: [PATCH] f2fs: add unlikely() macro for compiler more aggressively This patch adds unlikely() macro into the most of codes. The basic rule

Re: [f2fs-dev] [PATCH 09/18] f2fs: use generic posix ACL infrastructure

2013-12-10 Thread Jaegeuk Kim
2013-12-08 (일), 01:14 -0800, Christoph Hellwig: On Fri, Dec 06, 2013 at 10:37:34AM +0900, Jaegeuk Kim wrote: f2fs caches a new mode bit for a while to make the consistency between xattr's acl mode and the inode mode. Can you explain what exactly you're trying to do there? I've been

Re: [f2fs-dev] [PATCH 09/18] f2fs: use generic posix ACL infrastructure

2013-12-10 Thread Jaegeuk Kim
: Reviewed-by: Jaegeuk Kim jaegeuk@samsung.com Signed-off-by: Christoph Hellwig h...@lst.de --- fs/f2fs/acl.c | 140 +-- fs/f2fs/acl.h |1 + fs/f2fs/file.c |1 + fs/f2fs/namei.c |2 + fs/f2fs/xattr.c |9 ++-- fs

[f2fs-dev] [PATCH] f2fs: introduce sysfs entry to control in-place-update policy

2013-12-11 Thread Jaegeuk Kim
the threshold to trigger in-place-updates. The number indicates percentage of the filesystem utilization, and used by F2FS_IPU_UTIL and F2FS_IPU_SSR_UTIL policies. For more details, see need_inplace_update() in segment.h. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- Documentation/filesystems

Re: [f2fs-dev] libtool package is missing from README

2013-12-15 Thread Jaegeuk Kim
Hi, Thank you for the suggestion. I made a patch and then applied it to the git tree. Thanks, From 11d187cdfa2dcf504aa25b5a1aab4228f19f22ff Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Mon, 16 Dec 2013 12:32:37 +0900 Subject: [PATCH] README: add libtool guide

[f2fs-dev] [PATCH] f2fs: introduce a new direct_IO write path

2013-12-16 Thread Jaegeuk Kim
the block addresses to blockdev This policy induces that: - new allocated data are sequentially written to the disk - updated data are randomly written to the disk. - f2fs gives consistency on its file meta, not file data. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c

[f2fs-dev] [PATCH] f2fs: write dirty meta pages collectively

2013-12-17 Thread Jaegeuk Kim
This patch enhances writing dirty meta pages collectively in background. During the file data writes, it'd better avoid to write small dirty meta pages frequently. So let's give a chance to collect a number of dirty meta pages for a while. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com

Re: [f2fs-dev] [PATCH] f2fs: move all the bio initialization into __bio_alloc

2013-12-19 Thread Jaegeuk Kim
); Maybe it's more neat to use 'is_read' to instead of 'rw'. Thanks -- Jaegeuk Kim Samsung -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how

Re: [f2fs-dev] [PATCH] f2fs: introduce a new direct_IO write path

2013-12-20 Thread Jaegeuk Kim
Hi, 2013-12-20 (금), 10:14 +0800, Chao Yu: Hi Kim, One comment as following: -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Wednesday, December 18, 2013 8:12 AM To: linux-fsde...@vger.kernel.org Cc: linux-ker...@vger.kernel.org; linux-f2fs-devel

Re: [f2fs-dev] [bug] writes hanging

2013-12-22 Thread Jaegeuk Kim
___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel -- Jaegeuk Kim Samsung -- Rapidly

Re: [f2fs-dev] [PATCH 1/3] f2fs: check filename length in recover_dentry

2013-12-22 Thread Jaegeuk Kim
this before? This is a trivial bug case, so, if you have got this bug, we should fix the bug first instead of adding any workaround patch. Let's add WARN_ON() at least. Thanks, retry: de = f2fs_find_entry(dir, name, page); if (de inode-i_ino == le32_to_cpu(de-ino)) -- Jaegeuk Kim

[f2fs-dev] [PATCH 1/2] f2fs: introduce F2FS_INODE macro to get f2fs_inode

2013-12-26 Thread Jaegeuk Kim
This patch introduces F2FS_INODE that returns struct f2fs_inode * from the inode page. By using this macro, we can remove unnecessary casting codes like below. struct f2fs_inode *ri = F2FS_NODE(inode_page)-i; - struct f2fs_inode *ri = F2FS_INODE(inode_page); Signed-off-by: Jaegeuk Kim jaegeuk

[f2fs-dev] [PATCH] f2fs: check the blocksize before calling generic_direct_IO path

2013-12-26 Thread Jaegeuk Kim
, the output file contains a garbage data for that region. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 991e368..e0965b4 100644 --- a/fs/f2fs/data.c +++ b/fs

Re: [f2fs-dev] [PATCH v2] f2fs: introduce F2FS_INODE macro to get f2fs_inode

2013-12-26 Thread Jaegeuk Kim
Hi, Nice catch. :) Change log from v1: o handle recover_inode_page too From 58bfaf44df58082c72882b235cae611c975537d4 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim jaegeuk@samsung.com Date: Thu, 26 Dec 2013 16:30:41 +0900 Subject: [PATCH] f2fs: introduce F2FS_INODE macro to get f2fs_inode

[f2fs-dev] [PATCH 4/6] f2fs: refactor f2fs_convert_inline_data

2013-12-26 Thread Jaegeuk Kim
but the size to fill is less than MAX_INLINE_DATA, then we don't need to convert the inline_data with data allocation. Signed-off-by: Jaegeuk Kim jaegeuk@samsung.com --- fs/f2fs/data.c | 16 ++-- fs/f2fs/f2fs.h | 2 +- fs/f2fs/file.c | 25 + fs/f2fs

  1   2   3   4   5   6   7   8   9   10   >