Re: [f2fs-dev] [PATCH 1/1] f2fs: simplify the calculation of fggc_threshold

2017-10-26 Thread Sun Qiuyang
Hi Jaegeuk, I noticed that the log of the commit: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=7e515b31d44dcd20a98c938dfdc21877a30042a0 used a new expression as follows: sbi->fggc_threshold = div_u64((u64)(main_count - ovp_count) *

Re: [f2fs-dev] [PATCH v3] f2fs: dax: implement direct access

2017-06-08 Thread Sun Qiuyang
Hi Chao, See my comments below. Hi Qiuyang, On 2017/6/7 17:29, sunqiuyang wrote: From: Qiuyang Sun This is a new version of PATCH v2 2/2 with the following minor changes: - In dax_move_data_page(), the call of allocate_data_block() is changed according to the new definition of this functio

Re: [f2fs-dev] [PATCH v4 1/1] f2fs: dax: implement direct access

2017-06-22 Thread Sun Qiuyang
Hi Chao, Thanks for pointing it out. See below for how to fix this issue. Hi Qiuyang As I tested with pmem, this patch will corrupt f2fs image with generic/051 of fstest suit. Could you please take a look at this issue? Thanks, On 2017/6/15 16:56, sunqiuyang wrote: From: Qiuyang Sun Thi

Re: [f2fs-dev] [PATCH v6 1/1] f2fs: dax: implement direct access

2017-07-17 Thread Sun Qiuyang
On 2017/7/12 17:06, sunqiuyang wrote: From: Qiuyang Sun This patch implements Direct Access (DAX) in F2FS, including: - a mount option to choose whether to enable DAX or not - read/write and mmap of regular files in the DAX way - zero-out of unaligned partial blocks in the DAX way - garbage c

Re: [f2fs-dev] [PATCH v7 1/1] f2fs: dax: implement direct access

2017-07-18 Thread Sun Qiuyang
Hi Jaegeuk, Thank you for the edits and comments. I will accept them, except that f2fs_iomap_end() does not need to return any error. See below for details. Hi Qiuyang, On 07/18, sunqiuyang wrote: From: Qiuyang Sun This patch implements Direct Access (DAX) in F2FS, including: - a mount op

Re: [f2fs-dev] [PATCH v8 1/1] f2fs: dax: implement direct access

2017-07-24 Thread Sun Qiuyang
Hi Jaegeuk, Below is the error message I got from this testcase: --- write (Invalid argument) len 1024 dio [dax to nondax | both nodax] read (Bad address) len [4096 | 16777216 | 67108864] dio dax to nondax --- The write error is expected, as F2FS does not support unaligned direct IO (1024 B).

Re: [f2fs-dev] [PATCH 1/1] f2fs: merge equivalent flags F2FS_GET_BLOCK_[READ|DIO]

2017-08-08 Thread Sun Qiuyang
On 2017/8/8 18:27, sunqiuyang wrote: From: Qiuyang Sun Currently, the two flags F2FS_GET_BLOCK_[READ|DIO] are totally equivalent and can be used interchangably in all scenarios they are involved in. This patch deletes F2FS_GET_BLOCK_READ and uses F2FS_GET_BLOCK_DIO instead. Seems weird fro