Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-18 Thread Wanpeng Li
inline_data by default, isn't it? Do you mean to replace the codes above by something like f2fs_write_inline_data()? Regards, Wanpeng Li Thanks, +set_page_dirty(node_page); +f2fs_put_page(node_page, 1); +inode-i_size = symlen-1; +set_inode_flag

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-16 Thread Wanpeng Li
Hi Chao, On Mon, Mar 16, 2015 at 09:03:30PM +0800, Chao Yu wrote: Hi Wanpeng, Jaegeuk, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Friday, March 13, 2015 2:34 PM To: Jaegeuk Kim Cc: Changman Lee; Chao Yu; linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-16 Thread Wanpeng Li
Ping Jaegeuk, On Fri, Mar 13, 2015 at 02:33:39PM +0800, Wanpeng Li wrote: This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to using the original slow symlink

[f2fs-dev] [PATCH] f2fs: enable inline data by default

2015-03-18 Thread Wanpeng Li
Enable inline_data feature by default since it brings us better performance and space utilization and now has already stable. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- Documentation/filesystems/f2fs.txt | 2 -- fs/f2fs/f2fs.h | 11 +-- fs/f2fs

[f2fs-dev] [PATCH] f2fs: enable fast symlink by utilizing inline data

2015-03-18 Thread Wanpeng Li
Fast symlink can utilize inline data flow to avoid using any i_addr region, since we need to handle many cases such as truncation, roll-forward recovery, and fsck/dump tools. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/inline.c | 2 +- 1 file changed, 1 insertion(+), 1

[f2fs-dev] [PATCH v2] f2fs: add fast symlink support

2015-03-12 Thread Wanpeng Li
This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to using the original slow symlink if the target path exceeds the available inode space. Signed-off-by: Wanpeng

Re: [f2fs-dev] [PATCH RFC] f2fs: add fast symlink

2015-03-12 Thread Wanpeng Li
Hi Chao, On Thu, Mar 12, 2015 at 05:02:47PM +0800, Chao Yu wrote: Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Thursday, March 12, 2015 2:42 PM To: Chao Yu Cc: 'Wanpeng Li'; 'Jaegeuk Kim'; 'Changman Lee'; linux-f2fs-devel

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix get stale meta pages when build free nids

2015-03-08 Thread Wanpeng Li
Hi Jaegeuk, On Sun, Mar 08, 2015 at 09:18:47PM -0700, Jaegeuk Kim wrote: Hi Wanpeng, On Mon, Mar 09, 2015 at 11:00:54AM +0800, Wanpeng Li wrote: The blocks of nat pages to be scanned will be readahead when build free nids. The start blkno will be adjusted to 0 when the intended range over

[f2fs-dev] [PATCH RFC] f2fs: add fast symlink

2015-03-11 Thread Wanpeng Li
This patch add fast symlink for f2fs, I'm not sure if inline interference with fast symlink, f2fs_follow_link can't be called in my patch, so my patch still can't work correctly, please help review and give comments to help me out. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs

[f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-13 Thread Wanpeng Li
This patch introduces the improvement fast symlinks to allow storage of the target path within inode, thus symlinks with short target paths are more accessed quickly. It will fall back to using the original slow symlink if the target path exceeds the available inode space. Signed-off-by: Wanpeng

Re: [f2fs-dev] [PATCH RFC] f2fs: add fast symlink

2015-03-12 Thread Wanpeng Li
comments and it works well. Btw, one question, if inline xattr data area is reserved in inode even if it isn't mounted w/ inline_xattr option? If yes, why it is reserved? Regards, Wanpeng Li -- Dive into the World

Re: [f2fs-dev] [PATCH v3] f2fs: add fast symlink support

2015-03-22 Thread Wanpeng Li
. Regards, Wanpeng Li Thanks, On Thu, Mar 19, 2015 at 11:17:17AM +0800, Chao Yu wrote: Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Thursday, March 19, 2015 7:02 AM To: Jaegeuk Kim Cc: Wanpeng Li; Changman Lee; Chao Yu; linux

[f2fs-dev] [PATCH v2 2/2] f2fs: enable fast symlink by utilizing inline data

2015-03-22 Thread Wanpeng Li
Fast symlink can utilize inline data flow to avoid using any i_addr region, since we need to handle many cases such as truncation, roll-forward recovery, and fsck/dump tools. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/inline.c | 2 +- 1 file changed, 1 insertion(+), 1

[f2fs-dev] [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

2015-02-27 Thread Wanpeng Li
Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/segment.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index daee4ab..e7b83b6 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1730,6 +1730,9 @@ void

Re: [f2fs-dev] [PATCH 2/2] f2fs: fix the number of orphan inode blocks

2015-02-27 Thread Wanpeng Li
Hi Chao, On Thu, Feb 26, 2015 at 09:33:55AM +0800, Chao Yu wrote: Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Thursday, February 26, 2015 7:57 AM To: Jaegeuk Kim Cc: Wanpeng Li; linux-ker...@vger.kernel.org; linux-f2fs-devel

[f2fs-dev] [PATCH] f2fs: fix block_ops trace point

2015-02-27 Thread Wanpeng Li
premature even if block_ops doesn't have opportunity to execute. This patch fix it by move block_ops trace point just before block_ops. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/checkpoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs

[f2fs-dev] [PATCH] f2fs: don't need to collect dirty sit entries and flush journal when there's no dirty sit entries

2015-02-27 Thread Wanpeng Li
Don't need to collect dirty sit entries and flush sit journal to sit entries when there's no dirty sit entries. This patch check dirty_sentries earlier just like flush_nat_entries. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/segment.c | 6 +++--- 1 file changed, 3

Re: [f2fs-dev] [PATCH] f2fs: fix max orphan inodes calculation

2015-02-27 Thread Wanpeng Li
Hi Chao, On Fri, Feb 27, 2015 at 05:39:39PM +0800, Chao Yu wrote: Hi Wanpeng, -Original Message- From: Wanpeng Li [mailto:wanpeng...@linux.intel.com] Sent: Friday, February 27, 2015 3:05 PM To: Jaegeuk Kim Cc: Wanpeng Li; linux-ker...@vger.kernel.org; linux-f2fs-devel

[f2fs-dev] [PATCH] f2fs: fix recover orphan inodes

2015-02-25 Thread Wanpeng Li
recover_orphan_inodes is used to recover orphan inodes, the meta pages which readahead should be orphan_blkaddr - start_blk instead of orphan_blkaddr. This patch fix it. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/checkpoint.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [f2fs-dev] [PATCH] f2fs: fix recover orphan inodes

2015-02-25 Thread Wanpeng Li
Hi Jaegeuk, On Wed, Feb 25, 2015 at 10:35:23AM -0800, Jaegeuk Kim wrote: Hi Wanpeng, On Wed, Feb 25, 2015 at 12:53:37PM +0800, Wanpeng Li wrote: recover_orphan_inodes is used to recover orphan inodes, the meta pages which readahead should be orphan_blkaddr - start_blk instead

[f2fs-dev] [PATCH 1/2] f2fs: fix extent cache memory leak

2015-03-05 Thread Wanpeng Li
extent tree/node slab cache is created during f2fs insmod, how, it isn't destroyed during f2fs rmmod, this patch fix it by destroy extent tree/node slab cache once rmmod f2fs. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/super.c | 1 + 1 file changed, 1 insertion(+) diff

[f2fs-dev] [PATCH 2/2] f2fs: reduce searching region of segmap when set free section

2015-03-05 Thread Wanpeng Li
section. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/segment.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index 7fd3511..85d7fa7 100644 --- a/fs/f2fs/segment.h +++ b/fs/f2fs/segment.h @@ -336,7 +336,8 @@ static

[f2fs-dev] [PATCH v3 1/2] f2fs: enable inline data by default

2015-03-23 Thread Wanpeng Li
Enable inline_data feature by default since it brings us better performance and space utilization and now has already stable. Add another option noinline_data to disable it during mount. Suggested-by: Jaegeuk Kim jaeg...@kernel.org Suggested-by: Chao Yu chao2...@samsung.com Signed-off-by: Wanpeng

[f2fs-dev] [PATCH v3 2/2] f2fs: enable fast symlink by utilizing inline data

2015-03-23 Thread Wanpeng Li
Fast symlink can utilize inline data flow to avoid using any i_addr region, since we need to handle many cases such as truncation, roll-forward recovery, and fsck/dump tools. Signed-off-by: Wanpeng Li wanpeng...@linux.intel.com --- fs/f2fs/inline.c | 2 +- 1 file changed, 1 insertion(+), 1