Re: [f2fs-dev] [PATCH] f2fs: Fix build error while CONFIG_NLS=m
On 2019/8/8 14:18, Chao Yu wrote: > Hi Haibing, > > Thanks for the patch! > > Out of curiosity, does Hulk Robot check linux-next git repo as well? This will > be more valuable if the bug can be found during development of related patch? Yes, Hulk Robot now do this on linux-next.git and linux.git every day. > > On 2019/8/8 10:02, YueHaibing wrote: >> If CONFIG_F2FS_FS=y but CONFIG_NLS=m, building fails: >> >> fs/f2fs/file.o: In function `f2fs_ioctl': >> file.c:(.text+0xb86f): undefined reference to `utf16s_to_utf8s' >> file.c:(.text+0xe651): undefined reference to `utf8s_to_utf16s' >> >> Select CONFIG_NLS to fix this. >> >> Reported-by: Hulk Robot >> Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_{GET,SET}FSLABEL") >> Signed-off-by: YueHaibing > > Reviewed-by: Chao Yu > > Thanks, > > . > ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Re: [f2fs-dev] [PATCH] f2fs: Fix build error while CONFIG_NLS=m
Hi Haibing, Thanks for the patch! Out of curiosity, does Hulk Robot check linux-next git repo as well? This will be more valuable if the bug can be found during development of related patch? On 2019/8/8 10:02, YueHaibing wrote: > If CONFIG_F2FS_FS=y but CONFIG_NLS=m, building fails: > > fs/f2fs/file.o: In function `f2fs_ioctl': > file.c:(.text+0xb86f): undefined reference to `utf16s_to_utf8s' > file.c:(.text+0xe651): undefined reference to `utf8s_to_utf16s' > > Select CONFIG_NLS to fix this. > > Reported-by: Hulk Robot > Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_{GET,SET}FSLABEL") > Signed-off-by: YueHaibing Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
[PATCH] f2fs: Fix build error while CONFIG_NLS=m
If CONFIG_F2FS_FS=y but CONFIG_NLS=m, building fails: fs/f2fs/file.o: In function `f2fs_ioctl': file.c:(.text+0xb86f): undefined reference to `utf16s_to_utf8s' file.c:(.text+0xe651): undefined reference to `utf8s_to_utf16s' Select CONFIG_NLS to fix this. Reported-by: Hulk Robot Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_{GET,SET}FSLABEL") Signed-off-by: YueHaibing --- fs/f2fs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/Kconfig b/fs/f2fs/Kconfig index 110a38c..95f1b99 100644 --- a/fs/f2fs/Kconfig +++ b/fs/f2fs/Kconfig @@ -2,6 +2,7 @@ config F2FS_FS tristate "F2FS filesystem support" depends on BLOCK + select NLS select CRYPTO select CRYPTO_CRC32 select F2FS_FS_XATTR if FS_ENCRYPTION -- 2.7.4