Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread Yunlong Song
OK, Got it. On 2018/2/11 11:50, Chao Yu wrote: On 2018/2/11 11:34, Yunlong Song wrote: Ping... move_data_block misses set_cold_data, then the F2FS_WB_CP_DATA will lack these data pages in move_data_block, and write_checkpoint can not make sure this pages committed to the flash. Hmm.. data bl

Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread heyunlei
>-Original Message- >From: Songyunlong (Euler) >Sent: Sunday, February 11, 2018 11:35 AM >To: jaeg...@kernel.org; c...@kernel.org; Yuchao (T); yunlong.s...@icloud.com >Cc: miaoxie (A); Wangbintian; shengyong (A); heyunlei; >linux-f2fs-devel@lists.sourceforge.net; linux-ker...@vger.kernel

Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread Chao Yu
On 2018/2/11 11:34, Yunlong Song wrote: > Ping... > > move_data_block misses set_cold_data, then the F2FS_WB_CP_DATA will > lack these data pages in move_data_block, and write_checkpoint can > not make sure this pages committed to the flash. Hmm.. data block migration is running based on meta ino

Re: [f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-10 Thread Yunlong Song
Ping... move_data_block misses set_cold_data, then the F2FS_WB_CP_DATA will lack these data pages in move_data_block, and write_checkpoint can not make sure this pages committed to the flash. On 2018/2/8 20:33, Yunlong Song wrote: Signed-off-by: Yunlong Song --- fs/f2fs/gc.c | 1 + 1 file c

[f2fs-dev] [PATCH] f2fs: set_code_data in move_data_block

2018-02-08 Thread Yunlong Song
Signed-off-by: Yunlong Song --- fs/f2fs/gc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index b9d93fd..2095630 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -692,6 +692,7 @@ static void move_data_block(struct inode *inode, block_t bidx, fio.op = REQ