Re: [f2fs-dev] [PATCH v11 51/63] dax: Fix use of zero page

2018-05-20 Thread Ross Zwisler
On Sat, Apr 14, 2018 at 07:13:04AM -0700, Matthew Wilcox wrote:
> From: Matthew Wilcox 
> 
> Use my_zero_pfn instead of ZERO_PAGE, and pass the vaddr to it so it
> works on MIPS and s390.
> 
> Signed-off-by: Matthew Wilcox 

Feel free to add my:

Reviewed-by: Ross Zwisler 

To this version as well if you keep this patch in the larger series.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


[f2fs-dev] [PATCH v11 51/63] dax: Fix use of zero page

2018-04-14 Thread Matthew Wilcox
From: Matthew Wilcox 

Use my_zero_pfn instead of ZERO_PAGE, and pass the vaddr to it so it
works on MIPS and s390.

Signed-off-by: Matthew Wilcox 
---
 fs/dax.c | 10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/fs/dax.c b/fs/dax.c
index e014c99b21fd..b0efb0a9604a 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -909,17 +909,9 @@ static int dax_load_hole(struct address_space *mapping, 
void *entry,
struct inode *inode = mapping->host;
unsigned long vaddr = vmf->address;
int ret = VM_FAULT_NOPAGE;
-   struct page *zero_page;
void *entry2;
-   pfn_t pfn;
-
-   zero_page = ZERO_PAGE(0);
-   if (unlikely(!zero_page)) {
-   ret = VM_FAULT_OOM;
-   goto out;
-   }
+   pfn_t pfn = pfn_to_pfn_t(my_zero_pfn(vaddr));
 
-   pfn = page_to_pfn_t(zero_page);
entry2 = dax_insert_mapping_entry(mapping, vmf, entry, pfn,
DAX_ZERO_PAGE, false);
if (IS_ERR(entry2)) {
-- 
2.17.0


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel