Re: [f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-13 Thread Sahitya Tummala
On Tue, Mar 13, 2018 at 05:19:51PM +0800, guoweichao wrote: > > > On 2018/3/13 16:49, Sahitya Tummala wrote: > > On Thu, Mar 08, 2018 at 05:10:40AM +0800, Weichao Guo wrote: > >> @@ -159,8 +162,12 @@ bool f2fs_inode_chksum_verify(struct f2fs_sb_info > >> *sbi, struct page *page) > >>struct f

Re: [f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-13 Thread guoweichao
On 2018/3/13 16:49, Sahitya Tummala wrote: > On Thu, Mar 08, 2018 at 05:10:40AM +0800, Weichao Guo wrote: >> @@ -159,8 +162,12 @@ bool f2fs_inode_chksum_verify(struct f2fs_sb_info *sbi, >> struct page *page) >> struct f2fs_inode *ri; >> __u32 provided, calculated; >> >> +#ifdef CONFI

Re: [f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-13 Thread Sahitya Tummala
On Thu, Mar 08, 2018 at 05:10:40AM +0800, Weichao Guo wrote: > @@ -159,8 +162,12 @@ bool f2fs_inode_chksum_verify(struct f2fs_sb_info *sbi, > struct page *page) > struct f2fs_inode *ri; > __u32 provided, calculated; > > +#ifdef CONFIG_F2FS_CHECK_FS > + if (!f2fs_enable_inode_chks

Re: [f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-08 Thread guoweichao
Hi Chao, On 2018/3/8 17:11, Chao Yu wrote: > Hi Weichao, > > On 2018/3/8 15:56, guoweichao wrote: >> Hi Chao, >> >> On 2018/3/8 14:15, Chao Yu wrote: >>> On 2018/3/8 5:10, Weichao Guo wrote: Only enable in-memory inode checksum to protect metadata blocks from in-memory scribbles when ch

Re: [f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-08 Thread Chao Yu
Hi Weichao, On 2018/3/8 15:56, guoweichao wrote: > Hi Chao, > > On 2018/3/8 14:15, Chao Yu wrote: >> On 2018/3/8 5:10, Weichao Guo wrote: >>> Only enable in-memory inode checksum to protect metadata blocks >>> from in-memory scribbles when checking consistency, which has no >>> performance requir

Re: [f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-07 Thread Chao Yu
On 2018/3/8 5:10, Weichao Guo wrote: > Only enable in-memory inode checksum to protect metadata blocks > from in-memory scribbles when checking consistency, which has no > performance requirements. Once we modify the node page of inode, we will call set_page_dirty, not sure, can you check that we

[f2fs-dev] [PATCH v4] f2fs: support in-memory inode checksum when checking consistency

2018-03-07 Thread Weichao Guo
Only enable in-memory inode checksum to protect metadata blocks from in-memory scribbles when checking consistency, which has no performance requirements. --- fs/f2fs/inline.c | 18 ++ fs/f2fs/inode.c | 10 ++ fs/f2fs/node.c | 4 +++- fs/f2fs/node.h | 24 +