Re: [f2fs-dev] [PATCH] f2fs: disable nat bits without setting SBI_NEED_FSCK

2018-04-09 Thread Jaegeuk Kim 
On 04/09, Yunlei He wrote:
> nat bits feature is recover default by fsck, no need to
> set SBI_NEED_FSCK flag.
> 
> Signed-off-by: Yunlei He 
> ---
>  fs/f2fs/f2fs.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 1df7f10..0ffaefc2 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -1520,8 +1520,6 @@ static inline void disable_nat_bits(struct f2fs_sb_info 
> *sbi, bool lock)
>  {
>   unsigned long flags;
>  
> - set_sbi_flag(sbi, SBI_NEED_FSCK);
> -

In order to support old fsck.f2fs, we need to keep this.

>   if (lock)
>   spin_lock_irqsave(>cp_lock, flags);
>   __clear_ckpt_flags(F2FS_CKPT(sbi), CP_NAT_BITS_FLAG);
> -- 
> 1.9.1

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs: disable nat bits without setting SBI_NEED_FSCK

2018-04-09 Thread Chao Yu 
On 2018/4/9 11:40, Yunlei He wrote:
> nat bits feature is recover default by fsck, no need to
> set SBI_NEED_FSCK flag.
> 
> Signed-off-by: Yunlei He 

Reviewed-by: Chao Yu 

Thanks,


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel