Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-15 Thread Chao Yu
On 2019/9/10 20:09, Jaegeuk Kim wrote: >> The lock is used to protect F2FS_I(inode)->inmem_pages list... it should be >> kept? > Urg.. yup. I added. Reviewed-by: Chao Yu Thanks, >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-10 Thread Jaegeuk Kim
On 09/10, Chao Yu wrote: > On 2019/9/10 19:58, Jaegeuk Kim wrote: > > On 09/10, Chao Yu wrote: > >> On 2019/9/9 22:34, Jaegeuk Kim wrote: > >>> On 09/09, Chao Yu wrote: > On 2019/9/9 16:38, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 16:21, Jaegeuk Kim wrote: >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-10 Thread Chao Yu
On 2019/9/10 19:58, Jaegeuk Kim wrote: > On 09/10, Chao Yu wrote: >> On 2019/9/9 22:34, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On 2019/9/9 16:38, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 16:21, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote:

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-10 Thread Jaegeuk Kim
On 09/10, Chao Yu wrote: > On 2019/9/9 22:34, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 16:38, Jaegeuk Kim wrote: > >>> On 09/09, Chao Yu wrote: > On 2019/9/9 16:21, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 16:01, Jaegeuk Kim wrote: >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Chao Yu
On 2019/9/9 22:34, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 16:38, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On 2019/9/9 16:21, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 16:01, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2019/9/9 16:38, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 16:21, Jaegeuk Kim wrote: > >>> On 09/09, Chao Yu wrote: > On 2019/9/9 16:01, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 15:30, Jaegeuk Kim wrote: >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Chao Yu
On 2019/9/9 16:38, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 16:21, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On 2019/9/9 16:01, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 15:30, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Jaegeuk Kim
On 09/09, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: > > On 2019/9/9 16:21, Jaegeuk Kim wrote: > > > On 09/09, Chao Yu wrote: > > >> On 2019/9/9 16:01, Jaegeuk Kim wrote: > > >>> On 09/09, Chao Yu wrote: > > On 2019/9/9 15:30, Jaegeuk Kim wrote: > > > On 09/09, Chao Yu wrote: > >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2019/9/9 16:21, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 16:01, Jaegeuk Kim wrote: > >>> On 09/09, Chao Yu wrote: > On 2019/9/9 15:30, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 9:25, Jaegeuk Kim wrote: >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Chao Yu
On 2019/9/9 16:21, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 16:01, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On 2019/9/9 15:30, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 9:25, Jaegeuk Kim wrote: >>> If committing atomic pages is failed

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2019/9/9 16:01, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 15:30, Jaegeuk Kim wrote: > >>> On 09/09, Chao Yu wrote: > On 2019/9/9 9:25, Jaegeuk Kim wrote: > > If committing atomic pages is failed when doing f2fs_do_sync_file(), we >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Chao Yu
On 2019/9/9 16:01, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 15:30, Jaegeuk Kim wrote: >>> On 09/09, Chao Yu wrote: On 2019/9/9 9:25, Jaegeuk Kim wrote: > If committing atomic pages is failed when doing f2fs_do_sync_file(), we > can > get commited pages but

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2019/9/9 15:30, Jaegeuk Kim wrote: > > On 09/09, Chao Yu wrote: > >> On 2019/9/9 9:25, Jaegeuk Kim wrote: > >>> If committing atomic pages is failed when doing f2fs_do_sync_file(), we > >>> can > >>> get commited pages but atomic_file being still set like: > >>> >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Chao Yu
On 2019/9/9 15:30, Jaegeuk Kim wrote: > On 09/09, Chao Yu wrote: >> On 2019/9/9 9:25, Jaegeuk Kim wrote: >>> If committing atomic pages is failed when doing f2fs_do_sync_file(), we can >>> get commited pages but atomic_file being still set like: >>> >>> - inmem:0, atomic IO:4 (Max. 10),

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-09 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2019/9/9 9:25, Jaegeuk Kim wrote: > > If committing atomic pages is failed when doing f2fs_do_sync_file(), we can > > get commited pages but atomic_file being still set like: > > > > - inmem:0, atomic IO:4 (Max. 10), volatile IO:0 (Max.0) > > > >

Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid infinite GC loop due to stale atomic files

2019-09-08 Thread Chao Yu
On 2019/9/9 9:25, Jaegeuk Kim wrote: > If committing atomic pages is failed when doing f2fs_do_sync_file(), we can > get commited pages but atomic_file being still set like: > > - inmem:0, atomic IO:4 (Max. 10), volatile IO:0 (Max.0) > > If GC selects this block, we can get an