Re: [f2fs-dev] [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup

2019-12-04 Thread Tiezhu Yang
On 12/05/2019 03:06 PM, Matthew Wilcox wrote: On Thu, Dec 05, 2019 at 08:56:07AM +0800, Tiezhu Yang wrote: And, as I asked twice in the last round of review, did you benchmark this change? Before sending this v2 patch, I have done the test used with your test program and already pointed out

Re: [f2fs-dev] [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup

2019-12-04 Thread Matthew Wilcox
On Thu, Dec 05, 2019 at 08:56:07AM +0800, Tiezhu Yang wrote: > > And, as I asked twice in the last round of review, did you benchmark > > this change? > > Before sending this v2 patch, I have done the test used with your test > program and already pointed out the following implementation is

Re: [f2fs-dev] [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup

2019-12-04 Thread Tiezhu Yang
On 12/03/2019 09:56 PM, Matthew Wilcox wrote: On Tue, Dec 03, 2019 at 08:56:50PM +0800, Tiezhu Yang wrote: There exists many similar and duplicate codes to check "." and "..", so introduce is_dot_dotdot helper to make the code more clean. Signed-off-by: Tiezhu Yang --- v2: - use the

Re: [f2fs-dev] [PATCH v2] fs: introduce is_dot_dotdot helper for cleanup

2019-12-03 Thread Matthew Wilcox
On Tue, Dec 03, 2019 at 08:56:50PM +0800, Tiezhu Yang wrote: > There exists many similar and duplicate codes to check "." and "..", > so introduce is_dot_dotdot helper to make the code more clean. > > Signed-off-by: Tiezhu Yang > --- > > v2: > - use the better performance implementation of