Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-27 Thread Chao Yu
On 2020/5/28 4:56, Jaegeuk Kim wrote: > On 05/27, Chao Yu wrote: >> On 2020/5/26 9:56, Jaegeuk Kim wrote: >>> On 05/26, Chao Yu wrote: On 2020/5/26 9:11, Chao Yu wrote: > On 2020/5/25 23:06, Jaegeuk Kim wrote: >> On 05/25, Chao Yu wrote: >>> On 2020/5/25 11:56, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-27 Thread Jaegeuk Kim
On 05/27, Chao Yu wrote: > On 2020/5/26 9:56, Jaegeuk Kim wrote: > > On 05/26, Chao Yu wrote: > >> On 2020/5/26 9:11, Chao Yu wrote: > >>> On 2020/5/25 23:06, Jaegeuk Kim wrote: > On 05/25, Chao Yu wrote: > > On 2020/5/25 11:56, Jaegeuk Kim wrote: > >> Shutdown test is somtimes hung,

Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-26 Thread Chao Yu
On 2020/5/26 9:56, Jaegeuk Kim wrote: > On 05/26, Chao Yu wrote: >> On 2020/5/26 9:11, Chao Yu wrote: >>> On 2020/5/25 23:06, Jaegeuk Kim wrote: On 05/25, Chao Yu wrote: > On 2020/5/25 11:56, Jaegeuk Kim wrote: >> Shutdown test is somtimes hung, since it keeps trying to flush dirty

Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-25 Thread Jaegeuk Kim
On 05/26, Chao Yu wrote: > On 2020/5/26 9:11, Chao Yu wrote: > > On 2020/5/25 23:06, Jaegeuk Kim wrote: > >> On 05/25, Chao Yu wrote: > >>> On 2020/5/25 11:56, Jaegeuk Kim wrote: > Shutdown test is somtimes hung, since it keeps trying to flush dirty > node pages > >>> > >>> IMO, for

Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-25 Thread Chao Yu
On 2020/5/26 9:11, Chao Yu wrote: > On 2020/5/25 23:06, Jaegeuk Kim wrote: >> On 05/25, Chao Yu wrote: >>> On 2020/5/25 11:56, Jaegeuk Kim wrote: Shutdown test is somtimes hung, since it keeps trying to flush dirty node pages >>> >>> IMO, for umount case, we should drop dirty reference

Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-25 Thread Chao Yu
On 2020/5/25 23:06, Jaegeuk Kim wrote: > On 05/25, Chao Yu wrote: >> On 2020/5/25 11:56, Jaegeuk Kim wrote: >>> Shutdown test is somtimes hung, since it keeps trying to flush dirty node >>> pages >> >> IMO, for umount case, we should drop dirty reference and dirty pages on >> meta/data >> pages

Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-25 Thread Jaegeuk Kim
On 05/25, Chao Yu wrote: > On 2020/5/25 11:56, Jaegeuk Kim wrote: > > Shutdown test is somtimes hung, since it keeps trying to flush dirty node > > pages > > IMO, for umount case, we should drop dirty reference and dirty pages on > meta/data > pages like we change for node pages to avoid

Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-25 Thread Chao Yu
On 2020/5/25 11:56, Jaegeuk Kim wrote: > Shutdown test is somtimes hung, since it keeps trying to flush dirty node > pages IMO, for umount case, we should drop dirty reference and dirty pages on meta/data pages like we change for node pages to avoid potential dead loop... Thanks, > in an

Re: [f2fs-dev] [PATCH v3] f2fs: avoid inifinite loop to wait for flushing node pages at cp_error

2020-05-24 Thread Jaegeuk Kim
Shutdown test is somtimes hung, since it keeps trying to flush dirty node pages in an inifinite loop. Let's drop dirty pages at umount in that case. Signed-off-by: Jaegeuk Kim --- v3: - fix wrong unlock v2: - fix typos fs/f2fs/node.c | 9 - 1 file changed, 8 insertions(+), 1