Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-10-18 Thread Shinichiro Kawasaki
On Oct 02, 2019 / 14:30, Shin'ichiro Kawasaki wrote: > Now I'm preparing patches for fsck as well as kernel based on the valuable > and detailed e-mail discussion between you and me. Here I summarize my I have posted the two patch series to add write pointer consistency check, based on the

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-10-01 Thread Shinichiro Kawasaki
On Sep 29, 2019 / 10:09, Chao Yu wrote: > On 2019/9/25 16:05, Shinichiro Kawasaki wrote: > > On Sep 21, 2019 / 17:42, Chao Yu wrote: > >> On 2019/9/18 11:07, Shinichiro Kawasaki wrote: > >>> Thanks for the comments. I read f2fs code further, and think still the > >>> SIT vs write pointer check can

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-28 Thread Chao Yu
On 2019/9/25 16:05, Shinichiro Kawasaki wrote: > On Sep 21, 2019 / 17:42, Chao Yu wrote: >> On 2019/9/18 11:07, Shinichiro Kawasaki wrote: >>> Thanks for the comments. I read f2fs code further, and think still the >>> SIT vs write pointer check can be implemented and meaningful. >>> >>> F2fs

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-25 Thread Shinichiro Kawasaki
On Sep 21, 2019 / 17:42, Chao Yu wrote: > On 2019/9/18 11:07, Shinichiro Kawasaki wrote: > > Thanks for the comments. I read f2fs code further, and think still the > > SIT vs write pointer check can be implemented and meaningful. > > > > F2fs ensures consistency of SIT using two CP areas, two SIT

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-21 Thread Chao Yu
On 2019/9/18 11:07, Shinichiro Kawasaki wrote: > Thanks for the comments. I read f2fs code further, and think still the > SIT vs write pointer check can be implemented and meaningful. > > F2fs ensures consistency of SIT using two CP areas, two SIT areas and > sit_bitmap in CP. These metadata are

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-17 Thread Shinichiro Kawasaki
On Sep 16, 2019 / 09:37, Chao Yu wrote: > On 2019/9/12 16:16, Shinichiro Kawasaki wrote: > > On Sep 10, 2019 / 17:12, Chao Yu wrote: > >> On 2019/9/10 16:10, Shinichiro Kawasaki wrote: > >>> On Sep 09, 2019 / 15:14, Chao Yu wrote: > On 2019/9/6 16:31, Shinichiro Kawasaki wrote: > > On Sep

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-15 Thread Chao Yu
On 2019/9/12 16:16, Shinichiro Kawasaki wrote: > On Sep 10, 2019 / 17:12, Chao Yu wrote: >> On 2019/9/10 16:10, Shinichiro Kawasaki wrote: >>> On Sep 09, 2019 / 15:14, Chao Yu wrote: On 2019/9/6 16:31, Shinichiro Kawasaki wrote: > On Sep 05, 2019 / 17:58, Chao Yu wrote: >> Hi

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-12 Thread Shinichiro Kawasaki
On Sep 10, 2019 / 17:12, Chao Yu wrote: > On 2019/9/10 16:10, Shinichiro Kawasaki wrote: > > On Sep 09, 2019 / 15:14, Chao Yu wrote: > >> On 2019/9/6 16:31, Shinichiro Kawasaki wrote: > >>> On Sep 05, 2019 / 17:58, Chao Yu wrote: > Hi Shinichiro, > > Sorry for the delay. > >

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-10 Thread Chao Yu
On 2019/9/10 16:10, Shinichiro Kawasaki wrote: > On Sep 09, 2019 / 15:14, Chao Yu wrote: >> On 2019/9/6 16:31, Shinichiro Kawasaki wrote: >>> On Sep 05, 2019 / 17:58, Chao Yu wrote: Hi Shinichiro, Sorry for the delay. On 2019/9/3 16:37, Shinichiro Kawasaki wrote: > On

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-10 Thread Shinichiro Kawasaki
On Sep 09, 2019 / 15:14, Chao Yu wrote: > On 2019/9/6 16:31, Shinichiro Kawasaki wrote: > > On Sep 05, 2019 / 17:58, Chao Yu wrote: > >> Hi Shinichiro, > >> > >> Sorry for the delay. > >> > >> On 2019/9/3 16:37, Shinichiro Kawasaki wrote: > >>> On Sep 02, 2019 / 15:02, Chao Yu wrote: > On

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-06 Thread Shinichiro Kawasaki
On Sep 05, 2019 / 17:58, Chao Yu wrote: > Hi Shinichiro, > > Sorry for the delay. > > On 2019/9/3 16:37, Shinichiro Kawasaki wrote: > > On Sep 02, 2019 / 15:02, Chao Yu wrote: > >> On 2019/8/30 18:19, Shin'ichiro Kawasaki wrote: > >>> On sudden f2fs shutdown, zoned block device status and f2fs

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-03 Thread Shinichiro Kawasaki
On Sep 02, 2019 / 15:02, Chao Yu wrote: > On 2019/8/30 18:19, Shin'ichiro Kawasaki wrote: > > On sudden f2fs shutdown, zoned block device status and f2fs current > > segment positions in meta data can be inconsistent. When f2fs shutdown > > happens before write operations completes, write pointers

Re: [f2fs-dev] [PATCH v4 2/2] fsck.f2fs: Check write pointer consistency with current segments

2019-09-02 Thread Chao Yu
On 2019/8/30 18:19, Shin'ichiro Kawasaki wrote: > On sudden f2fs shutdown, zoned block device status and f2fs current > segment positions in meta data can be inconsistent. When f2fs shutdown > happens before write operations completes, write pointers of zoned block > devices can go further but