Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Prokop m...@grml.org wrote: Hi, If Michael Tautschnig as setup-storage maintainer acknowledges the patch and either you or MT applies it to svn so I can cherry-pick it from there that's absolutely fine for me and I'd provide it as 3.4.3 release, sure. OK, let's wait for Michael's

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Tautschnig m...@debian.org wrote: Hi, absolutely fine if the fix goes in via this patch). Just one stylistic note: Unless I'm missing something, the following if ... elsif ... -if (FAI::set_partition_type_on_phys_dev($d, raid)) { +if ($vol-{preserve}) { +

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Michael Tautschnig
Hi Julien, Michael Tautschnig m...@debian.org wrote: Hi, absolutely fine if the fix goes in via this patch). Just one stylistic note: Unless I'm missing something, the following if ... elsif ... -if (FAI::set_partition_type_on_phys_dev($d, raid)) { + if ($vol-{preserve})

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Tautschnig m...@debian.org wrote: Hi, Though pt_complete is only for physical devices, so all things considered I should have a second look at this. I'll do this on monday. Ouch, yes, you're absolutely right. I think the following code should do it: if ($vol-{preserve}) {