Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-25 Thread Michael Tautschnig
> * Julien BLACHE [Tue Sep 21, 2010 at 10:21:12PM +0200]: > > Michael Prokop wrote: > > > >> Mika, can this make it into a 3.4.3? Do you want a bug in the BTS? > > > > If Michael Tautschnig as setup-storage maintainer acknowledges the > > > patch and either you or MT applies it to svn so I can

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-22 Thread Michael Prokop
* Julien BLACHE [Tue Sep 21, 2010 at 10:21:12PM +0200]: > Michael Prokop wrote: > >> Mika, can this make it into a 3.4.3? Do you want a bug in the BTS? > > If Michael Tautschnig as setup-storage maintainer acknowledges the > > patch and either you or MT applies it to svn so I can cherry-pick it

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-21 Thread Julien BLACHE
Michael Prokop wrote: Hi, >> Mika, can this make it into a 3.4.3? Do you want a bug in the BTS? > > If Michael Tautschnig as setup-storage maintainer acknowledges the > patch and either you or MT applies it to svn so I can cherry-pick it I've just commited the fix to trunk, with a bit of delay

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Tautschnig wrote: Hi, > Well, setup-storage development is really driven by use cases and feature > requests these days, so unless someone explicitly requests that, it will not > be > supported, right. Yet it doesn't seem to hard to implement, IMHO just add a > few > commands with prop

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Michael Tautschnig
[...] > > Yes, that'll do :) Though I should note that preserving RAID on LVM or > LVM on RAID is not supported by setup-storage. > > For that to work, setup-storage would need to start RAID arrays to > detect LVM on RAID and start LVM VGs to detect RAID on LVM. It currently > doesn't do this, s

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Tautschnig wrote: Hi, >> Though pt_complete is only for physical devices, so all things >> considered I should have a second look at this. I'll do this on monday. > > > Ouch, yes, you're absolutely right. I think the following code should do it: > > if ($vol->{preserve}) { > $pre_req

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Michael Tautschnig
Hi Julien, > Michael Tautschnig wrote: > > Hi, > > > absolutely fine if the fix goes in via this patch). Just one stylistic note: > > Unless I'm missing something, the following if ... elsif ... > > > >> -if (&FAI::set_partition_type_on_phys_dev($d, "raid")) { > >> + if ($vol->{preserv

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Tautschnig wrote: Hi, > absolutely fine if the fix goes in via this patch). Just one stylistic note: > Unless I'm missing something, the following if ... elsif ... > >> -if (&FAI::set_partition_type_on_phys_dev($d, "raid")) { >> +if ($vol->{preserve}) { >> + $pre_req

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Michael Tautschnig
Hi Julien, hi all, > Michael Prokop wrote: > > Hi, > > > If Michael Tautschnig as setup-storage maintainer acknowledges the > > patch and either you or MT applies it to svn so I can cherry-pick it > > from there that's absolutely fine for me and I'd provide it as 3.4.3 > > release, sure. > > O

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Michael Prokop
* Julien BLACHE [Fri Sep 17, 2010 at 12:48:11PM +0200]: > Julien BLACHE wrote: > > Sure. Let's get 3.4.2 in first and foremost. ACK, should show up in testing in 9 days. > > Though having this fix would be nice, and I don't think the RT > > would object. Jepp. > Quoting the latest release up

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Julien BLACHE wrote: > Sure. Let's get 3.4.2 in first and foremost. Though having this fix > would be nice, and I don't think the RT would object. Quoting the latest release update: - fixes for severity: important bugs in packages of priority: optional or extra, only when this can be done

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-17 Thread Julien BLACHE
Michael Prokop wrote: Hi, > If Michael Tautschnig as setup-storage maintainer acknowledges the > patch and either you or MT applies it to svn so I can cherry-pick it > from there that's absolutely fine for me and I'd provide it as 3.4.3 > release, sure. OK, let's wait for Michael's review :) >

Re: [PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-16 Thread Michael Prokop
* Julien BLACHE [Thu Sep 16, 2010 at 05:41:37PM +0200]: > Preserving a RAID volume doesn't work in 3.4.x: > - mdadm --detail --scan doesn't give information on non-assembled >arrays, leading setup-storage to think there aren't any; > - preserved arrays must be assembled before setup-storage

[PATCH] Make preserve work for RAID in FAI 3.4.x

2010-09-16 Thread Julien BLACHE
Hi, Preserving a RAID volume doesn't work in 3.4.x: - mdadm --detail --scan doesn't give information on non-assembled arrays, leading setup-storage to think there aren't any; - preserved arrays must be assembled before setup-storage calls fai-vol-id; - (minor) always_format was not initia