Re: [RFC] TileFS - a proposal for scalable integrity checking

2007-05-08 Thread Valerie Henson
On Sun, Apr 29, 2007 at 02:21:13PM +0200, J??rn Engel wrote: > On Sat, 28 April 2007 17:05:22 -0500, Matt Mackall wrote: > > > > This is a relatively simple scheme for making a filesystem with > > incremental online consistency checks of both data and metadata. > > Overhead can be well under 1% di

Re: [PATCH 3/3] AFS: Implement basic file write support

2007-05-08 Thread Andrew Morton
On Tue, 08 May 2007 20:44:11 +0100 David Howells <[EMAIL PROTECTED]> wrote: > Implement support for writing to regular AFS files, including: > > (1) write > > (2) truncate > > (3) fsync, fdatasync > > (4) chmod, chown, chgrp, utime. > > AFS writeback attempts to batch writes into as chunk

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Greg KH
On Wed, May 09, 2007 at 01:10:09AM +0200, J??rn Engel wrote: > > The remaining question is how to deal with kernel-only code that uses > be64. Convert that to __be64 as well? Or introduce be64 in > include/linix/types.h instead? I say leave it alone for now, it's not that common :) thanks, gr

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 15:52:53 -0700, Greg KH wrote: > On Tue, May 08, 2007 at 10:58:27PM +0200, J??rn Engel wrote: > > > > Basically I prefer be64 over __be64 for similar reasons that most people > > prefer u64 over __u64. Others prefer uint64_t over both, but C99 hasn't > > defined beint64_t yet.

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jörn Engel
On Wed, 9 May 2007 00:44:14 +0200, Ingo Oeser wrote: > On Tuesday 08 May 2007, Thomas Gleixner wrote: > > On Tue, 2007-05-08 at 00:00 +0200, Jörn Engel wrote: > > > +#define packed __attribute__((__packed__)) > > > > Please use the __attribute__((__packed__)) on your structs instead of > > creatin

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Greg KH
On Tue, May 08, 2007 at 10:58:27PM +0200, J??rn Engel wrote: > On Tue, 8 May 2007 22:15:18 +0300, Pekka Enberg wrote: > > On 5/8/07, J??rn Engel <[EMAIL PROTECTED]> wrote: > > >> > +typedef __be16 be16; > > >> > +typedef __be32 be32; > > >> > +typedef __be64 be64; > > >> > > >> Why are those typede

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Ingo Oeser
On Tuesday 08 May 2007, Thomas Gleixner wrote: > On Tue, 2007-05-08 at 00:00 +0200, Jörn Engel wrote: > > +#define packed __attribute__((__packed__)) > > Please use the __attribute__((__packed__)) on your structs instead of > creating some extra "needs lookup" magic. Don't worry, we have __packed

Re: [PATCH 0/2] LogFS take two

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 01:53:38 -0400, Albert Cahalan wrote: > > You seem to be missing the immutable bit. This is really useful > for dealing with buggy or badly-designed things running as root. > I've used to to protect /dev/null from becoming a normal file > filled with junk, and to protect /etc/re

Re: [V9fs-developer] [PATCH 1/4] v9fs: rename non-vfs related structs and functions to be moved to net/9p

2007-05-08 Thread Eric Van Hensbergen
On 5/8/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Tue, 8 May 2007 14:51:02 -0600 "Latchesar Ionkov" <[EMAIL PROTECTED]> wrote: > This patchset moves non-filesystem interfaces of v9fs from fs/9p to net/9p. > It moves the transport, packet marshalling and connection layers to net/9p > leaving

Re: [PATCH 2/2] file capabilities: accomodate >32 bit capabilities

2007-05-08 Thread Serge E. Hallyn
Quoting Andreas Dilger ([EMAIL PROTECTED]): > On May 08, 2007 14:17 -0500, Serge E. Hallyn wrote: > > As the capability set changes and distributions start tagging > > binaries with capabilities, we would like for running an older > > kernel to not necessarily make those binaries unusable. > > >

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 22:58:26 +0200, Thomas Gleixner wrote: > On Tue, 2007-05-08 at 22:25 +0200, Jörn Engel wrote: > > > > > > Kernel doc comments as: > > > > > > /** > > > * struct hrtimer - the basic hrtimer structure > > > * @node: red black tree node for time ordered insertion > > > *

Re: [PATCH 1/4] v9fs: rename non-vfs related structs and functions to be moved to net/9p

2007-05-08 Thread Andrew Morton
On Tue, 8 May 2007 14:51:02 -0600 "Latchesar Ionkov" <[EMAIL PROTECTED]> wrote: > This patchset moves non-filesystem interfaces of v9fs from fs/9p to net/9p. > It moves the transport, packet marshalling and connection layers to net/9p > leaving only the VFS related files in fs/9p. (Please cc [EMA

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 22:15:18 +0300, Pekka Enberg wrote: > On 5/8/07, Jörn Engel <[EMAIL PROTECTED]> wrote: > >> > +typedef __be16 be16; > >> > +typedef __be32 be32; > >> > +typedef __be64 be64; > >> > >> Why are those typedefs necessary ? > > > >Not strictly. I tend to use the be* types fairly ofte

Re: [PATCH 2/2] file capabilities: accomodate >32 bit capabilities

2007-05-08 Thread Andreas Dilger
On May 08, 2007 14:17 -0500, Serge E. Hallyn wrote: > As the capability set changes and distributions start tagging > binaries with capabilities, we would like for running an older > kernel to not necessarily make those binaries unusable. > > (0. Enable the CONFIG_SECURITY_FS_CAPABILITIES o

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Thomas Gleixner
On Tue, 2007-05-08 at 22:25 +0200, Jörn Engel wrote: > > > > Please comment the structure with kernel doc comments and avoid the tail > > > > comments. > > > > > > I'd like to hear your rationale. > > > > Kernel doc comments as: > > > > /** > > * struct hrtimer - the basic hrtimer structure > >

[PATCH 2/4] v9fs: move non-vfs related headers to include/net/9p

2007-05-08 Thread Latchesar Ionkov
This patchset moves non-filesystem interfaces of v9fs from fs/9p to net/9p. It moves the transport, packet marshalling and connection layers to net/9p leaving only the VFS related files in fs/9p. This patch: Moves the non-VFS related header files from fs/9p to include/net/9p. Signed-off-by: Lat

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jörn Engel
Before I forget this again: thanks for the review! It really is appreciated. On Tue, 8 May 2007 20:00:41 +0200, Thomas Gleixner wrote: > On Tue, 2007-05-08 at 18:32 +0200, Jörn Engel wrote: > > > Please sort includes alphabetically and seperate the > > > #include from the #include ones > > >

Re: [PATCH 0/2] file capabilities: Introduction

2007-05-08 Thread Andrew Morton
On Tue, 8 May 2007 14:15:48 -0500 "Serge E. Hallyn" <[EMAIL PROTECTED]> wrote: > Following are two patches which have been sitting for some time in -mm. Where "some time" == "nearly six months". We need help considering, reviewing and testing this code, please. - To unsubscribe from this list: s

[PATCH 3/3] AFS: Implement basic file write support

2007-05-08 Thread David Howells
Implement support for writing to regular AFS files, including: (1) write (2) truncate (3) fsync, fdatasync (4) chmod, chown, chgrp, utime. AFS writeback attempts to batch writes into as chunks as large as it can manage up to the point that it writes back 65535 pages in one chunk or it meet

[PATCH 2/3] AFS: AFS fixups

2007-05-08 Thread David Howells
Make some miscellaneous changes to the AFS filesystem: (1) Assert RCU barriers on module exit to make sure RCU has finished with callbacks in this module. (2) Correctly handle the AFS server returning a zero-length read. (3) Split out data zapping calls into one function (afs_zap_data).

[PATCH 1/3] AFS: Export a couple of core functions for AFS write support

2007-05-08 Thread David Howells
Export a couple of core functions for AFS write support to use: find_get_pages_contig() find_get_pages_tag() Signed-off-by: David Howells <[EMAIL PROTECTED]> --- mm/filemap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c in

[PATCH 2/2] file capabilities: accomodate >32 bit capabilities

2007-05-08 Thread Serge E. Hallyn
From: Serge E. Hallyn <[EMAIL PROTECTED]> Subject: [PATCH 2/2] file capabilities: accomodate >32 bit capabilities (Changelog: fixed syntax error in dummy version of check_cap_sanity()) As the capability set changes and distributions start tagging binaries with capabilities, we would like for runn

[PATCH 1/2] file capabilities: implement file capabilities

2007-05-08 Thread Serge E. Hallyn
From: Serge E. Hallyn <[EMAIL PROTECTED]> Subject: [PATCH 1/2] file capabilities: implement file capabilities Implement file posix capabilities. This allows programs to be given a subset of root's powers regardless of who runs them, without having to use setuid and giving the binary all of root's

[PATCH 0/2] file capabilities: Introduction

2007-05-08 Thread Serge E. Hallyn
Following are two patches which have been sitting for some time in -mm. The first implements file capabilities, the second changes the format a bit to accomodate potential future 64-bit capabilities. We are hoping to get a few more eyes on the code before deciding whether this is safe to finally p

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Pekka Enberg
On 5/8/07, Jörn Engel <[EMAIL PROTECTED]> wrote: > > +typedef __be16 be16; > > +typedef __be32 be32; > > +typedef __be64 be64; > > Why are those typedefs necessary ? Not strictly. I tend to use the be* types fairly often in the code and simply grew weary of seeing the underscores. Any objectio

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Thomas Gleixner
On Tue, 2007-05-08 at 18:32 +0200, Jörn Engel wrote: > > Please sort includes alphabetically and seperate the > > #include from the #include ones > > Sort: will do. > Seperation: Any particular reason for that? Easier to see the different categories > > > +typedef __be16 be16; > > > +typedef

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Mingming Cao
On Mon, 2007-05-07 at 21:43 -0400, Theodore Tso wrote: > On Mon, May 07, 2007 at 05:41:39PM -0700, Mingming Cao wrote: > > We could check the total number of fs free blocks account before > > preallocation happens, if there isn't enough space left, there is no > > need to bother preallocating. > >

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Andreas Dilger
On May 07, 2007 21:43 -0400, Theodore Tso wrote: > On Mon, May 07, 2007 at 05:15:41PM -0700, Andrew Morton wrote: > > Userspace could presumably repair the mess in most situations by truncating > > the file back again. The kernel cannot do that because there might be live > > data in amongst ther

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Evgeniy Polyakov
On Tue, May 08, 2007 at 05:54:41PM +0200, Thomas Gleixner ([EMAIL PROTECTED]) wrote: > On Tue, 2007-05-08 at 14:46 +0200, Jan Engelhardt wrote: > > >> +static int __logfs_readdir(struct file *file, void *buf, filldir_t > > >> filldir) > > >> +{ > > >> +err = read_dir(dir, &dd, pos

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Thomas Gleixner
On Tue, 2007-05-08 at 14:46 +0200, Jan Engelhardt wrote: > >> +static int __logfs_readdir(struct file *file, void *buf, filldir_t > >> filldir) > >> +{ > >> + err = read_dir(dir, &dd, pos); > >> + if (err == -EOF) > >> + break; > > > > -EOF results in a retur

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Dave Kleikamp
On Tue, 2007-05-08 at 16:22 +0530, Amit K. Arora wrote: > On Mon, May 07, 2007 at 10:24:37AM -0500, Dave Kleikamp wrote: > > On Mon, 2007-05-07 at 17:37 +0530, Amit K. Arora wrote: > > > On Thu, May 03, 2007 at 09:31:33PM -0700, Andrew Morton wrote: > > > > So we don't implement fallocate on bitma

Re: Kernel error when closing a pipe

2007-05-08 Thread Chris Kottaridis
At the moment no. It happened one time on a customer's machine and all I currently have is the stack message from the kernel. I am working on adding some messages that may help sort out what is going on and trying to see if I can trigger the problem locally myself. If I do I'll certainly pass it a

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jan Engelhardt
On May 8 2007 09:22, Thomas Gleixner wrote: >> @@ -0,0 +1,14 @@ >> +obj-$(CONFIG_LOGFS) += logfs.o >> + >> +logfs-y += compr.o >> +logfs-y += dir.o >> +logfs-y += file.o >> +logfs-y += gc.o >> +logfs-y += inode.o >> +logfs-y += journal.o >> +logfs-y += memtree.o >> +logfs-y

Re: [PATCH 2/2] introduce I_SYNC

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 09:23:48 +0200, Thomas Gleixner wrote: > On Tue, 2007-05-08 at 00:01 +0200, Jörn Engel wrote: > > This patch is actually independent of LogFS. It fixes a deadlock > > hidden in fs/fs-writeback.c that LogFS was unlucky enough to trigger. > > I strongly suspect NTFS triggered the

Re: [PATCH 0/2] LogFS take two

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 09:39:37 +0200, Thomas Gleixner wrote: > > > Motivation 2: > > > > Flash is becoming increasingly common in standard PC hardware. Nearly > > a dozen different manufacturers have announced Solid State Disks > > (SSDs), the OLPC and the Intel Classmate no longer contain hard dis

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Amit K. Arora
On Mon, May 07, 2007 at 10:24:37AM -0500, Dave Kleikamp wrote: > On Mon, 2007-05-07 at 17:37 +0530, Amit K. Arora wrote: > > On Thu, May 03, 2007 at 09:31:33PM -0700, Andrew Morton wrote: > > > On Thu, 26 Apr 2007 23:43:32 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> > > > wrote: > > > > > +int ext4

Re: [PATCH 0/2] LogFS take two

2007-05-08 Thread Thomas Gleixner
On Mon, 2007-05-07 at 23:59 +0200, Jörn Engel wrote: > LogFS has an on-medium tree, fairly similar to Ext2 in structure, so > mount times are O(1). In absolute terms, the OLPC system has mount > times of ~3.3s for JFFS2 and ~60ms for LogFS. Impressive number > Motivation 2: > > Flash is becomi

Re: [PATCH 2/2] introduce I_SYNC

2007-05-08 Thread Thomas Gleixner
On Tue, 2007-05-08 at 00:01 +0200, Jörn Engel wrote: > This patch is actually independent of LogFS. It fixes a deadlock > hidden in fs/fs-writeback.c that LogFS was unlucky enough to trigger. > I strongly suspect NTFS triggered the same deadlock and "solved" it by > introducing iget5_nowait(). Fo