David Howells wrote:
Nick Piggin <[EMAIL PROTECTED]> wrote:
Why do you call SetPageUptodate when the page is not up to date?
That leaks uninitialised data, AFAIKS.
It only seems that way. If afs_prepare_write() is called, but doesn't return
an error, then afs_commit_write() will be called,
On Thu, May 10, 2007 at 01:01:27PM -0700, Andreas Dilger wrote:
> On May 08, 2007 16:49 -0500, Serge E. Hallyn wrote:
> > Quoting Andreas Dilger ([EMAIL PROTECTED]):
> > > One of the important use cases I can see today is the ability to
> > > split the heavily-overloaded e.g. CAP_SYS_ADMIN into mu
On Thu, 10 May 2007 15:33:34 +0100
David Howells <[EMAIL PROTECTED]> wrote:
> Following bug was uncovered by compiling with '-W' flag:
gcc -W finds a number of fairly scary bugs.
More than one would expect, given that it is recommended in
Documentation/SubmitChecklist, which everyone reads ;)
-
On Thu, May 10, 2007 at 05:26:20PM +0530, Amit K. Arora wrote:
> On Thu, May 10, 2007 at 10:59:26AM +1000, David Chinner wrote:
> > On Wed, May 09, 2007 at 09:31:02PM +0530, Amit K. Arora wrote:
> > > I have the updated patches ready which take care of Andrew's comments.
> > > Will run some tests a
On May 08, 2007 16:49 -0500, Serge E. Hallyn wrote:
> Quoting Andreas Dilger ([EMAIL PROTECTED]):
> > One of the important use cases I can see today is the ability to
> > split the heavily-overloaded e.g. CAP_SYS_ADMIN into much more fine
> > grained attributes.
>
> Sounds plausible, though it su
Implement the statfs() op for AFS.
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
fs/afs/afs.h | 23
fs/afs/afs_fs.h |3 -
fs/afs/dir.c | 18 ++-
fs/afs/fsclient.c | 298 +
fs/afs/internal.h |6 +
fs/afs/supe
Fix a couple of problems with unlinking AFS files.
(1) The parent directory wasn't being updated properly between unlink() and
the following lookup().
It seems that, for some reason, invalidate_remote_inode() wasn't
discarding the directory contents correctly, so this patch calls
Following bug was uncovered by compiling with '-W' flag:
CC [M] fs/afs/write.o
fs/afs/write.c: In function ‘afs_write_back_from_locked_page’:
fs/afs/write.c:398: warning: comparison of unsigned expression >= 0 is always
true
Loop variable 'n' is unsigned, so wraps around happily as far as I c
On Thu, May 10, 2007 at 10:59:26AM +1000, David Chinner wrote:
> On Wed, May 09, 2007 at 09:31:02PM +0530, Amit K. Arora wrote:
> > I have the updated patches ready which take care of Andrew's comments.
> > Will run some tests and post them soon.
> >
> > But, before submitting these patches, I thi
Nick Piggin <[EMAIL PROTECTED]> wrote:
> Why do you call SetPageUptodate when the page is not up to date?
> That leaks uninitialised data, AFAIKS.
It only seems that way. If afs_prepare_write() is called, but doesn't return
an error, then afs_commit_write() will be called, and it seems that the
10 matches
Mail list logo