Re: [PATCH] LogFS take three

2007-05-18 Thread Jan Engelhardt
On May 17 2007 21:00, Kyle Moffett wrote: Opinions? Why would we need another btree, when there is lib/rbtree.c? Or does yours do something fundamentally different? It is not red-black tree, it is b+ tree. It might be better to use the prefix bptree to help prevent confusion. A

Re: [PATCH] LogFS take three

2007-05-18 Thread Jan Engelhardt
On May 18 2007 09:01, Dongjun Shin wrote: On 5/18/07, Pavel Machek [EMAIL PROTECTED] wrote: Hmm.. so operating your camera on batteries should be against the warranty, since batteries commonly run empty while storing pictures? AFAIK, the camera stops writing to the flash card and

Re: [PATCH] LogFS take three

2007-05-18 Thread David Woodhouse
On Fri, 2007-05-18 at 08:17 +0200, Jan Engelhardt wrote: AFAIK, the camera stops writing to the flash card and automatically turns off when it's low on battery (before empty). But then, one should also consider the case where a cam is connected to AC and someone inadvertently trips on the

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-18 Thread Bharata B Rao
On Wed, May 16, 2007 at 09:57:28AM +0200, Jan Engelhardt wrote: On May 14 2007 15:13, Bharata B Rao wrote: + +if (flag 0x2) { +error = union_copyup(nd, flag); +if (error) +goto exit; +} What I dislike (and that also goes for

Re: [RFC][PATCH 8/14] Union-mount lookup

2007-05-18 Thread Bharata B Rao
On Tue, May 15, 2007 at 10:00:45AM -0400, Trond Myklebust wrote: On Mon, 2007-05-14 at 15:12 +0530, Bharata B Rao wrote: From: Jan Blunck [EMAIL PROTECTED] Subject: Union-mount lookup Modifies the vfs lookup routines to work with union mounted directories. The existing lookup

iocb-ki_pos != pos

2007-05-18 Thread Bernd Schubert
Hi, for our customers we are porting lustre to more recent kernel versions and a customer just run into a bug, which probably I introduced (wrote the ll_file_aio_write() function). For me it looks more like a generic vfs problem than a lustre problem, so I'm asking here. The trace is

Re: [RFC][PATCH 10/14] In-kernel file copy between union mounted filesystems

2007-05-18 Thread Shaya Potter
Bharata B Rao wrote: Not really. This is called during copyup of a file residing in a lower layer. And that is done only for regular files. That is broken. You should be able to change the permissions on a device node on a layer that is RO. so it would copy it up (1. mknod, 2. copy

Re: iocb-ki_pos != pos

2007-05-18 Thread Bernd Schubert
Forget my previous mail, I just see I modifying iocb-ki_pos if the file is opened in O_APPEND mode... Sorry for the noise. Bernd Bernd Schubert wrote: Hi, for our customers we are porting lustre to more recent kernel versions and a customer just run into a bug, which probably I