Re: [RFC] obsoleting /etc/mtab

Miklos == Miklos Szeredi [EMAIL PROTECTED] writes: Miklos So the best solution would be if /etc/mtab were a symlink to Miklos /proc/mounts, and the kernel would be the authoritative source Miklos of information regarding mounts. That would have to be a symlink to /proc/self/mounts, yes? -JimC

LogFS take four

This round the patch is split into file-sized hunks. There actually seem to be kernel developers not manly enough to digest 6000+ lines of code at once. An I thought I was the only wimp around. Again, anyone giving comments in the last round is on Cc:. I'll try to respond to comments but the

[Patch 01/18] fs/Kconfig

--- linux-2.6.21logfs/fs/Kconfig~logfs 2007-06-03 19:18:57.0 +0200 +++ linux-2.6.21logfs/fs/Kconfig2007-06-03 19:18:57.0 +0200 @@ -1351,6 +1351,32 @@ config JFFS2_CMODE_SIZE endchoice +config LOGFS + tristate Log Filesystem (EXPERIMENTAL) + depends on MTD

[Patch 03/18] fs/logfs/Makefile

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/Makefile 2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,14 @@ +obj-$(CONFIG_LOGFS)+= logfs.o + +logfs-y+= compr.o +logfs-y+= dir.o +logfs-y+= file.o +logfs-y+= gc.o +logfs-y

[Patch 06/18] fs/logfs/compr.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/compr.c 2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,95 @@ +/* + * fs/logfs/compr.c- compression routines + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007

[Patch 07/18] fs/logfs/dir.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/dir.c2007-06-03 19:54:55.0 +0200 @@ -0,0 +1,704 @@ +/* + * fs/logfs/dir.c - directory-related code + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c)

[Patch 08/18] fs/logfs/file.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/file.c 2007-06-03 19:55:14.0 +0200 @@ -0,0 +1,75 @@ +/* + * fs/logfs/file.c - prepare_write, commit_write and friends + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + *

[Patch 09/18] fs/logfs/gc.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/gc.c 2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,352 @@ +/* + * fs/logfs/gc.c - garbage collection code + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c)

[Patch 10/18] fs/logfs/inode.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/inode.c 2007-06-03 20:06:15.0 +0200 @@ -0,0 +1,512 @@ +/* + * fs/logfs/inode.c- inode handling code + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007

[Patch 11/18] fs/logfs/journal.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/journal.c2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,696 @@ +/* + * fs/logfs/journal.c - journal handling code + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c)

[Patch 12/18] fs/logfs/memtree.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/memtree.c2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,258 @@ +/* + * fs/logfs/memtree.c - Simple In-memory B+Tree + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright

[Patch 14/18] fs/logfs/segment.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/segment.c2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,524 @@ +/* + * fs/logfs/segment.c - Handling the Object Store + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright

[Patch 15/18] fs/logfs/super.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/super.c 2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,521 @@ +/* + * fs/logfs/super.c + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright (c) 2005-2007 Joern Engel + * + *

[Patch 16/18] fs/logfs/progs/fsck.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/progs/fsck.c 2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,316 @@ +/* + * fs/logfs/prog/fsck.c- filesystem check + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + * Copyright

[Patch 17/18] fs/logfs/progs/mkfs.c

--- /dev/null 2007-03-13 19:15:28.862769062 +0100 +++ linux-2.6.21logfs/fs/logfs/progs/mkfs.c 2007-06-03 19:18:57.0 +0200 @@ -0,0 +1,324 @@ +/* + * fs/logfs/prog/mkfs.c- filesystem generation + * + * As should be obvious for Linux kernel code, license is GPLv2 + * + *

Re: LogFS take four

On Sun, 3 June 2007 21:17:44 +0200, Jan-Benedict Glaw wrote: On Sun, 2007-06-03 20:38:46 +0200, Jörn Engel [EMAIL PROTECTED] wrote: This round the patch is split into file-sized hunks. There actually seem to be kernel developers not manly enough to digest 6000+ lines of code at once. An I

Re: LogFS take four

On Sun, 2007-06-03 20:38:46 +0200, Jörn Engel [EMAIL PROTECTED] wrote: This round the patch is split into file-sized hunks. There actually seem to be kernel developers not manly enough to digest 6000+ lines of code at once. An I thought I was the only wimp around. Though it would be nice to

Re: [RFC] obsoleting /etc/mtab

Peter == H Peter Anvin [EMAIL PROTECTED] writes: Peter /proc/mounts *is* a symlink to /proc/self/mounts. D’oh. I must have read mounts where modules showed up in the ls(1) I ran before writing that. I probably should adjust the cyan used for symlinks in the coloured ls(1) output; it does seem

Re: [Patch 04/18] include/linux/logfs.h

On Sunday 03 June 2007, Jörn Engel wrote: +struct logfs_je_spillout { +   __be64  so_segment[0]; +}__packed; All the on-disk data structures you define in this file have naturally aligned members, so the __packed attribute is not needed. However, I think it causes gcc to generate larger

Re: [Patch 06/18] fs/logfs/compr.c

On Sunday 03 June 2007, Jörn Engel wrote: +#define COMPR_LEVEL 3 + +static DEFINE_MUTEX(compr_mutex); +static struct z_stream_s stream; Is there a particular reason to choose '3' as the only compression level? Should this perhaps be a per-superblock option instead? Also, I thought I saw

Re: LogFS take four

On Sunday 03 June 2007, Jörn Engel wrote: Unchanged: o error handling ... Won't happen (unless I get convinced to do otherwise): o Change LOGFS_BUG() and LOGFS_BUG_ON() to inline functions These are macros for very much the same reasons BUG() and BUG_ON() are. I wonder how many of your

Re: [Patch 14/18] fs/logfs/segment.c

On Sunday 03 June 2007, Jörn Engel wrote: +static DEFINE_MUTEX(compr_mutex); + It seems you define a static compre_mutex in both segment.c and in compr.c, and always lock them both at the same time. Is that a correct observation? Is it intentional, or an oversight on your side? Arnd -

[PATCH -mm] Unionfs: Fix lock leak in unionfs_ioctl

(This patch is already in the Unionfs git tree. This is just a heads up.) Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index