Hello,
At all other places, j_list_lock is being held when b_transaction is
being modified. But at one place in transaction.c, this lock is not
held. Also, the journal-head.h file which defines journal_head
structure says that b_transaction should be protected by two locks -
j_list_lock and
On Fri, Aug 03, 2007 at 01:59:53PM +0200, Michael Kerrisk wrote:
Amit
There is a typo above. We have file system repeated twice in above
sentence. Second one should be file.
/Amit
Thanks for catching that.
Okay -- it seems that this page is pretty much ready for publication,
right?
Hi Michael,
On Mon, Jul 30, 2007 at 09:44:10PM +0200, Michael Kerrisk wrote:
Amit, David,
I've edited the previous version of the page, adding David's license, and
integrating Amit's comments. I've also added a few new FIXMES. (FIXME
Amit again.)
Ok, Thanks!
Could you please review
Hi Michael,
On Mon, Jul 30, 2007 at 09:43:08PM +0200, Michael Kerrisk wrote:
Hello Amit.
On Mon, Jul 23, 2007 at 08:09:45AM +0200, Michael Kerrisk wrote:
Amit,
I've taken the page that you sent and made various minor formatting and
wording fixes. I've also added various FIXMEs to
Hi Michael,
On Mon, Jul 23, 2007 at 08:09:45AM +0200, Michael Kerrisk wrote:
Amit,
I've taken the page that you sent and made various minor formatting and
wording fixes. I've also added various FIXMEs to the page. Some of these
(FIXME .) are things that I need to check up later. Some
On Sat, Jul 14, 2007 at 10:23:42AM +0200, Michael Kerrisk wrote:
[CC += [EMAIL PROTECTED]
Amit,
Hi Michael,
Thanks for this page. I will endeavour to review it in
the coming days. In the meantime, the better address to CC
me on fot man pages stuff is [EMAIL PROTECTED]
Sure.
BTW,
From: Amit Arora [EMAIL PROTECTED]
Change on-disk format for extent to represent uninitialized/initialized extents
This change was suggested by Andreas Dilger.
This patch changes the EXT_MAX_LEN value and extent code which marks/checks
uninitialized extents. With this change it will be possible
From: Amit Arora [EMAIL PROTECTED]
write support for preallocated blocks
This patch adds write support to the uninitialized extents that get
created when a preallocation is done using fallocate(). It takes care of
splitting the extents into multiple (upto three) extents and merging the
new
From: Amit Arora [EMAIL PROTECTED]
fallocate support in ext4
This patch implements -fallocate() inode operation in ext4. With this
patch users of ext4 file systems will be able to use fallocate() system
call for persistent preallocation. Current implementation only supports
preallocation for
From: David P. Quigley [EMAIL PROTECTED]
Revalidate the write permissions for fallocate(2), in case security policy has
changed since the files were opened.
Acked-by: James Morris [EMAIL PROTECTED]
Signed-off-by: David P. Quigley [EMAIL PROTECTED]
---
fs/open.c |3 +++
1 files changed, 3
Following is the modified version of the manpage originally submitted by
David Chinner. Please use `nroff -man fallocate.2 | less` to view.
This includes changes suggested by Heikki Orsila and Barry Naujok.
.TH fallocate 2
.SH NAME
fallocate \- allocate or remove file space
.SH SYNOPSIS
.nf
.B
From: Amit Arora [EMAIL PROTECTED]
sys_fallocate() implementation on i386, x86_64 and powerpc
fallocate() is a new system call being proposed here which will allow
applications to preallocate space to any file(s) in a file system.
Each file system implementation that wants to use this feature
This is the latest fallocate patchset and is based on 2.6.22.
* Following are the changes from TAKE6:
1) We now just have two modes (and no deallocation modes).
2) Updated the man page
3) Added a new patch submitted by David P. Quigley (Patch 3/6).
4) Used EXT_INIT_MAX_LEN instead of 0x8000 in
On Fri, Jul 13, 2007 at 02:21:19PM +0100, Christoph Hellwig wrote:
On Fri, Jul 13, 2007 at 06:17:55PM +0530, Amit K. Arora wrote:
/*
+ * sys_fallocate - preallocate blocks or free preallocated blocks
+ * @fd: the file descriptor
+ * @mode: mode specifies the behavior of allocation
On Sat, Jul 14, 2007 at 12:06:51AM +1000, David Chinner wrote:
On Fri, Jul 13, 2007 at 06:16:01PM +0530, Amit K. Arora wrote:
Following is the modified version of the manpage originally submitted by
David Chinner. Please use `nroff -man fallocate.2 | less` to view.
This includes changes
On Fri, Jul 13, 2007 at 02:21:37PM +0100, Christoph Hellwig wrote:
On Fri, Jul 13, 2007 at 06:18:47PM +0530, Amit K. Arora wrote:
From: David P. Quigley [EMAIL PROTECTED]
Revalidate the write permissions for fallocate(2), in case security policy
has
changed since the files were opened
This is the latest fallocate patchset and is based on 2.6.22.
* Following are the changes from TAKE7:
1) Updated the man page.
2) Merged revalidate write permissions patch with the main falloc patch.
3) Added linux/falloc.h and moved FALLOC_FL_KEEP_SIZE flag to it.
Also removed the two modes
Following is the modified version of the manpage originally submitted by
David Chinner. Please use `nroff -man fallocate.2 | less` to view.
Following changed from TAKE7:
* Removed FALLOC_ALLOCATE and FALLOCATE_RESV_SPACE modes.
* Described only single flag for mode, i.e. FALLOC_FL_KEEP_SIZE.
*
From: Amit Arora [EMAIL PROTECTED]
sys_fallocate() implementation on i386, x86_64 and powerpc
fallocate() is a new system call being proposed here which will allow
applications to preallocate space to any file(s) in a file system.
Each file system implementation that wants to use this feature
From: Amit Arora [EMAIL PROTECTED]
fallocate support in ext4
This patch implements -fallocate() inode operation in ext4. With this
patch users of ext4 file systems will be able to use fallocate() system
call for persistent preallocation. Current implementation only supports
preallocation for
From: Amit Arora [EMAIL PROTECTED]
write support for preallocated blocks
This patch adds write support to the uninitialized extents that get
created when a preallocation is done using fallocate(). It takes care of
splitting the extents into multiple (upto three) extents and merging the
new
From: Amit Arora [EMAIL PROTECTED]
Change on-disk format for extent to represent uninitialized/initialized extents
This change was suggested by Andreas Dilger.
This patch changes the EXT_MAX_LEN value and extent code which marks/checks
uninitialized extents. With this change it will be possible
On Thu, Jul 12, 2007 at 12:58:13PM +0530, Suparna Bhattacharya wrote:
On Wed, Jul 11, 2007 at 10:03:12AM +0100, Christoph Hellwig wrote:
On Tue, Jul 03, 2007 at 05:16:50PM +0530, Amit K. Arora wrote:
Well, if you see the modes proposed using above flags :
#define FA_ALLOCATE 0
On Thu, Jul 12, 2007 at 08:56:30AM -0400, David Patrick Quigley wrote:
From: David P. Quigley [EMAIL PROTECTED]
Revalidate the write permissions for fallocate(2), in case security policy has
changed since the files were opened.
Thanks for your patch! Will include it in the patchset.
--
On Thu, Jul 12, 2007 at 11:13:34PM +1000, David Chinner wrote:
On Thu, Jul 12, 2007 at 12:58:13PM +0530, Suparna Bhattacharya wrote:
Why don't we just merge the interface for preallocation (essentially
enough to satisfy posix_fallocate() and the simple XFS requirement for
space
On Wed, Jul 11, 2007 at 12:10:34PM +1000, Stephen Rothwell wrote:
On Wed, 11 Jul 2007 01:50:00 +0530 Amit K. Arora [EMAIL PROTECTED] wrote:
--- linux-2.6.22.orig/arch/x86_64/ia32/sys_ia32.c
+++ linux-2.6.22/arch/x86_64/ia32/sys_ia32.c
@@ -879,3 +879,11 @@ asmlinkage long sys32_fadvise64
On Wed, Jul 11, 2007 at 12:37:01AM +0300, Heikki Orsila wrote:
On Wed, Jul 11, 2007 at 01:48:20AM +0530, Amit K. Arora wrote:
.BI int syscall(int, int fd, int mode, loff_t offset, loff_t len);
Correction: int syscall(int fd, int mode, ...),
Here, we have syscall() with first argument being
This is the latest fallocate patchset and is rebased to 2.6.22.
Following are the changes from TAKE5:
1) Rebased to 2.6.22
2) Added compat wrapper for x86_64
3) Dropped s390 and ia64 patches, since the platform maintaners can
add the support for fallocate once it is in mainline.
4) Added a
Following is the modified version of the manpage originally submitted by
David Chinner. Please use `nroff -man fallocate.2 | less` to view.
.TH fallocate 2
.SH NAME
fallocate \- allocate or remove file space
.SH SYNOPSIS
.nf
.B #include sys/syscall.h
.PP
.BI int syscall(int, int fd, int mode,
From: Amit Arora [EMAIL PROTECTED]
sys_fallocate() implementation on i386, x86_64 and powerpc
fallocate() is a new system call being proposed here which will allow
applications to preallocate space to any file(s) in a file system.
Each file system implementation that wants to use this feature
From: Amit Arora [EMAIL PROTECTED]
Implement new flags and values for mode argument.
This patch implements the new flags and values for the mode argument
of the fallocate system call. It is based on the discussion between
Andreas Dilger and David Chinner on the man page proposed (by the later)
From: Amit Arora [EMAIL PROTECTED]
fallocate support in ext4
This patch implements -fallocate() inode operation in ext4. With this
patch users of ext4 file systems will be able to use fallocate() system
call for persistent preallocation. Current implementation only supports
preallocation for
From: Amit Arora [EMAIL PROTECTED]
Change on-disk format for extent to represent uninitialized/initialized extents
This change was suggested by Andreas Dilger as part of the following
post:
http://www.mail-archive.com/[EMAIL PROTECTED]/msg02445.html
This patch changes the EXT_MAX_LEN value and
On Sat, Jun 30, 2007 at 12:52:46PM -0400, Andreas Dilger wrote:
The @mode flags that are currently under consideration are (AFAIK):
FA_FL_DEALLOC 0x01 /* deallocate unwritten extent (default allocate)
*/
FA_FL_KEEP_SIZE 0x02 /* keep size for EOF {pre,de}alloc (default change
On Tue, Jul 03, 2007 at 11:31:07AM +0100, Christoph Hellwig wrote:
On Tue, Jul 03, 2007 at 03:38:48PM +0530, Amit K. Arora wrote:
FA_FL_DEALLOC 0x01 /* deallocate unwritten extent (default
allocate) */
FA_FL_KEEP_SIZE 0x02 /* keep size for EOF {pre,de}alloc (default change
On Mon, Jul 02, 2007 at 08:55:43AM +1000, David Chinner wrote:
On Sat, Jun 30, 2007 at 11:21:11AM +0100, Christoph Hellwig wrote:
On Tue, Jun 26, 2007 at 04:02:47PM +0530, Amit K. Arora wrote:
Can you clarify - what is the current behaviour when ENOSPC (or some
other
error) is hit
On Thu, Jun 28, 2007 at 02:55:43AM -0700, Andrew Morton wrote:
On Mon, 25 Jun 2007 18:58:10 +0530 Amit K. Arora [EMAIL PROTECTED] wrote:
N O T E:
---
1) Only Patches 4/7 and 7/7 are NEW. Rest of them are _already_ part
of ext4 patch queue git tree hosted by Ted.
Why the heck
On Wed, Jun 27, 2007 at 10:04:56AM +1000, David Chinner wrote:
On Wed, Jun 27, 2007 at 12:59:08AM +0530, Amit K. Arora wrote:
On Tue, Jun 26, 2007 at 12:14:00PM -0400, Andreas Dilger wrote:
On Jun 26, 2007 17:37 +0530, Amit K. Arora wrote:
I think, modifying ctime/mtime should
On Wed, Jun 27, 2007 at 09:18:04AM +1000, David Chinner wrote:
On Tue, Jun 26, 2007 at 11:34:13AM -0400, Andreas Dilger wrote:
On Jun 26, 2007 16:02 +0530, Amit K. Arora wrote:
On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote:
Can you clarify - what is the current
On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote:
On Jun 25, 2007 20:33 +0530, Amit K. Arora wrote:
I have not implemented FA_FL_FREE_ENOSPC and FA_ZERO_SPACE flags yet, as
*suggested* by Andreas in http://lkml.org/lkml/2007/6/14/323 post.
If it is decided that these flags
On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote:
On Jun 25, 2007 19:15 +0530, Amit K. Arora wrote:
+#define FA_FL_DEALLOC 0x01 /* default is allocate */
+#define FA_FL_KEEP_SIZE0x02 /* default is extend/shrink size */
+#define FA_FL_DEL_DATA 0x04 /* default
On Mon, Jun 25, 2007 at 03:56:25PM -0600, Andreas Dilger wrote:
On Jun 25, 2007 19:20 +0530, Amit K. Arora wrote:
@@ -2499,7 +2500,8 @@ long ext4_fallocate(struct inode *inode,
* currently supporting (pre)allocate mode for extent-based
* files _only_
*/
- if (mode
On Tue, Jun 26, 2007 at 11:34:13AM -0400, Andreas Dilger wrote:
On Jun 26, 2007 16:02 +0530, Amit K. Arora wrote:
On Mon, Jun 25, 2007 at 03:46:26PM -0600, Andreas Dilger wrote:
Can you clarify - what is the current behaviour when ENOSPC (or some other
error) is hit? Does it keep
On Tue, Jun 26, 2007 at 11:42:50AM -0400, Andreas Dilger wrote:
On Jun 26, 2007 16:15 +0530, Amit K. Arora wrote:
On Mon, Jun 25, 2007 at 03:52:39PM -0600, Andreas Dilger wrote:
In XFS one of the (many) ALLOC modes is to zero existing data on allocate.
For ext4 all this would mean
This patch implements sys_fallocate() and adds support on i386, x86_64
and powerpc platforms.
Changelog:
-
Changes from Take3 to Take4:
1) Do not update c/mtime. Let each filesystem update ctime (update of
mtime will not be required for allocation since we touch only
This is the patch suggested by Martin Schwidefsky to support
sys_fallocate() on s390(x) platform.
He also suggested a wrapper in glibc to handle this system call on
s390. Posting it here so that we get feedback for this too.
.globl __fallocate
ENTRY(__fallocate)
stm %r6,%r7,28(%r15)
fallocate() on ia64
ia64 fallocate syscall support.
Signed-off-by: Dave Chinner [EMAIL PROTECTED]
Index: linux-2.6.22-rc4/arch/ia64/kernel/entry.S
===
--- linux-2.6.22-rc4.orig/arch/ia64/kernel/entry.S 2007-06-11
Implement new flags and values for mode argument.
This patch implements the new flags and values for the mode argument
of the fallocate system call. It is based on the discussion between
Andreas Dilger and David Chinner on the man page proposed (by the later)
on fallocate.
Signed-off-by: Amit
N O T E:
---
1) Only Patches 4/7 and 7/7 are NEW. Rest of them are _already_ part
of ext4 patch queue git tree hosted by Ted.
2) The above new patches (4/7 and 7/7) are based on the dicussion
between Andreas Dilger and David Chinner on the mode argument,
when later posted a man page
This patch implements -fallocate() inode operation in ext4. With this
patch users of ext4 file systems will be able to use fallocate() system
call for persistent preallocation.
Current implementation only supports preallocation for regular files
(directories not supported as of date) with extent
This patch adds write support to the uninitialized extents that get
created when a preallocation is done using fallocate(). It takes care of
splitting the extents into multiple (upto three) extents and merging the
new split extents with neighbouring ones, if possible.
Changelog:
-
Changes
On Sat, May 12, 2007 at 06:01:57PM +1000, David Chinner wrote:
On Fri, May 11, 2007 at 04:33:01PM +0530, Suparna Bhattacharya wrote:
On Fri, May 11, 2007 at 08:39:50AM +1000, David Chinner wrote:
All I'm really interested in right now is that the fallocate
_interface_ can be used as a
On Thu, May 17, 2007 at 09:40:36AM +1000, David Chinner wrote:
On Wed, May 16, 2007 at 07:21:16AM -0500, Dave Kleikamp wrote:
On Wed, 2007-05-16 at 13:16 +1000, David Chinner wrote:
On Wed, May 16, 2007 at 01:33:59AM +0530, Amit K. Arora wrote:
Following changes were made
Description:
---
fallocate() is a new system call being proposed here which will allow
applications to preallocate space to any file(s) in a file system.
Each file system implementation that wants to use this feature will need
to support an inode operation called fallocate.
Applications
This is the patch suggested by Martin Schwidefsky to support
sys_fallocate() on s390(x) platform.
He also suggested a wrapper in glibc to handle this system call on
s390. Posting it here so that we get feedback for this too.
.globl __fallocate
ENTRY(__fallocate)
stm %r6,%r7,28(%r15)
Here is the 2.6.22-rc1 version of David's patch: add fallocate() on ia64
From: David Chinner [EMAIL PROTECTED]
Subject: [PATCH] ia64 fallocate syscall
Cc: Amit K. Arora [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED]
ia64 fallocate
This patch adds a check for overlap of extents and cuts short the
new extent to be inserted, if there is a chance of overlap.
Changelog:
-
Changes from Take3 to Take4:
- no change -
Changes from Take2 to Take3:
1) Patch rebased to 2.6.22-rc1 kernel.
Changes from Take1 to Take2:
1) As
This patch implements -fallocate() inode operation in ext4. With this
patch users of ext4 file systems will be able to use fallocate() system
call for persistent preallocation.
Current implementation only supports preallocation for regular files
(directories not supported as of date) with extent
This patch adds write support to the uninitialized extents that get
created when a preallocation is done using fallocate(). It takes care of
splitting the extents into multiple (upto three) extents and merging the
new split extents with neighbouring ones, if possible.
Changelog:
-
Changes
On Tue, May 15, 2007 at 05:42:46PM -0700, Mingming Cao wrote:
On Wed, 2007-05-16 at 01:33 +0530, Amit K. Arora wrote:
This patch implements sys_fallocate() and adds support on i386, x86_64
and powerpc platforms.
@@ -1137,6 +1148,8 @@ struct inode_operations {
ssize_t (*listxattr
On Wed, May 16, 2007 at 07:21:16AM -0500, Dave Kleikamp wrote:
On Wed, 2007-05-16 at 13:16 +1000, David Chinner wrote:
On Wed, May 16, 2007 at 01:33:59AM +0530, Amit K. Arora wrote:
Following changes were made to the previous version:
1) Added description before sys_fallocate
On Tue, May 15, 2007 at 12:31:21AM -0600, Andreas Dilger wrote:
On May 14, 2007 18:59 +0530, Amit K. Arora wrote:
asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len)
fd: The descriptor of the open file.
mode*: This specifies the behavior of the system call
On Tue, May 15, 2007 at 09:44:36AM +1000, Stephen Rothwell wrote:
On Mon, 14 May 2007 20:15:24 +0530 Amit K. Arora [EMAIL PROTECTED] wrote:
This patch implements sys_fallocate() and adds support on i386, x86_64
and powerpc platforms.
This patch no longer applies to Linus' tree
-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
P L E A S EN O T E :
***
1. Patches have been now rebased to 2.6.22-rc1 kernel. Earlier they were
based on 2.6.21.
2. An unnecessary export of symbol is removed from the ext4 preallocate
patch. Details
This patch implements sys_fallocate() and adds support on i386, x86_64
and powerpc platforms.
Changelog:
-
Note: The changes below are from the initial post (dated 26th April,
2007) and _not_ from TAKE2. The only difference from TAKE2 is the kernel
version on which this patch is based.
This patch adds a check for overlap of extents and cuts short the
new extent to be inserted, if there is a chance of overlap.
Changelog:
-
Note: The changes below are from the initial post (dated 26th April,
2007) and _not_ from TAKE2. The only difference from TAKE2 is the kernel
version
This patch implements -fallocate() inode operation in ext4. With this
patch users of ext4 file systems will be able to use fallocate() system
call for persistent preallocation.
Current implementation only supports preallocation for regular files
(directories not supported as of date) with extent
This is the new set of patches which take care of the review comments
received from the community (mainly from Andrew).
Description:
---
fallocate() is a new system call being proposed here which will allow
applications to preallocate space to any file(s) in a file system.
Each file
This patch implements sys_fallocate() and adds support on i386, x86_64
and powerpc platforms.
Changelog:
-
Following changes were made to the previous version:
1) Added description before sys_fallocate() definition.
2) Return EINVAL for len=0 (With new draft that Ulrich pointed to,
This is the patch suggested by Martin Schwidefsky. Here are the comments
and patch from him.
-
From: Martin Schwidefsky [EMAIL PROTECTED]
This patch implements support of fallocate system call on s390(x)
platform. A wrapper is added to address the issue which s390 ABI has
with the
This patch adds a check for overlap of extents and cuts short the
new extent to be inserted, if there is a chance of overlap.
Changelog:
-
As suggested by Andrew, a check for wrap though zero has been added.
Here is the new patch:
Signed-off-by: Amit Arora [EMAIL PROTECTED]
---
This patch implements -fallocate() inode operation in ext4. With this
patch users of ext4 file systems will be able to use fallocate() system
call for persistent preallocation.
Current implementation only supports preallocation for regular files
(directories not supported as of date) with extent
This patch adds write support to the uninitialized extents that get
created when a preallocation is done using fallocate(). It takes care of
splitting the extents into multiple (upto three) extents and merging the
new split extents with neighbouring ones, if possible.
Changelog:
-
1)
On Thu, May 10, 2007 at 10:59:26AM +1000, David Chinner wrote:
On Wed, May 09, 2007 at 09:31:02PM +0530, Amit K. Arora wrote:
I have the updated patches ready which take care of Andrew's comments.
Will run some tests and post them soon.
But, before submitting these patches, I think
On Wed, May 09, 2007 at 09:37:22PM +1000, Paul Mackerras wrote:
Suparna Bhattacharya writes:
Of course the interface used by an application program would have the
fd first. Glibc can do the translation.
I think that was understood.
OK, then what does it matter what the
I have the updated patches ready which take care of Andrew's comments.
Will run some tests and post them soon.
But, before submitting these patches, I think it will be better to finalize
on certain things which might be worth some discussion here:
1) Should the file size change when
Andrew,
Thanks for the review comments!
On Thu, May 03, 2007 at 09:29:55PM -0700, Andrew Morton wrote:
On Thu, 26 Apr 2007 23:33:32 +0530 Amit K. Arora [EMAIL PROTECTED] wrote:
This patch implements the fallocate() system call and adds support for
i386, x86_64 and powerpc
On Thu, May 03, 2007 at 11:28:15PM -0700, Andrew Morton wrote:
The above opengroup page only permits S_ISREG. Preallocating directories
sounds quite useful to me, although it's something which would be pretty
hard to emulate if the FS doesn't support it. And there's a decent case to
be made
On Thu, May 03, 2007 at 09:30:02PM -0700, Andrew Morton wrote:
On Thu, 26 Apr 2007 23:41:01 +0530 Amit K. Arora [EMAIL PROTECTED] wrote:
+unsigned int ext4_ext_check_overlap(struct inode *inode,
+ struct ext4_extent *newext
On Thu, May 03, 2007 at 09:31:33PM -0700, Andrew Morton wrote:
On Thu, 26 Apr 2007 23:43:32 +0530 Amit K. Arora [EMAIL PROTECTED] wrote:
This patch has the ext4 implemtation of fallocate system call.
...
+ /* ext4_can_extents_be_merged should have checked that either
On Thu, May 03, 2007 at 09:32:38PM -0700, Andrew Morton wrote:
On Thu, 26 Apr 2007 23:46:23 +0530 Amit K. Arora [EMAIL PROTECTED] wrote:
+ */
+int ext4_ext_try_to_merge(struct inode *inode,
+ struct ext4_ext_path *path,
+ struct
On Mon, May 07, 2007 at 03:40:26PM +0300, Pekka Enberg wrote:
On 4/26/07, Amit K. Arora [EMAIL PROTECTED] wrote:
/*
+ * ext4_ext_try_to_merge:
+ * tries to merge the ex extent to the next extent in the tree.
+ * It always tries to merge towards right. If you want to merge towards
+ * left
On Sun, Apr 29, 2007 at 10:25:59PM -0700, Chris Wedgwood wrote:
On Mon, Apr 30, 2007 at 10:47:02AM +1000, David Chinner wrote:
For FA_ALLOCATE, it's supposed to change the file size if we
allocate past EOF, right?
I would argue no. Use truncate for that.
The patch I posted for ext4
Based on the discussion, this new patchset uses following as the
interface for fallocate() system call:
asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len)
It seems that only s390 architecture has a problem with such a layout of
arguments in fallocate(). Thus for s390, we
This patch implements the fallocate() system call and adds support for
i386, x86_64 and powerpc.
NOTE: It is based on 2.6.21 kernel version.
Signed-off-by: Amit Arora [EMAIL PROTECTED]
---
arch/i386/kernel/syscall_table.S |1
arch/powerpc/kernel/sys_ppc32.c |7 ++
This patch implements support of fallocate system call on s390(x)
platform. A wrapper is added to address the issue which s390 ABI has
with preferred ordering of arguments in this system call (i.e. int,
int, loff_t, loff_t).
I will request s390 experts to please review this code and verify if
This is a fix for an extent-overlap bug. The fallocate() implementation
on ext4 depends on this bugfix. Though this fix had been posted earlier,
but because it is still not part of mainline code, I have attached it
here too.
Signed-off-by: Amit Arora [EMAIL PROTECTED]
---
fs/ext4/extents.c
This patch has the ext4 implemtation of fallocate system call.
Signed-off-by: Amit Arora [EMAIL PROTECTED]
---
fs/ext4/extents.c | 201 +++-
fs/ext4/file.c |1
include/linux/ext4_fs.h |7 +
This patch adds write support for preallocated (using fallocate system
call) blocks/extents. The preallocated extents in ext4 are marked
uninitialized, hence they need special handling especially while
writing to them. This patch takes care of that.
Signed-off-by: Amit Arora [EMAIL PROTECTED]
---
On Fri, Apr 20, 2007 at 10:59:18AM -0400, Jakub Jelinek wrote:
On Fri, Apr 20, 2007 at 07:21:46PM +0530, Amit K. Arora wrote:
Ok.
In this case we may have to consider following things:
1) Obviously, for this glibc will have to call fallocate() syscall with
different arguments on s390
On Wed, Apr 18, 2007 at 07:06:00AM -0600, Andreas Dilger wrote:
On Apr 17, 2007 18:25 +0530, Amit K. Arora wrote:
On Fri, Mar 30, 2007 at 02:14:17AM -0500, Jakub Jelinek wrote:
Wouldn't
int fallocate(loff_t offset, loff_t len, int fd, int mode)
work on both s390 and ppc/arm? glibc
On Fri, Mar 30, 2007 at 02:14:17AM -0500, Jakub Jelinek wrote:
Wouldn't
int fallocate(loff_t offset, loff_t len, int fd, int mode)
work on both s390 and ppc/arm? glibc will certainly wrap it and
reorder the arguments as needed, so there is no need to keep fd first.
I think more people are
On Thu, Apr 05, 2007 at 04:56:19PM +0530, Amit K. Arora wrote:
Correction below:
asmlinkage long sys_s390_fallocate(int fd, loff_t offset, loff_t len, int
mode)
{
return sys_fallocate(fd, offset, len, mode);
return sys_fallocate(fd, mode, offset, len);
}
--
Regards,
Amit
Hello,
We need to come up with the best possible layout of arguments for the
fallocate() system call. Various architectures have different
requirements for how the arguments should look like. Since the mail
chain has become huge, here is the summary of various inputs received
so far.
Platform:
this change to the patch.
Here is how it looks like now. Please let me know if anyone has concerns
about passing arguments this way (breaking each loff_t into two u32s).
Signed-off-by: Amit K Arora [EMAIL PROTECTED]
---
arch/i386/kernel/syscall_table.S |1
arch/x86_64/kernel/functionlist
On Fri, Mar 16, 2007 at 04:21:03PM +0100, Heiko Carstens wrote:
On Fri, Mar 16, 2007 at 08:01:01PM +0530, Amit K. Arora wrote:
First of all, thanks for the overwhelming response!
Based on the suggestions received, I have added a new parameter to the
sys_fallocate() system call
On Sat, Mar 17, 2007 at 04:33:50PM +1100, Stephen Rothwell wrote:
On Fri, 16 Mar 2007 20:01:01 +0530 Amit K. Arora [EMAIL PROTECTED] wrote:
+asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len);
--- linux-2.6.20.1.orig/include/asm-powerpc/systbl.h
+++ linux
()
call fallocate() system call
5 Changes to XFS to implement the fallocate inode operation
Signed-off-by: Amit K Arora [EMAIL PROTECTED]
---
arch/i386/kernel/syscall_table.S |1
arch/x86_64/kernel/functionlist |1
fs/open.c| 41
This is to give a heads up on few patches that we will be soon coming up
with. These patches implement a new system call sys_fallocate() and a
new inode operation fallocate, for persistent preallocation. The new
system call, as Andrew suggested, will look like:
asmlinkage long sys_fallocate(int
On Wed, Feb 07, 2007 at 12:25:50AM -0800, Mingming Cao wrote:
On Wed, 2007-02-07 at 13:18 +0530, Amit K. Arora wrote:
c) Do I need to put some hack in the filesystem code for above (to
allocate 32 bit physical block numbers) ?
I had a ext3 hack patch before to allow application specify which
1 - 100 of 101 matches
Mail list logo
