[PATCH 2/2] Unionfs: clarify usage.txt mount options

CC: Jim Kissel [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/usage.txt | 38 +++ 1 files changed, 27 insertions(+), 11 deletions(-) diff --git a/Documentation/filesystems/unionfs/usage.txt b/Documentation

Re: [PATCH 2/2] Unionfs: clarify usage.txt mount options

In message [EMAIL PROTECTED], Michael Tokarev writes: Erez Zadok wrote: --- a/Documentation/filesystems/unionfs/usage.txt +++ b/Documentation/filesystems/unionfs/usage.txt [] +OPTIONS can be any legal combination one of: ^ A small typo

Re: [PATCH 36/42] VFS: export drop_pagecache_sb

In message [EMAIL PROTECTED], Nick Piggin writes: On Monday 10 December 2007 13:42, Erez Zadok wrote: Needed to maintain cache coherency after branch management. Hmm, I'd much prefer to be able to sleep in invalidate_mapping_pages before this function gets exported. As it is, it can

Re: [UNIONFS] 00/42 Unionfs and related patches review

lower file systems whatsoever, because they are well tested and stable. In message [EMAIL PROTECTED], [EMAIL PROTECTED] writes: Erez Zadok: (1) Cache coherency: by far, the biggest concern had been around cache ::: unionfs. The solution we have implemented is to compare the mtime/ctime

Re: [PATCH 01/42] Unionfs: filesystems documentation index

In message [EMAIL PROTECTED], Jan Engelhardt writes: On Dec 9 2007 21:41, Erez Zadok wrote: Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/00-INDEX |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) This is not CVS, you are allowed to have

Re: [PATCH 33/42] MM: extern for drop_pagecache_sb

In message [EMAIL PROTECTED], Adrian Bunk writes: On Sun, Dec 09, 2007 at 09:42:06PM -0500, Erez Zadok wrote: Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/mm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/mm.h b/include

[UNIONFS] 00/42 Unionfs and related patches review

Al, Christoph, and Andrew, As per your request, I'm posting for review the unionfs code (and related code) that's in my korg tree against mainline (v2.6.24-rc4-190-g94545ba). This code is nearly identical to what's in -mm (the mm code has a couple of additional things that depend on mm-specific

[PATCH 18/42] Unionfs: directory reading file operations

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirfops.c | 290 ++ 1 files changed, 290 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dirfops.c diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c new file mode

[PATCH 02/42] Unionfs: unionfs documentation index

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/00-INDEX | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 Documentation/filesystems/unionfs/00-INDEX diff --git a/Documentation/filesystems/unionfs/00-INDEX b/Documentation

[PATCH 05/42] Unionfs: documentation for any known issues

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/issues.txt | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 Documentation/filesystems/unionfs/issues.txt diff --git a/Documentation/filesystems/unionfs

[PATCH 03/42] Unionfs: documentation for general concepts

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/concepts.txt | 199 1 files changed, 199 insertions(+), 0 deletions(-) create mode 100644 Documentation/filesystems/unionfs/concepts.txt diff --git a/Documentation/filesystems/unionfs

[PATCH 07/42] Unionfs maintainers

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- MAINTAINERS |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f3d7256..95f16f0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3805,6 +3805,15 @@ L: [EMAIL PROTECTED] W: http

[PATCH 04/42] Unionfs: usage documentation for users

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/usage.txt | 115 +++ 1 files changed, 115 insertions(+), 0 deletions(-) create mode 100644 Documentation/filesystems/unionfs/usage.txt diff --git a/Documentation/filesystems/unionfs

[PATCH 22/42] Unionfs: unlink/rmdir operations

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/unlink.c | 236 +++ 1 files changed, 236 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/unlink.c diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c new file mode 100644

[PATCH 09/42] Unionfs: main Makefile

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/Makefile | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/Makefile diff --git a/fs/unionfs/Makefile b/fs/unionfs/Makefile new file mode 100644 index 000..17ca4a7 --- /dev/null

[PATCH 28/42] Unionfs: async I/O queue operations

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/sioq.c | 119 + 1 files changed, 119 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/sioq.c diff --git a/fs/unionfs/sioq.c b/fs/unionfs/sioq.c new file mode 100644 index

[PATCH 26/42] Unionfs: extended attributes operations

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/xattr.c | 153 1 files changed, 153 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/xattr.c diff --git a/fs/unionfs/xattr.c b/fs/unionfs/xattr.c new file mode 100644

[PATCH 15/42] Unionfs: dentry revalidation

Includes d_release methods and cache-coherency support for dentries. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 498 +++ 1 files changed, 498 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dentry.c diff

[PATCH 29/42] Unionfs: miscellaneous helper routines

Mostly related to whiteouts. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/subr.c | 242 + 1 files changed, 242 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/subr.c diff --git a/fs/unionfs/subr.c b/fs/unionfs

[PATCH 31/42] VFS: fs_stack header cleanups

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/fs_stack.h | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/include/linux/fs_stack.h b/include/linux/fs_stack.h index bb516ce..6b52faf 100644 --- a/include/linux/fs_stack.h +++ b/include

[PATCH 41/42] eCryptfs: use simplified fs_stack API for inode operations

CC: Mike Halcrow [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/ecryptfs/inode.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c index 0b1ab01..a846557 100644 --- a/fs/ecryptfs/inode.c +++ b/fs/ecryptfs

[PATCH 38/42] VFS: simplified fsstack_copy_attr_all

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/stack.c | 30 +- 1 files changed, 17 insertions(+), 13 deletions(-) diff --git a/fs/stack.c b/fs/stack.c index 67716f6..a548aac 100644 --- a/fs/stack.c +++ b/fs/stack.c @@ -1,8 +1,20 @@ +/* + * Copyright (c) 2006

[PATCH 24/42] Unionfs: mount-time and stacking-interposition functions

Includes read_super and module-linkage routines. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c | 783 + 1 files changed, 783 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/main.c diff --git a/fs/unionfs

[PATCH 14/42] Unionfs: lower-level copyup routines

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 897 +++ 1 files changed, 897 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/copyup.c diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c new file mode 100644

[PATCH 33/42] MM: extern for drop_pagecache_sb

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/mm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index 1b7b95c..fc61bd3 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -19,6 +19,7 @@ struct anon_vma

[PATCH 37/42] VFS: export release_open_intent symbol

Needed to release the resources of the lower nameidata structures that we create and pass to lower file systems (e.g., when calling vfs_create). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/namei.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/namei.c b/fs

[PATCH 25/42] Unionfs: super_block operations

Includes read_inode, delete_inode, put_super, statfs, remount_fs (which supports branch-management ops), clear_inode, alloc_inode, destroy_inode, write_inode, umount_begin, and show_options. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/super.c | 1020

[PATCH 19/42] Unionfs: readdir helper functions

Includes whiteout handling for directories. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirhelper.c | 272 1 files changed, 272 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/dirhelper.c diff --git a/fs/unionfs

[PATCH 42/42] eCryptfs: use simplified fs_stack API for main operations

CC: Mike Halcrow [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/ecryptfs/main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c index b83a512..cebe7dc 100644 --- a/fs/ecryptfs/main.c +++ b/fs/ecryptfs/main.c

[PATCH 23/42] Unionfs: address-space operations

Includes writepage, writepages, readpage, prepare_write, and commit_write. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 338 + 1 files changed, 338 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/mmap.c

[PATCH 17/42] Unionfs: rename method and helpers

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rename.c | 533 +++ 1 files changed, 533 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/rename.c diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c new file mode 100644

[PATCH 27/42] Unionfs: async I/O queue headers

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/sioq.h | 92 + 1 files changed, 92 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/sioq.h diff --git a/fs/unionfs/sioq.h b/fs/unionfs/sioq.h new file mode 100644 index

[PATCH 08/42] Makefile: hook to compile unionfs

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/Makefile b/fs/Makefile index 500cf15..e202288 100644 --- a/fs/Makefile +++ b/fs/Makefile @@ -118,3 +118,4 @@ obj-$(CONFIG_HPPFS) += hppfs/ obj

[PATCH 35/42] Unionfs: common header file for user-land utilities and kernel

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/union_fs.h | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100644 include/linux/union_fs.h diff --git a/include/linux/union_fs.h b/include/linux/union_fs.h new file mode 100644 index

[PATCH 11/42] Unionfs: main header file

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/union.h | 591 1 files changed, 591 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/union.h diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h new file mode 100644

[PATCH 34/42] VFS path get/put ops used by Unionfs

Note: this will become obsolete once similar patches, now in -mm, make it to mainline. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/namei.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/include/linux/namei.h b/include/linux/namei.h index

[PATCH 16/42] Unionfs: lower-level lookup routines

Includes lower nameidata support routines. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/lookup.c | 652 +++ 1 files changed, 652 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/lookup.c diff --git a/fs/unionfs/lookup.c

[PATCH 13/42] Unionfs: basic file operations

Includes read, write, mmap, fsync, and fasync. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c | 227 + 1 files changed, 227 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/file.c diff --git a/fs/unionfs/file.c

[PATCH 10/42] Unionfs: fanout header definitions

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/fanout.h | 355 +++ 1 files changed, 355 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/fanout.h diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h new file mode 100644

[PATCH 30/42] Unionfs: debugging infrastructure

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 532 1 files changed, 532 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/debug.c diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c new file mode 100644

[PATCH 36/42] VFS: export drop_pagecache_sb

Needed to maintain cache coherency after branch management. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/drop_caches.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/drop_caches.c b/fs/drop_caches.c index 59375ef..90410ac 100644 --- a/fs/drop_caches.c +++ b

[PATCH 39/42] Put Unionfs and eCryptfs under one layered filesystems menu

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/Kconfig | 53 + 1 files changed, 41 insertions(+), 12 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index 635f3e2..cbcbbee 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -1041,6 +1041,47

[PATCH 12/42] Unionfs: common file copyup/revalidation operations

Includes open, ioctl, and flush operations. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 827 +++ 1 files changed, 827 insertions(+), 0 deletions(-) create mode 100644 fs/unionfs/commonfops.c diff --git a/fs/unionfs

[PATCH 21/42] Unionfs: inode operations

Includes create, lookup, link, symlink, mkdir, mknod, readlink, follow_link, put_link, permission, and setattr. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 1154 1 files changed, 1154 insertions(+), 0 deletions

[PATCH 40/42] eCryptfs: use simplified fs_stack API for dentry operations

CC: Mike Halcrow [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/ecryptfs/dentry.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c index cb20b96..a8c1686 100644 --- a/fs/ecryptfs/dentry.c +++ b/fs/ecryptfs

[GIT PULL -mm] 0/2 Unionfs updates/fixes/cleanups

, reiserfs, nfs2/3/4, jffs2, ramfs, tmpfs, cramfs, and squashfs (where available). See http://unionfs.filesystems.org/ to download back-ported unionfs code. Please pull from the 'master' branch of git://git.kernel.org/pub/scm/linux/kernel/git/ezk/unionfs.git to receive the following: Erez Zadok

[PATCH 1/2] Unionfs: cleanup/consolidate branch-mode parsing code

Also a bug fix: disallow unrecognized branch modes at mount time, instead of defaulting to rw. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c | 44 ++-- fs/unionfs/super.c | 12 fs/unionfs/union.h |3 +-- 3 files

[PATCH 2/2] Unionfs: reduce the amount of cache-coherency debugging messages

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 38 +++--- 1 files changed, 23 insertions(+), 15 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 05d9914..7d27987 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs

[GIT PULL -mm] 00/16 Unionfs updates/fixes/cleanups

of git://git.kernel.org/pub/scm/linux/kernel/git/ezk/unionfs.git to receive the following: Erez Zadok (15): Unionfs: use f_path instead of f_dentry/mnt Unionfs: minor coding standards applied Unionfs: minor cleanup in the debugging infrastructure Unionfs: set lower mnt

[PATCH 10/16] Unionfs: create opaque directories' whiteouts unconditionally

Needed to maintain Unix semantics (LTP testing). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/subr.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c index 968ee8c..1a26c57 100644 --- a/fs/unionfs/subr.c

[PATCH 13/16] Unionfs: support splice(2)

Also remove redundant variable from unionfs_readpage (saves a bit on stack space). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c |1 + fs/unionfs/mmap.c | 10 -- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c

[PATCH 15/16] Unionfs: update our inode size correctly upon partial write

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index ea5ef3d..8c07eed 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c @@ -250,7 +250,6 @@ static int

[PATCH 07/16] Unionfs: remove useless debugging messages

These are considered normal behaviour, they don't really reveal any insight to the person debugging the code, and they tend to clutter console messages. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |5 - fs/unionfs/dentry.c | 15 +++ 2 files

[PATCH 11/16] Unionfs: update times in setattr

Needed to maintain Unix semantics via utimes(2). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index ef61d9c..63ff3d3 100644 --- a/fs/unionfs/inode.c

[PATCH 12/16] Unionfs: reintroduce a bmap method

This is needed for swapon(2) files in the union. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 3f65e52..fa358ef 100644 --- a/fs/unionfs

[PATCH 08/16] Unionfs: release lower resources on successful rmdir

This patch prevents those resources from lingering around until memory pressure would have forced them out. The patch also properly handles directories that have been rmdir'ed which are still some process's cwd. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED

[PATCH 05/16] Unionfs: set lower mnt after mkdir which resulted in copyup

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 1708f40..9c144be 100644 --- a/fs/unionfs/inode.c +++ b/fs/unionfs/inode.c @@ -674,8 +674,10 @@ out

[PATCH 16/16] Unionfs: use generic_file_aio_read/write

There's no apparent need to define our own aio_read/write methods. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c | 27 ++- 1 files changed, 2 insertions(+), 25 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c index b7d0d55..c922173

[PATCH 02/16] Unionfs: minor cleanup in writepage

From: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 4918f77..1e10280 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c

[PATCH 01/16] Unionfs: use f_path instead of f_dentry/mnt

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |2 +- fs/unionfs/fanout.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 8464fbb..bc221d6 100644 --- a/fs/unionfs/debug.c +++ b/fs/unionfs/debug.c

[PATCH 03/16] Unionfs: minor coding standards applied

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c |4 ++-- fs/unionfs/dirfops.c |5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 98bed0b..3fe4865 100644 --- a/fs/unionfs/copyup.c +++ b/fs/unionfs

[PATCH 04/16] Unionfs: minor cleanup in the debugging infrastructure

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 64 --- 1 files changed, 30 insertions(+), 34 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index bc221d6..c2b8b58 100644 --- a/fs/unionfs/debug.c +++ b/fs

[PATCH 14/16] Unionfs: prevent multiple writers to lower_page

Without this patch, the LTP fs test rwtest04 triggers a BUG_ON(PageWriteback(page)) in fs/buffer.c:1706. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/unionfs

[PATCH 09/16] Unionfs: don't create whiteouts on rightmost branch

If we are unlinking/rmdir'ing an object on the rightmost branch, there's no need to create a whiteout there: this saves on storage space and inodes. Also, in the (degenerate) case of having only one branch, this really saves on whiteouts. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: On Tue, 13 Nov 2007, Erez Zadok wrote: [...] I'm glad to report that this unionfs, not the one in 2.6.24-rc2-mm1 but the one including those 9 patches you posted, now gets through my testing with tmpfs without a problem. I do still get

[PATCH 3/9] Unionfs: update cache-coherency detection heuristics

Use a small delay to reduce the number of times unionfs has to detect changed mtime's/ctime's, and also reduce the potential for false positives. See Documentation/filesystems/unionfs/concepts.txt for a detailed discussion. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation

[PATCH 8/9] Unionfs: fold do_readpage into unionfs_readpage

Simplify the code and reduce stack pressure a bit. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 44 ++-- 1 files changed, 14 insertions(+), 30 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 34fd8aa..ef8822f

[PATCH 6/9] Unionfs: debugging updates

Don't perform dentry+inode checks unless both are valid. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 0066ccd..8464fbb 100644 --- a/fs/unionfs/debug.c

[PATCH 9/9] Unionfs: move debugging checks inside locks

This is to ensure that the objects we want to check aren't being destroyed or changed by another thread. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |7 --- fs/unionfs/dentry.c |2 +- fs/unionfs/file.c | 10 +- fs/unionfs/inode.c

[PATCH 5/9] Unionfs: clear partial read in readpage

Signed-off-by: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 468dc61..bb00fd5 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs

[PATCH 4/9] Unionfs: writepage updates

Don't set/reset the PageUptodate flag on our page. Call flush_dcache_page on the lower page after copy_highpage, and set it uptodate. Call set_page_dirty right before clear_page_dirty_for_io. CC: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: On Fri, 9 Nov 2007, Erez Zadok wrote: In message [EMAIL PROTECTED], Hugh Dickins writes: Three, I believe you need to add a flush_dcache_page(lower_page) after the copy_highpage(lower_page): some architectures will need that to see

[PATCH 1/9] Unionfs: flush and release updates

Remove the totalopens counter which was intended to reduce unnecessary processing of d_deleted dentries. Move that processing from file_release to flush. Cc: Hugh Dickins [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 30

[PATCH 2/9] Unionfs: use i_size wrappers

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 10 +- fs/unionfs/inode.c |4 ++-- fs/unionfs/rdstate.c|4 ++-- fs/unionfs/rename.c |4 ++-- fs/unionfs/super.c |2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Dave Hansen writes: On Mon, 2007-11-05 at 15:40 +, Hugh Dickins wrote: [...] I have a decent guess what the bug is, too. In the unionfs code: int init_lower_nd(struct nameidata *nd, unsigned int flags) { ... #ifdef ALLOC_LOWER_ND_FILE

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: [Dave, I've Cc'ed you re handle_write_count_underflow, see below.] On Wed, 31 Oct 2007, Erez Zadok wrote: Hi Hugh, I've addressed all of your concerns and am happy to report that the newly revised unionfs_writepage works even better

[PATCH 1/8] Unionfs: delete whiteouts in sticky directories

This is needed to maintain Unix semantics. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 6ca52f4..f4facf4 100644 --- a/fs/unionfs/inode.c

[GIT PULL -mm] 0/8 Unionfs updates/cleanups/fixes

the following: Erez Zadok (8): Unionfs: delete whiteouts in sticky directories Unionfs: cleanup permission checking code Unionfs: update usage.txt documentation Unionfs: mmap updates Unionfs: avoid a deadlock during branch-management on a pivot_root'ed union Unionfs

[PATCH 2/8] Unionfs: cleanup permission checking code

Use vfs helpers and avoid redundant checks performed by the VFS already. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |4 --- fs/unionfs/inode.c | 70 +-- 2 files changed, 13 insertions(+), 61 deletions(-) diff

[PATCH 6/8] Unionfs: don't bother validating inode if it has no lower branches

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 894bf7c..0066ccd 100644 --- a/fs/unionfs/debug.c +++ b/fs/unionfs/debug.c @@ -49,6 +49,9 @@ void

[PATCH 5/8] Unionfs: avoid a deadlock during branch-management on a pivot_root'ed union

Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Herton Ronaldo Krzesinski [EMAIL PROTECTED] --- fs/unionfs/union.h | 39 +-- 1 files changed, 33 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h index 6333488..0476f97

[PATCH 7/8] Unionfs: don't printk an error if it's due to common copyup

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c |9 + fs/unionfs/rename.c |2 +- fs/unionfs/subr.c |8 ++-- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 169365c..bcefe45 100644 --- a/fs

[PATCH 3/8] Unionfs: update usage.txt documentation

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/usage.txt | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/Documentation/filesystems/unionfs/usage.txt b/Documentation/filesystems/unionfs/usage.txt index d8c15de..a6b1aca

[PATCH 4/8] Unionfs: mmap updates

Rewrite unionfs_writepage to minimize dependence on AOP_WRITEPAGE_ACTIVEATE, handle memory pressure better, and update documentation. Remove unionfs_sync_page because it's not needed. CC: Hugh Dickins [EMAIL PROTECTED] CC: Pekka Enberg [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL

[PATCH 8/8] Unionfs/VFS: no need to export 2 symbols in security/security.c

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- security/security.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/security/security.c b/security/security.c index 95a6733..0e1f1f1 100644 --- a/security/security.c +++ b/security/security.c @@ -409,7 +409,6 @@ int

Re: [PATCH v3] 0/4 fs/ioctl.c coding style, function renaming/factoring

In message [EMAIL PROTECTED], Andrew Morton writes: On Tue, 30 Oct 2007 15:39:55 -0400 Erez Zadok [EMAIL PROTECTED] wrote: This series of 4 proposed patches (take 3) changes fs/ioctl.c and Unionfs as follows. The problem is of course that you need these in your tree for ongoing

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

Hi Hugh, I've addressed all of your concerns and am happy to report that the newly revised unionfs_writepage works even better, including under my memory-pressure conditions. To summarize my changes since the last time: - I'm only masking __GFP_FS, not __GFP_IO - using find_or_create_page to

Re: [PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names

In message [EMAIL PROTECTED], Christoph Hellwig writes: On Tue, Oct 30, 2007 at 08:22:40AM -0700, Randy Dunlap wrote: They are just treated as part of the parameter explanation text. I don't see any problem with them. Well, it's completely inconsistant with any other kerneldoc.. If it

Re: [PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls

BTW, what's the origin of this oddity in fs/ioctl.c: #ifdef __sparc__ /* SunOS compatibility item. */ if (O_NONBLOCK != O_NDELAY) flag |= O_NDELAY; #endif It seems rather odd to have architecture-specific code in the VFS, no? Erez. - To unsubscribe from this

[PATCH v3] 0/4 fs/ioctl.c coding style, function renaming/factoring

to propose that the first 3 patches be merged in -mm and even mainline, pending review. Erez Zadok (4): VFS: apply coding standards to fs/ioctl.c VFS: swap do_ioctl and vfs_ioctl names VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls Unionfs: use vfs_ioctl

[PATCH 4/4] Unionfs: use vfs_ioctl

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 36 ++-- 1 files changed, 6 insertions(+), 30 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index 7654bcb..c99b519 100644 --- a/fs/unionfs/commonfops.c +++ b

[PATCH 1/4] VFS: apply coding standards to fs/ioctl.c

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/ioctl.c | 164 +++- 1 files changed, 84 insertions(+), 80 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index c2a773e..652cacf 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -12,8 +12,8

[PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names

because the names vfs_XXX should preferably be reserved to callable VFS functions which modules may call, as many other vfs_XXX functions already do. Export the new vfs_ioctl to GPL modules so others can use it (including Unionfs and eCryptfs). Add DocBook for new vfs_ioctl. Signed-off-by: Erez

[PATCH 3/4] VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/ioctl.c | 129 +++- 1 files changed, 75 insertions(+), 54 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index 1ab7b7d..cd8c1a3 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -53,32 +53,34

Re: [PATCH 1/3] VFS: apply coding standards to fs/ioctl.c

In message [EMAIL PROTECTED], Christoph Hellwig writes: Nice, I always hated these double-indented switch statements. + case FIBMAP: + { + struct address_space *mapping = filp-f_mapping; + int res; + /* do we support this mess? */ + if

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

Huge, I took your advise regarding ~(__GFP_FS|__GFP_IO), AOP_WRITEPAGE_ACTIVATE, and such. I revised my unionfs_writepage and unionfs_sync_page, and tested it under memory pressure: I have a couple of live CDs that use tmpfs and can deterministically reproduce the conditions resulting in A_W_A.

[PATCH] 0/4 fs/ioctl.c coding style, rename vfs_ioctl/do_ioctl, refactoring (take 2)

that the first 3 patches be merged in -mm and even mainline, pending review. Erez Zadok (4): VFS: apply coding standards to fs/ioctl.c VFS: swap do_ioctl and vfs_ioctl names VFS: factor out three helpers for FIBMAP/FIONBIO/FIOASYNC file ioctls Unionfs: use vfs_ioctl fs

[PATCH 4/4] Unionfs: use vfs_ioctl

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 32 ++-- 1 files changed, 6 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index 50e5775..c99b519 100644 --- a/fs/unionfs/commonfops.c +++ b/fs

[PATCH 1/4] VFS: apply coding standards to fs/ioctl.c

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/ioctl.c | 164 +++- 1 files changed, 84 insertions(+), 80 deletions(-) diff --git a/fs/ioctl.c b/fs/ioctl.c index c2a773e..652cacf 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -12,8 +12,8

[PATCH 2/4] VFS: swap do_ioctl and vfs_ioctl names

because the names vfs_XXX should preferably be reserved to callable VFS functions which modules may call, as many other vfs_XXX functions already do. Export the new vfs_ioctl to GPL modules so others can use it (including Unionfs and eCryptfs). Add DocBook for new vfs_ioctl. Signed-off-by: Erez

<    1   2   3   >