On 4/12/07, David Howells [EMAIL PROTECTED] wrote:
Nate Diller [EMAIL PROTECTED] wrote:
-static struct page *afs_dir_get_page(struct inode *dir, unsigned long index)
NAK. This conflicts with my AFS security patches, and eliminates any way of
passing the key through to readpage().
Hmmm
On 4/12/07, Phillip Lougher [EMAIL PROTECTED] wrote:
Nate Diller wrote:
+ page = read_cache_page(OFNI_EDONI_2SFFJ(f)-i_mapping,
+ start PAGE_CACHE_SHIFT,
+ (void *)jffs2_do_readpage_unlock
On 4/12/07, Roman Zippel [EMAIL PROTECTED] wrote:
Hi,
On Thu, 12 Apr 2007, Christoph Hellwig wrote:
On Wed, Apr 11, 2007 at 07:49:38PM -0700, Nate Diller wrote:
read_mapping_page_async() is going away, so convert its only user to
read_mapping_page(). This change has not been benchmarked
On 4/12/07, David Howells [EMAIL PROTECTED] wrote:
Nate Diller [EMAIL PROTECTED] wrote:
Hmmm you're right. Is your security work going into the next -mm?
I don't know. Andrew hasn't said anything. Andrew? Are you waiting for it
to go through DaveM's networking tree?
If so, I'll just re
On 4/10/07, Andrew Morton [EMAIL PROTECTED] wrote:
On Tue, 10 Apr 2007 20:36:00 -0700 Nate Diller [EMAIL PROTECTED] wrote:
It's very common for file systems to need to zero part or all of a page, the
simplist way is just to use kmap_atomic() and memset(). There's actually a
library function
checker functions that
return an error if the page is corrupted or has some other error. This
simplifies the logic since the checker function is not part of any helper
function anymore.
Compile tested on x86_64.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
drivers/mtd/devices/block2mtd.c
-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/cramfs/inode.c
linux-2.6.21-rc6-mm1-test/fs/cramfs/inode.c
--- linux-2.6.21-rc6-mm1/fs/cramfs/inode.c 2007-04-09 17:24:03.0
-0700
+++ linux-2.6.21-rc6-mm1-test/fs/cramfs/inode.c 2007-04-09 21:37
as
needing to keep the page locked. These changes collectively eliminate a
substantial amount of private fs logic in favor of generic code.
It also simplifies filemap.c significantly, by assuming that callers want
synchronous behavior, which is true for all callers anyway except one.
Signed-off-by: Nate
Replace ext2_get_page() and ext2_put_page() using the new read_kmap_page()
and put_kmapped_page() calls. Also, change the ext2_check_page() call to
return the page's error status, and update the call sites accordingly.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff
Use the new locking variant of read_mapping_page to avoid doing extra work.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/jfs/jfs_metapage.c
linux-2.6.21-rc6-mm1-test/fs/jfs/jfs_metapage.c
--- linux-2.6.21-rc6-mm1/fs/jfs/jfs_metapage.c 2007-04
Replace jffs2_gc_fetch_page() and jffs2_gc_release_page() using the
read_cache_page() and put_kmapped_page() calls, and update the call site
accordingly. Explicit calls to kmap()/kunmap() make the code more clear.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux
Replace minix dir_get_page() and dir_put_page() using the new
read_kmap_page() and put_kmapped_page()/put_locked_page() calls. Also, use
__read_kmap_page() instead of re-taking the page_lock.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc5-mm4/fs/minix
Replace page_read() with read_kmap_page()/__read_kmap_page(). This probably
fixes behaviour on highmem systems, since page_address() was being used
without kmap(). Also eliminate the need to re-take the page lock during
writes to the page.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff
read_mapping_page() is now fully synchronous, so there's no need wait for
the page lock or check for I/O errors.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff
linux-2.6.21-rc6-mm1/fs/reiser4/plugin/file/tail_conversion.c
linux-2.6.21-rc6-mm1-test/fs/reiser4/plugin
Replace sysv dir_get_page() with the new read_kmap_page().
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc5-mm4/fs/sysv/dir.c
linux-2.6.21-rc5-mm4-test/fs/sysv/dir.c
--- linux-2.6.21-rc5-mm4/fs/sysv/dir.c 2007-04-05 17:14:25.0 -0700
+++ linux
-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc5-mm4/fs/ufs/balloc.c
linux-2.6.21-rc5-mm4-test/fs/ufs/balloc.c
--- linux-2.6.21-rc5-mm4/fs/ufs/balloc.c2007-04-05 17:13:29.0
-0700
+++ linux-2.6.21-rc5-mm4-test/fs/ufs/balloc.c 2007-04-06 12:46
Replace ntfs_map_page() and ntfs_unmap_page() using the new read_kmap_page()
and put_kmapped_page() calls, and their locking variants, and remove
unneeded PageError checking.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc5-mm4/fs/ntfs/aops.h
linux
Now that read_mapping_page() does error checking internally, there is no
need to check PageError here.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/hfs/bnode.c
linux-2.6.21-rc6-mm1-test/fs/hfs/bnode.c
--- linux-2.6.21-rc6-mm1/fs/hfs/bnode.c
On 4/10/07, Anton Altaparmakov [EMAIL PROTECTED] wrote:
On 10 Apr 2007, at 07:10, Andrew Morton wrote:
On Mon, 09 Apr 2007 21:31:37 -0700 Nate Diller
[EMAIL PROTECTED] wrote:
It's very common for file systems to need to zero part or all of a
page, the
simplist way is just to use kmap_atomic
ones and the old
memclear_highpage_flush() ones. Following this patch is a series of
conversions for each file system individually, per AKPM, and finally a patch
deprecating the old call. The diffstat below shows the entire patchset.
Compile tested in x86_64.
signed-off-by: Nate Diller [EMAIL
Use zero_user_page() instead of open-coding it.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/affs/file.c
linux-2.6.21-rc6-mm1-test/fs/affs/file.c
--- linux-2.6.21-rc6-mm1/fs/affs/file.c 2007-04-09 17:23:48.0 -0700
+++ linux-2.6.21-rc6
Use zero_user_page() instead of open-coding it.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/ecryptfs/mmap.c
linux-2.6.21-rc6-mm1-test/fs/ecryptfs/mmap.c
--- linux-2.6.21-rc6-mm1/fs/ecryptfs/mmap.c 2007-04-09 17:24:03.0
-0700
Use zero_user_page() instead of open-coding it.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/ext4/inode.c
linux-2.6.21-rc6-mm1-test/fs/ext4/inode.c
--- linux-2.6.21-rc6-mm1/fs/ext4/inode.c2007-04-10 17:15:04.0
-0700
Use zero_user_page() instead of open-coding it.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/gfs2/bmap.c
linux-2.6.21-rc6-mm1-test/fs/gfs2/bmap.c
--- linux-2.6.21-rc6-mm1/fs/gfs2/bmap.c 2007-04-09 17:23:48.0 -0700
+++ linux-2.6.21
Use zero_user_page() instead of the newly deprecated memclear_highpage_flush().
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/nfs/read.c
linux-2.6.21-rc6-mm1-test/fs/nfs/read.c
--- linux-2.6.21-rc6-mm1/fs/nfs/read.c 2007-04-09 17:23
Use zero_user_page() instead of open-coding it.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/reiserfs/file.c
linux-2.6.21-rc6-mm1-test/fs/reiserfs/file.c
--- linux-2.6.21-rc6-mm1/fs/reiserfs/file.c 2007-04-09 17:24:03.0
-0700
Use zero_user_page() instead of open-coding it. Also replace the (mostly)
redundant zero_page() function.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff
linux-2.6.21-rc6-mm1/fs/reiser4/plugin/file/cryptcompress.c
linux-2.6.21-rc6-mm1-test/fs/reiser4/plugin/file
Now that all the in-tree users are converted over to zero_user_page(),
deprecate the old memclear_highpage_flush() call.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/include/linux/highmem.h
linux-2.6.21-rc6-mm1-test/include/linux/highmem.h
Use zero_user_page() instead of the newly deprecated memclear_highpage_flush().
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/xfs/linux-2.6/xfs_lrw.c
linux-2.6.21-rc6-mm1-test/fs/xfs/linux-2.6/xfs_lrw.c
--- linux-2.6.21-rc6-mm1/fs/xfs/linux
Use zero_user_page() instead of open-coding it.
Signed-off-by: Nate Diller [EMAIL PROTECTED]
---
diff -urpN -X dontdiff linux-2.6.21-rc6-mm1/fs/ntfs/aops.c
linux-2.6.21-rc6-mm1-test/fs/ntfs/aops.c
--- linux-2.6.21-rc6-mm1/fs/ntfs/aops.c 2007-04-09 10:41:47.0 -0700
+++ linux-2.6.21
On 08 Apr 2007 06:32:26 +0200, Christer Weinigel [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] writes:
Lennart. Tell me again that these results from
http://linuxhelp.150m.com/resources/fs-benchmarks.htm and
http://m.domaindlx.com/LinuxHelp/resources/fs-benchmarks.htm
are not of interest to
of *how*
it does the work rather than what the *purpose* is. So this patch renames
the function to zero_page_data(), and calls it from the various places that
currently open code it.
Compile tested in x86_64.
signed-off-by: Nate Diller [EMAIL PROTECTED]
---
drivers/block/loop.c
on x86_64.
signed-off-by: Nate Diller [EMAIL PROTECTED]
---
cifs/file.c |9 +
ext4/writeback.c | 17 +
reiser4/plugin/item/extent_file_ops.c | 13 +++--
3 files changed, 5 insertions(+), 34 deletions(-)
---
diff
On 2/8/07, Nick Piggin [EMAIL PROTECTED] wrote:
On Thu, Feb 08, 2007 at 07:49:53PM +, Christoph Hellwig wrote:
On Thu, Feb 08, 2007 at 02:07:24PM +0100, Nick Piggin wrote:
Add an iterator data structure to operate over an iovec. Add usercopy
operators needed by
On 1/15/07, David Brownell [EMAIL PROTECTED] wrote:
On Monday 15 January 2007 5:54 pm, Nate Diller wrote:
--- a/drivers/usb/gadget/inode.c 2007-01-12 14:42:29.0 -0800
+++ b/drivers/usb/gadget/inode.c 2007-01-12 14:25:34.0 -0800
@@ -559,35 +559,32 @@ static int
Convert the internals of blkdev_direct_IO to use a generic endio function,
instead of directly calling aio_complete. This may also fix some bugs/races
in this code, for instance it checks bio-bi_size instead of assuming it's
zero, and it atomically accumulates the bytes_done counter (assuming
This converts the iternals of nfs's directIO support to use a generic endio
function, instead of directly calling aio_complete. It's pretty easy
because it already has a pretty abstracted completion path.
---
diff -urpN -X dontdiff a/fs/nfs/direct.c b/fs/nfs/direct.c
--- a/fs/nfs/direct.c
Convert code using iocb-ki_left to use the more generic iov_length() call.
---
diff -urpN -X dontdiff a/fs/ocfs2/file.c b/fs/ocfs2/file.c
--- a/fs/ocfs2/file.c 2007-01-10 11:50:26.0 -0800
+++ b/fs/ocfs2/file.c 2007-01-10 12:42:09.0 -0800
@@ -1157,7 +1157,7 @@ static ssize_t
This converts the internals of __blockdev_direct_IO in fs/direct-io.c to use
a generic endio function, instead of directly calling aio_complete. It also
changes the semantics of dio_iodone to be more friendly to its only users,
xfs and ocfs2. This allows the caller to know how to release locks
This converts the _locking variant of blockdev_direct_IO to use a generic
endio function, and updates all the FS callsites.
---
Documentation/filesystems/Locking |5 +++--
Documentation/filesystems/vfs.txt |5 +++--
fs/block_dev.c|9 -
fs/ext2/inode.c
Remove unused arg from socket operations
The sendmsg and recvmsg socket operations take a kiocb pointer, but none of
the functions actually use it. There's really no need even theoretically,
it's really quite ugly having it there at all. Also, removing it will pave
the way for a more generic
On 1/15/07, Christoph Hellwig [EMAIL PROTECTED] wrote:
On Mon, Jan 15, 2007 at 05:54:50PM -0800, Nate Diller wrote:
This series is an attempt to generalize the async I/O paths to be
implementation agnostic. It completely eliminates knowledge of
the kiocb structure in the generic code
On 1/15/07, Christoph Hellwig [EMAIL PROTECTED] wrote:
On Mon, Jan 15, 2007 at 05:54:50PM -0800, Nate Diller wrote:
Convert code using iocb-ki_left to use the more generic iov_length() call.
No way. We need to reduce the numer of iovec traversals, not adding
more of them.
ok, I can work
On 11/30/06, Wendy Cheng [EMAIL PROTECTED] wrote:
How about a simple and plain change with this uploaded patch
The idea is, instead of unconditionally dropping every buffer associated
with the particular mount point (that defeats the purpose of page
caching), base kernel exports the
44 matches
Mail list logo