Re: [PATCH] fix quadratic behavior of shrink_dcache_parent()

2007-02-11 Thread Miklos Szeredi
> > Unfortunately this patch doesn't completely solve this problem, since > > the system will still be hosed due to all memory being used up by > > dentries. And I bet the OOM killer won't find the real target (du) > > but will kill anything before that. > > > > So the second part of the problem i

Re: [PATCH] fix quadratic behavior of shrink_dcache_parent()

2007-02-10 Thread Russ Cox
Unfortunately this patch doesn't completely solve this problem, since the system will still be hosed due to all memory being used up by dentries. And I bet the OOM killer won't find the real target (du) but will kill anything before that. So the second part of the problem is to somehow limit the

Re: [PATCH] fix quadratic behavior of shrink_dcache_parent()

2007-02-10 Thread Andi Kleen
Miklos Szeredi <[EMAIL PROTECTED]> writes: > So the second part of the problem is to somehow limit the number of > dentries used. Not easy... OpenVZ has some existing work in this area to separate their virtual machines. I assume they will eventually submit it. -Andi - To unsubscribe from thi

Re: [PATCH] fix quadratic behavior of shrink_dcache_parent()

2007-02-10 Thread Miklos Szeredi
> > "The file system mounted on /tmp/z in the example contains 2^50 > > directories". heh. > > > > I do wonder how realistic this problem is in real life. > > That's a fair concern, although I was trying this as part > of evaluating how much someone could hose a system > if we let them mount arb

Re: [PATCH] fix quadratic behavior of shrink_dcache_parent()

2007-02-09 Thread Andrew Morton
On Fri, 9 Feb 2007 19:23:31 -0500 "Russ Cox" <[EMAIL PROTECTED]> wrote: > > "The file system mounted on /tmp/z in the example contains 2^50 > > directories". heh. > > > > I do wonder how realistic this problem is in real life. > > That's a fair concern, although I was trying this as part > of e

Re: [PATCH] fix quadratic behavior of shrink_dcache_parent()

2007-02-09 Thread Russ Cox
"The file system mounted on /tmp/z in the example contains 2^50 directories". heh. I do wonder how realistic this problem is in real life. That's a fair concern, although I was trying this as part of evaluating how much someone could hose a system if we let them mount arbitrary FUSE servers.

Re: [PATCH] fix quadratic behavior of shrink_dcache_parent()

2007-02-09 Thread Andrew Morton
On Fri, 09 Feb 2007 23:01:06 +0100 Miklos Szeredi <[EMAIL PROTECTED]> wrote: > From: Miklos Szeredi <[EMAIL PROTECTED]> > > The time shrink_dcache_parent() takes, grows quadratically with the > depth of the tree under 'parent'. This starts to get noticable at > about 10,000. > > These kinds of

[PATCH] fix quadratic behavior of shrink_dcache_parent()

2007-02-09 Thread Miklos Szeredi
From: Miklos Szeredi <[EMAIL PROTECTED]> The time shrink_dcache_parent() takes, grows quadratically with the depth of the tree under 'parent'. This starts to get noticable at about 10,000. These kinds of depths don't occur normally, and filesystems which invoke shrink_dcache_parent() via d_inval