[patch 2/9] mm: revert generic_file_buffered_write(): handle zero length iovec segments

2007-02-04 Thread Nick Piggin
From: Andrew Morton [EMAIL PROTECTED] Revert 81b0c8713385ce1b1b9058e916edcf9561ad76d6. This was a bugfix against 6527c2bdf1f833cc18e8f42bd97973d583e4aa83, which we also revert. Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index:

[patch 5/9] mm: debug write deadlocks

2007-02-04 Thread Nick Piggin
Allow CONFIG_DEBUG_VM to switch off the prefaulting logic, to simulate the difficult race where the page may be unmapped before calling copy_from_user. Makes the race much easier to hit. This is useful for demonstration and testing purposes, but is removed in a subsequent patch. Signed-off-by:

[patch 6/9] mm: be sure to trim blocks

2007-02-04 Thread Nick Piggin
If prepare_write fails with AOP_TRUNCATED_PAGE, or if commit_write fails, then we may have failed the write operation despite prepare_write having instantiated blocks past i_size. Fix this, and consolidate the trimming into one place. Signed-off-by: Nick Piggin [EMAIL PROTECTED] Index:

Re: [patch 9/9] mm: fix pagecache write deadlocks

2007-02-04 Thread Nick Piggin
On Sun, Feb 04, 2007 at 01:44:45AM -0800, Andrew Morton wrote: On Sun, 4 Feb 2007 09:51:07 +0100 (CET) Nick Piggin [EMAIL PROTECTED] wrote: 2. If we find the destination page is non uptodate, unlock it (this could be made slightly more optimal), then find and pin the source page

Re: [patch 9/9] mm: fix pagecache write deadlocks

2007-02-04 Thread Christoph Hellwig
On Sun, Feb 04, 2007 at 11:15:29AM +0100, Nick Piggin wrote: Cool, a kernel thread is calling sys_write. Fun. There are tons of places where we possible call into -write from either kernel threads or at least with a kernel pointer and set_fs/set_ds magic. Anything in the buffer write path that

Re: [patch 9/9] mm: fix pagecache write deadlocks

2007-02-04 Thread Nick Piggin
On Sun, Feb 04, 2007 at 11:46:09AM +0100, Nick Piggin wrote: It's better than taking mmap_sem and walking pagetables... I'm not convinced. Though I am more convinced that looking at mm *at all* (either to take the mmap_sem and find the vma, or to take the mmap_sem and run get_user_pages)

Re: [patch 9/9] mm: fix pagecache write deadlocks

2007-02-04 Thread Andrew Morton
On Sun, 4 Feb 2007 11:46:09 +0100 Nick Piggin [EMAIL PROTECTED] wrote: On Sun, Feb 04, 2007 at 02:30:55AM -0800, Andrew Morton wrote: On Sun, 4 Feb 2007 11:15:29 +0100 Nick Piggin [EMAIL PROTECTED] wrote: The write path is broken. I prefer my kernels slow, than buggy. That won't

Re: [patch 9/9] mm: fix pagecache write deadlocks

2007-02-04 Thread Andrew Morton
On Sun, 4 Feb 2007 10:59:58 + (GMT) Anton Altaparmakov [EMAIL PROTECTED] wrote: On Sun, 4 Feb 2007, Andrew Morton wrote: On Sun, 4 Feb 2007 09:51:07 +0100 (CET) Nick Piggin [EMAIL PROTECTED] wrote: 2. If we find the destination page is non uptodate, unlock it (this could be

Re: [RFC] Pack the vfsmount and dentry in nameidata into a struct path

2007-02-04 Thread Andreas Gruenbacher
On Saturday 03 February 2007 20:16, Jörn Engel wrote: On its own, I don't like this patch too much. It is just a form of mental masturbation that complicates the source. Thanks for pointing out the masturbation thing. I was actually polling for comments; this single patch in itself wasn't

Re: [patch 9/9] mm: fix pagecache write deadlocks

2007-02-04 Thread Nick Piggin
On Sun, Feb 04, 2007 at 03:15:49AM -0800, Andrew Morton wrote: On Sun, 4 Feb 2007 12:03:17 +0100 Nick Piggin [EMAIL PROTECTED] wrote: On Sun, Feb 04, 2007 at 02:56:02AM -0800, Andrew Morton wrote: On Sun, 4 Feb 2007 11:46:09 +0100 Nick Piggin [EMAIL PROTECTED] wrote: If that

Re: [patch 9/9] mm: fix pagecache write deadlocks

2007-02-04 Thread Anton Altaparmakov
On Sun, 4 Feb 2007, Andrew Morton wrote: On Sun, 4 Feb 2007 10:59:58 + (GMT) Anton Altaparmakov [EMAIL PROTECTED] wrote: On Sun, 4 Feb 2007, Andrew Morton wrote: On Sun, 4 Feb 2007 09:51:07 +0100 (CET) Nick Piggin [EMAIL PROTECTED] wrote: 2. If we find the destination page is

Re: [RFC] Pack the vfsmount and dentry in nameidata into a struct path

2007-02-04 Thread Jörn Engel
On Sun, 4 February 2007 04:00:51 -0800, Andreas Gruenbacher wrote: On Saturday 03 February 2007 20:16, Jörn Engel wrote: On its own, I don't like this patch too much. It is just a form of mental masturbation that complicates the source. Thanks for pointing out the masturbation thing. I

Re: [PATCH] Fix d_path for lazy unmounts

2007-02-04 Thread Neil Brown
On Friday February 2, [EMAIL PROTECTED] wrote: Hello, here is a bugfix to d_path. Please apply (after 2.6.20). Looks good! Just a couple of little comments (to prove that I have really read it and thought about it :-) Signed-off-by: Andreas Gruenbacher [EMAIL PROTECTED] Reviewed-by: