Theodore Tso wrote:
> On Wed, Jan 09, 2008 at 02:52:14PM +0300, Al Boldi wrote:
> > Ok, but let's look at this a bit more opportunistic / optimistic.
> >
> > Even after a black-out shutdown, the corruption is pretty minimal, using
> > ext3fs at least.
>
> After a unclean shutdown, assuming you have
On Sat 2008-01-12 09:51:40, Theodore Tso wrote:
> On Wed, Jan 09, 2008 at 02:52:14PM +0300, Al Boldi wrote:
> >
> > Ok, but let's look at this a bit more opportunistic / optimistic.
> >
> > Even after a black-out shutdown, the corruption is pretty minimal, using
> > ext3fs at least.
> >
>
> Aft
> What are ext3 expectations of disk (is there doc somewhere)? For
> example... if disk does not lie, but powerfail during write damages
> the sector -- is ext3 still going to work properly?
Nope. However the few disks that did this rapidly got firmware updates
because there are other OS's that ca
Unfortunately I couldn't find an mbox archive of the cifs client list
anywhere, so I'll send you the review in reply to this mail, with
one reply per patch.
This is for the first patch:
+ * fs/cifs/cifs_dfs_ref.c
Please don't mention file names in top of file comments, they serve no
use and g
+struct dfs_info3_param {
+ int flags; /* DFSREF_REFERRAL_SERVER, DFSREF_STORAGE_SERVER*/
+ int PathConsumed;
+ int server_type;
+ int ref_flag;
+ char *path_name;
+ char *node_name;
+};
Please avoid mixed case struct member names.
+
+static inline void init_df
+#ifdef CONFIG_CIFS_DFS_UPCALL
+ /* copy mount params to sb for use in submounts */
+ /* BB: should we move this after the mount so we
+* do not have to do the copy on failed mounts?
+* BB: May be it is better to do simple copy before
+* complex operation (mount)
[David, any chance you could look at the suggestion below to refactor
the automount from ->follow_link code into a common helper now that
we've grown a second copy from it]
+ if (cifs_sb->tcon->Flags & 0x2) {
Please don't use magic numbers but symbolic defines.
+static void*
static vo
+#ifdef CONFIG_CIFS_DFS_UPCALL
+ if (is_remote) {
+ inode->i_op =
+ &cifs_dfs_referral_inode_operations;
+ inode->i_fop = NULL;
i_fop should never be set to NULL. Just leave it
On Jan 13, 2008 1:40 PM, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> Unfortunately I couldn't find an mbox archive of the cifs client list
> anywhere, so I'll send you the review in reply to this mail, with
> one reply per patch.
>
> + * This library is free software; you can redistribute it
I agree that CIFSGetDFSRefer needs to be reworked to be easier to
read. This was one of the reasons that I wanted to look at this
particular patch more.
On Jan 13, 2008 1:48 PM, Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -3879,8 +3879,8 @
Hi Ted,
On Saturday 12 January 2008 06:51, Theodore Tso wrote:
> What is very hard to check is whether or not the link count on the
> inode is correct. Suppose the link count is 1, but there are
> actually two directory entries pointing at it. Now when someone
> unlinks the file through one of t
Hi,
On Thu, 10 Jan 2008, Christoph Hellwig wrote:
> Is there any chance you could either send me a affs image to run fsx
> on it or do it yourself?
If you want you can use http://www.xs4all.nl/~zippel/affstools-0.1a.tar.gz
to create one.
bye, Roman
-
To unsubscribe from this list: send the lin
Hi all,
This release is long overdue and is very much needed to consolidate
the many patches we now have against 5.0.2.
See below for more information.
Known issues
- Restarting autofs when there are busy mount (with configure option
--enable-ignore-busy enabled) doesn't work pro
13 matches
Mail list logo
