possible deadlock shown by CONFIG_PROVE_LOCKING

I compiled the kernel with Ingo's CONFIG_PROVE_LOCKING and got the below at boot. Is it a problem? Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar ... MAX_LOCKDEP_SUBCLASSES:8 ... MAX_LOCK_DEPTH: 30 ... MAX_LOCKDEP_KEYS:2048 ... CLASSHASH_SIZE:

Re: [RFC] Parallelize IO for e2fsck

Alan Cox [EMAIL PROTECTED] wrote: I'd tried to advocate SIGDANGER some years ago as well, but none of the kernel maintainers were interested. It definitely makes sense to have some sort of mechanism like this. At the time I first brought it up it was in conjunction with Netscape using too

[patch 00/26] mount options: fix filesystem's -show_options

Andrew, Would you please consider these patches for -mm? They should be relatively uncontroversial and straightforward fixes. They touch a lot of filesystems though, so not sure about the logistics... For the description, see first patch's header. Thanks, Miklos -- - To unsubscribe from this

[patch 03/26] mount options: fix adfs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to adfs. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/adfs/super.c === --- linux.orig/fs/adfs/super.c 2008-01-24 13:48:43.0

[patch 04/26] mount options: fix affs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to affs. Use generic_show_options() and save the complete option string in affs_fill_super() and affs_remount(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/affs/super.c

[patch 05/26] mount options: fix afs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to afs. Use generic_show_options() and save the complete option string in afs_get_sb(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/afs/super.c

[patch 06/26] mount options: fix autofs4

From: Miklos Szeredi [EMAIL PROTECTED] Add uid= and gid= options to /proc/mounts for autofs4 filesystems. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/autofs4/inode.c === --- linux.orig/fs/autofs4/inode.c

[patch 02/26] mount options: add generic_show_options()

From: Miklos Szeredi [EMAIL PROTECTED] Add a new s_options field to struct super_block. Filesystems can save mount options passed to them in mount or remount. It is automatically freed when the superblock is destroyed. A new helper function, generic_show_options() is introduced, which uses

[patch 09/26] mount options: fix capifs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to capifs. Use generic_show_options() and save the complete option string in capifs_remount(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/drivers/isdn/capi/capifs.c

[patch 08/26] mount options: fix befs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to befs. Use generic_show_options() and save the complete option string in befs_fill_super(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/befs/linuxvfs.c

[patch 10/26] mount options: fix devpts

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to devpts. Also add minor fix: when parsing the mode option, mask with S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the mask. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index:

[patch 11/26] mount options: fix ext2

From: Miklos Szeredi [EMAIL PROTECTED] Add noreservation option to /proc/mounts for ext2 filesystems. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/ext2/super.c === --- linux.orig/fs/ext2/super.c 2008-01-17

[patch 12/26] mount options: fix ext4

From: Miklos Szeredi [EMAIL PROTECTED] Add stripe= option to /proc/mounts for ext4 filesystems. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/ext4/super.c === --- linux.orig/fs/ext4/super.c 2008-01-23

[patch 01/26] mount options: add documentation

From: Miklos Szeredi [EMAIL PROTECTED] This series addresses the problem of showing mount options in /proc/mounts. Several filesystems which use mount options, have not implemented a .show_options superblock operation. Several others have implemented this callback, but have not kept it fully up

[patch 14/26] mount options: fix fuse

From: Miklos Szeredi [EMAIL PROTECTED] Add blksize= option to /proc/mounts for fuseblk filesystems. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/fuse/inode.c === --- linux.orig/fs/fuse/inode.c 2008-01-19

[patch 15/26] mount options: fix hostfs

From: Miklos Szeredi [EMAIL PROTECTED] Add the host path option to /proc/mounts for UML hostfs filesystems. The mount source (mnt_devname) should really be used for this, but not easy to change now in a backward compatible way. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index:

[patch 16/26] mount options: fix hpfs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to hpfs. Use generic_show_options() and save the complete option string in hpfs_fill_super() and hpfs_remount_fs(). Also add a small fix: hpfs_remount_fs() should return -EINVAL on error, instead of 1, which is not an

[patch 18/26] mount options: fix isofs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to isofs. Use generic_show_options() and save the complete option string in isofs_fill_super(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/isofs/inode.c

[patch 21/26] mount options: partially fix nfs

From: Miklos Szeredi [EMAIL PROTECTED] Add posix, bsize=, namelen= options to /proc/mounts for nfs filesystems. Document several other options that are still missing. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/nfs/super.c

[patch 23/26] mount options: fix spufs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to spufs. Use generic_show_options() and save the complete option string in spufs_fill_super(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/arch/powerpc/platforms/cell/spufs/inode.c

[patch 07/26] mount options: fix autofs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to autofs. Use generic_show_options() and save the complete option string in autofs_fill_super(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/autofs/inode.c

[patch 24/26] mount options: fix tmpfs

From: Miklos Szeredi [EMAIL PROTECTED] Add .show_options super operation to tmpfs. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/mm/shmem.c === --- linux.orig/mm/shmem.c 2008-01-21 21:20:04.0 +0100

[patch 25/26] mount options: fix udf

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to udf. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/udf/super.c === --- linux.orig/fs/udf/super.c 2008-01-24 13:48:37.0

[patch 26/26] mount options: fix usbfs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to usbfs. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/drivers/usb/core/inode.c === --- linux.orig/drivers/usb/core/inode.c 2008-01-24

[patch 22/26] mount options: fix reiserfs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to reiserfs. Use generic_show_options() and save the complete option string in reiserfs_fill_super() and reiserfs_remount(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/reiserfs/super.c

[patch 20/26] mount options: fix ncpfs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to ncpfs. Small fix: add FS_BINARY_MOUNTDATA to the filesystem type flags, since it can take binary data, as well as text (similarly to NFS). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index:

[patch 19/26] mount options: fix jfs

From: Miklos Szeredi [EMAIL PROTECTED] Add iocharset= and errors= options to /proc/mounts for jfs filesystems. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/jfs/super.c === --- linux.orig/fs/jfs/super.c

[patch 17/26] mount options: fix hugetlbfs

From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to hugetlbfs. Use generic_show_options() and save the complete option string in hugetlbfs_fill_super(). Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] --- Index: linux/fs/hugetlbfs/inode.c

Re: [patch 10/26] mount options: fix devpts

Miklos Szeredi wrote: Also add minor fix: when parsing the mode option, mask with S_IALLUGO instead of ~S_IFMT, which could leave unsed bits in the mask. umode_t is 16 bits, so it doesn't. The change is still good, of course. + if (config.mode != DEVPTS_DEFAULT_MODE) +

Re: [patch 07/26] mount options: fix autofs

Miklos Szeredi wrote: [autofs patch] Acked-by: H. Peter Anvin [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 25/26] mount options: fix udf

[Miklos Szeredi - Thu, Jan 24, 2008 at 08:34:06PM +0100] | From: Miklos Szeredi [EMAIL PROTECTED] | | Add a .show_options super operation to udf. | | Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] | --- | | Index: linux/fs/udf/super.c |

Re: [patch 03/26] mount options: fix adfs

On Thu, Jan 24, 2008 at 08:33:44PM +0100, Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to adfs. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] Thanks. Acked-by: Russell King [EMAIL PROTECTED] -- Russell King Linux kernel2.6 ARM

Re: [patch 25/26] mount options: fix udf

[Miklos Szeredi - Thu, Jan 24, 2008 at 08:34:06PM +0100] | From: Miklos Szeredi [EMAIL PROTECTED] | | Add a .show_options super operation to udf. | | Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] | --- | | Index: linux/fs/udf/super.c |

[RFC] ext3: per-process soft-syncing data=ordered mode

Greetings! data=ordered mode has proven reliable over the years, and it does this by ordering filedata flushes before metadata flushes. But this sometimes causes contention in the order of a 10x slowdown for certain apps, either due to the misuse of fsync or due to inherent behaviour like

Re: [patch 21/26] mount options: partially fix nfs

Hi Miklos- Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Add posix, bsize=, namelen= options to /proc/mounts for nfs filesystems. Document several other options that are still missing. NFS lists only some options in /proc/mounts on purpose: only the essential options are

Re: [patch 21/26] mount options: partially fix nfs

On Thu, 2008-01-24 at 20:34 +0100, Miklos Szeredi wrote: plain text document attachment (nfs_opts.patch) From: Miklos Szeredi [EMAIL PROTECTED] Add posix, bsize=, namelen= options to /proc/mounts for nfs filesystems. Document several other options that are still missing. Signed-off-by:

Re: [PATCH 24/27] NFS: Use local caching [try #2]

On Wed, 2008-01-23 at 17:22 +, David Howells wrote: The attached patch makes it possible for the NFS filesystem to make use of the network filesystem local caching service (FS-Cache). To be able to use this, an updated mount program is required. This can be obtained from:

Re: [PATCH 25/27] NFS: Configuration and mount option changes to enable local caching on NFS [try #2]

On Wed, 2008-01-23 at 17:22 +, David Howells wrote: Changes to the kernel configuration defintions and to the NFS mount options to allow the local caching support added by the previous patch to be enabled. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/Kconfig|8

Re: [patch 19/26] mount options: fix jfs

On Thu, 2008-01-24 at 20:34 +0100, Miklos Szeredi wrote: plain text document attachment (jfs_opts.patch) From: Miklos Szeredi [EMAIL PROTECTED] Add iocharset= and errors= options to /proc/mounts for jfs filesystems. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] Acked-by: Dave Kleikamp

Re: [PATCH 23/27] NFS: Fix memory leak [try #2]

On Wed, 2008-01-23 at 17:22 +, David Howells wrote: Fix a memory leak whereby multiple clientaddr=xxx mount options just overwrite the duplicated client_address option pointer, without freeing the old memory. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/nfs/super.c |1 +

Re: [PATCH 24/27] NFS: Use local caching [try #2]

Some comments below. This patch really ought to be broken into more manageable atomic changes to make it easier to review, and to provide more fine-grained explanation and rationalization for each specific change via individual patch descriptions. David Howells wrote: The attached patch

Re: [RFC] ext3: per-process soft-syncing data=ordered mode

El Thu, 24 Jan 2008 23:36:00 +0300, Al Boldi [EMAIL PROTECTED] escribió: Greetings! data=ordered mode has proven reliable over the years, and it does this by ordering filedata flushes before metadata flushes. But this sometimes causes contention in the order of a 10x slowdown for certain

Re: [RFC] ext3: per-process soft-syncing data=ordered mode

On Thu, 24 Jan 2008 23:36:00 +0300, Al Boldi said: data=ordered mode has proven reliable over the years, and it does this by ordering filedata flushes before metadata flushes. But this sometimes causes contention in the order of a 10x slowdown for certain apps, either due to the misuse of

Re: [patch 19/26] mount options: fix jfs

On Thu, 24 Jan 2008 15:15:01 -0600 Dave Kleikamp [EMAIL PROTECTED] wrote: On Thu, 2008-01-24 at 20:34 +0100, Miklos Szeredi wrote: plain text document attachment (jfs_opts.patch) From: Miklos Szeredi [EMAIL PROTECTED] Add iocharset= and errors= options to /proc/mounts for jfs

Re: [RFC] Parallelize IO for e2fsck

On Jan 24, 2008 18:32 +0100, Bodo Eggert wrote: I think a single, system-wide signal is the second-to worst solution: All applications (or the wrong one, if you select one) would free their caches and start to crawl, and either stay in this state or slowly increase their caches again until

Re: [patch 26/26] mount options: fix usbfs

On Thu, Jan 24, 2008 at 08:34:07PM +0100, Miklos Szeredi wrote: From: Miklos Szeredi [EMAIL PROTECTED] Add a .show_options super operation to usbfs. Signed-off-by: Miklos Szeredi [EMAIL PROTECTED] Looks good to me. Do you want to take this through your tree, as it is dependant on other

Re: [patch 19/26] mount options: fix jfs

On Thu, 2008-01-24 at 13:57 -0800, Andrew Morton wrote: My usual algorithm here is to 1: queue all the patches and send the ones which have a maintainer to that maintainer until he merges it. 2: If the patches have a dependency upon (say) a VFS patch then I'll merge the VFS patch

Re: [RFC] Parallelize IO for e2fsck

On Thu, Jan 24, 2008 at 06:32:15PM +0100, Bodo Eggert wrote: Alan Cox [EMAIL PROTECTED] wrote: I'd tried to advocate SIGDANGER some years ago as well, but none of the kernel maintainers were interested. It definitely makes sense to have some sort of mechanism like this. At the time I

Re: [RFC] Parallelize IO for e2fsck

On Fri, Jan 25, 2008 at 01:08:09AM +0200, Adrian Bunk wrote: In practice, there is a small number of programs that are both the common memory hogs and should be able to reduce their memory consumption by 10% or 20% without big problems when requested (e.g. Java VMs, Firefox and databases come

Re: [patch 01/26] mount options: add documentation

In message [EMAIL PROTECTED], Miklos Szeredi writes: From: Miklos Szeredi [EMAIL PROTECTED] This series addresses the problem of showing mount options in /proc/mounts. Several filesystems which use mount options, have not implemented a .show_options superblock operation. Several others

Re: [RFC] Parallelize IO for e2fsck

On Thu, 2008-01-24 at 18:40 -0500, Theodore Tso wrote: On Fri, Jan 25, 2008 at 01:08:09AM +0200, Adrian Bunk wrote: In practice, there is a small number of programs that are both the common memory hogs and should be able to reduce their memory consumption by 10% or 20% without big problems

Re: [RFC] ext3: per-process soft-syncing data=ordered mode

Al Boldi wrote: Greetings! data=ordered mode has proven reliable over the years, and it does this by ordering filedata flushes before metadata flushes. But this sometimes causes contention in the order of a 10x slowdown for certain apps, either due to the misuse of fsync or due to inherent

Re: possible deadlock shown by CONFIG_PROVE_LOCKING

Carlos Carvalho wrote: I compiled the kernel with Ingo's CONFIG_PROVE_LOCKING and got the below at boot. Is it a problem? It was a problem - it has since been fixed in 2.6.23. Patch is attached in case you're interested. Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo

Re: [patch 06/26] mount options: fix autofs4

On Thu, 2008-01-24 at 20:33 +0100, Miklos Szeredi wrote: plain text document attachment (autofs4_opts.patch) From: Miklos Szeredi [EMAIL PROTECTED] Add uid= and gid= options to /proc/mounts for autofs4 filesystems. Apologies, I did say I would do this but have been quite busy.