Re: fs/ext2/inode.c:ext2_notify_change()

2000-11-23 Thread Stephen C. Tweedie
Hi, On Wed, Nov 22, 2000 at 07:34:55PM +0100, Andreas Gruenbacher wrote: ext2_notify_change() isn't referenced to from anywhere since a while. Should it be removed? I'm asking since my ACL patch needs a notify_change() function in ext2, and I'm not sure whether It's ok to replace

Re: fs/ext2/inode.c:ext2_notify_change()

2000-11-23 Thread Stephen C. Tweedie
Hi, On Thu, Nov 23, 2000 at 01:19:41PM +0100, Andreas Gruenbacher wrote: On Thu, 23 Nov 2000, Stephen C. Tweedie wrote: On Wed, Nov 22, 2000 at 07:34:55PM +0100, Andreas Gruenbacher wrote: ext2_notify_change() isn't referenced to from anywhere since a while. Should it be removed?

Re: fs/ext2/inode.c:ext2_notify_change()

2000-11-23 Thread Daniel Phillips
Andreas Gruenbacher wrote: Hmmm. I don't see any use of notify_change with any of ATTR_FLAG_APPEND, ATTR_FLAG_SYNCHRONOUS, ATTR_FLAG_NOATIME, ATTR_FLAG_IMMUTABLE set, so that part of notify_change is not invoked. Currently, these special inode flags are set through ioctl() directly. Is the

Re: fs/ext2/inode.c:ext2_notify_change()

2000-11-23 Thread Christoph Hellwig
On Thu, Nov 23, 2000 at 02:28:16PM +0100, Andreas Gruenbacher wrote: On Thu, 23 Nov 2000, Stephen C. Tweedie wrote: Not if we re-enable notify_change --- if we do that, the filesystem will rely on notify_change doing the right thing in such cases. Hmmm. I don't see any use of

Re: EBUSY on umount

2000-11-23 Thread David Gibson
On Thu, Nov 23, 2000 at 04:43:52PM +0100, Jan Kara wrote: On Tue, Nov 21, 2000 at 07:19:21PM -0800, Brian Pomerantz wrote: On Wed, Nov 22, 2000 at 02:17:37PM +1100, David Gibson wrote: In testing/fixing ramfs I've discovered a bug where umount() fails with -EBUSY for no readily

Re: [patch] O_SYNC patch 3/3, add inode dirty buffer list support to ext2

2000-11-23 Thread Jeff V. Merkey
On Thu, Nov 23, 2000 at 12:01:35PM +, Stephen C. Tweedie wrote: Hi, On Wed, Nov 22, 2000 at 11:54:24AM -0700, Jeff V. Merkey wrote: I have not implemented O_SYNC in NWFS, but it looks like I need to add it before posting the final patches. This patch appears to force

Re: [patch] O_SYNC patch 3/3, add inode dirty buffer list support to ext2

2000-11-23 Thread Stephen C. Tweedie
Hi, On Wed, Nov 22, 2000 at 11:54:24AM -0700, Jeff V. Merkey wrote: I have not implemented O_SYNC in NWFS, but it looks like I need to add it before posting the final patches. This patch appears to force write-through of only dirty inodes, and allow reads to continue from cache. Is this