Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread David Chinner
On Mon, Mar 19, 2007 at 05:37:03PM +1100, Nick Piggin wrote: David Chinner wrote: +/* + * block_page_mkwrite() is not allowed to change the file size as it gets + * called from a page fault handler when a page is first dirtied. Hence we must + * be careful to check for EOF conditions

Received a panic while closing the file.

2007-03-19 Thread Prasad Joshi
Hi All, I am writing a very simple file system for understanding purpose. After mounting the file system, I am able to create file and read write to the file. But, as soon as close the file, it is panicking. I did some analysis and found that My kernel has CONFIG_EPOLL enabled struct file {

Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread Christoph Hellwig
On Mon, Mar 19, 2007 at 10:30:08AM +1100, David Chinner wrote: Generic page_mkwrite functionality. Filesystems that make use of the VM -page_mkwrite() callout will generally use the same core code to implement it. There are several tricky truncate-related issues that we need to deal with

Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread Nick Piggin
David Chinner wrote: On Mon, Mar 19, 2007 at 05:37:03PM +1100, Nick Piggin wrote: David Chinner wrote: +block_page_mkwrite(struct vm_area_struct *vma, struct page *page, + get_block_t get_block) +{ + struct inode *inode = vma-vm_file-f_path.dentry-d_inode; +

Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread Nick Piggin
Nick Piggin wrote: David Chinner wrote: On Mon, Mar 19, 2007 at 05:37:03PM +1100, Nick Piggin wrote: David Chinner wrote: +block_page_mkwrite(struct vm_area_struct *vma, struct page *page, + get_block_t get_block) +{ +struct inode *inode = vma-vm_file-f_path.dentry-d_inode;

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-19 Thread Amit K. Arora
On Fri, Mar 16, 2007 at 04:21:03PM +0100, Heiko Carstens wrote: On Fri, Mar 16, 2007 at 08:01:01PM +0530, Amit K. Arora wrote: First of all, thanks for the overwhelming response! Based on the suggestions received, I have added a new parameter to the sys_fallocate() system call - an

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-19 Thread Amit K. Arora
On Sat, Mar 17, 2007 at 04:33:50PM +1100, Stephen Rothwell wrote: On Fri, 16 Mar 2007 20:01:01 +0530 Amit K. Arora [EMAIL PROTECTED] wrote: +asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len); --- linux-2.6.20.1.orig/include/asm-powerpc/systbl.h +++

Re: [RFC][PATCH] sys_fallocate() system call

2007-03-19 Thread Heiko Carstens
On Mon, Mar 19, 2007 at 02:54:04PM +0530, Amit K. Arora wrote: On Fri, Mar 16, 2007 at 04:21:03PM +0100, Heiko Carstens wrote: On Fri, Mar 16, 2007 at 08:01:01PM +0530, Amit K. Arora wrote: asmlinkage long sys_fallocate(int fd, int mode, loff_t offset, loff_t len) Currently we

[PATCH 1/2] fs: remove duplicated iovec checking code v8

2007-03-19 Thread Dmitriy Monakhov
Where are several places where the same code used for iovec checks. This patch just move this code to separate helper function, and replace duplicated code with it. IMHO it is better because these are checks that we want for all filesystems/drivers that use vectored I/O. Signed-off-by: Dmitriy

Re: [PATCH 1/2] fs: remove duplicated iovec checking code v8

2007-03-19 Thread Christoph Hellwig
On Mon, Mar 19, 2007 at 10:49:01AM +0300, Dmitriy Monakhov wrote: Where are several places where the same code used for iovec checks. This patch just move this code to separate helper function, and replace duplicated code with it. IMHO it is better because these are checks that we want for

Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread Christoph Hellwig
On Mon, Mar 19, 2007 at 09:11:31PM +1100, Nick Piggin wrote: I've got the patches in -mm now. I hope they will get merged when the the next window opens. I didn't submit the -page_mkwrite conversion yet, because I didn't have any callers to look at. It is is slightly less trivial than for

[PATCH] unionfs: sioq not __exit

2007-03-19 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] stop_sioq() is called from both __init and __exit functions, so it shouldn't be marked __exit. Reported on the kernelnewbies mailing list, but no patch offered there. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- fs/unionfs/sioq.c |2 +- 1 file

[PATCH] ROMFS: printk format warnings

2007-03-19 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Field width and precision must be of type int. fs/romfs/super.c:513: warning: field width should have type 'int', but argument 2 has type 'size_t' fs/romfs/super.c:513: warning: field precision should have type 'int', but argument 3 has type 'size_t'

[PATCH] reiserfs: proc support requires PROC_FS

2007-03-19 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] REISER_FS /proc option needs to depend on PROC_FS. fs/reiserfs/procfs.c: In function 'show_super': fs/reiserfs/procfs.c:134: error: 'reiserfs_proc_info_data_t' has no member named 'max_hash_collisions' fs/reiserfs/procfs.c:134: error:

Re: [PATCH] unionfs: sioq not __exit

2007-03-19 Thread Josef Sipek
On Mon, Mar 19, 2007 at 03:22:26PM -0700, Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] stop_sioq() is called from both __init and __exit functions, so it shouldn't be marked __exit. Reported on the kernelnewbies mailing list, but no patch offered there. Signed-off-by: Randy

Re: [PATCH 1 of 2] block_page_mkwrite() Implementation V2

2007-03-19 Thread Nick Piggin
Christoph Hellwig wrote: On Mon, Mar 19, 2007 at 09:11:31PM +1100, Nick Piggin wrote: I've got the patches in -mm now. I hope they will get merged when the the next window opens. I didn't submit the -page_mkwrite conversion yet, because I didn't have any callers to look at. It is is slightly

Re: Announce: new-aops-1 for 2.6.21-rc3

2007-03-19 Thread Nick Piggin
On Thu, Mar 15, 2007 at 04:47:13PM -0700, Mark Fasheh wrote: On Thu, Mar 15, 2007 at 05:17:04PM +0100, Nick Piggin wrote: (excludes the OCFS2 patch that Mark sent, in anticipation of an update) Attached is said patch. I needed to export __grab_cache_page (ext2/ext3 also need this if they're