Re: [PATCH 1/9] Unionfs: security convert lsm into a static interface fix

In message [EMAIL PROTECTED], Christoph Hellwig writes: On Mon, Oct 22, 2007 at 08:48:04PM -0400, Erez Zadok wrote: Why? Are you concerned that the security policy may change after a module is loaded? No, it's a matter of proper layering. We generally don't want modules like stackabke

[PATCH] 0/3 fs/ioctl.c coding style, rename vfs_ioctl/do_ioctl

and eCryptfs). Patch 3: demonstrates how Unionfs can use the new vfs_ioctl. I successfully tested unionfs with this new exported vfs_ioctl. (eCryptfs could do the same.) I'd like to propose that the first two patches be merged in -mm and even mainline, pending review. Erez Zadok (3): VFS

[PATCH 2/3] VFS: swap do_ioctl and vfs_ioctl names

because the names vfs_XXX should preferably be reserved to callable VFS functions which modules may call, as many other vfs_XXX functions already do. Export the new vfs_ioctl to modules so others can use it (including Unionfs and eCryptfs). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs

Re: [PATCH+comment] fix tmpfs BUG and AOP_WRITEPAGE_ACTIVATE

In message [EMAIL PROTECTED], Hugh Dickins writes: On Thu, 25 Oct 2007, Pekka Enberg wrote: With unionfs also fixed, we don't know of an absolute need for this patch (and so, on that basis, the !wbc-for_reclaim case could indeed be removed very soon); but as I see it, the unionfs case has

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

That's a nice historical review, Huge, of how got into these mess we're in now -- it all starts with good intentions. :-) On a related note, I would just love to get rid of calling the lower -writepage in unionfs b/c I can't even tell if I have a lower page to use all the time. I'd prefer to

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: On Mon, 15 Oct 2007, Pekka Enberg wrote: I wonder whether _not setting_ BDI_CAP_NO_WRITEBACK implies that -writepage() will never return AOP_WRITEPAGE_ACTIVATE for !wbc-for_reclaim case which would explain why we haven't hit this bug

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Hugh Dickins writes: Sorry for my delay, here are a few replies. In unionfs_writepage() I tried to emulate as best possible what the lower f/s will have returned to the VFS. Since tmpfs's -writepage can return AOP_WRITEPAGE_ACTIVATE and re-mark its page as

Re: [PATCH 1/9] Unionfs: security convert lsm into a static interface fix

In message [EMAIL PROTECTED], Christoph Hellwig writes: On Sun, Oct 21, 2007 at 07:51:14PM -0400, Erez Zadok wrote: From: Andrew Morton [EMAIL PROTECTED] ERROR: security_inode_permission [fs/unionfs/unionfs.ko] undefined! ERROR: security_file_ioctl [fs/unionfs/unionfs.ko] undefined

[PATCH 4/9] Unionfs: don't printk trivial message upon normal rename-copyup

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rename.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c index 91d41d4..1ab474f 100644 --- a/fs/unionfs/rename.c +++ b/fs/unionfs/rename.c @@ -40,10 +40,12

[PATCH 5/9] Unionfs: don't bother validating dentry if it has no lower branches

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 68692d7..894bf7c 100644 --- a/fs/unionfs/debug.c +++ b/fs/unionfs/debug.c @@ -132,6 +132,9 @@ void

[PATCH 6/9] Unionfs: convert a printk to pr_debug in release

This is mostly an informational message, not an error. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 6bab9d6..a3d7b6e 100644 --- a/fs/unionfs

[PATCH 2/9] Unionfs: slab api remove useless ctor parameter and reorder parameters

-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/super.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c index 515689d..7d28045 100644 --- a/fs/unionfs/super.c +++ b/fs/unionfs/super.c

[PATCH 9/9] Unionfs: remove obsolete #define and comment

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- include/linux/union_fs.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/union_fs.h b/include/linux/union_fs.h index 7f8dcc3..d29318f 100644 --- a/include/linux/union_fs.h +++ b/include/linux/union_fs.h

[PATCH 3/9] Unionfs: support lower filesystems without writeback capability

Implement unionfs_writepages. As per mm/filemap.c:__filemap_fdatawrite_range(), don't call our writepage if the lower mapping has BDI_CAP_NO_WRITEBACK capability set. Signed-off-by: Pekka J Enberg [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 23

[PATCH 7/9] Unionfs: remove for_writepages nfs workaround

This is no longer necessary since struct writeback_control no longer has a fs_private field which lower file systems (esp. nfs) use. Plus, unionfs now defines its own -writepages method. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 39

[PATCH 8/9] Unionfs: fix unionfs_setattr to handle ATTR_KILL_S*ID

' Sipek [EMAIL PROTECTED] Cc: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index

[PATCH 1/9] Unionfs: security convert lsm into a static interface fix

] Cc: James Morris [EMAIL PROTECTED] Cc: Stephen Smalley [EMAIL PROTECTED] Cc: Josef 'Jeff' Sipek [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- security/security.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Pekka Enberg writes: Hi, On 10/15/07, Erez Zadok [EMAIL PROTECTED] wrote: Pekka, with a small change to your patch (to handle time-based cache coherency), your patch worked well and passed all my tests. Thanks. So now I wonder if we still need the patch

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Pekka Enberg writes: Hi Hugh, On Sat, 13 Oct 2007, Pekka Enberg wrote: Doesn't msync(2) get to it via mm/page-writeback.c:write_cache_pages() without unionfs even? On 10/14/07, Hugh Dickins [EMAIL PROTECTED] wrote: I believe not. Please do double-check

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

In message [EMAIL PROTECTED], Pekka J Enberg writes: Hi Erez, On Sun, 14 Oct 2007, Erez Zadok wrote: In unionfs_writepage() I tried to emulate as best possible what the lower f/s will have returned to the VFS. Since tmpfs's -writepage can return AOP_WRITEPAGE_ACTIVATE and re-mark its

msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

According to vfs.txt, -writepage() may return AOP_WRITEPAGE_ACTIVATE back to the VFS/VM. Indeed some filesystems such as tmpfs can return AOP_WRITEPAGE_ACTIVATE; and stackable file systems (e.g., Unionfs) also return AOP_WRITEPAGE_ACTIVATE if the lower f/s returned it. Anyway, some Ubuntu users

[PATCH 18/19] Unionfs: coding style: miscellaneous fixes

No braces around single-statement if's. No externs in .c files. use linux/mman.h not asm/mman.h. Use (foo *) not (foo*). Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rdstate.c |3 +-- fs/unionfs/super.c |3 +-- fs/unionfs/union.h |3 ++- fs/unionfs/xattr.c |6

[PATCH 17/19] Unionfs: coding style: avoid multiple assignments on same line

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |3 ++- fs/unionfs/super.c |9 ++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index ac1a060..6440282 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c

[PATCH 14/19] Unionfs: use braces in both branches of conditionals

As per CodingStyle, if one branch of an if-then-else has braces because it has multiple statements, then the other branch should have braces too, even if the other branch has only one statement in it. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |6 -- fs

[PATCH 12/19] Unionfs: update/assign a KERN_* level to all printk statements

Also use pr_info() instead of printk(KERN_INFO ...) Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |4 ++-- fs/unionfs/copyup.c |2 +- fs/unionfs/dentry.c | 18 +- fs/unionfs/file.c |7 --- fs/unionfs/inode.c | 16

[PATCH 13/19] Unionfs: remove periods from the end of printk strings

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/lookup.c |2 +- fs/unionfs/main.c |2 +- fs/unionfs/rename.c |4 ++-- fs/unionfs/super.c | 10 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index

[PATCH 15/19] Unionfs: coding style: proper spacing

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c |2 +- fs/unionfs/debug.c | 22 +++--- fs/unionfs/dentry.c |8 fs/unionfs/fanout.h |2 +- fs/unionfs/super.c | 14 +++--- fs/unionfs/union.h | 38

[PATCH 10/19] Unionfs: convert all appropriate printk's to pr_debug calls

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 14 ++-- fs/unionfs/debug.c | 248 +++--- fs/unionfs/union.h |8 +- 3 files changed, 134 insertions(+), 136 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs

[PATCH 16/19] Unionfs: coding style: take assignments out of if conditions

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 12 fs/unionfs/copyup.c |9 ++--- fs/unionfs/dirfops.c|6 -- fs/unionfs/dirhelper.c |3 ++- fs/unionfs/file.c | 18 -- fs/unionfs/inode.c | 18

[PATCH 19/19] Unionfs: coding style: avoid lines longer than 80 chars

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 18 ++- fs/unionfs/debug.c | 80 +++--- fs/unionfs/dentry.c |3 +- fs/unionfs/dirfops.c|8 +++-- fs/unionfs/fanout.h |9 +++-- 5 files changed

[GIT PULL -mm] 00/19 Unionfs updates/cleanups/fixes

, and squashfs (where available). See http://unionfs.filesystems.org/ to download backported unionfs code. Please pull from the 'master' branch of git://git.kernel.org/pub/scm/linux/kernel/git/ezk/unionfs.git to receive the following: Erez Zadok (19): Unionfs: compile if debug is off

[PATCH 01/19] Unionfs: compile if debug is off

Signed-of-by: John Johansen [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/union.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h index 824bb67..7ce4771 100644 --- a/fs/unionfs/union.h +++ b/fs/unionfs

[PATCH 04/19] Unionfs: use consistent printk prefixes

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c |4 ++-- fs/unionfs/union.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 021e206..ba85a67 100644 --- a/fs/unionfs/inode.c +++ b/fs/unionfs/inode.c

[PATCH 03/19] Unionfs: minor comment cleanups

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/lookup.c |2 +- fs/unionfs/mmap.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index 94e4c8e..53668d6 100644 --- a/fs/unionfs/lookup.c +++ b/fs/unionfs/lookup.c

[PATCH 07/19] Unionfs: remove unnecessary if condition

The condition is always true there. Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirfops.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c index 200fb55..da0fcdb 100644 --- a/fs/unionfs/dirfops.c +++ b/fs

[PATCH 08/19] Unionfs: use page_offset() helper

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index cf9545e..8928e99 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c @@ -179,8 +179,7 @@ static int

[PATCH 09/19] Unionfs: use pr_debug() instead of custom dprintk()

Also turn on DEBUG if CONFIG_UNION_FS_DEBUG is on Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/Makefile |4 fs/unionfs/commonfops.c |4 ++-- fs/unionfs/dentry.c |6 +++--- fs/unionfs/lookup.c |2 +- fs/unionfs/union.h |6 +- 5 files

[PATCH 05/19] Unionfs: use UNIONFS_NAME macro

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |2 +- fs/unionfs/main.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index b103eb9..da82a47 100644 --- a/fs/unionfs/debug.c +++ b/fs/unionfs/debug.c

Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

In message [EMAIL PROTECTED], roel writes: Erez Zadok wrote: @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct unionfs_dir_state **namelist) BUG_ON(!S_ISDIR(dentry-d_inode-i_mode)); - if ((err = unionfs_partial_lookup(dentry))) + if (unlikely((err

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

In message [EMAIL PROTECTED], Kok, Auke writes: Erez Zadok wrote: Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 102 +- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/copyup.c b

Re: [PATCH 05/25] Unionfs: cast page-index loff_t before shifting

In message [EMAIL PROTECTED], Christoph Hellwig writes: On Tue, Sep 25, 2007 at 11:09:44PM -0400, Erez Zadok wrote: Fixes bugs in number promotion/demotion computation, as per http://lkml.org/lkml/2007/9/20/17 It's better to use te page_offset helper as that avoids any confusion on where

Re: [PATCH 03/25] Unionfs: display informational messages only if debug is on

In message [EMAIL PROTECTED], Jan Engelhardt writes: On Sep 25 2007 23:09, Erez Zadok wrote: --- a/fs/unionfs/commonfops.c +++ b/fs/unionfs/commonfops.c @@ -394,8 +394,8 @@ int unionfs_file_revalidate(struct file *file, bool willwrite) if (willwrite IS_WRITE_FLAG(file-f_flags

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

In message [EMAIL PROTECTED], Jan Engelhardt writes: On Sep 26 2007 11:43, Erez Zadok wrote: *That's* the information I was looking for, Kyle: what's the estimated probability I should be using as my guideline. I used 95% (20/1 ratio), and ;-) 19:1 = 95:5 = 95% = ratio=0.95 != 20.0

[GIT PULL -mm] 00/25 Unionfs updates/cleanups/fixes

/ezk/unionfs.git to receive the following: Erez Zadok (22): Unionfs: display informational messages only if debug is on Unionfs: cast page-index loff_t before shifting Unionfs: minor coding style updates Unionfs: add lower nameidata debugging support Unionfs: lower

[PATCH 05/25] Unionfs: cast page-index loff_t before shifting

Fixes bugs in number promotion/demotion computation, as per http://lkml.org/lkml/2007/9/20/17 Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/mmap.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/unionfs

[PATCH 24/25] Unionfs: add un/likely conditionals on xattr ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/xattr.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/xattr.c b/fs/unionfs/xattr.c index 7f77d7d..bd2de06 100644 --- a/fs/unionfs/xattr.c +++ b/fs/unionfs/xattr.c @@ -23,14 +23,14 @@ void

[PATCH 14/25] Unionfs: add un/likely conditionals on headers

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/fanout.h | 13 - fs/unionfs/union.h |4 ++-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h index 51aa0de..6405399 100644 --- a/fs/unionfs/fanout.h +++ b/fs

[PATCH 03/25] Unionfs: display informational messages only if debug is on

This is to avoid filling the console/logs with messages that are primarily of debugging use. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |4 ++-- fs/unionfs/dentry.c |6 +++--- fs/unionfs/union.h |4

[PATCH 21/25] Unionfs: add un/likely conditionals on readdir ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rdstate.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/rdstate.c b/fs/unionfs/rdstate.c index 0a18d5c..7ec7f95 100644 --- a/fs/unionfs/rdstate.c +++ b/fs/unionfs/rdstate.c @@ -45,7

[PATCH 19/25] Unionfs: add un/likely conditionals on mmap ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/mmap.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 37af979..1cea075 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c @@ -84,7

[PATCH 08/25] Unionfs: lower nameidata support for nfsv4

Pass nameidata structures as needed to the lower file system, support LOOKUP_ACCESS/OPEN intents. This makes unionfs work on top of nfsv4. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 11 +-- fs/unionfs/inode.c

[PATCH 07/25] Unionfs: add lower nameidata debugging support

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 20 fs/unionfs/dentry.c |4 +++- fs/unionfs/inode.c |8 +++- fs/unionfs/union.h |4 4 files changed, 34 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs

[PATCH 22/25] Unionfs: add un/likely conditionals on common subr

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/sioq.c |4 ++-- fs/unionfs/subr.c | 26 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/fs/unionfs/sioq.c b/fs/unionfs/sioq.c index 2a8c88e..35d9fc3 100644 --- a/fs/unionfs/sioq.c +++ b/fs

[PATCH 06/25] Unionfs: minor coding style updates

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c |6 -- fs/unionfs/dentry.c |2 +- fs/unionfs/inode.c | 14 -- fs/unionfs/main.c |4 ++-- fs/unionfs/union.h |2 +- 5 files changed, 16 insertions(+), 12 deletions(-) diff --git a/fs/unionfs

[PATCH 23/25] Unionfs: add un/likely conditionals on unlink ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/unlink.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c index 3924f7f..33d08d9 100644 --- a/fs/unionfs/unlink.c +++ b/fs/unionfs/unlink.c

[PATCH 15/25] Unionfs: add un/likely conditionals on fileops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/file.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c index d8eaaa5..06ca1fa 100644 --- a/fs/unionfs/file.c +++ b/fs/unionfs/file.c

[PATCH 17/25] Unionfs: add un/likely conditionals on lookup ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/lookup.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index 2109714..92b5e0a 100644 --- a/fs/unionfs/lookup.c +++ b/fs

[PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dirfops.c | 22 +++--- fs/unionfs/dirhelper.c | 30 +++--- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c index c923e58..fa2df88

[PATCH 12/25] Unionfs: add un/likely conditionals on dentry ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 68 ++ 1 files changed, 35 insertions(+), 33 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 52bcb18..3f3a18d 100644 --- a/fs/unionfs/dentry.c +++ b

[PATCH 20/25] Unionfs: add un/likely conditionals on rename ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/rename.c | 96 +- 1 files changed, 48 insertions(+), 48 deletions(-) diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c index 7b8fe39..92c4515 100644 --- a/fs/unionfs/rename.c +++ b

[PATCH 09/25] Unionfs: add un/likely conditionals on common fileops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 94 +++--- 1 files changed, 47 insertions(+), 47 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index e69ccf6..db8f064 100644 --- a/fs/unionfs

[PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 102 +- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 23ac4c8..e3c5f15 100644 --- a/fs/unionfs/copyup.c +++ b

[PATCH 16/25] Unionfs: add un/likely conditionals on inode ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/inode.c | 160 ++-- 1 files changed, 80 insertions(+), 80 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 7ee4760..7ae4a25 100644 --- a/fs/unionfs/inode.c +++ b/fs

[PATCH 18/25] Unionfs: add un/likely conditionals on super ops

Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/main.c | 98 ++- fs/unionfs/super.c | 90 2 files changed, 95 insertions(+), 93 deletions(-) diff --git a/fs/unionfs/main.c b/fs

[PATCH 02/25] Unionfs: Remove unused #defines

From: Josef 'Jeff' Sipek [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/union.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h index 1cb2e1d

[PATCH 04/25] Unionfs: cache-coherency fixes

From: Olivier Blin [EMAIL PROTECTED] Do not update mtime if there is no upper branch for the inode. This prevents from calling unionfs_lower_inode_idx() with a negative index, which triggers a bug. Signed-off-by: Olivier Blin [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs

[PATCH 01/25] Unionfs: Simplify unionfs_get_nlinks

PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/subr.c | 41 +++-- 1 files changed, 7 insertions(+), 34 deletions(-) diff --git a/fs/unionfs/subr.c b/fs/unionfs/subr.c index b7e7904..6b93b64 100644 --- a/fs/unionfs/subr.c +++ b/fs/unionfs

[PATCH 25/25] Unionfs: use poison.h for safe poison pointers

This also fixes a compile warning on 64-bit systems. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/debug.c | 16 ++-- fs/unionfs/union.h |1 + 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/fs

Re: [PATCH 4/11] eCryptfs: Replace encrypt, decrypt, and inode size write

In message [EMAIL PROTECTED], Michael Halcrow writes: On Wed, Sep 19, 2007 at 10:46:26PM -0700, Andrew Morton wrote: (from ecryptfs_encrypt_page()): + enc_extent_virt = kmalloc(PAGE_CACHE_SIZE, GFP_USER); I'd have thought that alloc_page() would be nicer. After all, we _are_ treating

[GIT PULL -mm] 0/6 Unionfs updates/cleanups/fixes

|1 - file.c | 12 ++-- inode.c |6 +- lookup.c | 52 +++- mmap.c |6 +++--- union.h |2 +- 9 files changed, 59 insertions(+), 45 deletions(-) Erez Zadok [EMAIL PROTECTED] - To unsubscribe from

[PATCH 1/6] Unionfs: use bool type in dentry and file revalidation code

Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 12 ++-- fs/unionfs/dentry.c |2 +- fs/unionfs/dirfops.c|4 ++-- fs/unionfs/file.c | 12 ++-- fs/unionfs/mmap.c |6 +++--- fs

[PATCH 4/6] Unionfs: check integrity only if validated dentry successfully

Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 91f9780..9e0742d 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs

[PATCH 5/6] Unionfs: unionfs_lookup locking consistency

this behavior. This cleanup allowed us to remove two unnecessary int declarations. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c |6 +- fs/unionfs/lookup.c | 38 +++--- 2 files changed, 24 insertions

[PATCH 6/6] Unionfs: cache coherency after lower objects are removed

Prevent an oops if a lower file is deleted and then it is stat'ed from the upper layer. Ensure that we return a negative dentry so the user will get an ENOENT. Properly dput/mntput so we don't leak references at the lower file system. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Acked-by: Josef

Re: [RFC] Union Mount: Readdir approaches

In message [EMAIL PROTECTED], Josef 'Jeff' Sipek writes: On Fri, Sep 07, 2007 at 01:28:55PM +0530, Bharata B Rao wrote: On Fri, Sep 07, 2007 at 04:31:26PM +0900, [EMAIL PROTECTED] wrote: When the first readdir is issued: - call vfs_readdir for every underlying opened dir (file)

Re: [GIT PULL -mm] Unionfs/fsstack/eCryptfs updates/cleanups/fixes

In message [EMAIL PROTECTED], Al Boldi writes: Josef 'Jeff' Sipek wrote: The following is a series of patches related to Unionfs, which include three small VFS/fsstack patches and one eCryptfs patch; the rest are Unionfs patches. The patches here represent several months of work and

Re: [GIT PULL -mm] Unionfs/fsstack/eCryptfs updates/cleanups/fixes

In message [EMAIL PROTECTED], Al Boldi writes: Erez Zadok wrote: Al, we have back-ports of the latest Unionfs to 2.6.{22,21,20,19,18,9}, all in http://unionfs.filesystems.org/. Before we release any change, we test it on all back-ports as well as the latest -rc/-mm code base (takes over

Re: JFFS2/mtdsuper modprobe unknown symbol in 2.6.23-rc1

In message [EMAIL PROTECTED], Adrian Bunk writes: On Thu, Aug 09, 2007 at 10:38:18PM -0400, Erez Zadok wrote: I'm getting an error modprobing jffs2 due to mtdsuper failing to insmod: ... Does anyone know what am I missing? You miss that 2.6.23-rc2 with this bug fixed has already been

JFFS2/mtdsuper modprobe unknown symbol in 2.6.23-rc1

I'm getting an error modprobing jffs2 due to mtdsuper failing to insmod: # modprobe jffs2 WARNING: Error inserting mtdsuper (/lib/modules/2.6.23-rc1/kernel/drivers/mtd/mtdsuper.ko): Unknown symbol in module, or unknown parameter (see dmesg) FATAL: Error inserting jffs2

possible bug/oops in nfs_pageio_add_request (2.6.22-rc2)?

I've hit a NULL ptr deref on desc-pg_error below, triggered when mounting a stackable file system on top of nfsv3: // from file: nfs/pagelist.c int nfs_pageio_add_request(struct nfs_pageio_descriptor *desc, struct nfs_page *req) { while

Re: Fix(es) for ext2 fsync bug

In message [EMAIL PROTECTED], Valerie Henson writes: On Thu, Feb 15, 2007 at 09:20:21AM -0500, Theodore Tso wrote: And POSIX also states that sync() is only required to schedule the writes, but may return before the actual writing is done. Looks like One more reason to form a group to

Re: [PATCH 01/24] Unionfs: Documentation

In message [EMAIL PROTECTED], Trond Myklebust writes: I'm saying that at the very least it should not Oops in these situations. As to whether or not they are something you want to handle more gracefully, that is up to you, but Oopses are definitely a showstopper. Trond I totally agree:

Re: [PATCH 01/24] Unionfs: Documentation

In message [EMAIL PROTECTED], Jan Kara writes: In message [EMAIL PROTECTED], Andrew Morton writes: On Sun, 7 Jan 2007 23:12:53 -0500 Josef 'Jeff' Sipek [EMAIL PROTECTED] wrote: +Modifying a Unionfs branch directly, while the union is mounted, is +currently unsupported.

Re: [PATCH 01/24] Unionfs: Documentation

In message [EMAIL PROTECTED], Christoph Hellwig writes: On Mon, Jan 08, 2007 at 07:03:35PM -0500, Erez Zadok wrote: However, I must caution that a file system like ecryptfs is very different from Unionfs, the latter being a fan-out file system---and both have very different goals

Re: [PATCH 01/24] Unionfs: Documentation

In message [EMAIL PROTECTED], Andrew Morton writes: On Sun, 7 Jan 2007 23:12:53 -0500 Josef 'Jeff' Sipek [EMAIL PROTECTED] wrote: +Modifying a Unionfs branch directly, while the union is mounted, is +currently unsupported. Does this mean that if I have /a/b/ and /c/d/ unionised under

Re: [PATCH 01/24] Unionfs: Documentation

In message [EMAIL PROTECTED], Andrew Morton writes: On Mon, 08 Jan 2007 16:30:48 -0500 Shaya Potter [EMAIL PROTECTED] wrote: Well yes. So the top-level question is is this the correct way of doing unionisation?. I suspect not, in which case unionfs is at best a stopgap until someone

Re: Is a NULL check missing in nfs_lookup?

In message [EMAIL PROTECTED], Matthew Wilcox writes: On Fri, Jan 05, 2007 at 02:10:06PM -0500, Erez Zadok wrote: Ah, ok. So why not put an ASSERT in there, or at least a comment, to make the code clearer. As it stands, anyone looking at the code in the future can easily rediscover

<    1   2   3