Re: [PATCH] make iunique use a do/while loop rather than its obscure goto loop

/while. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> diff --git a/fs/inode.c b/fs/inode.c index 23fc1fd..90e7587 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -689,21 +689,18 @@ ino_t iunique(struct super_block *sb, ino_t max_reserved) struct inode *inode; struct hlist

[PATCH] add procfs tunable to enable immediate panic when there are busy inodes after umount

nalyzing a coredump when this occurs can be. The following patch adds a procfs tunable that allows you to force a core when a "busy inodes after umount" problem occurs. It also changes the classic error message to be something a bit less cryptic to users. Signed-off-by: Jeff Layton <[

Re: [PATCH] add procfs tunable to enable immediate panic when there are busy inodes after umount

On Tue, 29 May 2007 23:38:13 +0400 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > On Tue, May 29, 2007 at 11:40:42AM -0400, Jeff Layton wrote: > > After spending quite a bit of time tracking down a "VFS: busy inodes > > after unmount" problem, it occurs to me that it

Re: [PATCH] add procfs tunable to enable immediate panic when there are busy inodes after umount

On Wed, 30 May 2007 10:28:57 +1000 David Chinner <[EMAIL PROTECTED]> wrote: > On Tue, May 29, 2007 at 11:40:42AM -0400, Jeff Layton wrote: > > After spending quite a bit of time tracking down a "VFS: busy inodes > > after unmount" problem, it occurs to me that it

[PATCH] have cifs_reconnect handle signals appropriately

* the following patch (or something like it) might be appropriate. I've tested a similar patch on Steve's backported 1.48a CIFS code and it seems to fix the problem there, but that code doesn't have the kthread changes. Does this look reasonable, or am I missing something importan

[PATCH 0/2] intro: make NFSv4 exclusive open calls set and use the bitmask in the reply

... -- Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] nfs4: on a O_EXCL OPEN make sure the SETATTR sets the fields holding the verifier

ds the server could reasonably use, but adding checks for others should be trivial. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 8e46e3e..34ddd66 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -955,6 +955,22 @@ stati

[PATCH 1/2] nfsd: set the response bitmask for an EXCLUSIVE CREATE

back to the client. This patch makes sure that we set the correct bits in the bitmask in this situation. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 8522729..da20674 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -99,7

Re: [NFS] [PATCH 2/2] nfs4: on a O_EXCL OPEN make sure the SETATTR sets the fields holding the verifier

be checking in nfs4_exclusive_attrset? Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 8e46e3e..6f76869 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -955,6 +955,22 @@ static struct nfs4_state *nfs4_open_delegated(struct inode

[PATCH] CIFS: make cifsd (more) signal-safe

ctly, it ignores it, flushes signals and moves on. I've tested a similar backported version of this on an earlier kernel, but have not tested this particular patch as of yet. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index f4e92

Re: [NFS] [PATCH 2/2] nfs4: on a O_EXCL OPEN make sure the SETATTR sets the fields holding the verifier

On Tue, 05 Jun 2007 14:13:02 -0400 Trond Myklebust <[EMAIL PROTECTED]> wrote: > On Tue, 2007-06-05 at 13:56 -0400, Jeff Layton wrote: > > The Linux NFS4 client simply skips over the bitmask in an O_EXCL open > > call and so it doesn't bother to reset any fields t

[PATCH] RFC: have tcp_recvmsg() check kthread_should_stop() and treat it as if it were signalled

ed. I'm just not clear on whether it will have any adverse side-effects. Obviously if this approach is OK then we'll probably also want to fix up other recvmsg functions (udp_recvmsg, etc). Anyone care to comment? Thanks, Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> diff --gi

Re: [PATCH] RFC: have tcp_recvmsg() check kthread_should_stop() and treat it as if it were signalled

On Sat, 09 Jun 2007 11:30:04 +1000 Herbert Xu <[EMAIL PROTECTED]> wrote: > Please cc networking patches to [EMAIL PROTECTED] > > Jeff Layton <[EMAIL PROTECTED]> wrote: > > > > The following patch is a first stab at removing this need. It makes it > >

Re: [linux-cifs-client] Re: [PATCH] CIFS: make cifsd (more) signal-safe

On Wed, 6 Jun 2007 09:55:50 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Tue, Jun 05, 2007 at 03:23:40PM -0400, Jeff Layton wrote: > > I recently sent a similar, smaller patch for this problem. After some > > discussion with Steve and Shaggy, I think I better

Re: [RFC:PATCH] How best to handle implicit clearing of setuid/setgid bits on NFS?

On Wed, 27 Jun 2007 18:15:55 -0400 Trond Myklebust <[EMAIL PROTECTED]> wrote: > On Tue, 2007-05-29 at 12:47 -0400, Jeff Layton wrote: > > I've been looking at issue of clearing setuid/setgid bits when a file > > is written to on NFS. Here's the problem in a nut

Re: [PATCH] CIFS: make cifsd (more)

gt; threads do is they either use tcp_read_sock and hooks into the sk_ callbacks > which would be nice for high performance reads in cifs aswell, but probably > not the demultiplexer thread, or they use MSG_DONTWAIT to avoid this problems > and deal with the blocking behaviour on a higher level.

[PATCH] error out if signing was requested, but can't be fulfilled

citly requests signing, we should error out if that request can't be satisfied. They can then reattempt the mount without signing if that's ok. Is there any reason not to do something like the following patch? Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> diff --git a/fs/cif

Re: [linux-cifs-client] Re: mount options for selectively disabling parts of CIFS Unix Extensions

ing the mount outright with an -EBUSY. NFS has just gone through a not too dissimilar situation (mounting the same export twice with different options). It now fails with -EBUSY in that situation. A new mount option was also introduced (nosharedcache) that makes it fall back on the previous behavior (n

Re: [NFS] [RFC:PATCH] How best to handle implicit clearing of setuid/setgid bits on NFS?

t before inode_change_ok is called. So I think we'll have to make sure that all .setattr ops call the helper explicitly. I'm working on a patchset now and hope to have something together in a few days. -- Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the li

[PATCH 03/25] AFFS: call attr_kill_to_mode from affs_notify_change

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/affs/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 4609a6c..1fa2937 100644 --- a/fs/affs/inode.c +++ b/fs/affs/inode.c @@ -218,6 +218,7 @@ affs_notify_change(

[PATCH 04/25] AFS: call attr_kill_to_mode from afs_setattr

Not sure if this is necessary or desirable for AFS, but adding it for consistency. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/afs/inode.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/afs/inode.c b/fs/afs/inode.c index d196840..d0ad5e6 100644 --

[PATCH 05/25] CIFS: call attr_kill_to_mode in cifs_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/cifs/inode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index dd41677..6fee1fa 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -1429,6 +1429,8 @@ int cifs_setattr(

[PATCH 02/25] 9p: have v9fs_vfs_setattr call attr_kill_to_mode

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/9p/vfs_inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index e5c45ee..00fcd4e 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -756,6 +756,7 @@ stat

[PATCH 08/25] ext234: have setattr functions call attr_kill_to_mode

.. and only save off ia_valid once it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ext2/inode.c |1 + fs/ext3/inode.c |5 - fs/ext4/inode.c |5 - 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 0

[PATCH 07/25] configfs: call attr_kill_to_mode from configfs_setattr

..and only set ia_valid just before it's actually used Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/configfs/inode.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c index ddc003a..a67f36b 100644 --- a/

[PATCH 06/25] coda: call attr_kill_to_mode from coda_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/coda/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/coda/inode.c b/fs/coda/inode.c index 342f4e0..c06d031 100644 --- a/fs/coda/inode.c +++ b/fs/coda/inode.c @@ -239,6 +239,7 @@ int coda_setattr(

[PATCH 12/25] HPFS: call attr_kill_to_mode from hpfs_notify_change

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/hpfs/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/hpfs/inode.c b/fs/hpfs/inode.c index 85d3e1d..d2b26eb 100644 --- a/fs/hpfs/inode.c +++ b/fs/hpfs/inode.c @@ -265,6 +265,7 @@ int hpfs_notify_

[PATCH 11/25] hostfs: call attr_kill_to_mode from hostfs_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/hostfs/hostfs_kern.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index c778620..ea75204 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_

[PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

ses that to decide whether to return early, and to pass a (hopefully) appropriate bitmask to fsnotify_change. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/attr.c | 54 +-- include/linux/fs.h |1 + 2 files changed, 36 i

[PATCH 10/25] GFS2: have gfs2_setattr call attr_kill_to_mode

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/gfs2/ops_inode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 911c115..8401fc7 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c @@ -994,6 +994,8 @@

[PATCH 18/25] ramfs_nommu: call attr_kill_to_mode from ramfs_nommu_setattr

..and only set old_ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ramfs/file-nommu.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c index cad2b7a..c354883 100644 --- a/fs/ramf

[PATCH 19/25] reiserfs: call attr_kill_to_mode from reiserfs_setattr

..and only save off ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/reiserfs/inode.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index ddde489..55b2aea 100644 --- a/fs/reiserfs/i

[PATCH 21/25] sysfs: call attr_kill_to_mode from sysfs_setattr

..and only save off ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/sysfs/inode.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index 10d1b52..38f2ba9 100644 --- a/fs/sysfs/inode.c +++ b/fs

[PATCH 22/25] UDF: call attr_kill_to_mode from udf_setattr

..and only save off ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ufs/truncate.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/ufs/truncate.c b/fs/ufs/truncate.c index 79c54c8..193679b 100644 --- a/fs/ufs/truncate.c +++ b/

[PATCH 23/25] XFS: call attr_kill_to_mode from xfs_vn_setattr

..and only save off ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_iops.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index 0b5fa12..67fba53 100644

[PATCH 25/25] spufs: call attr_kill_to_mode from spufs_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/spufs/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c index b3d0dd1..d0f6b62 100644 ---

[PATCH 09/25] FUSE: Call attr_kill_to_mode from fuse_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/fuse/dir.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index bd5a772..60c8d5e 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -1016,6 +1016,8 @@ static int fuse_setattr(

[PATCH 24/25] tmpfs: call attr_kill_to_mode from shmem_notify_change

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- mm/shmem.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index fcd19d3..d3b5421 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -719,6 +719,8 @@ static int shmem_notify_change(struct dentry *

[PATCH 20/25] smbfs: call attr_kill_to_mode from smb_notify_change

..seems unlikely that the sb mode would include a setuid bit, but I suppose it's possible. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/smbfs/inode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/smbfs/inode.c b/fs/smbfs/inode.c index 73d14

[PATCH 13/25] hugetlbfs: call attr_kill_to_mode from hugetlbfs_setattr

..and only set ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/hugetlbfs/inode.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index c848a19..3566abb 100644 --- a/fs/hugetlbfs/inode.c

[PATCH 17/25] procfs: add attr_kill_to_mode to setattr functions

Not sure if this is really needed, but I don't think it will hurt anything Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/proc/base.c|3 +++ fs/proc/generic.c |3 +++ fs/proc/proc_sysctl.c |3 +++ 3 files changed, 9 insertions(+), 0 deletions(-) diff

[PATCH 16/25] OCFS2: call attr_kill_to_mode from ocfs2_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ocfs2/file.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index c4034f6..d05d472 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -972,6 +972,8 @@ int ocfs2_setattr(

[PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions

vative approach and call the helper when I wasn't sure. I've tried to CC the maintainers for the individual filesystems as well where I could find them, please let me know if there are others who should be informed. Comments and suggestions appreciated... Signed-off-by: Jeff Layton

[PATCH 15/25] JFS: call attr_kill_to_mode from jfs_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/jfs/acl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c index 4d84bdc..34ca314 100644 --- a/fs/jfs/acl.c +++ b/fs/jfs/acl.c @@ -227,6 +227,8 @@ int jfs_setattr(struct dentry *

[PATCH 14/25] JFFS2: call attr_kill_to_mode from jffs2_do_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/jffs2/fs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c index 1d3b7a9..5218f04 100644 --- a/fs/jffs2/fs.c +++ b/fs/jffs2/fs.c @@ -37,6 +37,7 @@ static int jffs2_do_setattr (

[PATCH 05/25] CIFS: call attr_kill_to_mode in cifs_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/cifs/inode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index dd41677..6fee1fa 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -1429,6 +1429,8 @@ int cifs_setattr(

[PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

know if there are others who should be informed. Comments and suggestions appreciated... Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo

[PATCH 08/25] ext234: have setattr functions call attr_kill_to_mode

.. and only save off ia_valid once it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ext2/inode.c |1 + fs/ext3/inode.c |5 - fs/ext4/inode.c |5 - 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 0

[PATCH 06/25] coda: call attr_kill_to_mode from coda_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/coda/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/coda/inode.c b/fs/coda/inode.c index 342f4e0..c06d031 100644 --- a/fs/coda/inode.c +++ b/fs/coda/inode.c @@ -239,6 +239,7 @@ int coda_setattr(

[PATCH 10/25] GFS2: have gfs2_setattr call attr_kill_to_mode

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/gfs2/ops_inode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c index 911c115..8401fc7 100644 --- a/fs/gfs2/ops_inode.c +++ b/fs/gfs2/ops_inode.c @@ -994,6 +994,8 @@

[PATCH 09/25] FUSE: Call attr_kill_to_mode from fuse_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/fuse/dir.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index bd5a772..60c8d5e 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -1016,6 +1016,8 @@ static int fuse_setattr(

[PATCH 11/25] hostfs: call attr_kill_to_mode from hostfs_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/hostfs/hostfs_kern.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/hostfs/hostfs_kern.c b/fs/hostfs/hostfs_kern.c index c778620..ea75204 100644 --- a/fs/hostfs/hostfs_kern.c +++ b/fs/hostfs/hostfs_

[PATCH 12/25] HPFS: call attr_kill_to_mode from hpfs_notify_change

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/hpfs/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/hpfs/inode.c b/fs/hpfs/inode.c index 85d3e1d..d2b26eb 100644 --- a/fs/hpfs/inode.c +++ b/fs/hpfs/inode.c @@ -265,6 +265,7 @@ int hpfs_notify_

[PATCH 07/25] configfs: call attr_kill_to_mode from configfs_setattr

..and only set ia_valid just before it's actually used Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/configfs/inode.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c index ddc003a..a67f36b 100644 --- a/

[PATCH 13/25] hugetlbfs: call attr_kill_to_mode from hugetlbfs_setattr

..and only set ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/hugetlbfs/inode.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index c848a19..3566abb 100644 --- a/fs/hugetlbfs/inode.c

[PATCH 14/25] JFFS2: call attr_kill_to_mode from jffs2_do_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/jffs2/fs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c index 1d3b7a9..5218f04 100644 --- a/fs/jffs2/fs.c +++ b/fs/jffs2/fs.c @@ -37,6 +37,7 @@ static int jffs2_do_setattr (

[PATCH 17/25] procfs: add attr_kill_to_mode to setattr functions

Not sure if this is really needed, but I don't think it will hurt anything Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/proc/base.c|3 +++ fs/proc/generic.c |3 +++ fs/proc/proc_sysctl.c |3 +++ 3 files changed, 9 insertions(+), 0 deletions(-) diff

[PATCH 15/25] JFS: call attr_kill_to_mode from jfs_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/jfs/acl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c index 4d84bdc..34ca314 100644 --- a/fs/jfs/acl.c +++ b/fs/jfs/acl.c @@ -227,6 +227,8 @@ int jfs_setattr(struct dentry *

[PATCH 18/25] ramfs_nommu: call attr_kill_to_mode from ramfs_nommu_setattr

..and only set old_ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ramfs/file-nommu.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/ramfs/file-nommu.c b/fs/ramfs/file-nommu.c index cad2b7a..c354883 100644 --- a/fs/ramf

[PATCH 19/25] reiserfs: call attr_kill_to_mode from reiserfs_setattr

..and only save off ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/reiserfs/inode.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index ddde489..55b2aea 100644 --- a/fs/reiserfs/i

[PATCH 16/25] OCFS2: call attr_kill_to_mode from ocfs2_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ocfs2/file.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index c4034f6..d05d472 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -972,6 +972,8 @@ int ocfs2_setattr(

[PATCH 21/25] sysfs: call attr_kill_to_mode from sysfs_setattr

..and only save off ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/sysfs/inode.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index 10d1b52..38f2ba9 100644 --- a/fs/sysfs/inode.c +++ b/fs

[PATCH 20/25] smbfs: call attr_kill_to_mode from smb_notify_change

..seems unlikely that the sb mode would include a setuid bit, but I suppose it's possible. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/smbfs/inode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/smbfs/inode.c b/fs/smbfs/inode.c index 73d14

[PATCH 25/25] spufs: call attr_kill_to_mode from spufs_setattr

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/spufs/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c index b3d0dd1..d0f6b62 100644 ---

[PATCH 23/25] XFS: call attr_kill_to_mode from xfs_vn_setattr

..and only save off ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/xfs/linux-2.6/xfs_iops.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index 0b5fa12..67fba53 100644

[PATCH 22/25] UDF: call attr_kill_to_mode from udf_setattr

..and only save off ia_valid after it returns Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ufs/truncate.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/fs/ufs/truncate.c b/fs/ufs/truncate.c index 79c54c8..193679b 100644 --- a/fs/ufs/truncate.c +++ b/

[PATCH 24/25] tmpfs: call attr_kill_to_mode from shmem_notify_change

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- mm/shmem.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index fcd19d3..d3b5421 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -719,6 +719,8 @@ static int shmem_notify_change(struct dentry *

[PATCH 02/25] 9p: have v9fs_vfs_setattr call attr_kill_to_mode

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/9p/vfs_inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index e5c45ee..00fcd4e 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -756,6 +756,7 @@ stat

[PATCH 03/25] AFFS: call attr_kill_to_mode from affs_notify_change

Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/affs/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 4609a6c..1fa2937 100644 --- a/fs/affs/inode.c +++ b/fs/affs/inode.c @@ -218,6 +218,7 @@ affs_notify_change(

[PATCH 04/25] AFS: call attr_kill_to_mode from afs_setattr

Not sure if this is necessary or desirable for AFS, but adding it for consistency. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/afs/inode.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/afs/inode.c b/fs/afs/inode.c index d196840..d0ad5e6 100644 --

[PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

ses that to decide whether to return early, and to pass a (hopefully) appropriate bitmask to fsnotify_change. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/attr.c | 54 +-- include/linux/fs.h |1 + 2 files changed, 36 i

Re: [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

ill break out-of-tree fs, so a separate flag is > probably better. > In the past I've been told that adding new flags is something of a "last resort". Since it's not strictly necessary to fix this then it may be best to avoid that. That said, if the concensus is that we nee

Re: [fuse-devel] [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

this up later. As Trond said, in-tree filesystems will be converted so they won't be an issue. The only danger is someone who is running unconverted out-of-tree filesystem code on a kernel with this patch. Is that enough of an issue to warrant us taking extra steps to deal with it? An

Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

a little easier if you > really care.) Thanks. I debated about how best to split these up. A coworker mentioned that Andrew had tossed him back a single patch that touched several mainline filesystems and asked him to break it up. I took that to mean that the patches should generally be split out,

Re: [PATCH 01/25] VFS: move attr_kill logic from notify_change into helper function

gestions. I'll plan to incorporate them in the next respin of the set. Thanks, -- Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

On Tue, 7 Aug 2007 17:15:01 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 6 Aug 2007 09:54:03 -0400 > Jeff Layton <[EMAIL PROTECTED]> wrote: > > > Apologies for the resend, but the original sending had the date in the > > email header and

Re: [fuse-devel] [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

On Wed, 8 Aug 2007 22:05:13 +0200 (CEST) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Aug 8 2007 09:48, Andrew Morton wrote: > >> > On Mon, 6 Aug 2007 09:54:03 -0400 > >> > Jeff Layton <[EMAIL PROTECTED]> wrote: > >> > > >>

Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

ange a setuid/setgid file on these filesystems. Still, it should conceivably catch most if not all offenders. Would that be sufficient to take care of everyone's concerns? -- Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsd

Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

convert to the "new" scheme, so they can avoid this second setattr call. If this idea seems sound then I'll start the grunt work to fix up the in-tree filesystems so that they don't need the second setattr call. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> commit 52

Re: [PATCH 00/25] move handling of setuid/gid bits from VFS into individual setattr functions (RESEND)

On Mon, 13 Aug 2007 08:01:34 -0400 Jeff Layton <[EMAIL PROTECTED]> wrote: > On Sat, 11 Aug 2007 03:57:39 +0100 > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > I like the idea of checking ia_valid after return a lot. But instead of > > going BUG()

[PATCH 4/4] Have reiser4 call generic_attrkill from its setattr operation

This is the only filesystem in -mm but not in mainline that seems to be affected by this change... Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/reiser4/plugin/inode_ops.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/reiser4/plugin/inode_ops.c b/fs/r

[PATCH 3/4] Fix networked filesystems to handle ATTR_KILL_ bits correctly

notify_change doesn't try to do a second setattr. NFS already clears these bits, and this just updates a comment to make it clear that doing this is more than an optimization. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/cifs/inode.c |5 + fs/nfs/inode.c |6 +- 2 fi

[PATCH 0/4] move handling of setuid/gid bits from VFS into individual setattr functions (try 2)

broken out individually again if needed. Comments and suggestions appreciated. Also, please let me know if I've missed any filesystems that need to be converted... Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsd

[PATCH 1/4] VFS: move ATTR_KILL handling from notify_change into helper function

ld help us to catch filesystems that don't handle these bits correctly without breaking them outright. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/attr.c | 91 --- include/linux/fs.h |1 + 2 files changed, 72 ins

[PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly

This should fix all of the filesystems in the mainline kernels to handle ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is just a matter of making sure that they call generic_attrkill early in the setattr inode op. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> ---

Re: [PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly

On Tue, 21 Aug 2007 15:35:08 +1000 Timothy Shimmin <[EMAIL PROTECTED]> wrote: > Jeff Layton wrote: > > This should fix all of the filesystems in the mainline kernels to handle > > ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is > > just a matt

Re: [PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly

On Tue, 21 Aug 2007 17:21:28 -0400 Josef Sipek <[EMAIL PROTECTED]> wrote: > On Tue, Aug 21, 2007 at 07:35:51AM -0400, Jeff Layton wrote: > > On Tue, 21 Aug 2007 15:35:08 +1000 > > Timothy Shimmin <[EMAIL PROTECTED]> wrote: > > > > > Jeff Layton

[PATCH 1/4] VFS: Introduce the killattr inode operation for handling ATTR_KILL_S*ID

ined. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/attr.c | 33 - include/linux/fs.h |1 + 2 files changed, 21 insertions(+), 13 deletions(-) diff --git a/fs/attr.c b/fs/attr.c index ae58bd3..77608d3 100644 --- a/fs/attr.c +++ b/fs

[PATCH 0/4] add killattr inode operation to allow filesystems to interpret ATTR_KILL_S*ID bits

d suggestions appreciated... Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/4] NFS: add nfs_killattr inode_operation

Add the nfs_killattr inode operation. For NFS, we generally want the server to handle clearing these bits. So the function is really just a noop. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/nfs/dir.c |3 +++ fs/nfs/file.c |2 ++ fs/nfs/inode.c

[PATCH 3/4] CIFS: add cifs_killattr inode_operation

..make it just clear the ATTR_KILL_S*ID bits since we want the server to handle it. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/cifs/cifsfs.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index cabb6a5..c

[PATCH 4/4] Documentation: update in-tree fs docs for new function

This updates the VFS docs under the Documentation/ directory to describe the new killattr inode operation. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- Documentation/filesystems/Locking |2 ++ Documentation/filesystems/vfs.txt |6 ++ 2 files changed, 8 insertions

Re: [NFS] [PATCH 0/4] add killattr inode operation to allow filesystems to interpret ATTR_KILL_S*ID bits

| S_IXGRP)) { > > if (!(ia_valid & ATTR_MODE)) { > > ia_valid = attr->ia_valid |= ATTR_MODE; > > attr->ia_mode = inode->i_mode; > > } > > attr->ia_mode &= ~S_

[PATCH 0/3] fix setuid/setgid clearing in networked filesystems (take 4)

other two patches in the set fix up NFS and CIFS to ignore the mode change if either ATTR_KILL_S*ID bit is set. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [EMAIL PROTECTED] Mo

[PATCH 1/3] VFS: make notify_change pass ATTR_KILL_S*ID to setattr operations

both ATTR_MODE and either of the ATTR_KILL_S*ID bits set, since the filesystem would have no way to know what part of the mode change was intentional. If it is called this way, consider it a BUG(). Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/attr.c | 22 -- 1

[PATCH 0/7] fix setuid/setgid clearing in networked filesystems (take 5)

is is basically the same patchset as take 4 with a few extra patches to fix up the callers of notify_change, and some minor parenthetical cleanups. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in

[PATCH 1/7] VFS: make notify_change pass ATTR_KILL_S*ID to setattr operations

both ATTR_MODE and either of the ATTR_KILL_S*ID bits set, since the filesystem would have no way to know what part of the mode change was intentional. If it is called this way, consider it a BUG(). Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/attr.c | 23 +-- 1

[PATCH 2/7] NFS: if ATTR_KILL_S*ID bits are set, then skip mode change

If the ATTR_KILL_S*ID bits are set then any mode change is only for clearing the setuid/setgid bits. For NFS skip the mode change and let the server handle it. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/nfs/inode.c |4 1 files changed, 4 insertions(+), 0 deletions(-)

[PATCH 3/7] CIFS: ignore mode change if it's just for clearing setuid/setgid bits

If the ATTR_KILL_S*ID bits are set then any mode change is only for clearing the setuid/setgid bits. For NFS, skip the mode change and let the server handle it. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/cifs/inode.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-)

[PATCH 4/7] ecryptfs: allow lower fs to interpret ATTR_KILL_S*ID

Make sure ecryptfs doesn't trip the BUG() in notify_change. This also allows the lower filesystem to interpret these bits in their own way. Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> --- fs/ecryptfs/inode.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff

  1   2   3   >