Re: File system awareness (or lack thereof) of vfs granting of leases

2007-02-22 Thread David Teigland
On Thu, Feb 22, 2007 at 04:58:28PM -0500, J. Bruce Fields wrote: > I'm also curious--exposing my total ignorance of the dlm--why taking > such a lock would always be so expensive, or would always be required on > open. Surely the typical case should be one where there's no conflict > and never has

Re: File system awareness (or lack thereof) of vfs granting of leases

2007-02-20 Thread David Teigland
On Tue, Feb 20, 2007 at 03:51:54PM -0500, [EMAIL PROTECTED] wrote: > > On Tue, Feb 20, 2007 at 10:46:51AM -0500, Robert Rappaport wrote: > > We did an experimental distributed lease implementation in gfs(1) a while > > ago. It worked, but was so extremely expensive that there was no point in > > c

Re: File system awareness (or lack thereof) of vfs granting of leases

2007-02-20 Thread David Teigland
On Tue, Feb 20, 2007 at 10:46:51AM -0500, Robert Rappaport wrote: > Thank you both for your helpful replies. In particular, the addition > of the calls to file system specific functions in routines, > fcntl_setlease() and break_lease(), as well as the modifications to > the file_operations and ino

Re: [NFS] [PATCH 10/10] gfs2: nfs lock support for gfs2

2006-12-07 Thread David Teigland
On Wed, Dec 06, 2006 at 05:00:29PM -0500, J. Bruce Fields wrote: > On Wed, Dec 06, 2006 at 03:42:31PM -0600, David Teigland wrote: > > Oh yeah, that's painful, I knew it sounded too easy. > > Yeah. Well, we could try to teach GFS2 to reliably cancel posix locks. > I think

Re: [PATCH 10/10] gfs2: nfs lock support for gfs2

2006-12-06 Thread David Teigland
On Wed, Dec 06, 2006 at 04:23:47PM -0500, J. Bruce Fields wrote: > On Wed, Dec 06, 2006 at 02:58:22PM -0600, David Teigland wrote: > > On Wed, Dec 06, 2006 at 02:57:22PM -0500, J. Bruce Fields wrote: > > > The more annoying problem is the need to cancel the GFS lock when > &g

Re: [PATCH 10/10] gfs2: nfs lock support for gfs2

2006-12-06 Thread David Teigland
On Wed, Dec 06, 2006 at 02:57:22PM -0500, J. Bruce Fields wrote: > On Wed, Dec 06, 2006 at 09:49:51AM -0600, David Teigland wrote: > > The gfs side looks fine to me. Did you forget to call fl_notify from > > gdlm_plock_callback() or am I missing something? > > Yes, looks lik

Re: [PATCH 10/10] gfs2: nfs lock support for gfs2

2006-12-06 Thread David Teigland
On Wed, Dec 06, 2006 at 12:34:20AM -0500, J. Bruce Fields wrote: > +int gdlm_plock_callback(struct plock_op *op) > +{ > + struct file *file; > + struct file_lock *fl; > + int rv; > + > + spin_lock(&ops_lock); > + if (!list_empty(&op->list)) { > + printk(KERN_INFO "pl

Re: GFS, what's remaining

2005-09-07 Thread David Teigland
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote: > +static inline void glock_put(struct gfs2_glock *gl) > +{ > + if (atomic_read(&gl->gl_count) == 1) > + gfs2_glock_schedule_for_reclaim(gl); > + gfs2_assert(gl->gl_sbd, atomic_read(&gl->gl_count) > 0,); > + a

Re: [Linux-cluster] Re: GFS, what's remaining

2005-09-05 Thread David Teigland
On Mon, Sep 05, 2005 at 02:19:48AM -0700, Andrew Morton wrote: > David Teigland <[EMAIL PROTECTED]> wrote: > > Four functions: > > create_lockspace() > > release_lockspace() > > lock() > > unlock() > > Neat. I'd be inclined to make them

Re: [Linux-cluster] Re: GFS, what's remaining

2005-09-05 Thread David Teigland
On Mon, Sep 05, 2005 at 01:54:08AM -0700, Andrew Morton wrote: > David Teigland <[EMAIL PROTECTED]> wrote: > > > > We export our full dlm API through read/write/poll on a misc device. > > > > inotify did that for a while, but we ended up going with a straight sys

Re: GFS, what's remaining

2005-09-05 Thread David Teigland
On Mon, Sep 05, 2005 at 10:58:08AM +0200, J?rn Engel wrote: > #define gfs2_assert(sdp, assertion) do { \ > if (unlikely(!(assertion))) { \ > printk(KERN_ERR "GFS2: fsid=\n", (sdp)->sd_fsname); \ > BUG();

Re: GFS, what's remaining

2005-09-04 Thread David Teigland
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote: > +static unsigned int handle_roll(atomic_t *a) > +{ > + int x = atomic_read(a); > + if (x < 0) { > + atomic_set(a, 0); > + return 0; > + } > + return (unsigned int)x; > +} > > this is just p

Re: GFS, what's remaining

2005-09-04 Thread David Teigland
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote: > +void gfs2_glock_hold(struct gfs2_glock *gl) > +{ > + glock_hold(gl); > +} > > eh why? You removed the comment stating exactly why, see below. If that's not a accepted technique in the kernel, say so and I'll be happy to ch

Re: [Linux-cluster] Re: GFS, what's remaining

2005-09-04 Thread David Teigland
On Sat, Sep 03, 2005 at 10:41:40PM -0700, Andrew Morton wrote: > Joel Becker <[EMAIL PROTECTED]> wrote: > > > > > What happens when we want to add some new primitive which has no > > > posix-file analog? > > > > The point of dlmfs is not to express every primitive that the > > DLM has. dlm

Re: GFS, what's remaining

2005-09-04 Thread David Teigland
On Fri, Sep 02, 2005 at 10:28:21PM -0700, Greg KH wrote: > On Fri, Sep 02, 2005 at 05:44:03PM +0800, David Teigland wrote: > > On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote: > > > > > + gfs2_assert(gl->gl_sbd, atomic_read(&gl->gl_count) >

Re: GFS, what's remaining

2005-09-03 Thread David Teigland
On Sat, Sep 03, 2005 at 08:14:00AM +0200, Arjan van de Ven wrote: > On Sat, 2005-09-03 at 13:18 +0800, David Teigland wrote: > > On Thu, Sep 01, 2005 at 01:21:04PM -0700, Andrew Morton wrote: > > > Alan Cox <[EMAIL PROTECTED]> wrote: > > > > > - Why GFS is

Re: GFS, what's remaining

2005-09-02 Thread David Teigland
On Thu, Sep 01, 2005 at 01:21:04PM -0700, Andrew Morton wrote: > Alan Cox <[EMAIL PROTECTED]> wrote: > > > - Why GFS is better than OCFS2, or has functionality which OCFS2 cannot > > > possibly gain (or vice versa) > > > > > > - Relative merits of the two offerings > > > > You missed the import

Re: GFS, what's remaining

2005-09-02 Thread David Teigland
On Thu, Sep 01, 2005 at 01:35:23PM +0200, Arjan van de Ven wrote: > + gfs2_assert(gl->gl_sbd, atomic_read(&gl->gl_count) > 0,); > what is gfs2_assert() about anyway? please just use BUG_ON directly > everywhere When a machine has many gfs file systems mounted at once it can be useful to know

Re: GFS, what's remaining

2005-09-02 Thread David Teigland
On Thu, Sep 01, 2005 at 06:56:03PM +0100, Christoph Hellwig wrote: > Whether the gfs2 code is mergeable is a completely different question, > and it seems at least debatable to submit a filesystem for inclusion I actually asked what needs to be done for merging. We appreciate the feedback and ar

Re: [PATCH 01/14] GFS: headers

2005-09-01 Thread David Teigland
On Thu, Sep 01, 2005 at 04:19:34PM +0200, Arjan van de Ven wrote: > > +/* Endian functions */ > > e again why?? > Why is this a compiletime hack? > Either you care about either-endian on disk, at which point it has to be > a runtime thing, or you make the on disk layout fixed endian, at whic

[PATCH 03/13] GFS: directories

2005-09-01 Thread David Teigland
Code that handles directory operations. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/dir.c | 2158 ++ fs/gfs2/dir.h | 51 + 2 files changed, 2209 insertions(

[PATCH 04/13] GFS: allocation

2005-09-01 Thread David Teigland
Code that manages block allocation. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/bits.c | 179 +++ fs/gfs2/bits.h | 28 + fs/gfs2/rgrp.c | 1374 + fs

[PATCH 01/14] GFS: headers

2005-09-01 Thread David Teigland
Central header files that are widely used. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/gfs2.h | 77 +++ fs/gfs2/incore.h| 691 +++ include/linux/gfs2_ioctl.h | 3

[PATCH 11/13] GFS: lock_harness module

2005-09-01 Thread David Teigland
The lock_harness module allows a gfs file system to connect to a given lock module. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/locking/harness/Makefile |3 fs/gfs2/locking/harness/lm_interf

[PATCH 12/13] GFS: lock_nolock module

2005-09-01 Thread David Teigland
The lock_nolock module does no inter-node locking and allows gfs to be used as a local file system. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/locking/nolock/Makefile |3 fs/gfs2/locking/nolock/mai

[PATCH 10/13] GFS: build and documentation

2005-09-01 Thread David Teigland
Add gfs to the build system and gfs2.txt to Documentation. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- Documentation/filesystems/gfs2.txt | 194 + fs/Kconfig |

[PATCH 05/13] GFS: ea and acl

2005-09-01 Thread David Teigland
Code that handles extended attributes and ACL's. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/acl.c | 313 ++ fs/gfs2/acl.h | 37 + fs/gfs2/eaops.c | 179 ++ fs/gfs2/eaops.h | 30 + fs/gf

[PATCH 06/13] GFS: logging and recovery

2005-09-01 Thread David Teigland
A per-node on-disk log is used for recovery. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/log.c | 670 + fs/gfs2/log.h | 68 + fs/gfs2/recov

[PATCH 07/13] GFS: quotas

2005-09-01 Thread David Teigland
Code that deals with quotas. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/lvb.c | 61 ++ fs/gfs2/lvb.h | 28 + fs/gfs2/quota.c | 1209 fs/gfs2/quota.h

[PATCH 13/13] GFS: lock_dlm module

2005-09-01 Thread David Teigland
The lock_dlm module uses the DLM in linux/drivers/dlm/ for inter-node locking. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/locking/dlm/Makefile |3 fs/gfs2/locking/dlm/lock.

[PATCH 08/13] GFS: mount and tuning options

2005-09-01 Thread David Teigland
There are a variety of mount options, tunable parameters, internal statistics, and methods of online file system manipulation. Signed-off-by: Ken Preslan <[EMAIL PROTECTED]> Signed-off-by: David Teigland <[EMAIL PROTECTED]> --- fs/gfs2/ioc

GFS, what's remaining

2005-09-01 Thread David Teigland
Hi, this is the latest set of gfs patches, it includes some minor munging since the previous set. Andrew, could this be added to -mm? there's not much in the way of pending changes. http://redhat.com/~teigland/gfs2/20050901/gfs2-full.patch http://redhat.com/~teigland/gfs2/20050901/broken-out/ I'