Re: Question about synchronous write on SSD

2008-02-19 Thread Jens Axboe
writes. You can't force that behaviour by changing the block layer code. Perhaps you could force O_SYNC when a file is opened, if you want to experiment with worst case generally. Not sure that makes a lot of sense, though. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe

Re: Question about synchronous write on SSD

2008-02-19 Thread Jens Axboe
schedulers will now treat the IO as sync and introduce idling for the disk head. And you definitely don't want that. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: [PATCH][RFC] fast file mapping for loop

2008-01-15 Thread Jens Axboe
On Tue, Jan 15 2008, Jens Axboe wrote: On Mon, Jan 14 2008, Jens Axboe wrote: On Mon, Jan 14 2008, Chris Mason wrote: Hello everyone, Here is a modified version of Jens' patch. The basic idea is to push the mapping maintenance out of loop and down into the filesystem (ext2

Re: [PATCH][RFC] fast file mapping for loop

2008-01-15 Thread Jens Axboe
On Tue, Jan 15 2008, Jens Axboe wrote: On Tue, Jan 15 2008, Jens Axboe wrote: On Mon, Jan 14 2008, Jens Axboe wrote: On Mon, Jan 14 2008, Chris Mason wrote: Hello everyone, Here is a modified version of Jens' patch. The basic idea is to push the mapping maintenance out

Re: [patch] rewrite rd

2008-01-14 Thread Jens Axboe
, KM_USER1); You're using kmap_atomic, but I see no reason you can't be preempted. Don't you need to at least disable preemption while you have stuff atomically kmapped? kmap_atomic() disables preemption through pagefault_disable(). -- Jens Axboe - To unsubscribe from this list: send the line

Re: [PATCH][RFC] fast file mapping for loop

2008-01-14 Thread Jens Axboe
prio_tree_node *last_lookup; unsigned intblkbits; }; -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][RFC] fast file mapping for loop

2008-01-11 Thread Jens Axboe
On Fri, Jan 11 2008, Daniel Phillips wrote: Hi Jens, This looks really useful. On Wednesday 09 January 2008 00:52, Jens Axboe wrote: Disadvantages: - The file block mappings must not change while loop is using the file. This means that we have to ensure exclusive access to the file

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Jens Axboe
On Thu, Jan 10 2008, Jens Axboe wrote: On Wed, Jan 09 2008, Alasdair G Kergon wrote: Here's the latest version of dm-loop, for comparison. To try it out, ln -s dmsetup dmlosetup and supply similar basic parameters to losetup. (using dmsetup version 1.02.11 or higher) Why oh why

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Jens Axboe
have is a crappy bmap() interface to get at those mappings. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Jens Axboe
On Thu, Jan 10 2008, Christoph Hellwig wrote: On Thu, Jan 10, 2008 at 09:44:57AM +0100, Jens Axboe wrote: IMHO this shouldn't be done in the loop driver anyway. Filesystems have their own effricient extent lookup trees (well, at least xfs and btrfs do), and we should leverage

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Jens Axboe
as needed with some very simple logic to populate-ahead. In practice that performs as well as a pre-populated map, the first IO to a given range will just be a little slower since we have to bmap() it. Do you have plans to improve this area? -- Jens Axboe - To unsubscribe from this list: send the line

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Jens Axboe
On Thu, Jan 10 2008, Peter Zijlstra wrote: On Thu, 2008-01-10 at 10:49 +0100, Jens Axboe wrote: On Thu, Jan 10 2008, Peter Zijlstra wrote: On Thu, 2008-01-10 at 08:37 +, Christoph Hellwig wrote: Peter, any chance you could chime in here? I have this patch to add

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Jens Axboe
On Thu, Jan 10 2008, Chris Mason wrote: On Thu, 10 Jan 2008 09:31:31 +0100 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Jan 09 2008, Alasdair G Kergon wrote: Here's the latest version of dm-loop, for comparison. To try it out, ln -s dmsetup dmlosetup and supply similar

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Jens Axboe
On Thu, Jan 10 2008, Chris Mason wrote: On Thu, 10 Jan 2008 08:54:59 + Christoph Hellwig [EMAIL PROTECTED] wrote: On Thu, Jan 10, 2008 at 09:44:57AM +0100, Jens Axboe wrote: IMHO this shouldn't be done in the loop driver anyway. Filesystems have their own effricient extent lookup

Re: [PATCH][RFC] fast file mapping for loop

2008-01-10 Thread Jens Axboe
the posted patch and the posts from Chris as well, it basically covers everything in your email. The patch, as posted, doesn't work if the fs moves blocks around. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More

[PATCH][RFC] fast file mapping for loop

2008-01-09 Thread Jens Axboe
(root, cur-parent, cur); } +EXPORT_SYMBOL(prio_tree_remove); /* * Following functions help to enumerate all prio_tree_nodes in the tree that @@ -482,3 +485,4 @@ repeat: goto repeat; } +EXPORT_SYMBOL(prio_tree_next); -- Jens Axboe - To unsubscribe from this list: send the line

Re: [PATCH][RFC] fast file mapping for loop

2008-01-09 Thread Jens Axboe
On Wed, Jan 09 2008, Christoph Hellwig wrote: On Wed, Jan 09, 2008 at 09:52:32AM +0100, Jens Axboe wrote: - The file block mappings must not change while loop is using the file. This means that we have to ensure exclusive access to the file and this is the bit that is currently missing

Re: SLUB performance regression vs SLAB

2007-10-05 Thread Jens Axboe
have a new slot on the box just removing any developer motivation to work on the issue. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: SLUB performance regression vs SLAB

2007-10-05 Thread Jens Axboe
On Fri, Oct 05 2007, Pekka Enberg wrote: Hi, On 10/5/07, Jens Axboe [EMAIL PROTECTED] wrote: I'd like to second Davids emails here, this is a serious problem. Having a reproducible test case lowers the barrier for getting the problem fixed by orders of magnitude. It's the difference

Re: SLUB performance regression vs SLAB

2007-10-05 Thread Jens Axboe
On Fri, Oct 05 2007, Matthew Wilcox wrote: On Fri, Oct 05, 2007 at 08:48:53AM +0200, Jens Axboe wrote: I'd like to second Davids emails here, this is a serious problem. Having a reproducible test case lowers the barrier for getting the problem fixed by orders of magnitude. It's

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Jens Axboe
applications. Waving some standard at them if they complain is unlikely to impress them. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] fs: Correct SuS compliance for open of large file without options

2007-09-27 Thread Jens Axboe
of those things that people will complain about two releases later saying it broke app foo. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [11/36] Use page_cache_xxx in fs/buffer.c

2007-08-31 Thread Jens Axboe
On Fri, Aug 31 2007, Christoph Lameter wrote: On Fri, 31 Aug 2007, Jens Axboe wrote: Could you be more specific? Size of a single segment, for instance. Or if the bio crosses a dma boundary. If your block is 64kb and the maximum segment size is 32kb, then you would need to clone

Re: [11/36] Use page_cache_xxx in fs/buffer.c

2007-08-31 Thread Jens Axboe
On Fri, Aug 31 2007, Christoph Lameter wrote: On Fri, 31 Aug 2007, Jens Axboe wrote: A DMA boundary cannot be crossed AFAIK. The compound pages are aligned to the power of two boundaries and the page allocator will not create pages that cross the zone boundaries. With a 64k page

Re: [11/36] Use page_cache_xxx in fs/buffer.c

2007-08-31 Thread Jens Axboe
On Fri, Aug 31 2007, Christoph Lameter wrote: On Fri, 31 Aug 2007, Jens Axboe wrote: They have nothing to do with each other, you are mixing things up. It has nothing to do with the device being able to dma into that memory or not, we have fine existing infrastructure to handle

Re: [11/36] Use page_cache_xxx in fs/buffer.c

2007-08-31 Thread Jens Axboe
On Fri, Aug 31 2007, Christoph Lameter wrote: On Fri, 31 Aug 2007, Jens Axboe wrote: Ok. So another solution maybe to limit the blocksizes that can be used with a device? That'd work for creation, but not for moving things around. What do you mean by moving things around

Re: Distributed storage.

2007-08-13 Thread Jens Axboe
On Mon, Aug 13 2007, Jens Axboe wrote: You did not comment on the one about putting the bio destructor in the -endio handler, which looks dead simple. The majority of cases just use the default endio handler and the default destructor. Of the remaining cases, where a specialized

Re: Distributed storage.

2007-08-13 Thread Jens Axboe
On Mon, Aug 13 2007, Daniel Phillips wrote: On Monday 13 August 2007 00:28, Jens Axboe wrote: On Sun, Aug 12 2007, Daniel Phillips wrote: Right, that is done by bi_vcnt. I meant bi_max_vecs, which you can derive efficiently from BIO_POOL_IDX() provided the bio was allocated

Re: Distributed storage.

2007-08-13 Thread Jens Axboe
On Mon, Aug 13 2007, Daniel Phillips wrote: On Monday 13 August 2007 00:45, Jens Axboe wrote: On Mon, Aug 13 2007, Jens Axboe wrote: You did not comment on the one about putting the bio destructor in the -endio handler, which looks dead simple. The majority of cases just use

Re: Distributed storage.

2007-08-13 Thread Jens Axboe
On Mon, Aug 13 2007, Daniel Phillips wrote: On Monday 13 August 2007 02:13, Jens Axboe wrote: On Mon, Aug 13 2007, Daniel Phillips wrote: On Monday 13 August 2007 00:45, Jens Axboe wrote: On Mon, Aug 13 2007, Jens Axboe wrote: You did not comment on the one about putting the bio

Re: Distributed storage.

2007-08-13 Thread Jens Axboe
On Mon, Aug 13 2007, Daniel Phillips wrote: On Monday 13 August 2007 03:06, Jens Axboe wrote: On Mon, Aug 13 2007, Daniel Phillips wrote: Of course not. Nothing I said stops endio from being called in the usual way as well. For this to work, endio just needs to know that one call

Re: Distributed storage.

2007-08-07 Thread Jens Axboe
don't add temporary fields out of laziness, hoping that someone will later kill it again and rewrite it in a nicer fashion. Hint: that never happens, bloat sticks. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED

Re: Distributed storage.

2007-08-07 Thread Jens Axboe
On Tue, Aug 07 2007, Daniel Phillips wrote: On Tuesday 07 August 2007 05:05, Jens Axboe wrote: On Sun, Aug 05 2007, Daniel Phillips wrote: A simple way to solve the stable accounting field issue is to add a new pointer to struct bio that is owned by the top level submitter (normally

Re: [PATCH] block: factor out bio_check_eod()

2007-07-18 Thread Jens Axboe
. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] block: factor out bio_check_eod()

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: End of device check is done twice in __generic_make_request() and it's fully inlined each time. Factor out bio_check_eod(). Tejun, yeah I should seperate the cleanups and put them

Re: [PATCH] block: factor out bio_check_eod()

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: End of device check is done twice in __generic_make_request() and it's fully

Re: [PATCH] block: factor out bio_check_eod()

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: End of device check is done

Re: [PATCH] block: factor out bio_check_eod()

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: Jens Axboe wrote: On Wed, Jul 18 2007, Tejun Heo wrote: End of device check is done

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-07-09 Thread Jens Axboe
On Thu, Jul 05 2007, Tejun Heo wrote: Hello, Jens. Jens Axboe wrote: On Mon, May 28 2007, Neil Brown wrote: I think the implementation priorities here are: 1/ implement a zero-length BIO_RW_BARRIER option. 2/ Use it (or otherwise) to make all dm and md modules handle barriers

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-06-02 Thread Jens Axboe
On Sat, Jun 02 2007, Tejun Heo wrote: Hello, Jens Axboe wrote: Would that be very different from issuing barrier and not waiting for its completion? For ATA and SCSI, we'll have to flush write back cache anyway, so I don't see how we can get performance advantage by implementing

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-06-01 Thread Jens Axboe
straight through the io scheduler. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-06-01 Thread Jens Axboe
On Fri, Jun 01 2007, Tejun Heo wrote: Jens Axboe wrote: On Thu, May 31 2007, David Chinner wrote: On Thu, May 31, 2007 at 08:26:45AM +0200, Jens Axboe wrote: On Thu, May 31 2007, David Chinner wrote: IOWs, there are two parts to the problem: 1 - guaranteeing I/O ordering 2

Re: [dm-devel] Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-31 Thread Jens Axboe
a barrier request before that request and previously submitted requests are on STABLE storage, then it violates that principle. Look at the code and the various ordering options. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-31 Thread Jens Axboe
of barriers. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-31 Thread Jens Axboe
On Thu, May 31 2007, Bill Davidsen wrote: Jens Axboe wrote: On Thu, May 31 2007, David Chinner wrote: On Thu, May 31, 2007 at 08:26:45AM +0200, Jens Axboe wrote: On Thu, May 31 2007, David Chinner wrote: IOWs, there are two parts to the problem: 1 - guaranteeing I/O

Re: [dm-devel] Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-31 Thread Jens Axboe
On Thu, May 31 2007, Phillip Susi wrote: Jens Axboe wrote: No Stephan is right, the barrier is both an ordering and integrity constraint. If a driver completes a barrier request before that request and previously submitted requests are on STABLE storage, then it violates that principle. Look

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-31 Thread Jens Axboe
support or not), it may be nearly as slow as a real barrier write. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-30 Thread Jens Axboe
the highest pfn in the system -- in that case, * don't waste time iterating over bio segments -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [dm-devel] Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-28 Thread Jens Axboe
(dunny why you explicitly dropped me off the cc/to list when replying to my email, hence I missed it for 3 days) On Fri, May 25 2007, Phillip Susi wrote: Jens Axboe wrote: A barrier write will include a flush, but it may also use the FUA bit to ensure data is on platter. So the only situation

Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.

2007-05-25 Thread Jens Axboe
() would never be needed (unless you want to do a data-less barrier, and we should probably add that specific functionality with an empty bio instead of providing an alternate way of doing that). -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body

Re: [RFC][PATCH 3/3] Online defrag command

2007-02-08 Thread Jens Axboe
to provide support for putting multiple files close together? Ala # e4defrag file1 file2 file3 ... fileN I'm thinking boot speedup, gather the list of read files and put them close on disk. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Jens Axboe
On Wed, Jan 17 2007, Dave Kleikamp wrote: On Thu, 2007-01-18 at 10:18 +1100, Jens Axboe wrote: Can you try io_schedule() and verify that things just work? I actually did do that in the first place, but wondered if it was the right thing to introduce the accounting changes that came

Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging

2007-01-17 Thread Jens Axboe
? -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-05 Thread Jens Axboe
On Fri, Jan 05 2007, Suparna Bhattacharya wrote: On Fri, Jan 05, 2007 at 08:02:33AM +0100, Jens Axboe wrote: On Fri, Jan 05 2007, Suparna Bhattacharya wrote: On Thu, Jan 04, 2007 at 09:02:42AM -0800, Andrew Morton wrote: On Thu, 4 Jan 2007 10:26:21 +0530 Suparna Bhattacharya [EMAIL

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Jens Axboe
dependent on this. Patches against next -mm would be appreciated, please. Sorry about that. I _assume_ Jens is targetting 2.6.21? Only if everything works perfectly, 2.6.22 is also a viable target. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel

Re: [PATCHSET 1][PATCH 0/6] Filesystem AIO read/write

2007-01-04 Thread Jens Axboe
order of the patches, what is the fsaio target? -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html