Re: [PATCH 1/1] Unionfs: cache-coherency - dentries

On Mon, Sep 03, 2007 at 07:39:48PM -0400, Josef 'Jeff' Sipek wrote: ... /* + * Determine if the lower inode objects have changed from below the unionfs + * inode. Return 1 if changed, 0 otherwise. + */ +bool is_newer_lower(const struct dentry *dentry) +{ + int bindex; + struct

[PATCH 1/1] Unionfs: cache-coherency - dentries

purge_inode_data to take a struct inode] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |2 +- fs/unionfs/dentry.c | 143 ++- fs/unionfs/inode.c | 24 +--- fs

Re: [PATCH 12/32] Unionfs: documentation updates

On Mon, Sep 03, 2007 at 08:59:02AM +0200, Jan Engelhardt wrote: On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote: + +While rebuilding Unionfs's objects, we also purge any page mappings and +truncate inode pages (see fs/Unionfs/dentry.c:purge_inode_data). This is to fs/unionfs/dentry.c

Re: [PATCH 09/32] Unionfs: cache-coherency - dentries

On Mon, Sep 03, 2007 at 08:52:17AM +0200, Jan Engelhardt wrote: On Sep 2 2007 22:20, Josef 'Jeff' Sipek wrote: @@ -184,10 +183,92 @@ out: } /* + * Determine if the lower inode objects have changed from below the unionfs + * inode. Return 1 if changed, 0 otherwise. + */ +int

Re: [PATCH 01/32] VFS: export release_open_intent symbol

On Mon, Sep 03, 2007 at 09:59:15PM +0530, Satyam Sharma wrote: On Sun, 2 Sep 2007, Josef 'Jeff' Sipek wrote: diff --git a/fs/namei.c b/fs/namei.c index a83160a..b2b7c8e 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -374,6 +374,7 @@ void release_open_intent(struct nameidata *nd

[PATCH 1/1] Unionfs: cache-coherency - dentries

purge_inode_data to take a struct inode] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |2 +- fs/unionfs/dentry.c | 143 ++- fs/unionfs/inode.c | 24 +--- fs

[GIT PULL -mm] Unionfs/fsstack/eCryptfs updates/cleanups/fixes

rewrite Josef 'Jeff' Sipek, on behalf of the Unionfs team. [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 16/32] Unionfs: minor file_release updates

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index

[PATCH 22/32] Unionfs: handling lower vfsmount fixes

From: Erez Zadok [EMAIL PROTECTED] Properly increase/release lower vfsmounts. Validate proper use of unionfs mntget/put. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c |6 -- fs/unionfs/inode.c | 11

[PATCH 02/32] VFS/fsstack: remove 3rd argument to fsstack_copy_attr_all

by Unionfs. Acked-by: Michael Halcrow [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/ecryptfs/dentry.c |2 +- fs/ecryptfs/inode.c |6 +++--- fs/ecryptfs/main.c |2 +- fs/stack.c | 13

[PATCH 26/32] Unionfs: minor remount fixes

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c index 1de41ea..339afab

[PATCH 04/32] Unionfs: fixed compilation error

From: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- include/linux/mm.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index d823db0..aee99b6

[PATCH 08/32] Unionfs: cache-coherency - update inode times

From: Erez Zadok [EMAIL PROTECTED] Part of cache-coherency support (as per OLS'07 talk and Documentation/filesystems/unionfs/concepts.txt): update our inode time if lower had changed. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs

[PATCH 09/32] Unionfs: cache-coherency - dentries

purge_inode_data to take a struct inode] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |2 +- fs/unionfs/dentry.c | 127 -- fs/unionfs/inode.c | 24 ++--- fs

[PATCH 20/32] Unionfs: lower nameidata support

PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/copyup.c |8 ++- fs/unionfs/lookup.c | 58 +++ fs/unionfs/rename.c | 15 +++- fs/unionfs/subr.c | 14 ++- fs/unionfs/union.h |2 + 5 files

[PATCH 06/32] Unionfs: copyright corrections and updates

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/mmap.c |2 +- fs/unionfs/sioq.c | 13 +++-- fs/unionfs/sioq.h | 13 +++-- 3 files changed, 15 insertions(+), 13 deletions

[PATCH 25/32] Unionfs: readonly branch test fix

From: Erez Zadok [EMAIL PROTECTED] Bug fix to test if a lower branch is readonly, even when given negative dentries. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/union.h | 19 ++- 1 files changed, 14 insertions

[PATCH 31/32] Unionfs: debugging and validation of fan-out invariants

in detecting and fixing problems, especially when stacking on top of assorted file systems. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/Kconfig |6 + fs/unionfs/Makefile |2 + fs/unionfs/commonfops.c | 17 ++ fs/unionfs

[PATCH 24/32] Unionfs: remove old nfsro option

-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c | 48 ++--- include/linux/union_fs.h |3 -- 2 files changed, 23 insertions(+), 28 deletions(-) diff --git a/fs/unionfs/inode.c b/fs

[PATCH 28/32] Unionfs: use file f_path field

From: Erez Zadok [EMAIL PROTECTED] Start using file-f_path.dentry instead of file-f_dentry Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 42 -- fs/unionfs/dirfops.c

[PATCH 13/32] Unionfs: copyup updates

-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 135 +++ fs/unionfs/copyup.c | 348 +++--- fs/unionfs/inode.c | 33 -- fs/unionfs/rename.c | 26 +++-- fs

[PATCH 07/32] Unionfs: cpp endif comments

From: Erez Zadok [EMAIL PROTECTED] Add comments to #endif's to help clarify code. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/copyup.c |2 +- fs/unionfs/inode.c |4 ++-- fs/unionfs/sioq.h |2 +- fs/unionfs/union.h

[PATCH 14/32] Unionfs: file_revalidate updates

From: Erez Zadok [EMAIL PROTECTED] Correctly revalidate a file and account for lower mnts, even when branches are updated or inserted. Better info upon file copyup. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c

[PATCH 23/32] Unionfs: mount-time option parsing fix

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/main.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/unionfs/main.c b/fs/unionfs/main.c index bc5c105..ce08d96

[PATCH 18/32] Unionfs: unionfs_ioctl bug fixes

From: Erez Zadok [EMAIL PROTECTED] Properly update lower objects, and release lower mnts upon ioctl success or failure. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 25 +++-- 1 files changed

[PATCH 15/32] Unionfs: implement f/async

] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/dirfops.c |2 + fs/unionfs/file.c| 91 +- fs/unionfs/union.h |3 ++ 3 files changed, 95 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/dirfops.c b/fs/unionfs

[PATCH 27/32] Unionfs: extended attributes fixes

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 43 +++ fs/unionfs/union.h |6 -- fs/unionfs/xattr.c | 16 ++-- 3 files

[PATCH 05/32] Unionfs: do not use fsstack_copy_attr_all

From: Erez Zadok [EMAIL PROTECTED] Unionfs needs a special fan-out version of fsstack_copy_attr_all, which is called unionfs_copy_attr_all. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c | 12 +--- fs/unionfs

[PATCH 30/32] Unionfs: update unionfs version number

From: Erez Zadok [EMAIL PROTECTED] Update version number from 2.0 to 2.1 to reflect the amount of work that had gone in since 2.0 was first released, and also to sync up with Unionfs 2.x releases for earlier kernels. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek

[PATCH 19/32] Unionfs: partial_lookup update

From: Erez Zadok [EMAIL PROTECTED] Handle new semantics of lookup_backend. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/lookup.c | 22 -- 1 files changed, 16 insertions(+), 6 deletions(-) diff --git a/fs

[PATCH 10/32] Unionfs: cache-coherency - file flush

From: Erez Zadok [EMAIL PROTECTED] Update our inode's time after flush. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/fs/unionfs

[PATCH 32/32] Unionfs: unionfs_create rewrite

The code was hard to follow and violated some invariants (e.g., never modify a read only branch, and always create on branch 0). Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c | 207 +++- 1 files changed, 58 insertions

[PATCH 03/32] VFS/fsstack: cpp endif comments

From: Erez Zadok [EMAIL PROTECTED] Add comments to #endif's to help clarify code. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- include/linux/fs_stack.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux

[PATCH 17/32] Unionfs: interpose updates

From: Erez Zadok [EMAIL PROTECTED] Update unionfs_interpose to handle spliced dentries, which is important for NFS exporting. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c | 40 +++ fs/unionfs/lookup.c

[PATCH 21/32] Unionfs: mmap fixes

'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/file.c |6 +- fs/unionfs/mmap.c | 132 ++--- 2 files changed, 98 insertions(+), 40 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c index 0555b6c..b55da4f 100644 --- a/fs/unionfs/file.c

[PATCH 29/32] Unionfs: assorted comment and style updates

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/dirhelper.c |2 -- fs/unionfs/fanout.h|9 +++-- fs/unionfs/file.c |6 -- fs/unionfs/inode.c |2 +- fs/unionfs

[PATCH 3/5] Unionfs: Use file-f_path instead of file-f_dentry

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index

[PATCH 4/5] Unionfs: Clarification comment for unionfs_lookup

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index f946b33..a86da5b

[PATCH 5/5] Unionfs: Remove unnecessary BUG_ON in unionfs_follow_link

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c | 30 -- 1 files changed, 8 insertions(+), 22 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c

[PATCH 2/5] Unionfs: Add missing unlock call in unionfs_file_release

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index 6d87426..8527ac6 100644 --- a/fs/unionfs/commonfops.c +++ b/fs/unionfs/commonfops.c

[PATCH 13/16] Unionfs: Change free_dentry_private_info to take a struct dentry

This makes it more symmetric with new_dentry_private_info. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/dentry.c |3 +-- fs/unionfs/lookup.c | 13 ++--- fs/unionfs/main.c |2 +- fs/unionfs/union.h |2 +- 4 files changed, 9 insertions(+), 11

[PATCH 12/16] Unionfs: Cleanup new_dentry_private_data

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/lookup.c | 96 +++--- fs/unionfs/union.h |1 + 2 files changed, 60 insertions(+), 37 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index 758c813..246a67a

[PATCH 16/16] Unionfs: Remove superfluous check for NULL pointer

Since we use containers and the struct inode is _inside_ the unionfs_inode_info structure, UNIONFS_I will always (given a non-NULL inode pointer), return a valid non-NULL pointer. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/fanout.h |8 +++- fs/unionfs/super.c

[PATCH 14/16] Unionfs: Add BUG_ONs to unionfs_lower_*

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/fanout.h | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h index 0319835..d4933ce 100644 --- a/fs/unionfs/fanout.h +++ b/fs

[PATCH 11/16] Unionfs: Revalidate dentries passed to all inode/super operations

From: Erez Zadok [EMAIL PROTECTED] Be sure to properly revalidate all dentry chains passed to all inode and super_block operations. Remove the older BUG_ON test is_valid_dentry(). This should help improve cache-coherency. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff

[PATCH 15/16] Unionfs: Change the semantics of sb info's rwsem

}_{,un}lock() to something more descriptive. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 33 --- fs/unionfs/copyup.c | 10 --- fs/unionfs/dentry.c |7 + fs/unionfs/dirfops.c| 10 --- fs/unionfs/dirhelper.c

[GIT PULL -mm] Unionfs cleanups, fixes, and mmap

Unionfs: Revalidate dentries passed to all inode/super operations Josef 'Jeff' Sipek (5): Unionfs: Cleanup new_dentry_private_data Unionfs: Change free_dentry_private_info to take a struct dentry Unionfs: Add BUG_ONs to unionfs_lower_* Unionfs: Change the semantics of sb

[PATCH 02/16] Unionfs: Don't revalidate dropped dentries

From: Erez Zadok [EMAIL PROTECTED] This fixes a harmless but annoying message that unionfs prints if a dropped dentry is being revalidated, which could happen if you unlink open files. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs

[PATCH 04/16] Unionfs: Set lower inodes correctly after branch management succeeds

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c | 50 +- 1 files changed, 45 insertions(+), 5 deletions(-) diff --git a/fs/unionfs/super.c

[PATCH 07/16] Unionfs: Add standard copyright comment to include/linux/union_fs.h

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- include/linux/union_fs.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/include/linux/union_fs.h b/include/linux/union_fs.h

[PATCH 03/16] Unionfs: Retry lookup for different silly-renamed files

file name already existed, Unionfs would oops upon copyup to that temp name. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/unionfs

[PATCH 10/16] Unionfs: merge find_new_branch_index and branch_id_to_idx into one function

From: Erez Zadok [EMAIL PROTECTED] Useful code cleanup and consolidation between the ODF code and non-ODF code. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c | 35 +-- fs/unionfs

[PATCH 01/16] [PATCH] unionfs section mismatch

From: Randy Dunlap [EMAIL PROTECTED] Fix section marker in header file: WARNING: fs/unionfs/unionfs.o(.init.text+0x56): Section mismatch: reference to .exit.text:stop_sioq (between 'init_module' and 'init_sioq') Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek

[PATCH 08/16] Unionfs: Remove unnecessary #define

From: Erez Zadok [EMAIL PROTECTED] UNIONFS_TMPNAM_LEN is used in only one place, and we have calculate the length of the string to begin with. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |2 +- fs/unionfs

[PATCH 05/16] Unionfs: call statfs on lower file system properly

From: Erez Zadok [EMAIL PROTECTED] Get the correct lower dentry to use to statfs the first branch (always), Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c | 15 ++- 1 files changed, 10 insertions(+), 5

[PATCH -mm] Unionfs: Fix lock leak in unionfs_ioctl

(This patch is already in the Unionfs git tree. This is just a heads up.) Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index 83001aa

[PATCH 1/1] Documentation: Fix up docs still talking about i_sem

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- Documentation/filesystems/directory-locking |5 +++-- Documentation/filesystems/porting |8 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/Documentation/filesystems/directory-locking b

[GIT PULL -mm] Unionfs cleanups and fixes

: consistently Unionfs: Coding style fixes Unionfs: Tiny documentation fixups Thanks, Josef 'Jeff' Sipek [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

[PATCH 01/21] Unionfs: Tiny documentation fixups

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- Documentation/filesystems/unionfs/usage.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/filesystems/unionfs

[PATCH 03/21] Unionfs: Every printk should prefix with unionfs: consistently

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |7 --- fs/unionfs/copyup.c |2 +- fs/unionfs/dentry.c |8 +--- fs/unionfs/inode.c | 15

[PATCH 21/21] Unionfs: Correctly decrement refcounts of mnt's upon branch management

From: Erez Zadok [EMAIL PROTECTED] The old logic was broken in one place, which another place tried to fix incorrectly. Also added detailed comments to explain the new/correct logic. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs

[PATCH 17/21] Unionfs: Documentation update regarding overlapping branches and new lookup code

From: Erez Zadok [EMAIL PROTECTED] Added detailed comment and updated documentation to explain why overlapping branches are disallowed, and better explain the cache coherency issues. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED

[PATCH 04/21] Unionfs: Add missing copyright notices

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/stack.c | 11 +++ fs/unionfs/sioq.c|5 - fs/unionfs/sioq.h| 13 + include/linux/fs_stack.h

[PATCH 15/21] Unionfs: Use krealloc instead of open-coding the functionality

Change the branch management code to use krealloc instead of playing tricks with kmalloc/memcpy/kfree. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c | 56 +--- 1 files changed, 14 insertions(+), 42 deletions(-) diff

[PATCH 20/21] Unionfs: Removed a trailing whitespace

From: Yiannis Pericleous [EMAIL PROTECTED] Signed-off-by: Yiannis Pericleous [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c index

[PATCH 19/21] Unionfs: Actually catch bad use of unionfs_mnt{get,put}

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/union.h | 34 +++--- 1 files changed, 7 insertions(+), 27 deletions(-) diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h index 5376b76..335d579 100644 --- a/fs/unionfs/union.h +++ b/fs/unionfs

[PATCH 07/21] Unionfs: Consistent pointer declaration spacing

From: Erez Zadok [EMAIL PROTECTED] Change instances of foo * var to foo *var for consistency. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/copyup.c |6 +++--- fs/unionfs/file.c | 14 +++--- fs/unionfs/inode.c

[PATCH 16/21] Unionfs: Disallow setting leftmost branch to readonly

,ro if they want a readonly union). [jsipek: fixed up to apply cleanly] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/super.c

[PATCH 11/21] Unionfs: Combine unionfs_write with __unionfs_write.

The __unionfs_write helper function was used only by unionfs_write, and there is really no reason why they should not be combined. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/file.c | 30 ++ 1 files changed, 10 insertions(+), 20 deletions

[PATCH 12/21] Unionfs: Prefix external functions with 'extern' properly

From: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/sioq.h |1 + fs/unionfs/union.h | 50 +- 2 files changed, 26 insertions(+), 25 deletions

[PATCH 10/21] Unionfs: Move unionfs_query_file to commonfops.c

Moved unionfs_query_file closer to its one user in commonfops.c. Additionally, it can now become static, and branchman.c can be removed as it is empty. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/Makefile |4 +- fs/unionfs/branchman.c | 60

[PATCH 09/21] Unionfs: Rename our do_rename to __unionfs_rename

From: Erez Zadok [EMAIL PROTECTED] To avoid confusion with the VFS function do_rename, and to help ctags, rename our utility (static) function do_rename to __unionfs_rename. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/rename.c

[PATCH 08/21] Unionfs: Rename Unionfs's double_lock_dentry to avoid confusion

From: Erez Zadok [EMAIL PROTECTED] To avoid potential confusion with a VFS function, rename our version of double_lock_dentry to unionfs_double_lock_dentry. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/inode.c |2 +- fs

[PATCH 05/21] Unionfs: Cleanup of strings and comments

From: Erez Zadok [EMAIL PROTECTED] Includes: - consistent style for multi-line comments - spell-check of all strings and comments Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/stack.c |6 -- fs

[PATCH 06/21] Unionfs: Added numerous comments

errors. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/commonfops.c |7 --- fs/unionfs/copyup.c | 22 -- fs/unionfs/dentry.c |5 ++--- fs/unionfs/file.c |1 + fs/unionfs/lookup.c

[PATCH 14/21] Unionfs: Call realloc unconditionally

krealloc already checks if the new size is greater than the old size. Therefore, we can call realloc unconditionally - making the code simpler and cleaner. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/lookup.c | 26 -- 1 files changed, 8 insertions

[PATCH 13/21] Unionfs: Don't leak resources when copyup fails partially

Original-patch-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 24 ++-- 1 files changed, 22 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 0975b6e..a80ece6 100644

[PATCH 18/21] Unionfs: Remove defunct unionfs_put_inode super op

From: Erez Zadok [EMAIL PROTECTED] Removed old workaround code that was needed to get mmap working, is no longer needed with recent kernels. Signed-off-by: Erez Zadok [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c | 20 1

[PATCH 0/5] New path lookup function (V4)

on the nameidata structure to pass the create intent to the file system. Josef 'Jeff' Sipek. [1] http://lkml.org/lkml/2007/3/9/95 [2] http://lkml.org/lkml/2007/5/4/51 - To unsubscribe from this list: send the line unsubscribe linux-fsdevel in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 2/5] sunrpc: Use vfs_path_lookup

use vfs_path_lookup instead of open-coding the necessary functionality. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] Acked-by: Trond Myklebust [EMAIL PROTECTED] --- net/sunrpc/rpc_pipe.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/net/sunrpc

[PATCH 4/5] fs: Mark link_path_walk static

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c|4 +++- include/linux/namei.h |1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index a30efbc..50285a1 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -107,6 +107,8

[PATCH 5/5] fs: Remove path_walk export

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c|3 +-- include/linux/namei.h |1 - 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 50285a1..15f45ac 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1024,7 +1024,7

[PATCH 3/5] nfsctl: Use vfs_path_lookup

use vfs_path_lookup instead of open-coding the necessary functionality. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] Acked-by: NeilBrown [EMAIL PROTECTED] --- fs/nfsctl.c | 16 ++-- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/fs/nfsctl.c b/fs/nfsctl.c

[PATCH 1/5] fs: Introduce vfs_path_lookup

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c| 32 include/linux/namei.h |2 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 580162b..a30efbc 100644 --- a/fs/namei.c +++ b/fs

[PATCH] fs: Fix indentation in do_path_lookup

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 0262594..48078ea 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1156,11 +1156,9 @@ static int fastcall do_path_lookup(int

[PATCH 1/5] fs: Introduce vfs_path_lookup

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c| 32 include/linux/namei.h |2 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 3449e0a..090cce4 100644 --- a/fs/namei.c +++ b/fs

[PATCH 5/5] fs: Remove path_walk export

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c|3 +-- include/linux/namei.h |1 - 2 files changed, 1 insertions(+), 3 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index d9eb621..7a98676 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1026,7 +1026,7

[PATCH 2/5] sunrpc: Use vfs_path_lookup

use vfs_path_lookup instead of open-coding the necessary functionality. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] Acked-by: Trond Myklebust [EMAIL PROTECTED] --- net/sunrpc/rpc_pipe.c | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/net/sunrpc

[PATCH 0/2] [TRIVIAL] Small cleanups for do_path_lookup (V2)

(For changes since V1, see the end of this email.) The following 2 patches are trivial cleanups to do_path_lookup in namei.c. Since these changes are trivial, they can go into 2.6.22-rc1 without any problems. Josef 'Jeff' Sipek (2): fs: Fix indentation in do_path_lookup fs: Use

[PATCH 2/2] fs: Use path_walk in do_path_lookup

Since, path_walk sets the total_link_count to 0, and calls link_path_walk, we can just call path_walk directly. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 2a5c232

[PATCH 1/2] fs: Fix indentation in do_path_lookup

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 7a98676..2a5c232 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1159,11 +1159,9 @@ static int fastcall do_path_lookup(int dfd

[PATCH 4/5] fs: Mark link_path_walk static

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c|4 +++- include/linux/namei.h |1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 090cce4..925c62e 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -108,6 +108,8

[PATCH 1/1] nfsctl: Use vfs_path_lookup

use vfs_path_lookup instead of open-coding the necessary functionality. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/nfsctl.c | 16 ++-- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/fs/nfsctl.c b/fs/nfsctl.c index c043136..51f1b31 100644 --- a/fs

[GIT PULL -mm] Unionfs updates

Unionfs: Check remount options for being NULL Adrian Bunk (1): fix unionfs compilation fs/unionfs/super.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) Josef 'Jeff' Sipek. [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux

[PATCH 2/3] Unionfs: Check remount options for being NULL

From: Adrian Brunyate [EMAIL PROTECTED] Signed-off-by: Adrian Brunyate [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c index ee12d03

[PATCH 1/3] Unionfs: Accept MS_SILENT during remount

From: Adrian Brunyate [EMAIL PROTECTED] [jsipek: whitespace cleanup] Signed-off-by: Adrian Brunyate [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/fs/unionfs/super.c

[PATCH 3/3] [PATCH] fix unionfs compilation

/kernel-2.6/linux-2.6.21-mm1/fs/unionfs/super.c:822: error: for each function it appears in.) make[3]: *** [fs/unionfs/super.o] Error 1 -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/unionfs/super.c |3 +-- 1 files changed

[PATCH 0/2] [TRIVIAL] Small cleanups for do_path_lookup

The following 2 patches are trivial cleanups to do_path_lookup in namei.c. Since these changes are trivial, they can go into 2.6.22-rc1 without any problems. Josef 'Jeff' Sipek (2): fs: Fix indentation in do_path_lookup fs: Use path_walk in do_path_lookup diffstat for good measure

[PATCH 2/2] fs: Use path_walk in do_path_lookup

Since, path_walk sets the total_link_count to 0, and calls link_path_walk, we can just call path_walk directly. Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 600a4e7

[PATCH 1/2] fs: Fix indentation in do_path_lookup

Signed-off-by: Josef 'Jeff' Sipek [EMAIL PROTECTED] --- fs/namei.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 0262594..600a4e7 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1159,7 +1159,7 @@ out: if (likely(retval == 0

  1   2   >