Re: NFS client hang on attempt to do async blocking posix lock enqueue

2007-11-29 Thread Marc Eshel
The problem seems to be with the fact that the client and server are on the same machine. This test work fine with or without an underlaying fs that supports locking when the client and the server are on a different machines. Like you said the server is trying to send the grant message to the

Re: [PATCH 3/5] locks: rename lease functions to reflect locks.c conventions

2007-06-09 Thread Marc Eshel
We need to export vfs_lease so nfsd can call it. Marc. J. Bruce Fields [EMAIL PROTECTED] wrote on 06/08/2007 03:14:53 PM: From: J. Bruce Fields [EMAIL PROTECTED] We've been using the convention that vfs_foo is the function that calls a filesystem-specific foo method if it exists, or falls

Re: [NFS] [PATCH] locks: provide a file lease method enabling cluster-coherent leases

2007-06-05 Thread Marc Eshel
Hi Bruce, The file system does need to keep the local state up to date, like it does with posix locks, so it might need to call __setlease(). The why we had it before was that the call to the file system was done from outside of setlease() and the file system was able to call setlease() which

Re: [NFS] [PATCH] locks: provide a file lease method enabling cluster-coherent leases

2007-06-02 Thread Marc Eshel
[EMAIL PROTECTED] wrote on 06/02/2007 10:39:10 AM: On Fri, 2007-06-01 at 12:53 -0400, J. Bruce Fields wrote: It also means that you're calling twice down into the filesystem for every call to may_open() (once for vfs_permission() and once for break_lease()) and 3 times in

Re: [PATCH 1/10] lockd: add new export operation for nfsv4/lockd locking

2006-12-14 Thread Marc Eshel
Lets see if we use export operations or vfs calls. If we do exports we can even add another call just for cancel or maybe we can add a new vfs call. Marc. J. Bruce Fields [EMAIL PROTECTED] wrote on 12/14/2006 03:04:42 PM: By the way, one other issue I think we'll need to resolve: On Wed,

Re: [NFS] [PATCH 10/10] gfs2: nfs lock support for gfs2

2006-12-07 Thread Marc Eshel
[EMAIL PROTECTED] wrote on 12/07/2006 07:23:59 AM: On Wed, Dec 06, 2006 at 10:47:46PM -0800, Marc Eshel wrote: Here is a rewrite of gdlm_plock_callback(). We still need to add the lock cancel. Marc. int gdlm_plock_callback(struct plock_op *op) { struct file *file

Re: [PATCH 10/10] gfs2: nfs lock support for gfs2

2006-12-06 Thread Marc Eshel
Here is a rewrite of gdlm_plock_callback(). We still need to add the lock cancel. Marc. int gdlm_plock_callback(struct plock_op *op) { struct file *file; struct file_lock *fl; int (*notify)(void *, void *, int) = NULL; int rv; spin_lock(ops_lock); if