Re: [PATCH 15/19] gfs2: new export ops

2007-09-14 Thread Steven Whitehouse
f-by: Christoph Hellwig <[EMAIL PROTECTED]> > This looks good from a GFS2 point of view: Acked-by: Steven Whitehouse <[EMAIL PROTECTED]> Acked-by: Wendy Cheng <[EMAIL PROTECTED]> Steve. > > Index: linux-2.6/fs/gfs2/ops_export.c > ==

Re: do_generic_mapping_read abuse in gfs2

2007-07-29 Thread Steven Whitehouse
Hi, On Sat, 2007-07-28 at 19:42 +0200, Christoph Hellwig wrote: > I was looking into cleaning up the the read actor mess now that sendfile > uses splice and notices gfs2 now uses do_generic_mapping_read. > > The use is rather odd because it's used for reading small structures > from kernelspace a

Re: vm/fs meetup details

2007-07-06 Thread Steven Whitehouse
Hi, On Fri, Jul 06, 2007 at 05:57:49PM +0200, Jörn Engel wrote: > On Fri, 6 July 2007 09:52:14 -0400, Chris Mason wrote: > > On Fri, 6 Jul 2007 23:42:01 +1000 David Chinner <[EMAIL PROTECTED]> wrote: > > > > > Hmmm - I guess you could use it for writeback ordering. I hadn't > > > really thought a

Re: [PATCH 6/6] nfs: disable leases over NFS

2007-06-29 Thread Steven Whitehouse
ign to > fall back on some other behavior. And I can't see any reason it would > need to distinguish between those two remaining cases (filesystem > doesn't support leases, or leases are disabled by the sysctl). So, > OK, EINVAL sounds fine to me. > > But I don't ha

Re: [PATCH 4/5] gfs2: stop giving out non-cluster-coherent leases

2007-06-11 Thread Steven Whitehouse
Hi, On Sat, 2007-06-09 at 09:35 -0700, Marc Eshel wrote: > This is the return code that setlease() currently returns when the lease > can not be obtained. Although ENOTSUPP would be more accurately describing > the error it will be a new return code from setlease() that is currently > not expec

Re: [PATCH 4/5] gfs2: stop giving out non-cluster-coherent leases

2007-06-09 Thread Steven Whitehouse
Hi, On Fri, 2007-06-08 at 18:14 -0400, J. Bruce Fields wrote: > From: Marc Eshel <[EMAIL PROTECTED]> > > Since gfs2 can't prevent conflicting opens or leases on other nodes, we > probably shouldn't allow it to give out leases at all. > > Put the newly defined lease operation into use in gfs2 by

Re: + fs-introduce-write_begin-write_end-and-perform_write-aops.patch added to -mm tree

2007-05-30 Thread Steven Whitehouse
Hi, On Wed, 2007-05-30 at 05:13 +0200, Nick Piggin wrote: > On Tue, May 29, 2007 at 02:19:55PM -0700, Andrew Morton wrote: > > > > The patch titled > > fs: introduce write_begin, write_end, and perform_write aops > > has been added to the -mm tree. Its filename is > > fs-introduce-writ

Re: [PATCH 17/17] gfs2: nfs lock support for gfs2

2007-04-17 Thread Steven Whitehouse
Hi, Sorry for the delay, On Thu, 2007-04-05 at 19:41 -0400, J. Bruce Fields wrote: > From: Marc Eshel <[EMAIL PROTECTED]> - unquoted > > Add NFS lock support to GFS2. > > Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Acked-by: Steven Whitehouse <[EMAIL PR

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-15 Thread Steven Whitehouse
Hi, On Thu, 2007-03-15 at 05:36 +0100, Nick Piggin wrote: > On Wed, Mar 14, 2007 at 09:13:29PM -0700, Mark Fasheh wrote: [some comments snipped] > > Attached is a quick patch to hook up the existing ocfs2 write code. This has > > been compile tested only for now - one of my test machines isn't > >

Re: [PATCH] dlm/gfs2: indent help text

2007-01-31 Thread Steven Whitehouse
Hi, Now in the GFS2 -nmw git tree. Thanks, Steve. On Tue, 2007-01-30 at 14:30 -0800, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Indent help text as expected. > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> > --- > fs/dlm/Kconfig | 16 > fs/gfs2/Kc

Re: [PATCH] dlm & gfs2: use sysfs

2007-01-26 Thread Steven Whitehouse
Hi, Now in the GFS2 -nmw git tree. Thanks, Steve. On Thu, 2007-01-25 at 18:42 -0800, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > With CONFIG_DLM=m, CONFIG_PROC_FS=n, and CONFIG_SYSFS=n, kernel build > fails with: > > WARNING: "kernel_subsys" [fs/gfs2/locking/dlm/lock_dlm.k

Re: [PATCH] GFS2: Fix incorrect return code from gfs2_lookupi

2007-01-05 Thread Steven Whitehouse
Hi, On Thu, 2007-01-04 at 21:32 -0600, Russell Cattelan wrote: > This fixes a bug found by the fsfuzzer tool. > http://projects.info-pull.com/mokb/MOKB-15-11-2006.html > > A NULL was not an acceptable error condition expected > by any of the gfs2_lookupi callers. > Now applied to the GFS2 git t

Re: Status of buffered write path (deadlock fixes)

2006-12-11 Thread Steven Whitehouse
Hi, On Tue, 2006-12-12 at 03:39 +1100, Nick Piggin wrote: > Steven Whitehouse wrote: > > >>Hmm, doesn't look like we can do this either because at least GFS2 > >>uses BH_New for its own special things. > >> > > > > What makes you say t

Re: Status of buffered write path (deadlock fixes)

2006-12-11 Thread Steven Whitehouse
Hi, On Tue, 2006-12-12 at 02:52 +1100, Nick Piggin wrote: > Nick Piggin wrote: > > Mark Fasheh wrote: > > >> ->commit_write() would probably do fine. Currently, block_prepare_write() > >> uses it to know which buffers were newly allocated (the file system > >> specific > >> get_block_t sets the

Re: [PATCH 10/10] gfs2: nfs lock support for gfs2

2006-12-06 Thread Steven Whitehouse
Hi, This looks good to me, and I'm copying in Dave & Wendy who have both done previous work in this area for further comment. Provided we can get this tested, I'd be happy to accept the patch in its current form. Steve. On Wed, 2006-12-06 at 00:34 -0500, J. Bruce Fields wrote: > From: J. Bruce F

Re: NFSv4/pNFS possible POSIX I/O API standards

2006-11-29 Thread Steven Whitehouse
Hi, On Wed, 2006-11-29 at 01:48 -0800, Andreas Dilger wrote: > On Nov 29, 2006 09:04 +, Christoph Hellwig wrote: > > - readdirplus > > > > This one is completely unneeded as a kernel API. Doing readdir > > plus calls on the wire makes a lot of sense and we already do > > that f

Re: [PATCH -mm] gfs2 lock function parameter

2006-11-29 Thread Steven Whitehouse
Hi, I've put this in the -nmw git tree. I'd pull it into the -fixes tree too, but its probably better to let Linus take whats there first and then I'll send this on later, Steve. On Tue, 2006-11-28 at 22:29 -0800, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Fix function par