Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-08 Thread Jan Engelhardt
On Dec 7 2006 21:17, Josef Sipek wrote: +void __unionfs_mknod(void *data) +{ + struct sioq_args *args = data; + struct mknod_args *m = args-mknod; ... | vfs_mknod(m-parent, m-dentry, m-mode, m-dev); If I make the *args = data line const, then gcc (4.1) yells about

Re: [PATCH 15/35] Unionfs: Common file operations

2006-12-08 Thread Jan Engelhardt
On Dec 7 2006 23:16, Josef Sipek wrote: I think there was an ioctl for files to find out where a particular file lives on disk. That's the UNIONFS_IOCTL_QUERYFILE case. No I meant something that works on all filesystems, something generic, not unionfs-based. -`J' -- - To

Re: [PATCH 35/35] Unionfs: Extended Attributes support

2006-12-08 Thread Jan Engelhardt
On Dec 8 2006 00:35, Josef Sipek wrote: --- a/fs/unionfs/copyup.c +++ b/fs/unionfs/copyup.c @@ -18,6 +18,75 @@ #include union.h +#ifdef CONFIG_UNION_FS_XATTR ^^ this, do you?. Beware, copyup.c gets compiled all the time even when you don't have xattrs enabled. Oops, I thought

Re: [NFS] [PATCH 10/10] gfs2: nfs lock support for gfs2

2006-12-08 Thread J. Bruce Fields
On Thu, Dec 07, 2006 at 09:30:43AM -0600, David Teigland wrote: Some posix locks would be trivial to cancel and others would be hard. If gfs_controld has not yet read the op from the kernel's send_list, then we just remove the op and it never goes out. After gfs_controld has taken it and

Re: [PATCH 2/3] ensure unique i_ino in filesystems without permanent inode numbers (libfs superblock cleanup)

2006-12-08 Thread Josef Sipek
On Fri, Dec 08, 2006 at 08:08:03AM -0500, Jeff Layton wrote: Josef Sipek wrote: - ret = simple_fill_super(sb, IPATHFS_MAGIC, files); + ret = simple_fill_super(sb, IPATHFS_MAGIC, files, 1); I don't know...the magic looking 1 and 0 (later in the patch) seem a bit arbitrary. Maybe a

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-08 Thread Jan Engelhardt
On Dec 8 2006 11:00, Josef Sipek wrote: +void __unionfs_mkdir(void *data) +{ + struct sioq_args *args = data; + struct mkdir_args *m = args-mkdir; + + args-err = vfs_mkdir(m-parent, m-dentry, m-mode); + complete(args-comp); +} The members of m (i.e. m-*) are not

Re: Status of buffered write path (deadlock fixes)

2006-12-08 Thread Mark Fasheh
On Fri, Dec 08, 2006 at 02:28:10PM +1100, Nick Piggin wrote: In generic_file_buffered_write() we now do: status = a_ops-commit_write(file, page, offset,offset+copied); Which tells the file system to commit only the amount of data that filemap_copy_from_user() was able to pull in,

Re: [RFC][PATCH] Secure Deletion and Trash-Bin Support for Ext4

2006-12-08 Thread Nikolai Joukov
They are defined but unused in 2.6.19, right? I can't see anywhere in the 2.6.19 ext2/3/4/reiser trees that actually those flags, including setting and retrieving them from disk. JFS i can see sets, clears and retreives them, but not the fielsystems you mention. Though I might just be

Re: [NFS] [PATCH 1/10] lockd: add new export operation for nfsv4/lockd locking

2006-12-08 Thread Wendy Cheng
J. Bruce Fields wrote: From: Marc Eshel [EMAIL PROTECTED] There is currently a filesystem -lock() method, but it is defined only by a few filesystems that are not exported via nfsd. So none of the lock routines that are used by lockd or nfsv4 bother to call those methods. Filesystems such as